AsyncAPI AsyncAPI Crew Live Streams, 20 Nov 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Working on Global Actions Support - Part 3

Description

Previous session https://youtu.be/Gan8aOvULAs

A

Hey: what's up, it's me again: lukas asking api. um It's a part, number three of a series of streams, I'm doing about the github action that is supposed to provide functionality and github actions for having something. I call global workflows, so workflows that you have in one repo and you just have to change it in one repo and then this change is replicated populated.

A

I'm not sure which word fits better to other repos.

A

So let's me some. Let me summarize uh yesterday and today, because it's a second stream today.

A

I don't need to start sharing screen, maybe.

A

A

At the same time, I'm gonna.

A

Run preview for myself on youtube, so I know that um how the quality of the video looks like because it was pretty shitty um yesterday, but today, when I was recording without my face it got better, but I'm not sure if it's really because my face is that bad or maybe or maybe the thing is.

A

um That just the internet in the afternoon gets gets worse because I was recording yesterday afternoon.

A

um But yeah: let's, let's try so let's share the screen. Next to my photo.

A

And let's see how it looks like for.

B

A

Okay, so far so good.

A

Not not perfect, but it's it's readable and that's that's the most important right.

A

But yeah I'm gonna monitor it.

A

A

um Packages and that's not what is important here, um so let me just summarize by looking at the diagram, so the solution is that we, like that's a mvp solution, so without any configuration available for the user. So the easy solution is that we, the action, gets triggered by push event.

A

And we check uh from the payload of the event uh we check at what commit was done. With this um push event, then we with github api. We check details of the comment to figure out information.

A

What files were modified with this particular comment and we check if work for workflow file if work work, damn it if workflow files were edited, then we continue. If not, we stop.

A

Then we get from the api and the list of all the repositories for a given user organization and then basing on the list. We clone all of them and create a new branch in each of them and then copy over changes um from the repository.

A

Yeah, that's pretty much it and then after we copy, we just push the change and open pr. And then the assumption is that somebody has in every repository, has a action for auto, approving and auto merging prs.

A

Now the thing is that we yesterday and today I actually managed to provide simple implementation of all the steps except of the pr creation.

A

So I actually have the whole logic to to check um if there were changes, copy them over clone all the repository, etc and like few hours ago, I managed to push the changes to the repos. So now I will just work on the pr's now before I continue.

A

I see that I have like six uh six live viewers. So just to sum up for you um folks, because um like a few minutes ago, I started no one. Was there, so I'm doing a live stream about a github action that we're creating for async api organization, but it will be able anybody will be able to use it for their organizations.

A

So it's not particularly related to asking api spec or anything like this, but I'm I'm working on the sync api. So I'm asking api maintainer.

A

So if you joined the stream because you expected a dedicated stream about async, api spec or some tooling, then um just write your questions um in the chat.

A

um Then don't worry that I'm talking about the github actions and don't worry that you can like um I don't know like disturb me or something I'm here to help and answer questions, so you can easily disturb me with questions about the spec but yeah. So let's continue so um the code is pretty pretty ugly um because that's how I approach coding um some some features so first I just code.

A

Code ugly, so I don't refactor, I don't create functions. I just make sure that the code works. So I discover apis and check if my diagram, that I, like my architecture, diagram that I created, if it's, if it makes sense or not and then if it makes sense, I was able to code it then there's time to to refactor and start writing tests so and and yeah. That's how it looks like and that's why the code is ugly, but um that's that was clear from the very beginning.

A

So we are that's the last line I added. So we are really able to push um to push the change to to the repository you can see it.

A

I have this repo here opened and I can see that bot update, workflow branch was created, so it works pretty well.

A

Now now what's next um yeah, first of all, so I don't forget during last stream. I sneaked my tokens to recording, of course I removed them, but I don't want to do it.

C

A

So I'm gonna do two things.

A

I have this start script, that is removing clones and enabling debug. So I will.

A

I will do another script, maybe.

A

Start debug: it's going to be too long.

A

Maybe death yeah, that's the death and it's gonna be npm start.

A

But this is what we're gonna remove and use here.

A

A

A

Looks good looks, good, looks good.

A

It's it's cool that we have twitch users um hi folks, so now the yeah: how to create a pull request.

A

With graphql, because that's always my preference right, um I just love, love graphql, that's it and simplicity how it can be used with the github client.

A

So first I want to do. I want to check if there's a mutation that.

A

Allows me to create pull request.

A

A

A

Okay, so let me.

A

How was it working with the explorer is it like?

A

Do I have to write mutation.

A

What I didn't copy the name, what was it create? Poorly, a polar.

A

Request cut it.

A

A

And as an input, we have to provide.

A

It doesn't render.

A

C

C

C

A

What am I doing wrong here? Why this window doesn't want to.

A

Doesn't want to scale to maximum.

A

Okay, let me maybe just quit the sharing.

C

A

Why is this window not scaling.

A

Why it doesn't scale?

A

Okay, I think I'm gonna quit the my view, but why why why.

A

C

What the hell is happening here with this view.

A

You know what let me quit the the broadcast.

A

uh So don't run away. um I will just quit the broadcast and join it again. It's not going to end when I leave.

A

A

Okay, I'm back.

A

And now screen sharing, let's see.

C

A

A

You know what I'm really getting tired of this stream.

A

A

A

It screw it I'm just gonna zoom as much as I can, okay um back into business back into business. So I know it's a create. We take credible requests, mutation and assign.

A

A

There goes a creatable request, input.

A

How to generate the input type of.

C

C

C

A

A

A

Sorry, I have information what fields I have to pass so, let's play with it.

A

A

And an object and the object should have repository.

B

A

A

The name of the branch you want, your changes pulled into.

A

So it's gonna be.

A

Master, but that's going to be, of course, later configurable, because there's master now it's main and people might also choose different head ref name, the name of the branch where your changes are.

A

A

And we're gonna test it on on chewy.

A

So that's the that's. The name.

A

Okay, so we copied it.

A

Okay, one title of course, title.

A

Title update on don't know, update, update.

A

Global work flows.

A

um Body is not.

A

But it's not required, so let's not provide it.

A

B

A

Sure should I mean if it's a bot provided pr.

A

You think it's indicating the default yeah, I think it's default and it's.

A

A

Not draft client mutation id.

A

Okay, that's not required, so the only thing I'm missing is this repository id.

A

So that's an addition, that's additional stuff. I need to get from the.

A

From the api, because I had it okay, this this query.

A

Let's check it.

A

A

Well, come on what's happening.

A

A

Oh, let me refresh, then decision expired or.

A

A

Okay, I had some. I had some luck with the connection. Sorry, for that should be better now,.

A

Okay, okay looks good um so.

A

Okay, so I have id so I have id so for now. I'm gonna just.

A

I'm gonna just hard code. It.

A

What was the name repository id yeah? I think it's repository yeah.

C

A

um Let's take the id, so I don't don't forget we grab it as well and we give access to it in our.

B

C

A

Okay, where are we? Where are we.

C

A

So there's something wrong with the syntax of the.

A

A

A

Oh yeah, what can I.

A

What can I get in return? I'd like to get the pr number I'd like to get pr number in response from the server.

A

Let's check create create world, uh not close, uh yeah yeah. I am blind. Okay.

A

For polar requests.

C

A

A

A

Wait wait, wait paul.

A

C

Oh yeah, I just forgot to scroll.

A

A

What information I will get in return.

B

A

A

Let's go from the maybe url yeah the url, to this request: okay, your url.

A

What else would be useful? I think, on the.

A

A

Wait wait, wait what's the difference between.

A

Resource path is the hd http path to this pull request. So what's the url.

A

Okay, so I get the full url here, not just the path which makes sense.

A

Now, yeah, I think we really it's just really enough to have this. Let's, let's run it, let's see if the request will be created.

A

You can't perform that action at this time.

A

I mean seriously: that's.

A

A

Let's see repository id, I have it base ref name address.

A

B

A

A

Mistake come on looking at the dogs, everything looks.

A

A

Wait: let's, let's just check this record, so it's chewy sample data.

A

A

A

Oh yeah yeah, you.

C

Again, pull request new pull request.

A

A

C

Lucas love, you guys love it.

A

Okay, the change is detected.

A

So from the ui perspective, all is good. What's wrong with my mutation here, creatable request base is master update, workflow.

A

Update workflow the title.

A

And repository id, why does every message is so useless.

A

Let's go into history and choose again the query.

A

So really, what was the.

A

Chewy sample data right chewy sample data, let's copy the id.

A

A

It's exactly the same.

A

But why it fails.

A

I don't think it's a problem of token, because any user with his own token, should be able to create a pull.

C

C

This is pretty strange.

A

What, if I choose id.

A

Of the repo where the headref name doesn't match, because the branch is not there, I.

A

Seriously, I mean I can't copy it.

A

This is a kind of.

A

A

C

A

A

Okay and let's go back here.

A

And will it throw an error that branch does not exist.

A

Whoa, it's really lame.

A

It's really really.

A

A

No, it's a joke or.

A

A

I'm pretty sure everything is fine on my side.

A

Oh, the dude is actually getting more more details in the error, while I'm just getting super.

A

A

A

That's exactly what I have.

A

No that's correct, otherwise graphql would show, would draw.

A

A

Wait wait, is it master the.

B

A

Why what's a waste of time master, but.

C

Update workflow.

A

All is good the same if I would create it manually, go here, new request.

C

A

A

A

hmm This issue in github cla.

C

Really be helpful, I.

C

A

No not related.

A

Okay, what's the exact error message.

A

You can't perform that action at this.

A

A

A

What's come, was it.

C

What a bastard.

A

Okay, let me let me just confirm to be 100 percent sure that it's um not related to to authentication, even though I don't, I really don't think so. Let me sign in in the explorer.

A

B

B

A

A

So it's about authentication which at the end it's good. At least I know. What's the problem and the progress was got created, perfecto live okay, so we have.

A

Another proof that github the github actions just rock just see- I mean I have this right.

A

Cool right now I go to the code.

A

And yes, I will still have ugly code, but that doesn't.

C

C

A

A

A

And I just copy paste.

A

Oh, I didn't copy.

A

And yes, of course, it's it's a bit hard coded and it's for now it's fine! um I'm gonna in another stream show how to use this api properly, but now we're just gonna we're just gonna hack packet, the string just just hug, the string.

A

So it's gonna be.

A

It's gonna be like this.

A

And repository.

A

A

Also gonna be like this.

A

So looks good title can be hard coded for now base ref name as well.

A

Oh, it's gonna be problematic. I think I mean I don't want to think about it now, especially that the stream was not supposed to be super long, but um when I will now create those pr's in different repositories for entire organization, I'm gonna face an issue that of course was brought by introducing main branch.

A

So the the thing is that sometimes the main upstream branch will be master and in other cases it's gonna be main, so I basically have to always check.

A

Like by default check, if master, is there so push to master otherwise.

A

Main also maybe user should be allowed to to configure.

A

I don't know, I really don't know anyway, it has to be handled. Oh jesus, all those tiny details. Okay, so we have. um We have query ready.

A

A

That's how you that's, how you use it! It's beautiful!

A

It's just beautiful! So.

A

A

What's this structure, not here, where was it successful here? Okay, it's pretty! It's data create request: okay, okay, I'm gonna copy.

A

A

Of course, I'm gonna trigger at the end, the.

A

Mutation and yes, so the structure is the following: I it's data then create pull request object. Then pull request object.

A

A

Create pull request.

A

A

A

A

A

A

One two three, four one, two three four.

B

A

You should be able to get the url from the response from the server.

A

Beautiful console log.

A

A

Okay, let's do some nice console look with first, when we tried first on from the first time.

A

um Let's see, what's what's the problem with url here, what is it.

A

Url was used before it was.

C

A

You mean this url.

A

A

A

Let's call it nice pull request.

A

A

Okay, no issues, no issues looks good. I mean even at the end, if the workload works, it's just 72 lines of code, so refactoring is not going to be also super painful.

A

ah There will be problem master and main, because I think I have.

C

A

A

Master: okay, let's not just let's not analyze. What happened.

A

A

Anyway, let's, let's run it.

A

Hold your fingers crossed.

B

B

A

A

One which request parse error on slash.

A

At 5, 20 25.

A

C

A

B

B

A

Let's see first, if the what stage it failed, it's for sure.

A

A

Let's go to branches huh okay, so the branch was created.

A

The branch got created.

A

Is this the problem.

A

But that's how you can name branches with slash right.

A

hmm Give me some.

A

And it's anyway, it's great.

A

I probably can't do it. We have to do it properly from the very beginning: okay, let's um yeah! Sometimes you just need to do stuff properly from the very beginning uh tool: okay, graphql.

A

How do you do this of variables, query variable and what's that, what's.

B

B

A

We have this nice context here, but it's okay, it's not graphql.

C

Graph ql: no, it's.

A

You can also make graphql requests, see.

A

Quarry and variables.

A

But how can I access those variables? I just don't remember.

A

Okay, okay, okay, makes sense, makes sense.

A

So we need to pass the objects.

A

um So it's great pr mutation.

C

A

Or ribose and those.

C

C

A

What that's not the name.

A

What the hell am I doing?

A

Okay and we're gonna? How do you do it? You said the name and the volume? Okay, fine,.

A

So we're gonna take branch name.

A

A

C

A

A

That's what we need and then here we do dollar.

A

A

We simply could not fake the system.

A

Which is fine, it's fine.

A

We need to manually.

B

Just remove this branch.

A

Because for now we're working locally on a fake event- okay, let's do it again or did I forget about something? No.

C

C

A

A

A

What you're, trying to tell me.

A

So we have variable and just grab.

A

I mean, like seriously, should be possible.

A

I really need to see it what's what is it what's the value.

C

C

A

Yeah exactly so, that's how you do.

A

Objects in javascript, if you want to, if you have the same key as the name of the variable.

A

This looks good to me, let's, just as I remember just remove the.

C

A

Variable branch name is used by but not declared declared. It is declared it's branch name and the id.

A

Okay, let's look again at docs.

A

Graphql you pass the query.

A

It's not a separate object.

C

It's different.

C

C

A

Don't use template groups, laws in the query strings as they make all vulnerable.

C

To query injections attacks.

A

Oh yeah, okay, I know I don't want to use it anymore.

A

But still I don't get why here you pass query a string and then pass object with variables. But here you pass query.

A

What's the what's different here, what's the difference here.

A

This is an object, and this is a string.

A

Okay, that's that's fine. We can do.

A

It we can do it this way, that's fine! So it's going to be an.

A

A

Okay, mutation branch name.

A

Id one variable less still still good to me just make sure that I I forgot how those variables work. I mean I use it here, but then.

B

A

I need to specify.

A

A

And I need to because it's like graphical is strongly typed, so I need to specify that the branch name is required and it's a string.

A

And it's basically the same with id okay, so I didn't have to refactor. But yes still, I like that. There's just one object: now it has to work. There's no other option, especially because one hour passed and I don't want to continue too much today. It's.

A

Friday, yeah, of course it couldn't work.

C

B

A

C

A

A

A query attribute.

C

Must be specified and must be a.

A

String what query.

A

A

A query attribute must be specified and must be a string.

A

Really must be query what, if it's.

A

A

Of course, all examples are for.

A

A

A

Okay, let's remove the ripple and and let's just rename it to.

A

A

Branch created and it failed, cannot read property, create pull requests of.

A

A

You're kidding me.

A

Not kidding me you're killing me.

B

A

Okay, let's just fall.

A

A

A

A

I don't really have time for.

C

A

Let's remove and let's refresh.

A

Make it work please. I really want to finish.

A

Cannot read property create, pull.

A

C

This is correct, that is.

A

Right create beat property kind of big property.

A

um It's really weird.

A

Because I really when I take a look it, it looks really like like in docs. So we have a query name of the query, with the type definition of the of the variables and then.

A

C

C

B

B

A

No, I'm not gonna get answered.

C

There it was create, pull request.

C

C

B

A

It was created.

A

Now I'm super confused.

A

Because I am that's.

A

It so let's go to branches.

A

A

Pull request and let's run this beast again, so maybe it's ah yeah yeah, maybe that's.

C

B

B

A

Damn it I don't read, I probably don't.

C

A

Those that's the thing, so everything is fine. It's my destructuring sucks.

A

Maybe data should.

C

Be removed, let's see.

A

A

It's happening, it's happening, entire workflow works like a charm and the link to pull request is here. Let's open it.

A

And it's opened but in different.

A

Browsers, damn damn.

A

Pull request is opened.

A

C

A

You can't imagine how happy I am, and now it continues creating for requesting every and every repo which is awesome, which is awesome. Let me just shut it down. It doesn't have to be completed so summarizing this week. We have all the flow. The whole flow created.

A

So the entire diagram works. Now it's just um now, it's just time for for refactoring next week, but basically it looks like the the initial idea is.

A

Can work so we can have a in in dot github repository. We can have workflows that we call global and whenever we make changes to those workflows, this github action will clone all the other. All the repositories from from organization will.

A

Will clone them will make changes, push them and create request to every repo.

A

Which is pretty nifty, which is pretty nifty just now. I have to clean up the code and expose some functionalities, because today I also made a lot of notes of missing things stuff that is hardcoded but yeah. That's the mvp right, like it's really really mvp.

A

I don't think it's actually mvp, because mvp is something you can ship and this crap you can't ship, um not sure. Yet, um if next week I'm gonna continue with sessions about this github action.

A

If you want me to continue because the initially I was thinking only about doing the brainstorming life and showing that the flow is possible, what if you like it, you want to hear, especially during during the uh to see the refactoring, um how I use all the different options of github actions and then testing github action.

A

Maybe it's interesting for you. So just let me know if you want me to continue with the streams next week, otherwise I will just write it quietly without showing off that's it then, for for today I wish you a really good weekend and friday have some beers.

A

How do I end it? Oh yeah and broadcast.

A