Backdrop CMS Weekly meetings, 23 May 2019

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Backdrop Weekly May 23

Description

Today’s development agenda: http://bit.ly/2WQIhx8

A

All right we are on air today is Thursday May 23rd, and this is a meeting on backed-up CMS active development tasks. Before we get into our tasks, we have an announcement from the PMC. We passed a vote which is pretty exciting to add security to our principles.

A

So, on our philosophy page, we have a section for principles, I'm going to throw a link in the meeting, chat and indicator, and we decided to have sort of an open discussion about the wording around security, so I thought I would create an issue and the backdrop semester, org cube where we can sort of revise and refine that. But since there's a bunch of people here at once, I just wanted to see. If we had any preferences on like we're in the list, it should go.

A

The list I feel, like is sort of ordered by I, mean not really priority, but like the order in which we ran into problems.

A

But I don't know if that means we have to have security in a particular location. If the location is important, you want to just address the end yeah one.

B

A

B

We should change that least from being numbered to just being pulled upon us, so so it doesn't imply sort of like a priority. Yeah.

A

Having like a total count of them is useful, we could just put it in the heading that, where it says principles they could say like. Are you okay, love it and then any preference on where in the list it should go.

B

Sounds like top the.

A

B

So we don't give excuses to people to say: oh, it's not a priority right.

A

List I was thinking we would put it.

B

Museum thanks at the bottom well.

A

Not the very I was thinking like, maybe after performance, thanks.

B

A

But I don't have super strong feelings. I hop one should be easier updates, the kids that what brought us all here, but beyond that I also kind of like simplicity in focus I like them all I mean that's like they're. There.

B

Just put them in alphabetical, tur.

B

So if people say whether you have it there's a little medical.

C

Ok well, I would say before between extensibility and performance or either that are between focus and extensibility. Ok,.

A

Yeah I like that so sort of slot for slot 5.

C

A

C

After focus, yes,.

A

Right after focus, yeah.

C

I like that, because, like like easy, easy, simple focus, those are like concepts you know like just general and then like extensibility, security and performance are like implementation. Things right like I'm, it kind of grouped together. Okay,.

A

Like it and then we have sort of a one or two sentence: explanation right now about each principle, and what do we want to say about security, and is this worth talking about now or should we just start writing some drafts in an issue and review there? Okay, let's create an issue on backdrop, semester org, and we can't figure it out.

A

Okay, that was exciting. Thank you. Pmc website. We talked a little bit about the website in the design and usability meeting in the last hour. But when we talked about the demo button, we said it wasn't working and we have news apparently Nate thinking up a button in the last hours so fix now, which is great, and we can then move forward about replacing Pantheon button.

A

That's currently on the home page with the demo button, but as just pointed out in the last meeting that button, the Pantheon button is the only way to currently install a doctor up on Pantheon. So we need to make sure we get the secondary page up at the same time as we remove the bottom. The camera button right away so I think we have a secondary page.

A

It's a view somewhere, I'm, not sure I, think it's accesses and turned on or I don't know, but all the content should be there and we just need to kind of do it like once over it for design. It's been a long time since the design make sure it's okay and then first about so should we create a straight board theory: okay,.

B

Do we already have a aneasha for replacing that, yes.

A

It's like don't forget the number, but there's an issue in the.com. Oh wait! That's right here so issue number 476 at a home page button should have related issues linked from it. They might not be all nice and orderly.

A

Okay, so that's it for peripheral stuff this week that rolls into effective CMS progress report Nate. Do you want to talk about I, don't have an issue on here to 113 one, but we should probably talk about that section. Yeah.

C

That's a really good thing to cover so I see it need to pull up that issue. We had an issue earlier today actually filed a couple of days ago. That's we had a problem with the changes to the entity, API that we added a consistent way of working with entities or access control and as part of that changes change, we had.

C

We made a the entity type method into a static method instead of just a normal one and that caused an API break that affected a bunch of contribs, and so the reason why was that it was for convenience, basically that it would be nice if you could just say no :, : entity type and then kept back the entity type of that thing without having to create a new instance, but it wasn't actually required as part of that overall API addition to add access control, so I saw there were a bunch of different issues, open saying: oh, we have to update our modules to comply with core, but instead of doing that, I've gone through and kind of posted to all those contributors, saying no, no, all fixed core.

C

Don't change anything and so we're just going to remove the static declaration and basically under the API change, because I had a lot larger impact than we had expected. So because that's a really big problem, let's say this: the issue number on this is 38: oh nine, three, eight or nine and that's already been merged and pushed into the 113 dot, X branch and I.

C

Think because this is such a big thing and we don't want, contribute to start updating and then break when we do the reverting like you know, we really have to get this out as soon as possible.

C

Today, yeah I was I was thinking maybe after this meeting. If that would be okay, there's only there's only five issues so far they've been merged into the 113 branch, so I think there's gonna be really trivial, but it is important, so we should get out there quickly if you, okay, that's kind of it. For the 113 update then looks like in the agenda. We also hadn't removed.

C

Any other bug fixes that we might want to prioritize, but I really think I mean that's the only one that I know of that was been super critical and are there any other issues that you guys know that are in the prioritize list for 113 the branches a whole.

B

Critical ones, but interesting ones, yes, good again,.

C

Cool yeah I went through the are TBC lists and that's what those five issues are I know there's also like another like forty issues or something like that in the 113 one list, but they'll probably just keep up to 113 yep.

C

We still haven't actually deployed to some of our upstream locations like Pantheon. Our policy is usually waiting two weeks to make sure we get out any kinks. This definitely qualifies as kinky.

C

So but but I think that we'll probably still strive to make another release at the two week mark, so we'll probably still make one in early June just I mean this is just really important, so we need to get it out and then any other things you cross. If you lean or.

A

Get that next Wednesday, what's up to week, markers next Wednesday, correct.

C

B

So, are we saying that we're gonna have a 113 to next Wednesday or because we're gonna have the one today, maybe we'll extend it to a two weeks from now.

C

A

If there are any other case.

A

We can do another release soon and if everything is going smooth sailing, then I would say you know maybe on Wednesday nothing has come up. We pushed a Pantheon and at the two week mark yeah.

C

Yeah I'm a little bit fuzzy with the two week concept, because when I was saying early, June, sometimes two weeks after the 15th is into the next month. But sometimes not me.

A

C

A and I January, either only.

A

You ever September.

C

Oh yeah I guess it never applies, then actually.

C

Well, nevermind, okay, all right! Well, anyway, the the immediate plan make 113 1 make 113 in the next one.

A

C

Needed, but within the next two weeks for sure and.

C

Great I think that's all that we have to talk about for the for the bug fixes. Otherwise, I know that we've updated, like backdrops EMS torque to the latest version right, Jen, yeah and anybody else updated their sights up any other I.

A

Updated three sites: that's how I discovered all of the tanks and vector on the forums updated mm-hmm that found a kink to uh and the API site. Great.

C

Ok, let's talk about 114 Jen I requested the beginning of meeting like last week and the week before, we've been working out how to prioritize features for 114 and actually for all kind of versions going forward. Could you go over that again.

A

Sure so I also posted a link to this page in the agenda. I'll post it again in the Gator chat into sidebar, but I wrote up a documentation page after our last meeting. Since it sounds like we finally figured out a sensible way to manage milestones, I wanted to write it down so that everybody who is coming to work in the issue queue could figure it out.

A

So I put a section for bug, fix milestone, so it's just sort of what we have been doing or basically you can't have anything in the bug fix milestone unless it has a pull request, unless it has been deemed by a cork emitter to be a super high priority issue, um and those would like folks something like this. If we didn't have a fix for it, but we know it was important, so they're quiet Rancheria are.

A

It must have first been tagged with a minus one candidate like one person, it must have had the milestone candidate added by a second person. It must have a recent poor question to put near ready states. That would mean something that got a pull request like two years ago and doesn't apply anymore could be bumped and it must be suitable for a bug-fix release.

A

So something that's not a new feature and I tried to outline that saying it's either going to be tagged with the label, bug report type task or have user experience tag in the title or a cork emitter must have said. Yes, this is appropriate for bug fix release, so we have some things are like kind of.

A

We have one issue right now: I think that um what was it converting comments to views like could maybe be a bug fix, but I think it might be better as a mind as a minor release in a new feature issue so stuff like that, where I think we need to get core committers sign-off and whether that's allowed and then minor releases, which is the thing that's new here, is how do we figure out what goes into our next milestone, so the requirements there are that it has to be tagged with the milestone candidate, minor label.

A

It must have an advocate and that doesn't have to be a person, who's gonna work on the issue, but it is a person. Who's gonna push the issue forward, and then we also explained what an advocate is in detail on this page, where we said the Advocate would ideally be able to attend most of our weekly meetings to report on the status of the issue. That's not possible, then you can put an update or summary of issue into the issue queue and that way or into the top post and the issue in queue.

A

And now, if someone in the meeting can understand the progress of that issue and report it to the rest of the car, so basically we have someone who's gonna, try and make sure that those things make their milestone.

A

Then there's one exception to minor release milestones and that's. If you have an issue, it's a feature request that has a pull request. That's ready to be committed. We can add that milestone to that issue.

A

So, in the same way that if you have a bug fix with a pull request, it can get added to the bug fix release if you have a feature request with an RVT sequel request, I can get into the minor release so that way, if you are working on something that hasn't been a priority, but you get it all the way to done we're, not gonna prevent that from going in, like that's good work, it's ready, but we do want to have a list that will help us prioritize. Let's laughs,.

C

There's some note in here saying: I, think that make sense for, like our TVC state means that it can be moved into the next milestone like right away, yeah, but there's a comment here saying that the advocate for this issue can cannot also be the advocate for another open issue in this milestone, unless, of course, the other issue has a pull request in the near ready state yeah. Are you saying that if you were an advocate, there's this documentation been saying?

C

If you were an advocate and you've got something to art to be see, then at that point you could go and advocate advocate another issue right.

A

So we don't want to make sure that you only commit one thing in three months like if you're super motivated to work around, like eight things at a time or eight things in a cycle. That's fine, but we don't want you to have any things at a time we want to have in succession, but there might be a period of time where your pearl request is marked our TBC and it's not getting reviewed. It's not getting merged. We don't want you sitting around doing nothing.

A

So at that point you can adopt another one, and even if your art to BC issue gets bumped back to like needs work that doesn't mean you'll have to remove your other issue from the milestone. You can go back and forth between the two of them, but one of them has to be close enough that it you're not confused about which one to work on okay.

C

And maybe this China, it didn't make sense when I read it, but I was like seems maybe there's no another way to rework know.

A

What we can work on the wording Gregory from doing more than one thing in four months.

B

The exceptions are for me yeah, so the words that you just said now make it more understandable day, one it's what it's already.

C

B

So plain language that we don't want to stop you if you want to work on other things, things like okay,.

A

B

A

Okay, that's good.

B

And yet the the the notes on the definition of the issue you had forget where, like the last one, was the initial version of it said that you had to solve like attend the meetings, and that was very limiting, because some people don't have the time there aren't favorite time zone. That's why we adapted it to sort of like. If you cannot make it then here's alternatives. The point is that try to get an update to someone that can get it during the meetings.

A

So following our new rules, I have adopted one issue or 114, and that is core field of all file entity. Bundles and that's because right now, I feel like that. Jeff's priority should be on feature compatibility with Drupal in particular, Drupal 7, so that people are updated for some don't have to use.

A

All the way there and I think this issue will help bridge that gap. That's why I want to help um I noticed.

B

Then sorry you froze there for a moment. We can, you repeat the last like 30 seconds, I.

A

Want to work on feel the whole file data tunnels, because they're not the same in vector poor as they were in Drupal 7, contract and I think that working on that will get that difference.

A

Resolved I also feel like it's pretty close, because doc Lamont did a ton of amazing work on it and what prevented it from going in the last time it was almost ready, was usability stuff, and so that's why I'm motivated to take it over, because I've always felt that file enemies in Drupal, 7, contributed a nightmare and I would love to try to solve, resolve that problem or improve it slightly. That's all I can do so that we can get it.

A

Gregory, it looks like you've adopted trusted host patterns, which is a security improvement that Drupal 8 has. This goes nicely with our new principal security.

B

Yeah and we decided that we should at some point have a dedicated security section, like maybe configuration security or something like that, the product itself. So this is a stat. This is a good candidate, so where this issue is left at it's the implementation impact rope is a bit more less intruding. Does it say so? It doesn't prevent you from installing bat-rope and it's not a an error. It's rather a warning and the that the goal is to have it be configurable via the user interface and via the settings.

B

Php yeah, yeah yeah, so where that that is that it was waiting for code review and testing. So.

A

It's pretty close, yes,.

B

A

Can almost have another issue, yeah.

B

So so long as I find someone to our thule see it.

A

And then the other one I left here, digital signatures on project packages- that's assigned to you currently I- think cuz. It's still like 90% reviewed, but not all the way, and so I put you down as an advocate for that one. But Jeff Franklin could be the advocate for it if he wanted so I, don't know but you're both working on that one. So we'll just leave it there and let you guys fight over who gets down it. Cool.

C

So this is interesting, so that means that the three issues that we've got listed in the 114 minor version right now, at least that we've gotten this agenda. One person present is the advocate for each one of them. So does that mean that we're going to start having the Advocate be present to talk about their issue and the meetings we.

A

Didn't cover this twice already: yes, if they can, that would be great if they can't they just have to put an issue summer on the issue in the queue so that we can. When we make the agenda, we can check on it and see how it's doing yeah.

C

Great okay, I'll should I go ahead and start on signatures on packages. Sure, okay, all right so issue. 1992 is our digital signatures on packages that John Franklin has been leading the charge on we're working through kind of the necessary infrastructure to support it. Currently, we did make an update to project module a couple weeks back. That makes it so that it can now be XML.

C

Feeds can be altered by other modules, and that makes it so that the code sign extension to project module can now start inserting its information into the update, XML feeds, and so, oh sorry, that's I'm getting out of myself that change isn't yet in its RTP seeds, issue number 25 in the project module queue, and so once that is in place, then we can continue proceeding, putting code sign or the functional necessary for code sign into project module and getting the the signatures in the XML feeds and then from there we'll flip back to court and start actually having the XML feeds start being respected by by court.

C

So that's where we are on that there's so many like really crazy changes. Recently.

C

Okay, thanks going on so I'm hoping to get back to that shortly. That's it for me! Oh 1992,.

A

That's I think for all 114 issues that we know about, um but there are a bunch of people who do a bunch of great work on course up who maybe not aware of this new policy or process ocean yeah and so I would encourage anyone who wants to work on something and hasn't anything the priority to continue to bring it up and get her and the issue queue. However, and we'll try and spread. This information is not just making.

B

Other than the past's that are targeted for the 114 I would also like to push for the views cross boards yeah, which can happen in bug, releases, not 114, but even if not all together, maybe just one sort of like that's one issue at a time which has multiple pull requests. Yeah.

A

I think I was last week, but I think I spent some time. I wanted to make a similar meta. You know we met her from use that links all the issues to have all this ones.

A

I also wanted to make a similar meta for all of the other modules, because we have a page that lists them all, but no, not all of them are linked and then I wanted to go through and make those lists of commits because I know that takes a lot of crazy, get magic to happen and I just figured out how to do that for views and I would love to do it for other things too, like you have to start by going back to the point in time that the project was committed to backtrack or look at the last commit on that separate project from that particular point in time, and then that's the point forward that you pull commits from and that doesn't always map to a release in Drupal world, so like we've merged in the dev branch abuse right.

A

So it was a little hard to figure out exactly where that came from. So, if I can help with that on any of the other issues, let me know or any of the modules I think you should definitely be our priority. So there's been a lot going on and you slightly and there's been not a lot going on a lot of those other Drupal 7 can trim projects but I'm definitely happy to help set up those metas, if that makes it easier for other people to do the cross. Porting yeah.

B

I think that when it came to coarse porting from Drupal, he was def that he was adding the script required at the bottom of the feet issues. So there is.

A

B

A

B

One problem that I noticed is that some of the links do not work because it wasn't pointing to right the lane or something, but it's an easy sell to search and replace so I've been fixing those okay, but I can't remember who was the links to the commits or the links to their respective issue? There's.

A

Probably the commits because we wrote that before get changed to get web good.

B

D

B

Okay, yes, I, don't know how to sort of like move these issues forward, but yours is sort of like more critical, that I say or because it's an integral bit of backdrop Cornell and we did it in a lot of places. Oh.

A

Also need for today's really speaking of use being integral. We committed something recently that broke filters like a filter operator and in the drupal issue queue they had a fix that didn't actually fix the problem, but they had an earlier commitment did, and I was recommending that we commit the fix that actually fixes the problem and then, when Drupal 7 lands on a solution that fixes it in a way that they like better.

A

We can merge that in, but right now, with our core views broken, it is presenting some issues on sites that we're working before we I think it was in 112 where we broke it. Wow.

E

A

Yeah, it would be good to revisit that issue and I can I can try and find it. It's marked our TBC, so hopefully it's easy for you to find, but I.

C

Don't care anymore I could be.

A

Okay, mm-hmm well I can find that issue all.

A

C

Effective thing that we want to fix up today, yeah.

A

If we're gonna do a release, it would be great to not do it to include a fix for use in that release. Okay,.

C

Let's take a look yeah.

A

All right general discussion, open Q&A.

A

Thank you quiet Justin's here. Should we talk about moving back to of CMS that we're gone to a new server.

C

Sorry, Joseph Justin yeah.

E

A

Right now, the only urgency is that our sanitized service is on the new server and the site is trying sanitizes on the old server. So it's not helpful. People are trying to get such.

C

As database isn't.

A

That we don't have that hooked up, so I think I was like what we could move sanitized back, but really I'd. Much rather move back top CMS I worked forward to you, so the only problem just says that Nate and I are gonna, be out of town until Monday I mean it's a long weekend and not sure I won't ask anyone to work this weekend anyway. Well, maybe we can schedule a day next week to do a car over yeah.

C

I thought it is backed up CMS toward the only site left so.

A

C

Farm is over the dip them and the API site is over. Look.

A

C

Who I sort of site is over? There might be one of those. You know. We've had a couple of weird. Oh.

A

I, don't think we set up cbc room yet, but Spivey or oh yeah I'm that backup see I'm Esther org. It's gonna be on the new server to see.

C

Okay, thanks I was gonna start the forum localized and there's one called ECU for the doctor about dates. Yeah.

A

It's good. Nobody ever used that one, although it was a really good idea, but now Gregory wants to use it again. So initially I was like no one's using it. We don't need it. Gregory's like wait. I want to use it so I.

B

Think craning those the ones that suggested that we can use a github API house to do some motivation and that- and we sort of like said okay, let's put the DCU on the side, but they get have automation ever happen. So maybe we fall back to the.

A

Is that for every control that we put in back to our core, we can have it running on a Drupal, 7 site and then anytime, there's an due to the module. The triple7 site will email someone to go: hey, there's a new update up for links and that'll help us know when we need to create a meta to include all the crosswords for those yeah.

B

And ideally not mail, one single person, but a team of people that would work on the cross sports.

A

So I don't know, it's definitely I think we can set it up on the new server and decide if we need to use or not, but there's nothing of value in the old site, like you know, like I'm.

E

A

E

A

E

A

E

It can be tested well, well, you know to make it live well to the database.

A

Up to you, I, don't think I, don't think anyone's logged in I. Don't think since you didn't moved it so.

B

Yeah, it would make it easier if I had access to just push changes there and manage it, because it's like it's not user facing like what can ever even get it behind a shield. So.

A

We can something Oh like we should password protect it, give you access and then I get every bout, so you can manage it because.

B

Now I have to always like poke you and say, and please merge this one. So I can manage that. So, if I can have my meds access to your the report that then it would make life easier. Yes,.

A

I also recently set up some better group handling on github for our control projects. So there's a group for every site. So if you won't commit access to individual site, you can do that, but there's also a like web team that has access to all of the sites. So I think where you might already be on the web team but I'll check and make sure that if not, you have at least commit access to that one.

B

Okay, yeah. That would help so.

A

That way, we don't have to I, don't have to add someone to like eight properties when they ask for permission on this. We guy cares a lot yeah.

B

And and the reason why I think so, I kind of member the last time that wasn't dated so it might be even an insecure version of Drupal and I, don't want to compromise the rest of the sites. That's why maybe password-protected like under a shield or something.

B

E

B

E

A cutoff date, you know what do you think backdrops Ibiza yeah.

C

How does Wednesday sound the 29th.

E

Yeah looks good to me great.

C

A overtime Justin well at least I'm, open to pretty much all you can yeah.

E

um I felt, while I'm available after night yeah hard.

A

Time your time, my.

E

Time yeah say yeah.

C

E

So Sam in here, okay.

C

I'm gonna send your invite okay.

E

Know what it's a there right, it's just narrow difference! Okay, that's right from you guys.

C

Right here, calendar but I do so.

C

Sorry John I sent you an invite outside of your working hours.

A

I didn't know I had working hours. Thank you, I! Don't give.

C

Me an alert saying this is outside this person is working out, or so you should enjoy meeting yes.

C

A

So I'll start on release a release, meta or 113, one yep and every year around Oh new things. Yes, um okay, maybe.

B

Would be a great idea to get a what you call it an announcement out because we didn't for the 115. Oh.

A

Well, so we do write a blog post and then we need to send the blog post to the marketing team, so they can put it in the newsletter. If.

B

A

Has any time to work on a blog post? Don't we now and eight weeks from now when we do the second release in push to Pantheon, okay,.

B

I don't want to set the newsletter.

A

Before we push the Pantheon focus, okay,.

B

A

B

So we sort of like Tessa, sometimes they'll, hunt, all so universe.

A

113 1 to Pantheon I forgot what we decided. No.

C

We're gonna wait, I think I always do yeah. Okay, well,.

A

We always wait until the first bug-fix release that that's now so I know cuz. This is early. It was different. Okay sounds good. Do you.

C

Alright I just have had something to say before we great okay about hosting right, yeah.

F

So I took a look at ways to respond to other modules. Doing a database update and I wasn't able to find them a thing you.

C

F

Well, we would have so themes. Don't really have that kind of functionality in.

C

F

Module I think.

A

You can have updates, but I don't think they are definitely don't.

C

Everything that being they've branded update hook but.

A

I saw documentation somewhere. That said, most themes don't have updates, but that means that someone wants try. This.

A

Anyway, carry on, let's pretend it doesn't.

F

So I wasn't able to find a hook that allowed me to respond to some other module doing a database update right, but.

A

There should be a function within within the theme that you can call little generate the new files right.

F

No, mostly all.

F

Yeah, it's the submit handler so.

A

Probably, what we then need to do is abstract that out into a separate function that can be called and then the submit handler should call it and so should whatever it is that so that we can call it from an update. Look anyway.

F

A

Hopefully, that's not go in together.

A

And then Nate, you are in the design meeting, but the problem space we're facing right now is that if we made a change to the way that team colors work, we might want to regenerate all of the color modulized versions of that scene, which generates CSS files and right now. The only way those files are regenerated by hitting save on the game settings form and we wanted to be able to do it in an update hook.

A

So we were thinking about adding it to something like system module, but your gut on that, too, would be that's where we should put it or yeah.

C

I would think so maybe color module since it's oh.

A

C

Every generation but yeah yeah.

A

That's good yeah.

F

My my idea was, or that we're gonna have to do this anytime. We touch the theme, and so if we could just have like an automated thing that just regenerates it without needing an update hook, and that would be better because and that would allow like anything in the future.

A

We probably won't touch the theme in a not update right like if we're gonna be making changes. People Aaron, that's gonna, be a time when people probably run that feat anyway, right.

F

So yeah, but it's like we should come up with a way where we don't have to write a new update hook. You know module.

A

But that's what they're for! But what can you explain that downside to that so.

F

I work on a website that has several hundred update, hooks and I. Don't know it gets unwieldy, but they.

A

Only run once yeah.

F

C

I can see this being a problem for control Poncho's that have color integration, that they change their color options. They don't have the ability to have core run an update hook for them like we do. It's.

A

A pincher pouch, all I can add an update hook in contrary.

C

A

Can trim 15, oh yeah, so maybe so. The bigger problem here is that themes need a way to run, updates.

A

Regardless of what they're doing this smaller version of like just regenerated, color files could maybe be handled by some kind of a theme setting that you could define that would trigger an update and color module could be listening for that trigger.

F

Right, well, that's that was my original question as I can't find that trigger right. We might have to make one okay.

A

Yeah, that would look like the kind of thing that would have to also only have to be run once like exactly like an update hook. So I don't know if that's like a config change. That would then gets changed back.

A

C

I, don't know like I, really don't like things that aren't like you know, listening all the time you know like did something change. Yes, then then do something invisibly like on the first time. The page is loaded like I feel like any kind of update like if you update a module or theme like the process to actually apply that update. You know should be explicit.

C

So something like updating a theme actually seems like you know. If you've added new color options, having the release notes, say, save your color form seems kind of okay, I, don't but I, don't know.

A

We could so what about the state system.

C

Yeah this well I mean when, when does the regeneration action occur? That's kind of the question I think like we didn't get started in state yeah. But what does the check against state says? Okay, this.

A

C

Kind of module win.

A

So the color module could define something like regenerate new themes, files, true/false right and you put in your theme- be like okay, it's time to do it set to true and then color module would be like. Oh okay, this is it such a true regenerate file. I mean something you don't like me, because it would needed a moment that check.

C

And that regenerate equals.

B

C

Would that happen like a nastily yeah on cache, clear.

C

And I may be regenerating CSS file isn't terribly expensive thing, but it is kind of expensive and it's like a thing that it seems pretty unlikely to change for most cache clears like it's not really a cache. It's literally like a CSS of your site, yeah.

F

F

It does like have a folder where it just generates new copies of all your files and stores them in this folder. Every time you save your settings, mm-hm.

F

So I don't know, have you messed with it a lot lately, the the preview thing regenerates all the files on the fly. Every time you refresh it mm-hmm so it is I was actually surprised by how quick it was yeah.

C

A

Just if you guys are curious, Drupal 8 has bean update hooks.

C

Those Drupal 7 I am checking.

A

You think I would notice.

A

Nothing about it in the hook, update documentation.

A

Your account I.

F

Think that this is kind of similar to the thing where there's an issue to put color color pellets in config, but there's a problem with getting them into config in the first place, because themes can't have config files at the moment, so that this seems like a kind of a related thing.

C

Yeah, sir, if we table this I think we're kind of running running along and not really relevant for most yeah.

E

C

Visitors or most viewers, yeah.

A

C

Yeah and I'd like to get started on that the one 13:1 release, so at the very least, could we just wrap up and say goodbye to everybody out there thanks for joining us today and we'll see you guys on the Internet mr. coming, everyone.