DFFML Rolling Alice: Engineering Logs: Volume 1: Coach Alice, 28 Jul 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Coach Alice: Volume 1: Part 39: Refactoring and Thinking About Locking of Repos for Contributions

Description

https://github.com/intel/dffml/pull/1401#issuecomment-1197407300

A

Where we at we are on youtube all right, thanks youtube. Okay, I know I didn't uh this guy said some interesting stuff, good good thread so.

A

Okay, so I realized that uh the refactoring that we did really made no sense, um it didn't I mean like it made sense, but it it was a little clunky. So, let's see where we're at right now, um I think we've been working on getting the yeah. I think we've been working on getting the overlay infrastructure working so that we could do the dynamic applications so that we could fix up the flow and whatever so that we could do the uh addition of the arguments to the meta, um the meta issue creation.

A

um So I think that that's not a very high priority right now is what I realized. um The meta issue. Creation is kind of icing on the cake and we don't really have time to support the plug-in interface on top of that right now I I'm going to be taking a month off here in august, so I'm going to step away from the code, um and so I don't have time. I don't have time to do that between now and then so somebody wants to pick that up.

A

Please go for it, so I'm going to go ahead and save this and we'll just do um what we got here so yeah, let's just dump it out.

A

Come on locals.

A

A

um Do I have to forward the port or something I think I do.

A

No, don't run the sleeping straight, I think. Oh maybe I do need her now. I don't know. Let's see.

A

Four: nine: nine nine.

A

Okay, there we go.

A

All right, let's say there, we go okay,.

A

So I've been doing this new thing uh where I think what we'll do is we can all kind of post in that in the comments here. uh I think this is gonna work pretty well, um so, basically, we'll post and I'll try to set it up, so that alice will scrape the well okay. We're not gonna do that now, because I'm not gonna have time for that, um but basically um yeah. So basically we can just use like because I was using remember so we were using like we were playing with.

A

Yeah we were playing with the this, this style of dudes right, so we're playing with this style here right. So, where we're doing each engineering log, we do one so now, uh we'll basically do this per day, and that way we won't end up with a large common thread, and that way we can go back every day and see see what's what on a daily basis. Okay, so um so yeah, I guess what we'll do right here is. I guess I can do one of these right, so this would be here's what we're doing and.

A

Refactoring and thinking about locking, replace, okay, okay and let's do the metadata thing.

A

All right, we're evolving right, we're evolving that we're evolving the process, we're we're trying to figure out what is the what is the most most efficient process here? Okay, so, okay,.

A

A

Okay, so now that we're here, okay, so I think, let's just uh oh we're gonna paste this dip.

A

Okay, so we'll say.

A

This, which was some work on right so stash, is great, but stash doesn't help anybody else. If it's on my machine so uh hopefully once we switch over to the web5 stuff that we'll fix that um so saving this diff, which was some work on dynamic application.

A

System context, or of overlay so as to support the support fix up of the of the op imp or meta issue body.

A

A

Issue: bodies inputs.

A

We are going to table this for now for time reasons, uh but if someone wants to pick it up wants to pick it up before john is here before johnny is back in september.

A

A

So we'll just make a note here: please create an issue right if you want to work on this okay, nice, so there we have the div okay. So now, let's get into what are we doing today? So we noticed that the so I noticed that that we have an issue with adding new files and locking right. So if the current, the current uh lock is on the get repo um spec whatever that is and get revo whatever it is, give or pause.

A

Tory what is it.

A

Okay, we both back.

A

Get repository.

A

Okay, so uh if we have so, uh we then convert to owl scare repo.

A

At which point uh we are all anything anything that takes it that takes alice, get repo.

A

Will then oh wait? Actually? Is there a lineage there yeah, so the the problem is that these things will all be executing. Basically, so if we throw all of these functions all of these um operations into the same data flow, then, for example, if we have contributing and readme when they try to create the branch, it's going to have a problem and also we're going to fix up the fork thing. So we'll do that next, so then to do.

A

Auto fork repo: uh it's not no.

A

Before or yeah before, push okay.

A

Push through all right create vr, okay and then okay. We will then so uh well. Well, then, okay, so.

A

At this point anything so if we had both read me okay, so you know what this isn't even like. I think you guys get the point so um okay, so we have the transcript here. Let's just do it.

A

A

A

Let's see, does it run now.

A

It doesn't run it doesn't like that. Okay, it basically says the pro request for master already exists. Okay, so, let's maybe add the fork code, so cd entities.

A

Recommended standards.

A

This structure makes no sense, we're going to throw it in. You know what it is. Basically issues at the yeah: each file, okay, operations.

A

Okay, so maybe pull requests.

A

A

Read me pr, read me pr title: can you hear me so you can hear me great okay, so reading pr reading pr body preview, pr title so.

A

Okay, so this is.

A

Your ghpr create.

A

Okay- and this is basically saying gtfo- you already have a pull request. Okay, that's fine! So, let's add the fork so origin, so writable get remote origin. So where does writable get remote or get crap readable, yeah.

A

Permissions checks: oh okay, permissions check party owns repo okay.

A

So if you're already on the repo, then we're gonna do this permissions check origin, okay, so.

A

A

A

Okay, so already owns repo should probably return its own thing. So.

A

Rounds repo- and this is a new type.

A

A

Okay, so maybe this is a github dot.

A

That is okay; okay, that's a bull.

A

A

Already owns repo.

A

Okay, this returns an origin. If we already on the repo.

A

So this returns an origin. If we already on the repo, we wanted to say, create fork if not owner.

A

Okay, so already owns repo.

A

A

This is doing two things.

A

A

Origin, url, okay, so we check all the origins and we see if we can post if we can push to one so already owns repo. That's not what this does then. Basically, so, basically, what do we want to say? We want to say: okay.

A

We want to check: do you own the remote on a base branch? That's what we want to check, because if you own the remote on the base branch, then you can push up.

A

If you don't, then you have to make a fork.

A

A

So this is create pork.

A

So the repo is.

A

A

Oh I'm pretty burned out. Okay,.

A

A

Okay, so we want to check the base branch.

A

You know, I think, we're actually going to move all this we're going to refactor all this first okay. So now, let's get repo already on two phone.

A

A

Okay, I think we're going to throw all the functions back in one file again. Actually so erdeon's repo honest, please contribute regulate, okay, so.

A

hmm This is where it would be nice to be able to do like a type transformation.

A

A

Within the data flow definition, and so what I'm thinking here is basically, if you're defining a class so say we pulled this thing out here right and it's using stuff. So so we pulled this thing out right and then.

A

Okay so say we pulled it out: rdns, repo, okay and face.

A

Okay, so take some directory longer.

A

A

And then it returns the origin, okay, all right, okay. So so, if we did an auto def on this, if we did an auto def on this okay, so if we did an auto def on this, it should turn directory into its own definition. Okay, so we should do all those definitions.

A

A

Okay, so this is our basic thing here: base okay, so.

A

Url, so origin, so if origin equals base or wait, no that's fortune, okay, so then we have to do to do uh check if origin is for target branch. Okay, yeah. So if we can push to the base.

A

So if we can push to the base.

A

A

Okay, if we can push to the base, then we should be able to so. If origin equals equals base.

A

Now, because we'd have to go, do the branch that's r right grab.

A

And it would just be crap dash d, because we want end of line right.

A

Okay, so basically origin main or upstream main, so those are our. So if we had base okay so then we check each of those and we'd say: can we push to that origin right? So if you have the base, okay so base, so what origins can I push to basically.

A

So we're going to come in we're just going to say: please make this contribution. Alice is going to say well what origin should I push to and she's gonna say basically.

A

So if it's your own repo you're not going to make a fork right.

A

So if you so maybe we don't clone it right, we can't so we can't assume that we're cloning it because everything is overlays. So if we're not cloning it we look for the base branch, which is the default branch.

A

A

You can do set origin, can you do get origin.

A

Oh branch show current: that's all it takes to get the branch. Oh wow.

A

A

A

A

A

A

Whoa whoa, what the is this.

A

A

Okay pushes to.

A

Okay, so local branches configured for get push so get remote, show origin. So.

A

How do we do the face.

A

Then feature get yeah operations.

A

Default branch here: repo good default branch; okay, so get branch dash, r.

A

Okay, so whatever one we're pointed at okay.

A

Okay, so and then it returns the branch, let's return, the origin.

A

All right so good origin.

A

Branch for branch.

A

If branch, so, if, if there so basically loop through all the branches loop through this list, if there's an arrow split it and grab.

A

Whatever the last one is.

A

So yeah grab that zero with indexes there's only one. We wanted these to the arrow split. It grabbed, whatever the last one, so origin master, so main dot, split.

A

A

Next split one: okay, so that should return branching origin, so good origin, because.

A

A

A

Okay, now I should return origin.

A

A

A

This is not us, of course, okay, so.

A

Okay, so what did we do here? So we basically said.

A

So we need this back.

A

A

Okay, so already on gear repo itself, repo dot directory.

A

Base logger equals self.logger all right.

A

Doesn't like this, it doesn't like line 43.

A

that doesn't like that.

A

Okay, now we should have the same thing: okay, okay, repo default branch.

A

List object has no attribute split.

A

A

Left a little cop deposited there.

A

Okay base is not defined okay, so we must be getting the origin. So let's go see where it is there. It is good origin.

A

Origin, master: okay branch; okay, branch; origin, origin, master; okay, so we up.

A

A

So this is backwards.

A

And we'll say.

A

We'll just put a little comment in here.

A

Or this should be remote.

A

A

That's it for the remote tear them out view them out.

A

Where is it I'll put branch get branch from.

A

A

Okay, here it is yeah remote origin branch master, okay great, so we have that data now.

A

A

A

Okay, and so now we added them both. Let's see if base isn't used anywhere else, let's see so base base branch. Okay, so we have to get actually this here.

A

This would be this base branch thing, and then we have git remote, okay, so base branch, okay, and so what creates that base branch.

A

A

So this alice, please contribute recommended. Is standards recommended community standards? Overlay get okay, determine base branch all right, so this basically just says okay, so it's just it's a pass through determine default base branch which I think that's spelled the terminal okay, but it basically ends up doing this.

A

So github permissions checks, so we have to go dot, dot, dot, dot, dot, dot and then dfml operations good, contribute. Okay,.

A

Operations get contribute, okay,.

A

Okay, so yeah there's the base branch. Okay. So then we have git remote.

A

Okay, future kit.

A

Okay, let's see what happens so. Repo is not defined. Okay,.

A

A

All right, so if the origin doesn't equal the check origin, then.

A

Okay, so we don't even need that.

A

We actually just need that base branch.

A

Face okay, so we're gonna want that one.

A

A

I should have been saying remote dude, that's my bad.

A

Okay, great, so we got the same functionality: okay, so already on skit repo or already owns repo.

A

We give a directory and a remote to check against and given that we're able to say.

A

A

A

Github owns remote all right, so that's more appropriate title for this function right, so it checks if it get repo.

A

If you have a if you own the remote a given remote of a git repo yeah, I like that a lot better.

A

Okay, so already owns reaper is not defined. Okay,.

A

A

A

Okay, I like to do this golang style error out. First, I think it keeps it clean. Okay, so.

A

All right, so I'm realizing this can be simplified here.

A

Oh wait: let's see right, so this is just remote. Okay, so enumerate all the remotes and then go check them now. Okay, yeah! So we really just want to say.

A

A

Okay, oh that's remote, dashb, okay, so yeah look through the remotes. If it's not the one we care about, we don't care otherwise grab the url.

A

Royal number five.

A

Equals urls, okay, so.

A

Okay, this looks better.

A

Okay, that looks much better. Let's do a little tlc, okay, so.

A

Yeah, so this gives us this is a lot cleaner here. So then github owns remote, okay, repo.

A

Then what I'm saying here is that what we're about to do is we're going to go in and we're going to have a few of these right. So please contribute recommended community standards. uh Read me.

A

Okay, wait a minute so already owns repo. So in this case this doesn't matter right, but so in this case this doesn't matter because this is one that's going to be generic across all of them, um but for the other ones, then what we would do is we just you know we just have different types on them right so we'd say.

A

Alice, please come true recommended community standards lead me get repo right, so that will allow us to appropriately scope. So we can place the lock on the alice get repo, and then we can appropriately scope the subflows so that they only run with the readme one at a time, and so that way we only are trying to actually like fork the repo we'll fork, the repo once before we get in there.

A

um Actually will we fork the repo once before we get in there. So we don't really need to fork the repo unless we're making a contribution. So if we are making a contribution.

A

Then we need to fork the repo.

A

So for making a contribution, we need to fork the repo.

A

So we're making a contribution, we need to fork the repo so.

A

We could have.

A

We decide we need to create a readme and we're within the locked, the lock to the lock on alaska repo. So then we need to create yeah. So then we would do this once remote, okay, so this stuff would be within these flaws, and that way, when you exit, you would check again if you're on the remote within the other, contributing check.

A

Okay, but then don't you want to do contributing tricks in parallel? Well, you really only want to do the you want to do the contributing additions. You want to do the contributing checks in parallel, but you want to do the addition.

A

In with the lock on the repo, so.

A

Okay, so you want to do that in parallel, so you would take the repo object. You would say you would make it.

A

A

You would have to remove the lock on the repo object, so you have to redefine the up.

A

You have to redefine the ops that get used.

A

A

So here, when we create these, we would have to say so clone gear repo. What we would do is, we would say up and then this will wrap the clone gear, repo right and we can say um we're actually going to say monkey refill operations like one gear, repo.

A

um Can we do after replace.

A

I think the off keeps a reference to the op amp. Does it.

A

Or does does the op keeper reference to the input, I'm not sure.

A

But yeah, then you would do dot, replace inputs.

A

A

We clearly need a shorthand for this.

A

I know this would be outlets.

A

So it would be the same outputs right, except for.

A

A

So we want to replace.

A

A

Okay, so df feature kit, if not futurecare, future operations: okay, okay, repo, okay, so outputs repo, give repository okay,.

A

Definitions: okay, lock, equals true.

A

Here from df types, last definition.

A

Block or false.

A

All right, this should be the ticket here, um so this should say clone. You know creamy new, clone gear reposter. Now then there was the question about. Does it preserve this.

A

A

Operation, funk.amp lock.amp, so the off so the amp. The operation implementation has an op on it. Function.

A

So if we were to just re-wrap it with.

A

A

A

Okay, I think that's actually that's what we want so then that redefines the inputs and the outputs.

A

I don't think that really does what we want, but here it is okay. Why are we doing this? I think I need a break.