DFFML Rolling Alice: Engineering Logs: Volume 1: Coach Alice, 2 Sep 2022

Previous Meeting

Next Meeting

⏯

youtube image

►

From YouTube: Coach Alice: Volume 1: Part 48: Raise Retry from Exception for Problematic Operations

Description

https://github.com/intel/dffml/discussions/1406#discussioncomment-3538692

A

Hello, hello, all right: what do we got here? This is backwards again, no I think it's just a lot. Okay,.

A

So what do we have today? um Oh that's, right! Okay, yes, raise no retry race, retry, all right, so um this operation that we were messing with. um Where was it so? Please.

A

A

Alice period standards.

A

Okay, so let's go into the readme okay, so here uh this thing is annoying right. So this was our problem. This thing is annoying so uh so, and so why? It's because uh the GitHub API returns a um foreign s, a link to the issue, but then we try to query it too quickly and the uh the server side doesn't resolve the issue and it tells us it doesn't know what it's talking about on the graphql error right, so we tried decorating uh with the op.

A

Try equals five that didn't work out. um So let's go ahead and just throw it here, see what happens um so um yeah. Why not?

A

um Okay and then what we're going to do in response to this right is we're going to go over to your really slow today, computer all right and we're going to go over to memory uh run right. Okay, so if not operation, dot, retry Okay, so.

A

uh So, let's just do this just to fail on that so except exception and we'll say if not operational retry raise okay so and then in this one we'll catch. uh What is the exception that we're supposed to be catching here? I, don't know.

A

A

Where is it here's my notes?

A

So I've got multiple computers, your monitors right now. Okay, so, let's see.

A

What are we supposed to be doing? This is not. Why is this not.

A

Display here we go so what did I say? Retry operation exception, okay, so let's just call it that right, so retry operation exception right. So if it's raised, um how do we do that from? uh How do you grab the from crap? Okay, um there's a way to grab what exception the operation was to run from. So what we'll do here?

A

A

It's always here so.

A

A

All right, so, let's go ahead and retry operation.

B

A

B

B

A

So we can just put it here too there. It is okay. So now we have the exception.

A

Right where's, why aren't we seeing that? What is that.

A

That's because that's sorry yeah so.

A

B

A

A

C

A

Is okay so, basically.

A

Is it oh yeah, okay, so if not operational retry, so basically, if we haven't been told to retry this explicitly, you know beforehand or we find out that it is a retry exception. So we should um so uh I would raise instance.

A

um So raise it, no more tries left Okay so.

A

A

Okay, so how can we I want I want one code path for this? um If operation that we try foreign.

A

A

Okay, so if not retries.

A

So, if okay, so here we go so if.

A

If the air is a retry operation exception, then.

A

A

Equals error, Dot, retries, okay, great: we need to go and modify this uh foreign.

A

Tries equals retries. So then we need to implement the function in BF. um You know we can just.

A

Let's put this in place for now too, if.

A

And now, let's put this until yes, internal or let's see so this is an internal. This is so.

A

hmm Reason or raise retry.

A

I'm just going to call that.

A

Phrase retry all right, so this will be from dot dot. Now, let's see where, where are we so we're in DF? So DF is dot, utilis, dot, dot, DF, Mouse, dot, dot, dot, so DF dot exceptions, import.

B

A

Except the context manager right because we're using a with statement.

A

Simpler context, lab.

A

So what does this thing do right? So it says.

A

It's written here too.

A

A

A

We yield from the middle of our blueprint, so now what happens is- and this is a context manager.

A

A

If there's a typing iPad for this, there is context manager.

A

Okay, so abstract context, manager, new inversion.

A

A

Deprecated, since 3.9, okay and I think are we stuck on 359 right now for some reason, Okay. So.

A

This, like this.

A

And we'll clean up all those typing things later upgrade python versions: okay, so raise the retries okay. So now.

A

So this should be none Okay, so.

B

A

At this we have okay. So if is instance error, then we have the.

A

Okay, so if is instance, error, retry operation, exception, retries equals error, dot, retry, okay, so the first time it goes in it gets set to that.

A

um Okay, so we're gonna retry.

A

Context, octx inputs, okay, context.

A

Inputs, okay, so we're missing a little bit of context here. So, let's see that's not good, so we should really have a context for the call.

A

A

Yeah, we should really have a context for the call.

A

Because that DF now raise retry.

B

A

Oh, we do have context recall, so we have the operation implementation context and it is meant for this type of thing right. So.

B

B

A

To create an op-amp context and run the operations, so I kind of think that foreign.

B

A

If we move this out yeah that might do it.

A

um Okay yeah, this might work so because, quite honestly, if you're running it, you probably want to retry just a run and not the whole context, entry right, so this is probably not what it should be anyway. So, let's see we're running over retries used.

A

See if we have offenders here so um Okay so.

A

We're fine great.

A

This isn't used like this anywhere else, so this.

A

So and here's another thing, I like to do: here's uh with fixlib dot in all context,.

A

Now we are gonna, have a nice clean disc on this um to operation will move the op CTX to the parameter operation.

A

We're not CTX, we want to take location.

A

A

We can do a width.

A

And this should be the operation implementation context.

A

A

Now we have moved this down, so we instantiate the operation when we attempt to run it so retries Okay. So.

A

Okay, so off CTX that we tries so read my PR title.

A

A

To give Maurice retry, or maybe we do self yeah, this should probably be self a raise. We try okay yeah, so this is self-direct.

A

Five times, okay, so then we can throw this method.

A

A

Operation implementation context, it retries.

A

B

A

And we import our exception so now we're going to take our raised. Retry function rather method now and.

A

A

B

A

Let's write a little example here.

B

A

B

Class data flow.

B

A

Yeah I mean I, guess we you know use so.

A

uh Okay, so use this context manager to have the orchestrator all the operations.

A

A

Multiple times within the same operation.

A

Same context and implementation.

A

Context, entry right so they interrupt this thing.

B

A

B

B

A

B

A

So op Ctrl retries equals operation now retry, oh wait! No! So that happens here.

A

Okay, self operations: okay,.

A

A

Okay so pre-trice.

A

I'm gonna have to go here.

A

We're going to retries less than four, so this should come in raise exception.

A

A

C

Okay, all right I gotta go.

C