.Net Foundation Design Reviews, 2 Jan 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: .NET Design Reviews GitHub Triage

Description

00:-04:-40 - Approved: Add StringBuilder.Equals(string) to efficiently compare a StringBuilder with a string. https://github.com/dotnet/corefx/issues/25846#issuecomment-354837835
00:15:54 - Approved: Add MemberInfo.IsCollectible & Assembly.IsCollectible https://github.com/dotnet/corefx/issues/25671#issuecomment-354839520
00:23:02 - Needs Work: XPathNodeIterator should implement IEnumerable(XPathNavigator) https://github.com/dotnet/corefx/issues/1593#issuecomment-354841164
00:32:14 - Approved: X509Certificate GetCertHash and GetCertHashString with SHA256 https://github.com/dotnet/corefx/issues/16493#issuecomment-354843685

A

Yes, alrighty so.

B

Of course, it's a Brooklyn camera hello.

B

Yeah here you go a camera crew and.

C

Alright preferences for water: let's do this drink number four from the top, then we have two simpler moms.

B

You've not much this baby 17 is ready, see the day.

D

Okay, so string builders, you may or may not know as horrendous performance when you iterate over it with the indexer, because it's chunky- and this is a pair of failure- that people fall into logic. Msbuild, for example, was comparing a string builder, the strength this over there in turn start and when the string gets to the tens of thousands of characters it becomes pathologically slow, so I initially tried to find a way to make indexing more efficient and there is a way, but yarn suggested this wasn't worth it so I think.

D

The right thing to do here is add an equals method to take the string and within string builder, it can very efficiently walk along itself. So this can be done both on the spear version. Good I.

E

Don't know about that, I was about to say, do we need all the equals with a custom comparison and and any of that so yeah I haven't.

D

Seen the use case for that, like I, guess you could well, how do you compare what they mean? Maybe should be ordinal comparison. This is literally it's the same if, in other words, if you scroll down slightly and you scroll down like three lines, that's what the implementation would be equivalent to I'll.

E

Allow an allocation I think our default for Strings means comparison, is current culture. Not ordinal is.

D

That for the operator also, you was above all those every way see I mean I. Would.

B

Probably just pass in the comparison: okay, just forward it you fold, it I mean I, don't know what you actually do, I, don't think that's what the actual implementation right so.

C

Stepping back I'll, but you said that you know indexing is slow, so how's. It related to the comparison, because the indexing, because they were doing.

D

Comparison manually or okay, so what they wanted to do was decide whether they already had the string in turn before the native strings another, and to do that they were literally you know for all over the contents of the table, okay, which you would think is fast, but since we made it chunky, it's not so they're, so they're, intern strings and sprinkle. Mr.

D

right literally we're just heard 10 years ago, the stringbuilder built up a string and then it has to decide whether to internet, and it wants to do that without making a new string.

D

Yeah I can't remember so then rolls over door again at.

B

It so my only concern would be. We need to be consistent with the other equals we have, because otherwise it will be a bit of failure in the sense that you can't know all in comparison. But when you do to string it and do the same thing you get different results makes total sense. So the.

D

One one without the comparin as well.

F

That's that's consistency with other, so it which would be here and culture but but.

E

Then a string, compare er, you can't walk a character, my character anymore, yeah. If you have to go straight, which.

D

E

That you've lost the benefit of this method right.

E

The only thing that the equals can do is immediately short-circuit and say that out the same links and then it's going to allocate the string well, you don't need a method to do that. Right.

F

Just cases where they using ordinal explicitly when they're doing the compressions are already this nothing I'm doing it later is indexing to our pie. Chart checking everyone. They.

D

Rain, Dixon and shot by challenging or Northern Pass like we can.

E

D

Know ordinal equals that's, not a bad idea.

D

Do we have precedent.

F

For locals- and you know we.

D

Have compare wouldn't help if.

F

You don't have, we've had a long-standing issue over been people wants to account and reduce and go ahead. I.

E

Mean the only reason that I'm mentioning it here is because then it lets it, compare it character by character without like if it's once its user, everybody has allocated straight and what.

B

You could do, is you could say you have an overloaded, basically sorry, the Texas string comparison if the guy goes or no or in ignore case you have a fast path and if they do the culture sensitive one world in too bad, you, okay right does.

D

That count the sending people to the paper yeah or it would be no worse at it and they would fall into I.

E

Mean I can still do a couple of quick checks of stringbuilder equals strain with current culture says is: is the link that I'm going to allocate equal to this guy nope nope they're anything, but when I'm doing a culture specific comparison is it is it? Is it accurate to compare lengths like I, guess technically, if you're accepting an arbitrary compare, they could have done anything they wanted to. So you.

D

E

Ii more like that, you know that, what's that thing in the.

D

Ssss thing: yes, the beta character to those compare is equal, yes and they presume you're decent lengths. It's.

B

Actually worse, when you to a president more to lower than actually so.

D

You can't bail out with.

B

A link I could do doing your cultures city comparison, it don't see crap again.

E

And again, if it was a custom comparison that somebody put in they could they can normalize that they can normalize anything the way they wanted to. So the only way that we could the only way that we could optimize it is if we explicitly get the ordinal, so it.

D

Would be an emotionally to have one with took a compare then, because, if we're behind the scenes make a string of arbitrary length and further away the.

F

Beef, fair just equals that take a string, but it already exists first overload: there doesn't do any culture where comparisons, it does purely index or ordinal compares yeah, but this isn't use a string, but it's comparing two string boaters, which logically are extreme I.

B

Wouldn't learn it's still the same. Pole invite you to string both sides. You do equal to sit at different results. I mean that was probably a bad idea. Well, I'm, looking at as implementation.

F

Right now, it's not using any normal professionals, just using operators, which is always well.

E

Wait if, if we have an ordinal comparison, that takes a string builder, then the correct fix for msbuild would be take their string, wrap it in a string builder and call the string builder equals method. Well, if the think system on.

D

Yellow why a string builder.

E

With the string, will they just allocating yeah you're, allocating a very small I guess I, don't remember the way that string builder stores is jumped. So it was that's your allocated, turning it back into charm right or is it it does it.

D

Dinah shop, it's, the chunking, is only when it grows as.

G

They either begin to because.

E

If it, if stringbuilder over a string just held that one string until it needed to do anything on it, then this would have been because he's not very pushing right.

H

Yeah, the sixth we're not allocating is never to allocate, is.

D

E, this is the.

H

Hardest path for them, that's why they don't create.

F

A string well that they, partly you, know gaining anything by doing the in turn, check to begin. What is it really worth it yeah all.

D

Things go is done through intensive profiling yeah. It was definitely recruits right now that putting a fakes up that it strings over forty characters and visiting string. Forty thousand characters on this.

G

End even people read a file into a knife. Investors.

E

Presumably, by in turn here they have.

D

Their own custom in very cool. Oh, it's yeah! It's totally custom! If you, if you're interested you go to the click on Pat load performances, how do you think they're going to be able to improve the performance if it is on stringer? It was purely ordinal, because the pathological part is the stringbuilder. When you ask for a certain index has to find the chunk it's in and the way does that is it walks the link list of chunks? It doesn't have any.

E

So you're you're walking is ordering its it's in the worst order and hands whatever right. Yes, where's case, and that's what you actually see.

D

It goes like this because, because each time you have to seek back to the redacted, so the proposal that Andy had was to store the last index because you, if you're, going along the string that will then become very efficient Lisak, and we could do that at the expense of adding another field.

F

Just wondering if we not better just to have a more efficient memory that doesn't have to keep the cracking.

D

Well, that's what we do you know you could you could do that relatively cheaply as long as you were optimizing for the steady iteration of restraint, I, wonder.

E

If yeah, if what we just for it to a bit integrator a chart, so.

D

You can get the characters back in that anymore. Right, put up a PR, something like that and yawns position. Is it's intrinsically not an efficient thing to enumerate, so don't lead people to do that. I.

B

Mean what is true is if we have a method like equal equals. Ordinal right I mean like you, could do something more fancy and not to character by character.

B

If the other traction equals you're, not forcing the caller to do this work yeah because I mean they give you if you internally, holding for like three arrays, you can basically do to me. You know I, don't know simply optimize. Oh yeah, Hertz right, it could be, and yes, yeah, that's right. So.

C

Like I think I'm time to go over.

B

My labels or yeah I mean I, go to have strain. Compare, although I don't think it's insane to eventually have a spring load whose ordinal, which we don't have today so I would not be opposed to adding the same API here. Okay,.

D

B

I think, like the more like, it is a bit weird that we have a string below below that is already ordinal.

B

Okay, I feel like no matter what we do. We don't get like you know,.

C

Justice tree yeah.

B

Consistency, but you know it seems to me, like it's more important on string builder, to be consistent with itself, because it's very weird to have that issue in there. So hey, we should just say equals, takes a string and it's on an island like that's what it does. Maybe that's. Okay,.

E

Yes, it's fair, just as as used.

E

Well, I guess: if ordinal equals returns, true culture equals should always return, always return true, because the same input, so you would never get stringbuilder equals returns. True and then your custom comparator returns false unless it's doing stupid things like checking against an intern to and but you could have shrink builder equals returns false, but to string both sides equals returns. True right, that's right, I would be upset if string builders equals could return true, and then the two string would return false, but that one can't happen if we worked on.

B

Your proposal created well with it the case that there will be a variables culture.

E

I, don't think it could be because the well yes I mean like it's, you would need to be like reference comparison to string objects to something in order to get.

B

Well, I guess no I mean or national always be true, because otherwise you're violating the sexy beauty right. Because ordinal me do you have the exact same pie, pattern.

E

So the only way that it would be different is, if you're preparing it by reference right.

B

No so then, let me just write this up and say.

H

It's unfortunate.

I

I went through said 15 minutes till.

E

Of a thing, we have like three different competing. No, it's true guys.

F

E

Say that's everything. Everything that was done here is roughly.

F

Stringbuilder doesn't take any ups. I can't find any DPS that actually take culture, but some of the API is default to current culture. In these. Oh, my.

I

Mental picture stringbuilder the chili doesn't have like cemented, but.

F

You have a ton of a pen and format, things that don't really taking any cultures easy, which is like a little hard to write. It's just it.

E

The char I mean yes, but if you wanted, if you care about the culture, you could just call the format in the streets and I guess. Appearances.

D

Position actually they mentioned on a previous issue. Was they you could see stringbuilder growing, to have most of the API of strength, so you can basically.

G

You probably didn't consider this.

E

Well, the real question is they're, probably the solution for that with the stringbuilder games, an API that can return a whatever the multi span is of chart and then we've written multi span of chart into multi path, where the memory is not necessarily contiguous chunks really done that Chris stops working on it.

E

It will be less efficient than span, but that would allow string builder to represent some magazine and it's not necessarily contiguous yeah yeah.

G

Might take another bottom, making indexing more efficient.

E

It's like some unused fields. Maybe I could squish it well. I mean there's also an interesting question of like how often / or how often does stringbuilder compact, and if the answer is never it doesn't compact that should.

D

It yeah. Well then, yes, imagine the peat. How much responding does assume that if we take months to get that through.

G

E

Some point to do compaction that indexing.

D

The erratic it it won't matter, I wasn't around when they have made it chunky. I seemed it was to try and keep it out a lot.

E

Of job for you but like if it did something like if it held the strict so where I was like it just held the original strength, and it's already fast then like. If a call to to stir how I see remembered the string, it did last night just returns that again it hasn't been modified yeah. You could do that, but what I'm saying is compaction with the feet that reason that.

D

They did fragmented it and you can just copy into another screen builder, if you like, impacted.

C

At the bottom, we already, you know reviewed that, and the only question was do we put is collectible an assembly or member info uh or type. Actually it was tried and yon with John Hana discuss it later on at the bottom, and y'all suggested that we should be both.

B

So is there any way we're type is collectible sembly as a whole is not it isn't collectability affected a function of your assembly. You are a yes.

C

The argument was that nothing params us in future actually or we should not impose the assembly information on on developers, but in theory like the collectability, especially LC g, is the property of the member not of the assembly like and watch Utley certain cases. The fact that's on assembly is implementation detail, but we want to expose that too.

E

Whatever the thing is that we're talking about the language of runtime spec says that it's a member property, oh there's,.

B

A spec for that I think we just said to feature like it have to those what nine ten I was.

C

Around for long well, I'll see you look surely prior to that right. So what else you geez is literally.

B

Just a single method, right yep, what is Elsie father, Michael generation, but.

C

There's a fake assembly.

B

If you clear a delegate essentially out of then you I, omit I already, don't conceive it italic with member yields and the full-blown recommitted.

C

Go with call dynamic button select length again, which means that we're gonna be frozen again by the way.

C

You have to update the software.

B

It's the drivers.

C

B

Setup man, oh this is a computer, tell you're not.

B

So then I mean, if that's the conclusion on the future aerial and then I mean that's what it is. No poems.

B

And that seems like this is the only two things, because everything else inherits remember info.

E

um I mean I'm personally confused as to why it belongs on two places. If it's really.

C

E

The assembly, then somebody can do pro, get typed assembly and read it in there if it's really a property of the member it further. Why would the assembly know about it, but I guess what Yann once one.

C

Is implementational he provided free opportunites, but one one approach is kind of the implementation detail. The other approach is like an opening.

C

And possibly are heading into like more flexible collectability in future, so I mean.

E

Like if it makes, if there is a thing of like collectability oven is simply, though it makes sense, but if that's purely an implementation detail and there's no notion of collecting and assembly than it should. Oh, no, no.

C

No, the notion existed.

G

A it's not the only notion, okay I'm, just the implementation to do that's. Currently, it's the only I'm just making.

E

Sure that that that we're exposing the API here of the semantics we need to and not be limitations. We have yes, so that's the.

B

Only question I have is what to do with type info. Do we care.

B

Like this is weird thing where.

B

We had this falling before with certain things grow on time, and they should have been also on type info and they are desktop, did inherit, but they're, not in core because it split it. This is epic lilius.

E

F

Impose now remember info is basically the base effort time there are some other in reflection names just like parameter info. It's not like that. Don't inherit from member info, but there's a I, don't think interesting was that again parameter opposed not doesn't inherit from a miracle. I mean physically typing for because they did because an FF o now is reversed. So this the hairs from Type O would they should be something that we had with this in the new contract.

B

The repair shop are you basically, the implication that we have like get type in full and the way it works is causing issues because on desktop, basically, it's the same time just cost, essentially like an outcast and then encore visually different instance right because they actually have a ever split I forgot what this thing is, so you basically have to allocate a type. Essentially you have to wrap the other one to get the correct, behavior husband, induction.

F

B

Maybe it wasn't native.

F

I forgot, where.

B

It was oh, but I guess we don't care.

B

Let me just ask the question.

B

So, what's the representation to be having Cornell is typing for an original type, blue, double.

F

B

There in the service area a check.

C

Right next, one well well: bus is looking at more simpler fish, oh and the first one to.

F

The bottom and a hair trim type I mean if I'd ever let him it gets free, essentially.

D

Mike DN replied the stringbuilder one. He said stringy coasters uses.

G

Ordinal string compare.

I

False to the current calculus me: okay, that's what we said it. You.

F

Can please let us alright shelf.

C

F

Goes does the object, reference quality, yep.

B

Buzzer spoke, I. Think if you do, you know we do string, dot equals a comma B and you don't specify comparison. It certainly is not order.

B

Will first do a shortcut to say or is it same identity then I? Clearly um it's true and then it goes to the other capacity. Basically, for he says one. Yes, it's.

H

A string to compare.

B

In the compare as equals doesn't do culture.

F

No equals is working, looks like you, there's fishing, it checks for exact objects in look, sorry reference equality and then it calls equals helper, which is just looping through char stars and a3. Okay, really I think I.

C

Are I thought equals.

F

Is cultured ho doesn't mind I'm reading unless they have a Virgo which spots.

A

A little wrinkly use.

E

F

But compare is culture.

E

I can't be myself, compare equal, equal, zero and equals. Don't give the same answer. Probably not so you can pair without.

A

Or can wear those called culture to the a so equal and prepare elect no same thing.

C

Frozen to do again.

C

With that, we know, oh.

B

I stand corrected and I could have sworn that. It's not true.

A

A

C

You don't have Jeremy over here or just that. You want to go for this.

G

C

E

G

Is part is liberation invertible.

G

This is this: should have the army. Now there.

C

Are two from German is not inform another K weeks, so the bottom one X bar notes, iterator.

C

The idea is to play since they we got inherit from item herbal of X both navigator, not just iron in marble, so we provide people from groups two-bit custody.

C

Well, we can't remove I believe that I know miracle all stop implements as well. I know marbles on it. Yeah like this is not the X representation.

B

It will be not.

E

B

A

Because they have different return, types of the same river, no I knew move of T implement. Sign you another.

B

The only unfortunate thing is that means that the default that whatever.

C

Turns Publius will be the jerk.

B

Base actually I commander that.

C

You know it might be different semantics if it's explicitly implemented in sharper sources, not an implicitly like you know, transition line, so I would keep it, but just not mess up. It's a thanks. Otherwise,.

B

So only question is whether, if we change that is actually helping because it depends on world XPath nor iterator is defined, but if it has a public getting numerator method that this doesn't help. You at all.

E

Yeah I, don't think you know maybe changing the return number. Basically.

B

When you write a for each loop over this guy and when this interface doesn't buy you anything because a compiler will still call to this one. So, like you still get a car, so.

C

E

Let me point it out: in the middle: that's very contained.

E

Is the it would have to explicitly implement the new.

E

Interface and then.

E

It would have to defer to the existing virtual.

C

So people are have I, wrote that on the fret already.

E

Okay, do they have a solution.

E

C

I

C

Much more that'll be breaking change, so let's leave just the interface over there. A.

E

Sensitive since there is an existing virtual or.

E

We have to keep that one, as is yeah, and that means.

E

Innumerable of XPath Navigator, then the only time anybody get a benefit is if they directly cast a tie and revolve XPath navigator, which then every derive types going to have to go. We explicitly implement that method if they want so it's it is it's doable. It's just your neural cost-prohibitive, I.

B

Mean like if the base type implements I'm new mobile of expert navigator at every derived class plus implements as well. The problem is that the way the competitors for each is it looks at the type and checks for the patterns right, so it says, like you, have a getting rid our method, the variance yes.

C

So I will use it. It doesn't look at the interface necessarily.

B

So, like its I, don't know what the cogent does it's possible, that it will prefer the generic explicit implementation over the you know, non-generic public, getting numerator method, I, don't think so, but I don't.

E

Think it waits for the public get a numerator method to do the innumerable pattern. All that the question for type safe then.

C

The question is, like you know, is it easier? You know for our more readable for people to say like for for each X in and explicitly goes to the iron numerable of T over here and then not cast inside versus having the like for each without the cast and then cost kind of per here's. A customer ID like either cost at the.

B

Decided for each you know: foo X in blah or you're, saying.

E

B

Equals and then well I'm, just so because.

E

There's already a public get integrator that returns I integral frozen.

B

E

New like to conform to this interface, if it have to explicitly implement the ienumerable of T.

E

As if it made that meant that defer to a new method, call that get type numerator and then they'd have to override get typed a numerator, because they're.

C

E

C

E

Going to help them know we're I think it's not going to help.

C

Them because you know it's still someone to learning by tomorrow and.

E

Then they still would only get the benefit if they cast it. To idea.

E

This needed to have been fixed before it shipped and again.

C

C

It would be nice to understand the benefits what they expect from that that's what I like I, don't, but in general, like we're not against right. No.

H

I mean they wouldn't hurt.

B

C

That yeah, it's feels useless ish and the only benefit is.

B

Link realistically, which may be good enough, even if it's hype implement ienumerable of something far enough, all the link method slide up fair enough. It isn't anymore. That's actually.

C

A product like do you, son, was decent.

B

Honorable still yeah I mean like that, may be the only one but like for for each it doesn't help you I would like it would be a lot of work, because every derive type would have to.

E

Go switch; no, no! No! No because they have an existing virtual I mean.

B

Unless you're less, you say.

E

That matter, you a stipend.

B

Compensate defense explicitly right, so every instance is able to do that. It's only a change in the base. That is nothing that assuming.

F

There's no overarching what yeah! What's your implementation gonna, do you can't make it just.

B

F

Other one in does it cos. You can't make an explicit now change the return type version so.

B

You want to know you've. Them is a new method, so.

F

You wonder if it's you access.

B

The implement getting numerator that returns and I numerator off T, and you do that by just basically passing the one to the other. You can literally just do the video thing you really want to do. Probably.

A

The only way you could do it, what.

B

If yeah I mean, if you funny, you want to satisfy the existing virtual right yeah but like you, don't have to do anything in the drive side.

E

Override nothing themselves.

B

Now, the only thing I would say is.

E

B

Don't think it's it's more efficient because, like you have to take the existing one and then do the cost right like they get it. That's the I. Don't think that's a way you can avoid the cost. The only thing you get in my opinion is like the link style API. Is it light up with something, but.

F

Close the door on the string equals thing. It's actually documented as being important to just read the docs just to make sure so we trying to stop string.

H

F

Equals is not going to be on for 20 years, documentation, regular people.

B

And what does double equal same thing week? You know each string.

D

Equals inches I like the operator yeah, okay, also, my caste, why it's not really span of the string, how we doing when we're adding new string methods now are we always going to add.

B

My chart I mean I I would say to me. This is not I mean we could do both I'm, not sure that we'd only spend.

F

Because if you go on yeah straight yeah after.

I

F

Retiree will be great, equals string. String is called Moore's law. This.

D

This seems relatively loaded at all. That maybe were. That means that it says right. Yeah I am.

B

What I didn't see you both okay? You want me to write that no I mean I, don't know if you get the same performance, but Justin we'd only spent sure I could get mean actually gives. So is.

H

The cost is not asking this thing to read any spam. I do not remember I.

C

Think it was very, very small, but you know the key thing is like you know: do we really want to sprinkle the reed on the span everywhere? I, don't think so. I think the decision was like we're gonna make it on metals where it makes sense, but it's kind.

H

Of like personal.

C

H

And this is like an extreme builder is as intrinsic to the platform as possible. There's.

C

Virtually no that we.

H

Have getting straight? No, that is the true the thing you would use when you do a population, yeah I, think I. Think.

E

It makes it well.

C

But why why would you compare it with freedom or string them already knows plan you.

E

C

E

Every said of the spring, maybe what you're doing is oh I'm asking him I built the middle of this other string, and so now you want to do the substring without doing the allocate. What.

C

H

Said you want bird to just yeah, okay, I would say if you.

B

Get the same performance, but just soon we'd, only spangled we'd only span otherwise, together.

F

Frozen again and we've done a pastor over that span, ApS bro.

E

Like we had a vision and scream, it's not like we.

I

A

C

Because you see him on that.

B

Yeah, there's one there's a penny: we'd only stay, there is a copy of the spam where we're looking is. It is.

C

Singular Carol everybody.

H

C

One two three time: yeah I mean.

B

That case I agree. Let's just do we don't we spend okay on.

I

Their birth- and this is narrow, right.

C

Can we consider the proof test.

E

Okay, Ottomans evil in the world carefully. No.

C

Oh, did you just mark.

E

It yeah well, this is the one that I pulled. I said: I sent an email in all.

B

E

B

I

E

Someone know yeah I did I didn't want to edit this guy supposed to throw the bomb just.

C

Put there a Heche, original and latest on the top.

F

This is one you said, an email right before Christmas.

E

Yeah yeah that was so funny that you were Christoph would respond that I could just check it. uh I saw that both of you were in the office today. uh He's had good luck right, so we have there's a couple different ways that somebody can get a value that we also call thumbprint, which is the sha-1 hash of a certificate x.509 certificate. The base class exposes it through a byte array method, a string, string method gets or a she gets, or hash string x.509 certificate to exposes.

E

If you have property called thumbprint, the property will not get upgraded to support things other than one. But the give me a byte array and give me that as an extreme, we can take an algorithm because their methods so again at grammars.

E

And this is just part of our continued: don't rely on problem so.

B

Basically, instead of basically would say, get bought arguments is different, kids and you should call get certain hash preparer glue, sha-256 yeah, because it would count as a use of shovel do.

F

These things support multiple hashes, or is it always you're going to have to know the right magic cache for this certificate? It hashes the search contents, so also it actually is doing.

E

The computations yeah I get suresh. The implementation is the first time the windows. Implementation is the first time you ask, for the properties will hash it and we'll just remember that value can do that copy of time. In our case, I, don't think that we would optimize. I was.

F

Since fine to me and.

E

You said on certificate: we already have it essentially. X.509 certificate has the property thumbprint, which returns as the string of the binary dope number, but since it's a property, I can't take a parameter, and so it's just that getting afraid. Well, we'll have to mark that one with that. Please go call this other method. You said yeah.

B

It's gentleman all.

C

Right so I will try to the bottom one again, that's low.

C

Rinkle native libraries latest proposal just API shape, whose wedding is known that Erika's Cagayan was driving that basically basically extended.

H

C

Young catered I mean a frozen video again by the way, I should just put that message from repeated well yeah.

C

Wanted the interrupts him to drive that and they you know, II didn't bites and I think that Russ didn't bite either yet so he's driving it himself with with the people from the system drawing because they that's where we discovered that with Eric and QM Frederic. This is effectively like.

B

If you know don't library get proc addresses that effectively what it does it yeah get.

C

Symbol address and you know prepping with the delegate around that there's handle and if you dispose it, you say, like you I mind, you know it's up to the color.

B

So why does implement I, disposable and not cook a good fine line drop shape.

E

Yeah, this is no. This is not a way.

G

E

G

Dish pose right.

E

Because you now have like II quote: results in under.

C

So what are you allowed to do that, like.

E

You're, either not allowed to dispose the library once you've loaded it or we to somehow make delegates be smart and make them throw a oh, my god, someone unloaded this library out from under me exception, but we cannot have a thing that lets you easily create function, calls pointing to addresses that then got disposed and reclaimed and are now doing whatever the hell that you like do it. This is just no is that a policy that do we define easily someone.

D

F

This disposed also scale.

D

Calls the delegates.

F

Michigan neuter them the Raptor worse or something. If.

E

We can make that happen, then that would be fine. The problem is, you have what looks like a safe operation in safe code that now is jumping to a pointer and executing it, and that's very, very bad. So we can hand out rapid delegate so.

D

Then our decision that is.

E

Well, I guess they get another two T yeah.

C

So I was the different from normal I'll interrupt because Interop is not considered safe. When.

E

You write the PM vote is down. You can't download it so good solution over here, we're saying, basically, you cannot unload it right. So if you can't ever unload these native library things, then we find the delegate would be bound with the map to be in proc. You have to do all sorts of crazy piano garbage done with the library out under it and sort of do it yourself. This is that, like you, can technically I won't see how our from the CLR for what so.

E

Letting something like having using like I can certainly see somebody trying to write the code using this native library go return this function and so you've never turned to delegate out. Well, you just have loaded the library whenever somebody in folks that delegate you're now executing on it. Okay.

C

So so we don't like it at this post, okay gone so.

E

If, if we have understand that they have been illuminant.

B

Yeah I feel like that's a discussion we should have yonder, probably because it's unclear to me what's in ours, are going after.

B

Added well maybe, but like I mean the number one thing that it does. He also is like, if you don't know the name up front, but you can't actually buy the PE book signature because you have to decide the name statically right. So there's.

C

An original proposal there's more background on that, so we can read that by device, if you scroll down yeah I carry it may.

B

Still be better, if you actually have people in the room to talk about it, um yeah.

E

We, whatever yeah.

I

D

B

That's something we need more people, I. Think all right today,.

B

But you drop it, you just click the button for John man.

C

And I think that after that maybe dead memory extensions we might need a stuff over here. One is blocked on Stefan. The RSS I think we need needs Shannon yeah, that's both AP is no.

I

They're done for all it.

C

For today, unless you feel brave on the memory, the number frito on the dog I just looked at it like this little quip, yes and okay,.

B

Alright, then I think that's it for today the minutes early.

D

Know what the thread safety guarantees the stringbuilder all, because it seems to have any some attempt to be safe from.

D

Perfect, the distinct or thread-safe copying that.

E

Pretty sure it's going to contain the line that says that safety is not guaranteed. Why does it have threats? A proper may be threats at copies assistance? Well,.

B

This is yeah, there was some and some security fix that remember a few months here and I think the problem that they want to avoid is that if you so the basic default looks like this right. The type is not threats a generally speaking, but you want to avoid a situation where read you. You have a threading over yeah yeah, okay, it's true and then basically you, they see the same immutable data times where the ideas, if you buy less thread safety of the builders.

B

Even if you do that, you should never be able to observe business.

B

D

Don't you can violate thread safety, get weird behavior, but you'll never write. You are but remember what.

B

That tuber enacted, for example, let's say you have two two threads fighting on the same string builder and calling effectively to string. You should never be able to get once again a string. You should never have a black interpreter that could cause you, that instance, to change ever because that may be a security bug to courts. The string itself to get and select that's why?

B

Maybe the copying functions are usually protected with where they tried to be smart about all that swap the pointers so that they're, even if you used to use the Builder, you cannot mutate. The underlying string.

B

And these are so in this point for all the mutable filter stuff, where we said yeah they're not thread safe, but you really really do not want to buy all.

D

That the thread safety of the email- I, don't know how you could possibly write two strings, so the two threads are screw that up, but would the issue is if I'm doing to string a copy or whatever, when someone else is appending and possibly mutating.

B

On my string well well,.

D

Depends how what.

B

You do what I mean. Thank you, like is the stream brothers underlying array right. That said, the array has the right sides right. You could potentially, assuming you just point to the array and what ironic start the string out of them. If you actually just copy memory, then it's fine, but it all. You double erased. I, for example, the Builder actually use the annoying array and shove it in the blu-ray in particular string builder. That removes.

E

Okay, so you remove some stuff, so some rays get thrown out and remapped. Well now, some things reading are you reading from the new array or the old array in the middle of this copy right, and is it otherwise.

D

E

Garbage collected because we've already turned it in order, so.

D

I have no idea why thread-safe copy is solving and I.

A

E

Like that's the that's, the concern is.

B

B

Alright, sighs things online.