Ethereum Cat Herders EIP Editing Office Hour, 21 Sep 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: EIP editing Office Hour #2

Description

Agenda: https://github.com/ethereum-cat-herders/EIPIP/issues/178

A

Welcome to EIP editing office at 2, we are joined by Sam Wilson, who is an EIP editor for ethereum, and we have a list of some open poll requests to go through so over to you, Sam.

B

Hey everyone how's it going um good. So today, I guess: we've got a couple eips to go through, um which one did you which one that the authors here that we want to start with, or do we want to just go in order from the agenda.

A

uh We can go by the order of agenda the one that author shared is on review. So probably we can check the final one and then get into review perfect.

B

So 4399 go into final. uh Why didn't this merge.

B

Circular depend: oh, this is an easy one.

A

I think this is the proposals uh from March 1499 3675, both.

B

Yeah, just because, like uh there's a loop of uh dependencies, so it's a bug in Eep W. Well, it's not really a bug. It's just under specified. So.

B

um Yeah I think this is probably fine.

B

Unless there was something wrong with it was five days ago and now I think this is manual. Merge queue is removed from the manual merge queue. Then we got an author approval.

B

Sorry I just want to make like double yeah. Okay, we have author approval, so should be good to go.

B

All right moving on.

B

Okay, so this I should be able to do with just an e-spot.

B

We don't use that too often, it's kind of a new feature we'll see if it works.

A

Right yeah with new Bots, we can expect some more hiccups.

B

B

Is it not rerun, I thought it was rerun. Let's go find out.

B

Get her workflows, CI rerun trigger that each pot rerun. So that is the right one. So.

B

Why didn't you rerun.

B

Okay, we'll just get one of these. We had one of those and that will definitely rerun it.

B

B

Oh, that won't work because it hasn't been rebased. That makes sense so we'll do that.

B

B

Well, while that's going, uh we can go to the next one here. 2135.

A

um Oh wait: uh Sam. If I can ask you to take a party, uh we are joined by an author Felix. The author has some question uh related to proposal Felix. If you would like to share the number.

C

Sure it's a 54.96.

B

This one right here.

C

D

A

So can you, please repeat the question: if it is just about showing the status, then I think it is showing? Is there any other question.

C

Yeah the question is uh like it's: uh the pull request for move to review it's closed and right now it's merged is the status. It's like right. Now, it's in the review state right am I, am I understood in this right. Yeah.

B

It's so 54.96 is in the review status, yeah.

C

Okay, then, what should we do like um like? So basically.

B

C

B

An author or yeah.

C

B

So so the review stage is kind of a signal to people saying like um we're ready for people to start commenting on this and investigating it. um So it's up to you to decide when you're done with the review stage.

B

um You could end it today if you want, but generally speaking, you should try to reach out to people in the ecosystem that have opinions or might be affected by it. So, like I'm, not sure like I have I I haven't reviewed this one, um but it sounds like you'd probably want to reach out to maybe uh like uh smart contract wallet people.

B

um Maybe a couple Dows see if you can get some of their developers to comment on your discussion thread and then when you're yeah and then when you're happy, and you feel like you've gotten enough review, you can open a PR to move it to last call.

C

Oh okay, thank you, then yeah, no problem. Okay,.

A

Thank you um I think we have another proposal, but that is of draft, so we can probably cover up the review proposals first and then move into draft one. Thank you.

B

This one's still going okay, so so 2135, let's see what's going on here,.

B

So needs a review, doesn't have any review okay. So this is a new one. Let's see what's going on here,.

B

Nft consumables.

A

Just FYI author is also available in the call. So if you have any question, we have him here perfect.

E

D

Yes, I'm here, uh if you have any feedback, let me know perfect.

B

Yeah I'm just I'm just going to read through it um I, don't think I've seen this one in a while. So um let's make this a little wider, so the text wraps better there we go um okay.

B

This makes sense.

B

um So I might suggest for the title um instead of like nft consumables, maybe one-time use, um nfts or or something along those lines just to give it a little bit more context. Do you want me to put the comments on the pr as well or.

D

Yeah, okay: yeah: can you put it in the piano yep.

D

From the community yeah, the behavior has been defined, I think but title yeah I'll agree with you that is uh I haven't been able to find the best title. Yeah.

B

Naming, like you know, the hardest part of an EIP isn't actually rating the EIP. It's coming up with a good title and description uh title a bit.

D

That's true, that's true, yeah. The goal is to kind of allow it to be consumed, and should it should also imply some.

D

Well, not necessarily one-time due so I'm, not sure, um because.

D

Yeah use case I I have to minus the ticket that if you go to a concert, you have a ticket someone check it in. You should not be able to use it again, but then it also.

B

Oh, you cut out there part way through.

D

B

hmm Yeah um one time you use maybe limited use I'll throw a few in here we can. We don't need to figure out what it is now.

C

B

See the description interface extending Erp 721 and for consumability. So let's do this and then.

B

Okay, an interesting time adding.

B

um Consumer Power.

B

So I guess the idea is that consuming doesn't actually use up the nft. It just is like a bit of metadata on the nft.

D

It should tear it apart, the NFP or like different tickets. It.

B

Should it does actually destroy it? That is.

D

These two: it should yeah okay, it does I in the second mandate that uh you should it made. The transfer events as a token is being transformed. Okay, current order to zero zero address.

B

So it is um like.

A

F

D

B

So an interesting thing, adding.

D

But yeah, as you can see, another's uh another uh ERC being going to review today that there's minting and burning I want to differentiate, consume and burning by the fact that the consume has the event immediate for on action.

B

Yeah, that makes sense yeah.

D

B

Same as yeah one-time youth, yeah.

B

Something like that, I, don't know you don't have to take those suggestions like to itself it's big, but it's just um we don't want to say, consume too many times and I I don't know and consume.

B

It is a bit vague on what it does, um but yeah I know it. Can you can Implement a lot of things with it so yeah the interferes K being power.

B

The consuming them on the Technologies to get access to a concert, that's good good.

D

Well, maybe I could take this to the theory, uh if you're in musicians, to ask for a broader audience for the naming.

B

Okay, good, you have an interface ID, um so does this require 165? It does um assume it's consumed by good matches up, comply, a contract.

D

B

So do you do you have to implement um 721 and 1150 uh eat one of 721 or 11 55, or is it optional.

D

D

The thing that I can think of speakers, this question is whether you're, actually 20 at yahoo77 other type of token, can be consumed in a single occurrence.

D

Would it be okay for it to be vague, yeah I, think that's fine just to let uh that this PRC hit grass with the ecosystem and see what people were trying to do. I, don't want to say it's the optional or required. If that is okay, yeah, that's totally fine! Well, I can I can put it in a rationale to say this is intentional needle required. Nor do you say it's optional, but like we have designed it to work with 721.

D

If you come up with something available in the future, let us know we will come back. Yep.

B

D

B

B

B

B

E

B

B

B

B

B

B

E

Something like that, it could be better.

B

B

Okay, so this is so easy consumable by is like a way to uh like give the consume permission to someone else.

D

B

D

That that's uh that's just for checking uh just note that uh there's a new annotation keyword to the function yeah, it was intentionally predictable, checking yeah.

B

So my concern with that is that, if, um like let's say, we were using this for like event, tickets or something like that right so you'd be in your wallet and you had like a ticket to a concert, and you want to like uh let somebody else go to the concert on your behalf.

B

um You'd probably want a standard way to uh assign that right to somebody else and that's a little bit different than like ownership. Rights which are um like not shared between different uh tokens, like uh the owner of a token, is like a non-standard thing, but in this case I think it'd be important to be able to standardize like delegating this to somebody else. I, don't know it might be worth looking at, creating a function for that. But that's up to you.

D

uh This is uh achieved by putting in the consume the first parameter being consumer, which.

B

Means, oh okay, ah owner still has to make the transaction but interesting.

D

So I I am anticipating that the person who, in a lot of case, particularly the person who actually conduct that transaction to consume, would be the person at the gates, the organizer at the gates because they cut off the ticket, but they will need to set the consumer to the person and therefore it's typically whoever sign up, does sign that transaction being someone else and authorize, Access Control role and then the consume, um the the consumer, being the person who currently owns the tickets so that that's the use case that I think okay.

B

D

E

D

You can you can transfer it to someone else and let it authorize it and I. Think it's it's it's good that you mentioned that I think we can say Hey. You delegate this to the other person, but without changing the ownership so that person can be put in the consumer, but I don't know if yeah, that's a good question. Let me think about it.

B

I'll put a comment on your discussion thread.

D

um Yeah yep good idea.

D

um Maybe I should just call a ticket, I mean yeah.

D

Yeah just to have a very specific but useful use case. It's a shame that we haven't used the the our own nft tow ticket for the Defcon and all the Italian events. Oh.

B

C

um Like, let's hear like eat them, or we'll probably can have it.

B

Oh that'll be cool yeah.

D

C

D

That would be cool yeah. When is that next.

C

D

Yes, yeah yeah, please I I love to be connected to that and see if we can make nft a ticket yeah.

D

C

D

Cool yep all righty. Thank you.

D

All right, foreign.

E

B

All right, let's go on to the next one: I can close all those.

B

86.79? ah Why is this the same? One probably the same one, no, okay yeah! This is fine.

E

B

Some implementations transfer.

B

Yeah so I guess the only thing that I need to say on this one is.

B

Complete before moving to review and please flash out the.

D

Ic, okay sounds good.

B

Yeah yeah, so it's just um before we move to review. Everything should be done uh at least mostly done.

B

C

um 54.96 there's a new like four request like uh created by uh Puja, I, think uh the fix or the titles like.

A

uh Yeah I can see that it's by another editor canopy.

C

A

So it's just one small spell I think typo yeah.

B

54.96 5667.

B

B

What's wrong with this one, it's.

C

Just regarding 54., oh.

B

Yeah, it just needs an author approval and that's all okay, yeah.

B

Are you a final EIP or.

E

B

C

Yeah, it was in the review right now. It's already in review. Oh.

B

Okay, so it just needs uh a rebates yeah. So just this just needs author approval, that's all and that should uh should go through.

B

Yeah, we we try not to um edit eips without the authors like consenting, so uh feel free to pick them if they don't uh reply.

B

B

4910 from draft review extension, hey hierarchical, oh God, I, hate on chain, royalties, I hate them. Oh no! It's this! It's this one! All right!.

B

B

Pretty sure this EIP is is fully written, I've read it so many times. um Is there any problems with the ipw.

B

Now we're good okay, so I don't have a problem moving this to review um just because the EIP is complete, but I'm going to have to read through it again before we let it go to last call.

B

All right, so that's the end of that and then, which was when you said, we're going to review and draft.

A

So that is already there in the number 5606 we can go sequentially or yeah preferred ones. Also. We have enough time either way it will be fine. Okay,.

B

Let's do the ones with the authors here, I think they're more fun. So five.

A

Six, zero: six: it is all right.

D

Hey hey, go down here.

B

How's it going yeah.

F

B

To hear so, what is this EIP.

F

So yeah uh it's about proxy nfts, so uh we are working on uh metaverse interoperability. So, for example, let's take an example: okay, so you have a T-shirt and right now, if you want to create a variable nft for the T-shirt, you have to go to each metaboss like sandbox, decindola and crypto voxels and create an NXT For That t-shirt different nfts. For that you know, but we are working on a proxy nft which is like a riper nft one level above these nfts, which kind of owns these nfts and represents this across multiple metaverses.

F

You know so that's just one use case of this second use case could be, let's say, you're playing a game and you have a whole set of an armor. You know with a helmet, your breastplate, your breaches, all these things, so property nft could own all those individual, armor nfts and you could have just one nft at the top, which kind of represents all these things. You know.

B

Oh I see okay yeah.

C

B

I will I will suggest um a more descriptive name for the title um yeah. So.

B

Yeah, sorry to cut you out there, you feel free to continue.

F

Yeah yeah so that Second Use case League set of an outfit or armor. You know and uh yeah third use case could be your in-game assets. So, let's see uh you, you buy like a weapon in a game and you want to use that across multiple games, so this nft could potentially help you do that yeah, okay,.

B

Cool yeah that sounds useful, so have you seen the um the standard metadata extension for uh nfts um that describes like where to get the assets for the different metaverse games.

F

Oh no I haven't okay.

B

um Yeah see if you can find it, if you can't I can look for it, but I do remember. Somebody else is working on something similar, so well, not exactly similar, but in in at least in the same area of of crypto.

B

F

Oh yeah that keeps popping up yeah.

B

If you there's a way to um configure your git globally to never add that file, um I, don't remember how I just know it's possible. Okay, yeah.

B

Okay, a year was representation of digital assets across from.

E

B

Yeah, okay, discussions: two perfect drafts: it has a dates: we're good, okay, the specification if I'm gonna like face to create a proxy energy standard for digital assets such as wearables and turn.

B

E

So kind of counters are.

B

B

Yeah, okay, so this first paragraph is very much like that other EIP um I can find it here.

B

Four: nine five five I'll put a link to this on your discussion thread: okay,.

B

B

C specification defines interface in some. This looks like.

B

B

So because it's describing what the EIP is doing as opposed to why the EIP exists so uh yeah, so it should just go there, but otherwise yeah, that's looking good um yeah proxy nft representative contracted on one of them are delegates. Okay, so approximate of T, so delicate data, so con. So contract address token ID. So this is the um like the token contract and the okay. Oh, so you can actually bundle things from multiple different contracts together into one bundle, because.

F

Right now, let's say the T-shirt will have three different nfts on each of the metaverses, but in reality the t-shirt is the only one thing right. Oh.

B

I see so so you create multiple different nfts but they're all the same, like there's only ever one owner for all three of them, so you bundle them together into this. Exactly interesting, interesting.

F

E

F

Right so Tiffany is launched a pendant like last month right, but now this pendant, if you want to have it on different metaverses you'll, have to have different nfts for this pendant but in reality you're just buying one pendant. You know yeah.

B

That makes sense yeah okay. So how do you deal with the ownership of I guess this contract just owns all of the nft okay, yeah.

F

Exactly so, there are two steps when you bundle it in this contract, uh you send the nfts to this contract and the proxy nft owns the individual and delegated makes.

B

Sense makes sense so.

F

Yeah and when you're on bundle that you get like the individual nfts in your wallet again.

D

That's it I mean this, and this uh proxy nft contract has symptoms.

D

F

Yeah, it could inherit from any of those yeah foreign.

F

So we have a reference implementation. We are just inheriting the open, Zeppelin contracts, the standard pse71.

B

Okay, so why does this take a delegate data here for the unbundle? Isn't that information already in the contract.

F

uh Yeah, but uh we actually looked at a few edge cases where uh there could be. You know uh you might get someone else's nft in your in your wallet, especially if you're looking at one one, five. Five, um that's why we have this.

B

Okay, yeah, so uh is that covered in your your rationale down here? Okay, so yeah I'll get to that in a sec, um because I think that needs to be explained um so bundle makes sense, yep and then bundle.

F

E

F

A bundle so essentially you meant approximity and at that time, you're defining which metabolism this nft will hold. You know: okay,.

B

Okay: okay, all right bundle.

E

B

So it so it's it's not when you init the bundle, it's not just limiting, which contracts it actually limits, exactly which um oh okay, okay!

B

So when you actually do the bundle um you're passing in the same delegate data again here, but you can't change any of that information.

F

Yes exactly so you need a bundle. You can't change the bundle at all. So after that, uh so let's say you create a bundle with three metaverse nfts right yeah. Now, when you're bundling, you can send two of those or you can certainly one of those right, so a bundle cannot have more than three. After that, that's the idea makes.

B

Sense: yeah and yes, if you set like a quantity of 10, let's say and you're using an ERC 1155, you could only transfer four and it would be fine, but you could never transfer more than 10.. Okay, interesting.

B

um Did you want to search.

B

Representative, okay, so all of this is more motivation than rationale, so this.

E

Is more option then.

F

B

Yeah yeah, so the restaurant section should be releasing behind individual technical choices and CIP. Well, the sorry I'm just I'm typing this out more for anybody who comes across its benefit, not necessarily ours, patient and.

E

B

F

F

B

Yeah, okay I actually wants to be able to use the original standards. Reference implementation, perfect, I, think I understand now, because you have to do the approve first. So the delegate data describes how many to pull from this yeah. That makes sense. Okay, um yeah! Well, it's kind of external contracts, yep, perfect good, and then we have this cc0. That's awesome.

B

B

Cool so I think this looks pretty decent, just a few um DS4 files to get rid of, and then I'm good to go.

B

Yeah thanks for coming out, I appreciate it. It's always nice to talk to the authors so.

F

Yeah just a quick question: there sorry uh yeah so once I make these changes, then it can move to the rough stage right. Yep.

B

It should be able to yeah yeah it I'm a little slow at reviewing, so it'll probably be about a week before I get back to it, but um yeah.

B

Okay, so did that one uh were there any other authors here or should I just start at the top.

A

No I think that's it.

B

So we'll just start here, so what do we got? Going on? We've got a failing, Eep w.

B

Yeah so I'm not even gonna. Look at this one, it's a draft and has a lot of VIP errors. So they can. They can fix this and then we'll come back to it.

B

um Social media, URI, propagation event.

B

We got okay, so this is pretty new social media, URI propagation event commit URI events for social media.

B

E

E

B

B

So it's a nice short EIP, then we got social media and we did that. One memory copying instruction.

B

Yeah I got a nice, um the IP number 5656 5650.

E

Yeah, it's interesting.

B

So 655 was created five days ago at 8 32. five days ago at 9 10.. That's.

B

Really really close to another EIP.

B

I'm, not opening that can of worms.

B

I swear these people, like intentionally like try to make EIP editors jobs more difficult, um okay,.

A

B

B

Thanks for coming out, bye.

D

B

You memory areas.

B

Red totally pre-compile.

B

Yeah I think Panda Pep's gone through and done a pretty good job on this.

B

Foreign yeah I'll just um leave this one for now. I think be good.

B

The extendable pattern.

B

So we have some comments already on here.

B

That's never a good sign all right. Let's see, excuse me, okay, good, um so there's quite a functionality. For my oh, my God, this is just diamonds, especially empty and extended worth giving the contract its functions.

B

All right, I can at least put Sierra move.

B

To the interface you can put inside text.

B

B

um That's just the erc165.

B

B

Okay, I'm, not even gonna, look at this right now, I'm just going to take a look at their discussion thread and we'll see if anybody's mentioned the similarity to Diamonds. No, so.

C

C

B

Oh my God they've.

B

Why do people keep doing this? So you don't see.

B

All right and we'll just leave that until they reply, because it's I'm guessing basically exactly the same thing.

A

I, don't know for some.

A

For somebody, people that we're dead either it is very popular or something that might needs to be fixed, yeah.

B

I'm working with the author on it.

B

He's been uh quite attentive in following up on it: um okay, modular certain promoters, extending functions, storage, slot address, okay, specification.

B

Okay, we're just trying to face.

B

Yeah this is going to take a longer read. I probably won't be doing this on the call. um Okay, so that's extensible, so restrict three provider object. Api injection! That's that's a name! What's going on here, restricted by 3 provider, object, API, wallet, guidance for restricting web3 provider; object; API, oh okay, so.

B

B

C

E

B

That is a poorly worded sentence, um so walnuts.

B

Security and safety is users, funds.

B

D

This reason it's.

B

A good idea to restrict access to the API, so Grant.

B

B

Oh, my God okay, so it is a good idea to restrict access to the apis that Grant this access in certain context, so to align it more closely with the principles of element for web platform. Apis go on such a sentence, okay, but this reason it is a good idea to restrict two restrict access to the apis.

B

Getting these restricted access to the ethereum apis to align more closely with principles followed for web platform, apis.

B

Okay, finding in restrictions to where extensions inject their apis will produce in the surface area that malicious. What pages.

B

Use to fingerprint or falsely request access to the web3 provider object API, it's too high on users.

B

E

B

Oh, it should be accessible.

B

And that's more of a Content question, so that's gonna go over on their discussion thread.

B

S instead, sorry I'm mostly mumbling to myself during this I, don't know if it's useful for people to hear or or not, but uh yeah.

A

Yeah, so no that's all right.

B

Just a reminder.

A

Sorry Felix: please go ahead.

C

Yeah we can hear basically what Sam says.

B

C

E

B

B

Yeah, that's not like I, don't know what that is. Foreign.

E

B

That seems like a fairly reasonable uh proposal, so.

A

Moreover, this is too much as draft.

B

Yeah yeah, it just needs a few changes. It needs to pass ew and yeah all right, so I don't think I'll be able to get through another EIP before time. I mean I can take a look, but uh we could also just wrap it up here.

B

Great well thanks, uh thanks for coming out, everybody and.

A

Thanks for making this happen, Sam have a good day. Everyone, the back.