Ethereum Cat Herders EIP Editing Office Hour, 22 Aug 2023

Previous Meeting

Next Meeting

⏯

youtube image

►

From YouTube: EIPIP Office Hour Meeting 23

Description

https://github.com/ethereum-cat-herders/EIPIP/issues/258

A

Welcome to EIP editing office hour 23, we are joined by Sam Wilson, the editor to maybe take a look at the proposals which are listed here on the agenda, which is issue number 258 at eipip Repository.

A

Thank you, Sam for joining. We can go ahead.

B

Sounds good, so uh I think the first PR here the only thing was.

B

uh That it just seems the last call deadline, updated um I can edit it directly so yeah that that's it for that one. uh Next up we have 6997, which is a proposal to add validation, steps before uh approving or transferring nfts.

B

So the big problem with this one, at least in my opinion, is that there's a lot of um uh like I, don't want to say second order effects, but like a lot of unexpected behaviors that might come up with this and I. Don't think they're discussed well enough in The Proposal, so I'm just reading up a little thing here, um first and foremost, The Proposal, pretty dramatically changed the behavior transfer functions to the point where devs really uncommon approve the transfer. Workflow would break.

B

B

B

B

Oh to anybody who's um watching this recording are here now uh probably a good time to mention that we're no longer assigning PR numbers as EIP numbers we've moved to a different system.

B

um So don't be surprised if we give you a different number than your. Your PR.

B

B

And this is another one of these ones: okay,.

B

I think it's the same Facebook here it's important, however pressing the interface ID it's actually equivalent to okay.

B

B

This should just be in the can I just edit this, because that would make this easier. I cannot all right.

B

C

D

We're actually following just what you guys did with 8 20, uh which was replaced by 1820.

C

Yeah, just like just testing.

B

Yeah, it's it's this little blurb at the top here right, yeah yeah I mean this is this is a when was this made? This was made in 2019 and it's so different from all the other proposals already um yeah. So I guess at the very least, um um the information source.

B

B

Yeah everything else is exactly the same as the old one I I guess so.

B

All right, thank you. Oh no problem. Sorry, it took so long to get to uh to PRS.

B

um This is just removing a table of contents on a.

B

Stagnant DRC.

A

I could not understand the purpose here, but I found that it was approved by Panda, so I kept it over here. Perhaps the author should also change the I mean the proposal should also try to change their status.

B

I think they're, just updating some formatting um I'd prefer if they updated the status but uh yeah I. Don't think this changes any content, so yeah I'm. Okay, with this.

A

Yeah I did any movement so like any change, bring it to understand and Status. They could have done it easily. Yeah yeah.

B

It's just it's, so it's not updating the content so whose proposal is this? Is this their own proposal.

B

um No, it's not it's, not their proposal, so I think I think they just noticed this and they're updating it, but it hasn't actually like they're, not planning on moving it forwards. So I'm, okay, just.

A

E

B

B

I mean it'd, be even better. If you know it changed the uh All These Warnings and fix that, but yeah all right cool, that's good. So to draft 7406.

B

B

B

So multi-name space on chain registry 7406 all right. We have get out again. Okay, it was a universally accepted description for on-chain registry entries for support for multi-name spaces.

B

Versatility nurse use cases.

B

B

Me for my general mapping: data structures, okay,.

B

And the thought functions: okay, owner of the key under the given namespace um Returns, the resolver address for the specified key.

B

B

Okay, let's change that and then we have to go up here and we have to add: okay, let's swap one three, seven or one.

E

B

Three: seven: okay.

B

B

So that part's already in the motivation, yeah, okay.

B

um It's a key under the given namespace to other owner.

B

Okay, the same key under different namespace. We have different owners between your name space.

F

B

Okay for this momentation registry implementation- okay, good! That's fine!.

B

That's good. um This resolver address for key under the given namespace. This function may only be called by the owner of a specific key under gaming space same key and a different name is basically a different resolvers and successful instructions.

B

Okay, that seems pretty reasonable common and then let's go leave a.

B

B

And we will say.

F

B

B

All right so that one's good uh tokenized reserved what's going on with this one, please don't! Okay,.

C

uh uh Hello, oh hey, hey! uh Last last meeting you had mentioned to remove uh the struts, so I had to replace the struts with um some getter functions, because you said that uh you wanted to allow for the implementer yeah, the struts.

B

Yeah I remember all.

C

Right I made that change and um I changed the ration. Now because um you said it didn't really mention why technically used um e-pipe, uh EIP, 4626, so I kind of explained it a little bit perfect.

B

C

B

Take a look here.

B

F

B

Facebook Reserve is okay.

C

I had a question about the events yeah, um so the events are not considered the same as the strut or like allowing the implementer to use an event or not or.

B

Should we yeah so events are fine because, like there's something you can so like, um if you were let's say, writing a Dap You could subscribe to the events and receive notifications about them. So they're part of the public interface of the.

C

Okay, because you had mentioned it, it was either returned, but not like the returned variable or a parameter that goes into the implementation right, yeah.

B

You talk about uh like a struct yeah.

C

So if you have.

B

A if you have a struct in the event too, that would also work. Okay,.

C

B

Just like um so like, if you had um like, let's just imagine you had say um just let me type here so you added just like a.

B

uh Let's go address, so you just have something like this, just like in your interface like in your interface, but it's not public right, so you wouldn't put that in your interface because you don't want to constrain how, like the actual implementers of your interface work, because it's a private function right or a private member.

B

um So it's the same thing here, like anything that isn't externally visible you don't need to put in the interface okay, but, like events are extremely visible because you can see them off chain uh and functions are, are obviously uh extremely visible because you can interact with them.

E

B

So events, okay pause. The time.

B

B

C

I, don't think that's the updated one.

D

C

uh What's the link to that one.

B

So this is this one here.

C

um It should be, it should be under um Pat, the pat 1 branch.

B

Yeah pet one: oh.

C

Okay, yeah; okay! Sorry, no.

B

Worries: okay, you see four six, two six ers.

B

B

I always forget what RFC that is: uh 2119.

B

B

Interesting requirements then.

B

B

Yeah, so it's basically just that these these keywords here um they kind of create requirements, so they should go in the specification section so like, for example, you'd say um here: I might as well just write this down, but um let's see.

B

D

B

So that's about the only other thing. Everything else looks good, um sorry for Teacher auditing, uh actually.

C

Yeah I need to change that I. Just can't think of what it's hard yeah.

B

B

I, don't know if that's helpful, um I'm very bad at coming here with descriptions too it's it's.

C

I need more time to think about it.

B

And you don't need to get it right for the draft. um It's totally fine, otherwise um yeah awesome is there. Was there anything else you wanted to talk about on this one? There.

C

No, that's it. Thank you. Awesome.

B

B

Okay and non-punchable token.

A

So uh Sam, if you would like we can take the last one. We have the author for that.

B

A

Yes, that's right.

B

B

All right, so, let's change down here, I think we're good I would assume we're good.

B

E

B

B

You've got to give me edit on your um your pull requests. It'll, make it a lot faster I, so I didn't notice that this didn't render.

B

B

And this is a draft so yeah. This is totally fine to just go with me.

B

Okay, so there's that and then non-fungible.

E

B

D

Hey there um I'm the author, just sharing that I'm on the call yeah.

B

Well, welcome: do you have any particular questions or just want somebody to look at.

D

um Actually, we we have been with the pr open for a month. There is a little discussion on um on the on the Forum as well, so we actually want to move forward with the process in yeah reviewing and and potentially get it to be accepted.

B

All right management friend of tease, it was kind of show utility, but it is very expirable role. Assignments.

D

B

Right so there are a couple other proposals that are similar based on your description. I, don't know if you've seen them.

D

I did- and uh there are some in in the comments that we addressed. Okay,.

B

Perfect just wanted to check so 59.82 59.82.

B

So this is in review, so I will go here and I will mention to another.

B

Like a CRC, 74, 32.

B

B

D

Yeah, maybe just crack the language there, because we we don't actually extend it. We we just yeah we're just inspired by it. Yeah.

B

So just creating the link at all um creates this dependency.

D

B

B

You know and all right excited to introduce the raw magical of energy draw assignment. This is associated with some Phoenix birds automatically at a given timestamp future custom data field, laboratory status, okay, so nft Rose interface, answer standard for role, management, ft, tracking Engineers, okay, preference actions between Target with a raw okay.

B

Real estate, okay, there that's interesting use cases in Essentials, Finance cool that looks good.

B

B

D

I didn't understand that comment. Oh.

B

uh What are the biggest problems we have with eips? Is that they'll edit the content of the EIP, but not edit, the ERC 165 identifier?

B

um So every time I see an 165 identifier, I'm just going to leave a comment to make sure it's correct.

D

D

Is it recommended to include the identifier? Yes.

B

Yeah, so it's nice to include the identifier, because it gives you like a second check to make sure that you're implementing the interface correctly. But on the flip side it also means that they can get out of sync in the uh the EIP Ro granted Grant roll control, two user, okay,.

B

B

I mean I, guess that's all right. um It's just so so supports. Multiple assignments is kind of like a ambiguous, not ambiguous. It's just too difficult to understand. Name.

D

Yeah, we actually renamed it a couple times on our first iterations, it's hard to find the ideal one.

B

Yeah I know I know.

D

There's a unique roles make sense in a Boolean.

B

D

There's a unique rules as a potential refactor for that variable name makes sense.

B

Unique roles so.

D

Yeah because if it's true it.

B

Means that it's, the role is only assigned to one person and then.

D

Exactly okay, but it would be the other way around right, because support for multiple assignments would be true if it were multiples and if it was unique roles, it would be false, so we had to change the logic a little bit, but uh maybe it's more intuitive.

B

Okay um and again, it's just like a suggestion: it's not like required or anything so check over user has a room really notified good okay, World data.

B

Okay, Returns the custom date of a role assignment: okay,.

D

Do you have a suggestion for the behavior when it's a I, don't know if you should revert or just be turned empty I.

B

I I'm no expert- it's just uh I- mean this. This technically shouldn't even be on the pull request. I should have put that on. You know what I will.

D

Yeah, maybe on the on the caveats we can describe that behavior, something like that.

B

Okay and then a little expiration date.

B

Okay, uh well, okay, can you explain the I erc7432 interface, 7432 yep, uh we're all represented by bystation, is recommended to use Cable's name for this purpose. Grant Ramos reverted the expiration news in the past, but we okay.

B

Spongebob, okay,.

B

So is there a so, is there a way to revoke.

D

Yeah there is a revoke function: Okay.

B

B

um Then, if we go in here and we see.

B

The last row of assignment.

D

We do have a table on a.

E

D

Called unique and non-unique um growth: uh it comes a little later. Okay,.

B

D

We try to explain very thoroughly what the behavior should be.

B

Well account simultaneously yep when it's true the function checks and it's not expired afterwards.

B

B

So this is specifications since it defines.

B

B

Since it defines behavior.

B

B

Okay, yeah, so anything that defines Behavior should be in the specification section um so like even if it's clarifying stuff it should go in specification. But if you want to explain why something the way it is, it can go in rationale.

B

D

That makes sense yeah.

B

B

B

B

Okay, um custom data, bytes yep, that's perfect, Rose, metadata extension.

B

Yeah, so this is specification.

B

Okay and I'll punch the zoom token address talking: ID contract, okay, reference implementation.

B

D

Yeah, that's something I actually put a comment on the pr about. We do have a GitHub repository where you have. You know this food project with 100 test coverage that.

B

D

Of stuff, but it was flagged when we tried to link it right, because it's.

B

D

External link, so how? How should we go about it.

B

um If you can provide so it is cc0 license right, so you could just drop it in the assets directory.

D

um Yeah yeah, but but it's a it's a lot of different files.

B

Yeah, okay, so generally, we recommend that people have like a minimal reference implementation so like just like something super simple: that kind of conveys the point of the specification and like it doesn't have like build system files or anything like that.

B

um But you don't have to right, like you can just not provide a reference implementation, it's up to you. If you want to go through and and um trim it down.

D

You got it I think we're going to include the at least the main solidity file. But is it fine if we reference somehow uh the other repository, even if it's indirectly, not with an actual external link.

B

uh Even even just mentioning it by name would be an external link, so, okay.

D

B

B

um Perfect yeah, so that looks great um a few little comments here and then uh should be good to merge. This draft.

D

Yeah I was gonna, ask um it was doing draft um yeah. If they ask us just hope we have understanding. Once we get these sorted, then it's going to jump to review.

B

So once you merge this uh so so all of the status changes are driven by you, guys the authors, so uh once you're done, writing it and you're ready for like to share it around with people. It's like mostly complete. You can open a PR to move it to review. It seems like you're already at the review stage, so once it's merged as draft, you can just immediately open a review PR, but.

D

We have to first merge it as a draft.

B

Yep yeah, it's just so uh oftentimes we get like half written proposals, so they they go in as draft, but when they're done, then they go to review. So you can pretty much just skip that and go to review um and then once you're ready- and you know you're pretty sure that it's not going to change anymore.

B

You can open a PR to move it to last call, and then two weeks after that, you can move it to final um I will mention that once it goes to final, there are no edits allowed so make very sure that it is correct before you move it to final.

D

Got it got it and uh yeah? The last question: um do the reviews happen offline as well, or only every every couple weeks on this on this call.

B

They're supposed to happen uh off like offline um yeah I think some of our reviewers have been on vacation for a little while and yeah. So sorry, it's taking so long. No.

D

Worries no worries, uh yep we'll adjust them as soon as possible and hopefully get some feedback. Thank you appreciate.

B

It no thanks for coming in.

B

All right and then we have 30 26, move to draft.

B

Core proposal I don't get to see core proposals very often. This is exciting and.

B

Okay, so we have I, am Michael Connor and.

B

I am Mike O'connor, okay,.

B

So this is moving it to a draft.

B

Why didn't any of these get picked up as.

B

Okay, they did great.

B

Okay, of course, one more approval from so we have an approval from Michael Connor and then one rule. Okay, so I will approve this and then manually merge it.

B

B

Okay, so allowed and.

B

We are going to let this merge.

B

All right so I think that's all the scheduled eips for today. That's.

A

B

I guess let's go through and grab our random one.

B

Let's see said we want.

B

Let's look at this one.

B

Okay, so this one hasn't been updated.

B

Automatic transaction representation.

B

We'll sign EAP number.

B

B

Automatically generating a human, readable, Transit question: okay, with representation of a transaction; okay,.

E

B

Transactions to be much more secure by each 712 martial arts center yeah, okay, only finally IPS made references okay, which refer to foreign, okay,.

B

B

What was a hand of hips justification for? Thank you.

E

B

Wait did you resolve my comment or did it just disappear in there yeah? Let me final.

B

Yeah, it's fine.

B

B

It's really hard to edit another editor's EIP, because it always feels like you're nitpicking like to death, and it's so annoying um must indicate to the wall. Yeah, okay consumed more than 90 percent.

A

But I think in a way it is a good example for all authors like this.

B

A

It's the same foreign.

B

B

B

All right, so that's that and then let's pick another EIP to look at here.

A

um So Sam I have a shared. A number 6734 looks like uh the author has addressed your comments.

B

A

Yeah I missed to include that earlier.

B

The last open item is to add nest to the list of allowed URLs all right.

E

B

Now let me just see if that exists here.

B

B

B

All right, then, I have to go and add that and then I think that's pretty much it. Let's see, IP mini eight.

A

I have added both of them for two days yeah agenda, so it should be included. Yes,.

B

Oh, is it, is it in here nest.

B

Okay, I'll put it down here too,.

E

B

Perfect all right, um I think that's pretty much it for today.

A

B

Awesome well thanks and uh see you all in two weeks.

A

Thank you. Sam have a good one. Everyone.