Ethereum Cat Herders EIP editor apprenticeship meeting, 26 Jul 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: EIP Editors Apprenticeship Meeting 22

Description

Agenda: https://github.com/ethereum-cat-herders/EIPIP/issues/160

A

So I have tried to list some of the um issues which were like over a month old. Those were actually new eips but uh for some reason they were not merged. I have added a list of that too, and restaurant as usual.

B

Is my audio unbearable? Can you hear me okay,.

C

It's okay! That's fine!.

B

All of a sudden, it just been extremely loud out here in the last 15 minutes. It was so peaceful earlier.

B

Alrighty, um so I should just start at the top, or should I start with something else.

A

Anyway, it's fine. I just wanted to give you a heads up that we have added some of the older proposals.

B

Okay, I'll start with the miscellaneous fix spdx license identifier.

D

B

I don't know if we can do this. This is put in here by the authors. I don't think that we can just go in and say.

B

C

A ceo now it needs author approval for sure.

A

I'm fine adding it to like a eipab meeting agenda because there were so many, so I just added it here. We take a look.

A

I guess there are four other pull requests: 5 31 to 35 all four.

B

Okay, this one actually prove, I think.

B

Yeah these randomized.

B

This one should be okay, though there's cco, it's just clarifying, it's 1.0.

C

Yeah that one looks fine, I mean yeah.

C

Thankfully, it's uh it's not a required check.

C

That's discussion for tomorrow.

E

C

A

Wait uh there were more, uh I just have added 31 and 35, but there are.

D

B

What is bustle, I.

E

Don't know it's.

B

Like I've never seen that one before.

C

Is it like the boost universal software license yeah? I don't know.

B

It's actually okay. It looks like.

D

B

Rc information.

B

I just don't understand.

C

Oh, this is still being discussed. I wouldn't I wouldn't approve this or anything yet yeah, but technically we're allowed to redistribute rfcs. So we could link to them without external links.

B

Decentralized is the preferred choice of discussion. Two.

C

Is it the uh cat herders that runs the fellowship of ethereum, magicians or.

B

D

D

E

I think we have bigger fish to fry.

C

Yeah, I'm okay with closing it.

A

Yeah I mean like it took a lot of time for us to make the centralized place, and now we are decentralized.

C

Like the only thing, I'd like from the fellowship of ethereum additions forum is like a torrent of a backup like once a month or something.

C

A

I remember reading micah's comment somewhere. He mentioned that possibly it is being backed up, although we need to get it confirmed from one of the fam people.

D

B

Yeah we got alex van der sands here comments.

C

Yeah this one's interesting, I think it's good to merge. I think yeah.

B

I mean it looks fine to me. Let me just check the text real, quick.

B

Do I need to force merge this, or is it going to accept now probably need native forest merge.

C

Yeah yeah, I think so because alex didn't actually approve the pr.

B

I think alex did approve the pr.

C

No, he just said he approved the pr. Oh okay,.

D

B

I don't have access to the old accounts.

C

Yeah so we changed the editor field to his new account, but yeah okay, cool.

D

C

Many withdrawn eips are there. I don't think there's that many.

B

Probably like a dozen or two.

B

Do we even have the ability to see that.

B

There's a handful there's like maybe 20., oh.

C

A

C

D

A

Every category like like a divided category, boys, young yeah, all right.

B

Changing erc with eap, along with relative links,.

D

A

Just for some context, I had a chat with author here we have invited them for a penny penny explained and as per our documentation process that we are following for eip1 so far, I requested him to uh change it to eip instead of erc but uh and later on, I found that there is another I know issue or pull request, which suggests that we may be changing it to erc, I'm not sure so yeah just to add context here.

C

Yeah, I think that the rules as implemented in epw right now are eip, not erc, but that's easy to change. If we, if we want.

B

So so we're going to talk about tomorrow.

A

Yeah, I think I have added this.

A

uh Three uh 2.3 yep, so it is for erc's versus the erc.

B

I'm just going to say we're going to wait until after.

B

Do I need to even do anything like don't they have the ability to just themselves? Oh.

A

Yeah, they can't do that. Actually, they are in the last call and they are just trying to fulfill every requirement. So the proposal can be moved to final, and this was a suggestion from me uh that they should be just updating it. So I mean I don't.

B

A

Yeah, please go ahead. Yeah.

B

Do you know why it didn't auto emerge for them.

B

Yeah, let's turn her off turn her back on real quick.

E

Shoot it closed it with my comments, I'll wait, yeah.

E

Oh man, it's unclear what that means.

C

Have you been finding the output from epw helpful.

B

It has been pretty helpful so far.

C

B

I assume that'll merge, we'll just leave it in the background for now.

B

165 is a dependency.

C

B

This requires 165. 165 is the interface format.

C

Yeah, it's supports interface.

B

Yeah I mean it says in the spec like that it implements this so.

B

I don't know, I'm generally a fan of making updates like this, without making all of the changes. Yeah.

C

B

Agree, look at me I'll stress it.

B

B

What non-normative changes are.

C

Like reordering the sections and stuff like that,.

B

Oh, some of the changes required.

B

Wait non-norm the meaning is changed. What meaning would be changed by an ew request.

B

Doesn't make sense.

B

The type header field- I don't think the header fields- have to be ordered. Do they.

C

B

C

D

B

I think it says they have to be ordered, though,.

B

E

C

B

Does nevermind.

B

I don't know why I questioned the eip static analysis, god.

C

Well, I don't know, sometimes I get confused between what's an actual rule and what micah yells at people. So you know.

B

Okay, so that should be about category and they haven't updated that look at that.

A

A disclaimer here um today I have updated the eap editors apprenticeship, hacking, the file with one comment, and that comment was related to an stagnant eip, so that erp received some update and michael's comment was like a stagnant eip should not receive update without the status change. So I have added that as recommendation for new eip editors or apprentice.

A

So I don't know I mean, as sam rightly said, what is the rule? Sometimes we get confused, but I'm considering sometimes that as a reference point to share with people.

C

Yeah, I think, that's correct if you update an eip, it's not stagnant anymore, so.

A

Yeah right, so the recommendation was either you reach out to author, get it to a review or or we cannot approve this full request.

B

Just allowed word: smart eip titles and descriptions. Lord.

C

See smart, I think, appears in a lot like less prs than standard, um but I don't really care.

B

I also don't really care. Let's just take a little look. The theme smart contract privacy standards see that would just be annoying. If I couldn't say smart, I think agreed yeah, revised, ethereum smart contract packing the same thing order. Smart control files.

B

Smart proposal I mean.

E

C

E

What that means.

B

I mean this is just a bad title like. I think that the problem is that this shouldn't have been approved. With that title.

B

Look how easy it is to find the eave when the number matches the pr.

A

I have added that discussion for tomorrow's discussion.

B

Okay, I yeah. I don't really think this is. This is a change that we should have.

D

A

I feel like even standard is a is something that is sometimes needed.

B

A

C

It's every single erc put the word standard in the title that.

B

One yeah, I think it's easier to.

D

B

Yeah, it's a lot easier. I feel like smarter, like we just don't see it abuse that much.

D

D

D

B

B

Last call 26-12.

C

So the last call deadline needs to be pushed.

A

A question: um does our bot even check for the order of the fields those are added in preamble, because I have seen people write anything anywhere.

C

So eep w does check them now.

A

Oh, that's nice.

B

Please push an empty commit.

C

Yeah, I think uh they didn't realize you can just open and close the pr's.

B

Yeah, so that's still waiting on them to fix ew.

B

uh Entangled tokens.

C

Oh, my god, this was such an unclear pr. It's gotten better! It's gotten better, but yeah.

B

Wow, this has comments on it.

C

Oh, it didn't auto merge what's under like does it have an editor approval, yeah, it doesn't panda pip. I think.

B

Panda pimp- and this guy is sam wilson,.

C

I don't know if I approved it, you.

D

B

Why I don't work.

B

The world, if the eap bot just merged, whenever all the checks passed.

C

Should make a browser extension to make uh make memes for github, I think that'd be pretty funny. So what.

E

Do you mean make names for your github.

C

Like uh you like, it adds a button to every text field where it's like insert meme and lets. You find an image template and then image editor.

B

E

That would be lovely.

B

Rates limiter for token outflows from contracts.

C

I love it when people tag us like we don't constantly read the eb's repository.

B

E

Do you mind a review.

B

Looks like they haven't, responded to panda pips.

B

Let's give them a taste of their own medicine.

B

Authenticity method for client script assert and revoke the authenticity of your c5169.

B

Still waiting for canada updates.

B

Okay, still waiting on that one as well cross-chain execution.

B

They're very very excited about this.

B

They have not. Okay. Did you clear the last three four minutes and get okay.

C

Yeah has has it run on this.

B

I can't see it.

B

No, if I close and open it will it. I.

C

Have no idea, let's find out.

B

Turn her off turn it back on yeah.

A

Do we need a bar too, which can only close and open it if something is not running.

C

I think we could do a. um I think eip bot is a github app, so it can watch for comments and if it gets mentioned, maybe rerun the ci. I'm not sure how that would work.

D

B

Oh, what is this this is: um is this jane presswitch's project.

B

What is james press, which is project right now,.

C

A

C

A

I think I I knew.

B

A

D

B

Interesting, okay, I saw this listen for no man.

D

B

What does it mean? This should be explained.

C

Like when it requires payment, I guess isn't.

B

That, like uh like you, can define that as a user of the bridge.

C

Yeah, I think it might be better to say, may allow payment instead of may require payment. I'm not sure.

C

Writing pr comments is an art.

C

B

In which case stan wilson is a master class at it.

C

I don't know, I think I say I think too much.

B

Yeah but that's like s tier with approaching a they can't tell you that you're wrong.

C

You're not wrong.

B

If you say, I think then it's like what are they gonna say like you, you thought wrong, your brain. They don't know.

C

I mean if somebody replied with you, thought wrong. That'd be pretty funny.

D

A

This has a good list of authors.

B

Yeah, yes, no matter serious, apparently.

A

Yeah I see yeah amex, I see oren nathan.

C

Yeah, at least it's unlikely, the eip will be abandoned.

E

That's what I was just checking to make sure I was like this is going to be another one of these things that just never go anywhere.

C

Implementing the interface right.

B

W unhappy suppose this must be referenced with foreign.

D

Just to carry out.

B

Last three comments.

D

Receive messages from.

B

Okay, we'll just wait for this to respond to those things. Rich scythe proposed contract metadata.

B

And you're in the trenches.

A

One point I don't know: if we looked into that or we missed in the last proposal, I find a link for an implementation which is going to a github which is obviously out of the eip's github repositories. It's fine, or would we like to suggest or recommend anything on that too?.

D

A

It implementation section.

A

Or am I looking at earlier.

B

We're looking at different ones, five, one six, four.

A

That's right! No, I'm looking at five one six, four! It's just that.

B

I don't even see the implementation section.

A

Yes, but have they removed it? I just pasted the link here in the chat yeah. Oh.

B

This is probably an old.

A

B

He suggested this, so I don't know how you managed to end up on that one 3b ec, the last commit patch is on.

B

Yeah they're already on af64, so that was just an older commit.

E

For some reason,.

B

B

Okay, many types of phishing attacks, your line users, not knowing what contract they're hearing.

D

B

Have you seen this at inverse frosting.

E

You haven't seen this.

B

E

C

God, no, like just the general, oh, no, okay, somebody mine.

B

I don't know if I can actually just oh come on.

C

No, that was the one.

B

C

But it was like failing.

B

E

Yeah, look at this: can you imagine just like interacting with something and just be showing up in your mouth like add, inverse bruh wait? How does it what I think that someone.

B

Just like mine at inverse bra as like some other.

C

Function: yeah.

B

And so now some functions for some reason: it takes precedence. So it's like you, do a transfer between contracts and then it shows up in metamask, like you just add, inverse fraud to the contract.

E

That's hilarious.

E

This is why I hate it. I hated all the contracts.

D

D

B

B

Oh, they fully follow what they're proposing here.

C

It's probably storing some kind of stuff in your wallet about individual contracts.

B

Yeah, that's roughly where I'm getting to, but that kind of then relies to use the user verify it. The first time you interact with it, which to me is a non-starter.

B

She's, adding a new optional parameter and it keeps the sites users more resistant to fishing.

D

B

Yeah, I have to spend some more time thinking about this, but.

B

Please, overall, the e.

D

B

I'm back sorry, my internet fully cut out.

A

Not a problem, I don't know, um I lost you and I lost sam, so I was confused like all.

B

A

I get dropped on what happened.

E

Sam was like no no they're. Gonna hang out here anymore,.

B

Anyways, I was just in the process of trying to decide if this makes sense of an interface vip or not.

D

Yeah, I'm gonna.

B

B

B

Contract resource plus.

D

B

I know the problem with this is.

B

I guess I need to approve it.

B

D

B

Secures its correct name.

B

721 user and expires and level extension.

D

D

D

D

D

D

B

B

Still waiting to get updated after panda pips comments, it appears.

D

B

Pattern layer, three.

A

B

B

This is a basic restructuring suggestion, although it starts.

E

Off with, I don't feel like this needs to be any ip.

B

Let's take a look at it: 17 66 lines, sorry.

A

No no suggestion with a lot of opinion, starting with I don't feel like it should be an efp.

B

D

D

D

See what they do.

B

The ap 9000.

A

Do we have an eap.

B

A

It's quite futuristic proposal.

B

There's a lot of contractor in here.

D

B

We will store the slots addressing the special structs call it parent storage and retrieve the slot whenever the specific awesome.

D

D

D

B

I'll say that I'm just going to comment on the title issue, and now we have one minute left, probably just stop it. There.

A

Yeah, I think this is it, for today we covered almost all only five yeah, only five are left, but that should be fine. I hope that it would be done by the next meeting. If not, then we can continue from here. Thank you so much matt we covered a lot talk to you. Yeah.

B

Thanks a lot pleasure see you tomorrow, bye.