►
Description
Enrique Mogollan will explain how to best give valuable feedback while pairing, in formal code reviews or in the pull request process, including: How often do you get a good code review? How often do you give a good review in a pull request? What is a good code review?
In the tech community, giving positive and constructive feedback is the foundation in which we build a safe environment to learn, teach, and get better on writing code. It has been these environments which has made the Ruby community attractive for many people.
About GitHub Universe:
Great software is more than code. GitHub Universe serves as a showcase for how people work together to solve the hard problems of developing software.
For more information on GitHub Universe, check the website:
http://githubuniverse.com
A
My
name
and
I
am
a
software
engineer.
I
work
at
one.
Medical
and
one
medical
is
a
healthcare
company,
but
they
also
have
an
engineering
team
and
the
engineering
team
is
in
charge
of
building
software
that
improves
the
relationship
between
patients
and
providers
and
it
also
builds
software
for
the
medical
doctors.
A
I've
been
a
severely
there
for
around
10
years
now
and
I
work
in
Spain
in
Mexico
and
here
in
the
US
I
work
in
small
companies,
medium
companies.
I
work
in
consulting
companies
and
product
companies,
so
I
have
some
experience.
Giving
and
receiving
feedback.
I
want
to
ask
you.
How
often
do
you
get
a
good
curl
review?
A
A
Feedback
is
the
process
of
returning
part
of
the
output
of
a
system
of
a
circuit
device
or
input
back
to
the
sea
to
the
input
of
the
system,
and
allow
me
to
explain
that
there
is
this
system
that
generates
an
output,
and
then
there
is
a
process
that
takes
that
output
and
then
analyzes
or
does
something.
This
is
what
we
call
feedback
and
there
is
something
that
comes
out
from
that
feedback,
and
you
put
it
back
into
the
system
covering
the
circle.
A
A
circle
and
an
amazing
consonance
is
that
in
electronics,
when
you
inject
positive
feedback,
the
system
will
expand.
But
when
you
inject
negative
feedback,
the
system
will
contract
and
I'm
saying.
That
is
an
amazing
consciousness,
because
it's
the
same
thing
that
happens
with
collaboration
if
you're
running
a
positive
environment
of
collaboration
collaboration
would
be
easier.
Collaboration
will
be
something
that
you
do
every
day,
but
if
there
is
negative
feedback,
collaboration
will
be
harder
and
allow
me
to
share
next
a
story
of
one
of
those
occasion.
Well,
I
got
nada
feedback.
A
This
happened
to
me.
This
happened
to
me
when
I
was
working
as
a
consultant
from
Mexico
and
it
was
working
remotely
for
a
company
here
in
the
US.
It
was
my
first
week
and
I
was
going
to
have
one
of
my
first
code
reviews
back.
Then
we
were
not
using
github,
so
record
reviews
were
mostly
talking
about
cold
I.
A
A
A
So
the
first
thing
that
I
thought
is
hey,
is
he
telling
me
stupid?
Is
he
telling
my
code
is
stupid?
Yes,
he
gave
me
honest
feedback,
but
it
was
hard
to
accept
because
it
didn't
allow
I
didn't
allow
me
to
grow
as
an
engineer
it
didn't
add
anything
to
the
product
to
the
project,
and
it
didn't
point
me
to
the
real
issue.
A
In
the
end,
we
figure
out
a
solution,
but
the
truth
is
that
it
took
us
a
little
bit
more
because
I
I
was
not
willing
to
ask
a
direct
question
because
of
his
negative
feedback.
I
think
that
he,
it
would
have
been
an
entire
different
conversation
if
he
had
asked
me
something
like
whom.
Why
did
you
do
this
or
do
you
think
it
would
be
better
to
approach
this
in
a
different
situation?
A
Why
I
think
positive
feedback
is
is
important
because
it
enables
communications.
So
in
a
positive
feedback
environment
people
are
more
likely
to
ask
questions.
People
are
more
likely
to
take
risk
and
actually
in
a
positive
feedback
environment.
If
you
are
in
sales,
you
are
thirty-seven
percent,
more
likely
to
make
a
cell,
but
if
you're
in
a
paper
gaming
session,
you
are
thirty
percent,
seven
more
likely
to
convince
your
pair
that
you
break
the
rules.
A
Another
reason
why
positive
feedback
is
important
is
because
it
makes
you
feel
good
and
when
you
feel
good
good,
he
has
been
proven
that
you
perform
better.
Actually
you
perform,
you
perform
thirty-one
percent
better,
and
one
of
the
reasons
I
think
you
perform
better
is
because
it
makes
you
feel
confident.
A
A
One
other
reason
why
positive
feedback
is
important
is
because
it
opens
your
mind
as
soon
as
you
get
negative
feedback,
your
star
project
to
new
ideas.
By,
on
the
other
hand,
do
you
receive
positive
feedback,
you're
more
likely
to
take
those
new
ideas,
so
positive
feedback
is
important
because
enabled
communications
opens
your
mind,
makes
you
feel
good
and
it
inspires
confidence.
A
But
what
is
positivity
positivity
is
quality
of
having
a
positive
attitude
and
I'm
going
to
use
a
tool
to
allow
me
to
describe
positivity
a
little
bit
more.
How
many
of
you
have
heard
about
sentiment?
Analysis
all
right,
so
I
participated
in
a
real-world
project
and
this
project
we
analyze
it
comments
on
pull
request
and
we
try
to
find
out
if
the
comments
were
positive
or
negative
and
if
that
affected
the
outcome
of
the
pull
request.
A
A
You
feel
energized
enthusiastic
and
it
is.
This
is
the
level
of
energy
that
you
want
to
be
to
get
things
done
so,
for
example,
here
under
our
co,
indirect
he's
using
have
a
word
that
describes
joy,
lovely
and
wine
coming
on
a
pull
request,
so
these
kids
just
show
enjoyed
all
right.
The
next
one
is
interested
when
you,
when
you
show
interest,
is
because
you
care
an
idea,
we
could
take
ownership
of
the
project
and
when
you
do
that,
you
don't
let
box
or
the
defects
go
into
production.
A
A
He
has
a
demon
and
I
guarantee
you
that,
after
taking
on
that
task,
he
learned
something
that
X
positive
emotion
that
I
want
to
ascribe
is
gratitude.
Gratitude
makes
others
feel
good,
acknowledge
the
words
of
someone
else
and
helps
you
build
a
stronger
relationship
with
your
team.
It
has
been
proven
that
gratitude
is
just
the
most
effective
way
to
be
more
positive,
so
be
grateful
today
for
one
thing
and
your
brain
would
remember
it
be
grateful
tomorrow,
but
something
else
and
your
brain
would
remember
it.
A
A
A
Or
people,
why
do
we
care
about
giving
feedback?
I
think
there
are
mainly
two
reasons.
One
of
them
is
to
reinforce
a
behavior,
to
show
that
you
saw
that
something.
Someone
did
something
good
and
you
want
them
to
keep
doing
it.
The
other
reason
is
because
you
want
them
to
improve
or
because
you
care
about
the
output,
that
you
want
to
improve
the
output
and,
if
you
have
positivity
to
add
you'll,
get
positive
reinforcement
and
positive.
A
Constructive
feedback
and
I
want
to
say
this
that,
because
a
lot
of
people
think
that
being
positive
is
only
about
positive
reinforcement
but
I
think
that
giving
positive
feedback
when
you
are
when
you
are
trying
to
help
someone
to
improve
and
when
you
are
trying
to
make
someone
to
do
something
better.
It's
very
important
to
give
positive
feedback
I
want
to
tell
you
that
there
are
I'd
rating.
There
are
two
extremes
of
positive
feedback
in
general
on
one
extreme
is
something
like
I
describe.
A
What
happened
with
my
peer
people
are
aggressive
or
negative,
but
in
the
other
stream
that
is
not
enough.
Feedback
of
their
RDS
are
not
expressed
well
enough
and
I
want
to
share
a
story
of
that
that
happened.
I
made
this
enthusiastic
developer.
He
was
amazing,
he
build
features
in
the
matter
of
hours,
but
he
was
a
junior,
develop
best
practices.
A
A
He
just
straight
through
started,
writing
better
code
right
away.
So
will
we
realized
that
we
had
to
do
something,
but
we
probably
could
have
done
it
before.
So
this
is
one
of
the
extremes
of
feedback
that
I
was
talking
about.
Our
team
failed
to
be
assertive,
so
what
is
assertiveness
assertiveness
is
the
quality
of
being
self-assured
and
confident
without
being
aggressive
and
I.
Think
it's
a
very
important
skill
to
give
feedback
and
I
have
good
news.
Everyone
assertiveness
is
a
skill
that
you
can
learn.
A
The
first
one
is,
you
have
to
practice
and
I
practice
every
time
I
can
I
try
to
speak
loud
and
clear,
and
one
of
the
things
that
I
that
I
noticed
is
that
my
volume
increases
and
one
of
the
other
benefits
that
are
no.
This
is
there
now
that
I
go
to
my
favorite
coffee
shop,
I
get
a
coffee
for
Enrique,
not
forge
every
week,
Ricardo
or
some
other
name,
I
get
my
coffee
with
my
name.
A
A
If,
during
a
pair
programming
session,
one
thing
that
has
worked
very
well
for
me,
it's
just
add
a
comment
right
there
and
if
you
are
going
to
commit-
and
you
still
have
that
comment,
you
will
remember
to
go
back
and
talk
with
your
paralyzed
it.
The
next
thing
is
that
you
have
to
be
open
and
honest.
A
A
Let's
look
at
an
example:
I
think
this
method
is
very
complex
or
I
feel
I
could
read,
it
could
reduce
the
complexity
and,
of
course,
as
soon
as
I
talk
about
I
messages.
With
my
team,
someone
said
one
of
the
things
I
think
you
do
very
well
and
constantly
is
fail.
Fast,
don't
be
like
that
focus
on
the
code,
not
on
the
author
and
try
to
avoid
being
critic
of
the
of
the
author
of
the
code,
I.
A
A
A
A
A
What
do
you
think
is
the
best
way
to
solve
this
problem,
or
what
do
you
think
would
be
the
right
way
to
approach
it
and
if
they're
after
a
while,
we
haven't
solved
the
problem,
then
I
would
have
suggested.
How
do
you
use
hash
tables
before
I
think
that
questions
are
a
key
part
to
understand
the
person,
because
you
don't
know
whether
person
is
coming
friend,
you
don't
know
the
entire
history
of
that
person.
A
In
our
community
as
product
managers,
designers,
engineers
I
think
that
is
very
important,
that
we
use
positive
feedback
to
create
environments
and
wiggle,
in
which
we
can
ask
questions
and
start
conversation.
And
once
we
have
opened
the
channels
of
communications,
we
will
be
able
to
learn
to
teach
to
grow.
A
A
A
Alright,
so
the
question
was:
if
you're,
not
a
senior
in
the
team,
how
can
you
help
to
promote
positive
feedback?
I
think
that
positive
feedback
it's
everywhere
and
you
can
do
it
everywhere,
no
matter
if
you
are
just
learning
or
if
you
are
already
an
experienced
developer
and
I
think
that
is
just
by
asking
questions.
But
by
trying
to
learn
from
your
peers
and
I
think
that
if
you
are
candied
when
you're
asking
questions,
I
think
I
will
help
a
lot.