20 Sep 2023
Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/425392
Possibly similar to: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/124271
Sorry that most of this video is just us walking through debugger breakpoints. We don't end up finding anything but Malcolm later on DID figure it out!! See https://gitlab.com/gitlab-org/gitlab/-/issues/425392#note_1568228654
Possibly similar to: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/124271
Sorry that most of this video is just us walking through debugger breakpoints. We don't end up finding anything but Malcolm later on DID figure it out!! See https://gitlab.com/gitlab-org/gitlab/-/issues/425392#note_1568228654
- 3 participants
- 54 minutes
13 Sep 2023
Exploring weird behavior in reactive caching / rescue in this MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/129561
Documentation on reactive caching: https://gitlab.com/gitlab-org/gitlab/-/blob/5209dd4b628df856e8ac1abe7a42a509730c0dd6/doc/development/reactive_caching.md
Documentation on reactive caching: https://gitlab.com/gitlab-org/gitlab/-/blob/5209dd4b628df856e8ac1abe7a42a509730c0dd6/doc/development/reactive_caching.md
- 4 participants
- 57 minutes
6 Sep 2023
Responding to MR feedback: "User is an omniscient class. Could this logic be encapsulated somewhere else?"
Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/421265
Branch with work in progress changes: https://gitlab.com/gitlab-org/gitlab/-/commit/082e330bc6aaf03eda79300
We also discuss Numbered block Parameters in Ruby https://medium.com/@baweaver/ruby-2-7-numbered-parameters-3f5c06a55fe4
Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/421265
Branch with work in progress changes: https://gitlab.com/gitlab-org/gitlab/-/commit/082e330bc6aaf03eda79300
We also discuss Numbered block Parameters in Ruby https://medium.com/@baweaver/ruby-2-7-numbered-parameters-3f5c06a55fe4
- 4 participants
- 56 minutes
16 Aug 2023
Today we paired on fixing a master broken issue
https://gitlab.com/gitlab-org/quality/engineering-productivity/master-broken-incidents/-/issues/3317
https://gitlab.com/gitlab-org/quality/engineering-productivity/master-broken-incidents/-/issues/3317
- 4 participants
- 49 minutes
9 Aug 2023
Today we discussed authentication options for remote development and time precision in RSpec tests.
Remote development auth issue: https://gitlab.com/gitlab-org/gitlab/-/issues/421289
MR with time precision issue:https://gitlab.com/gitlab-org/gitlab/-/merge_requests/126530#note_1496791930
Remote development auth issue: https://gitlab.com/gitlab-org/gitlab/-/issues/421289
MR with time precision issue:https://gitlab.com/gitlab-org/gitlab/-/merge_requests/126530#note_1496791930
- 4 participants
- 1:00 hours
2 Aug 2023
Discussing the newly-merge styleguide recommendation to avoid Rails callbacks: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/125836
Specifically as it relates to an in-progress MR that adds a callback: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/127497#note_1489574714
We refactored this callback into a service class, draft MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/128215
Specifically as it relates to an in-progress MR that adds a callback: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/127497#note_1489574714
We refactored this callback into a service class, draft MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/128215
- 5 participants
- 54 minutes
30 Jul 2023
Related MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/129075
This MR’s pipeline is failing because an existing N+1 test now fails because the query count has gone up.
Looks like someone else brought up a different N+1 issue in an MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/126175
Related issue about general N+1 testing guidance: https://gitlab.com/gitlab-org/gitlab/-/issues/385205
Documentation on Query Recorder:
https://docs.gitlab.com/ee/development/database/query_recorder.html
Gem that detects N+1 issues: https://github.com/charkost/prosopite
This MR’s pipeline is failing because an existing N+1 test now fails because the query count has gone up.
Looks like someone else brought up a different N+1 issue in an MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/126175
Related issue about general N+1 testing guidance: https://gitlab.com/gitlab-org/gitlab/-/issues/385205
Documentation on Query Recorder:
https://docs.gitlab.com/ee/development/database/query_recorder.html
Gem that detects N+1 issues: https://github.com/charkost/prosopite
- 3 participants
- 57 minutes
27 Jul 2023
Today we worked on adding a feature enhancement to GitLab triage to support posting internal comments
Issue: https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/-/issues/329
Issue: https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/-/issues/329
- 4 participants
- 1:02 hours
26 Jul 2023
Sam Figeroua discusses backend implementation of this epic: https://gitlab.com/groups/gitlab-org/-/epics/11084
High-level description: Before someone approves an MR, there should be re-authentication with SAML.
Similar feature: Password required for MR approvals: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/10364
High-level description: Before someone approves an MR, there should be re-authentication with SAML.
Similar feature: Password required for MR approvals: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/10364
- 3 participants
- 47 minutes
19 Jul 2023
Today we discussed Railway Oriented Programming and started work on refactoring into that pattern
https://gitlab.com/groups/gitlab-org/-/epics/10956
https://gitlab.com/groups/gitlab-org/-/epics/10956
- 3 participants
- 54 minutes
13 Jul 2023
Today we attempt a refactor of a complex method.
https://gitlab.com/gitlab-org/gitlab/-/issues/395693
https://gitlab.com/gitlab-org/gitlab/-/issues/395693
- 4 participants
- 59 minutes
21 Jun 2023
Discussing design for an MVC to create polls within GitLab issues/MRs.
Related issue: https://gitlab.com/gitlab-org/gitlab/-/issues/415232
Related issue: https://gitlab.com/gitlab-org/gitlab/-/issues/415232
- 3 participants
- 58 minutes
7 Jun 2023
Today we paired on https://gitlab.com/gitlab-org/gitlab/-/merge_requests/108236
- 5 participants
- 1:01 hours
17 May 2023
In this session, w pair on a few items: Trial sign up page (reCAPTCHA and specs) and Elasticsearch index repair
- 2 participants
- 58 minutes
10 May 2023
In this session, we pair on a %16.0 breaking change. Personal Access Tokens (PATs) will no longer be allowed to have a nil value for expiration. We discuss this change and breaking changes in general.
- 2 participants
- 42 minutes
3 May 2023
In this session, we pair up on keeping SAML identity when deprovisioning via SCIM
https://gitlab.com/gitlab-org/gitlab/-/issues/379149
https://gitlab.com/gitlab-org/gitlab/-/issues/379149
- 4 participants
- 57 minutes
24 Mar 2023
In this session we try to set up Rails debugging in VSCode. We didn't quite get there, but after the call Marco figured it out!
In .vscode/tasks.json :
{
"version": "2.0.0",
"tasks": [
{
"label": "start rdbg",
"type": "shell",
"command": "gdk stop rails-web && GITLAB_RAILS_RACK_TIMEOUT_ENABLE_LOGGING=false PUMA_SINGLE_MODE=true rdbg --open -c -- bin/rails s",
"isBackground": true,
"problemMatcher": {
"owner": "rails",
"pattern": {
"regexp": "^.*$",
},
"background": {
"activeOnStart": false,
"beginsPattern": "^(ok: down:).*$",
"endsPattern": "^(DEBUGGER: wait for debugger connection\\.\\.\\.)$"
}
}
}
]
}
In .vscode/launch.json :
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "rdbg",
"name": "Attach with rdbg",
"request": "attach",
"preLaunchTask": "start rdbg"
}
]
}
Before that:
run `gem install debug` from inside the gitlab folder
In .vscode/tasks.json :
{
"version": "2.0.0",
"tasks": [
{
"label": "start rdbg",
"type": "shell",
"command": "gdk stop rails-web && GITLAB_RAILS_RACK_TIMEOUT_ENABLE_LOGGING=false PUMA_SINGLE_MODE=true rdbg --open -c -- bin/rails s",
"isBackground": true,
"problemMatcher": {
"owner": "rails",
"pattern": {
"regexp": "^.*$",
},
"background": {
"activeOnStart": false,
"beginsPattern": "^(ok: down:).*$",
"endsPattern": "^(DEBUGGER: wait for debugger connection\\.\\.\\.)$"
}
}
}
]
}
In .vscode/launch.json :
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "rdbg",
"name": "Attach with rdbg",
"request": "attach",
"preLaunchTask": "start rdbg"
}
]
}
Before that:
run `gem install debug` from inside the gitlab folder
- 5 participants
- 51 minutes
17 Mar 2023
In this session we continue a problem that was brought up in a past BE pairing -adding a cookie that can be read from about.gitlab.com whenever the user is signed in.
- 3 participants
- 1:03 hours
16 Mar 2023
In this Backend pairing session we work on adding a `gitlab.com` cookie that can be read from `about.gitlab.com`.
- 3 participants
- 1:14 hours
8 Mar 2023
In this session we pair on and discuss some BE topics.
00:00 - Discussing a new DB seed script
14:00 - Testing out the seed and talking about the next problem
17:55 - Refactoring EE permission check out of CE
40:30 - Discovering that the root problem actually doesn't actually exist
42:42 - Testing out dead code we ran into
54:20 - Final question about DB seeds
00:00 - Discussing a new DB seed script
14:00 - Testing out the seed and talking about the next problem
17:55 - Refactoring EE permission check out of CE
40:30 - Discovering that the root problem actually doesn't actually exist
42:42 - Testing out dead code we ran into
54:20 - Final question about DB seeds
- 6 participants
- 1:00 hours
1 Mar 2023
In this session we discuss how to roll out large refactors that cannot be handled by a single engineer or even a single group of engineers. Strategies discussed include: named Ruby arguments, code comments, Dangerbot warnings, CI failures, custom Rubocop rules. We also discuss how to create custom Rubocop rules as part of this discussion.
- 4 participants
- 50 minutes
24 Feb 2023
In this session we discuss testing permission changes. We also talk about a contribution that looks to adding an anchor to an email link.
00:00 - Permission discussions and brainstorm
36:01 - Review adding system note anchor to email
00:00 - Permission discussions and brainstorm
36:01 - Review adding system note anchor to email
- 3 participants
- 53 minutes
15 Feb 2023
In this Backend pair programming session, we dive into writing a GraphQL field for accessing project forks which the user has write access to.
- 7 participants
- 57 minutes
25 Jul 2022
In this session we discuss and explore simplifying common "Finder" responsibilities such as ordering and paginating.
- 4 participants
- 50 minutes
18 Jul 2022
In this session, we discuss ways to improve the speed of elasticsearch specs. We also discuss approaches to make a script more deterministic like the test environment
- 4 participants
- 1:01 hours
4 Oct 2021
In this session we push forward and MR we've been refining to update our GraphqlController to read the relevant request's feature category from the request header.
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/67800
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/67800
- 3 participants
- 54 minutes
13 Sep 2021
In this pair programming session we discuss the existing methods for calculating feature_category from Rails controllers and how we might extend this to receive the feature_category from the request header.
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/67800
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/67800
- 5 participants
- 44 minutes
23 Aug 2021
In this session, we pair up on skipping a CI job in JH's fork of GitLab.
https://gitlab.com/gitlab-jh/gitlab/-/merge_requests/81
https://gitlab.com/gitlab-jh/gitlab/-/merge_requests/81
- 4 participants
- 52 minutes