►
From YouTube: Reviewing an MR using Gitpod (runners + feature flags)
Description
Nadia performs an MR review for one of the Pipeline Authoring MRs using Gitpod.
A
So
I've
already
opened
up
gift
pod
and
since
we're
piloting
the
new
merge
request
review
guidelines,
I'm
following
these
guidelines,
so
I've
already
actually
provided
the
initial
review
for
the
semr,
but
I'm
kind
of
going
through
this
again
to
ensure
that
I
don't
miss
anything
because
there
are
some
additional
steps
that
I
need
to
take.
I
think
so.
A
The
the
whole
domain
of
the
samara
is
very
clear
to
me.
So
what's
happening
here
is
we're
adding
the
existing
mini
pipeline
craft
component
to
the
pipeline
editor,
so
we're
not
changing
the
actual
pipe
mini
pipeline
craft
component.
In
any
way,
so
that
makes
this
mr
pretty
easy
to
review.
I
think
so.
I
need
to
preview
the
mr
in
the
gdk,
so
I'm
using
git
pod
for
this-
and
I
already
have
have
this
instance
running
here
with
the
feature
flag
enabled.
A
I
will
save
you
some
time
by
not
going
through
these
steps
in
this
recording.
But
I
have
the
instructions
here
and
I
will
clarify
some
things
so
first,
when
you're
reviewing
a
mr
like
this,
that
you
need
to
be
able
to
run
pipelines
to
review
the
changes
you
need
to
enable
a
runner
and
we
have
git
pod
instructions
gdk
with
git
pod
in
this
repo.
A
So
you
can
follow
the
instructions
here.
So
first
you
need
to
move
to
the
right
directory.
They
need
to
enable
that
your
git
pod
is
using
a
port
that
is
set
to
public.
So
you
do
it
here
in
the
remote
explorer
you're
able
to
see
which
of
your
ports
are
public
and
which
are
private
and
the
3000
port
that
you're
using
needs
to
be
set
to
public,
and
you
do
it
by
clicking
on
this
little
icon
right
here.
A
So
we
do
that
and
then
you
need
to
just
run
these
commands
and
perform
these
steps,
as
laid
out
here
in
these
instructions
to
set
up
your
runner
one
thing
to
look
out
for
at
step:
5
when
you
need
to
enter
the
instance
url
for
your
runner,
you
will
have
to
go
to
the
admin
dashboard.
You
will
have
to
go
to
runners
and
the
instructions
tell
you
that
you
need
to
take
this
url
and
copy
it
and
paste
it
in
your
terminal.
A
So
this
is
where
you
would
be
operating,
but
for
some
reason
I
think
it's
a
bug,
but
this
url
doesn't
match
the
actual
url
of
the
instance.
So
you
need
to
take
this
url
and
then
this
one
excuse
me
so
yeah.
So
you
take
this
url
and
then
run
it
in
your
terminal.
And
then
you
can
skip
the
questions
from
part
six
and
you
select
the
executor
type
shell,
and
then
you
run
this
command
to
start
your
runner,
and
now
your
owner
will
be
able
to
pick
up
jobs.
A
I
think
the
instructions
are
the
same,
so
I
already
have
the
feature
flag
enabled
and
the
pipeline
is
running
and
everything
so
we're
in
the
pipeline
editor
and
we
see
the
mini
pipeline
graph,
which
is
great,
so
it
looks
and
works
as
it
should.
I
mean
we're
not
changing
anything
with
the
actual
pipeline
graph,
so
we
just
need
to
see
how
it
works
in
this
layout.
A
So
I'm
using
this
design
and
ui
changes
checklist
that
covers
writing.
So
we
don't
have
any
writing
here
patterns,
it's
not
a
new
pattern,
so
that
makes
it
easy
visual
design
same
thing,
we're
not
changing
anything
to
the
mini
python
graph
component
and
not
to
say
that
everything
is
perfect
with
that
component.
But
it's
out
of
scope
for
this
particular
mr.
A
A
So
when
it
it's
in
a
really
small
screen
size,
you
see
that
there's
no
padding
between
the
pipeline
graph
and
the
view
pipeline
button,
and
it
doesn't
look
very
good
and
also
it
makes
it
easy
to
click
on
the
wrong
thing
or
not,
not
where
you
intended.
So
we
need
to
add
a
bit
more
distance
here
to
make
sure
that
the
distance
between
the
midi
pipeline
graph
and
the
button
is
the
same
as
between
the
mini
pipeline
graph
and
the
commit
link
here.
A
So
I
just
edit
this
as
a
non-blocking
comment
here
for
maria
and
this
can
be
addressed
as
part
of
the
semr
or
it
can
be
addressed
in
the
future,
because
this
whole
feature
is
now
behind
the
feature
flag.
So
we
have
some
time
here
to
address
this
small
thing,
and
one
more
thing
that
I
want
to
look
at
is
the
accessibility
of
this.
So
I'll
start
by
trying
to
tab
through
this
layout
and
yeah.
A
A
A
You
know
yeah.
This
is
not
working
out
for
me,
though.
I'm
pretty
sure
this
problem
is
not
with
the
current
tomorrow,
but
it's
the
problem
with
the
mini
pipeline
graph
in
general.
So
this
is
something
that
I'm
going
to
raise
with
the
engineer,
but
it's
probably
going
to
be
a
separate
follow-up
issue
and
not
within
the
scope
of
the
slr
but
yeah.
Let
me
write
a
comment
about
it
and
I'll
be
back
so.
A
A
Yeah
and
the
whole
I
mini
popular
graph
also
doesn't
have
an
easily
identifiable
name
and
a
label.
So
this
is
something
that
I
will
also
bring
up
as
a
non-blocking
comment
to
be
addressed
in
a
follow-up,
so
I
ended
up
writing
a
comment
about
it
and
creating
a
separate
issue
to
address
this
and
yeah.
Let's
see,
if
there's
anything
else,
that
needs
to
be
done
here.
A
A
All
of
my
comments
are
not
blocking,
and
one
of
them
will
be
explored
further
in
an
issue
and
the
other
one
can
be
completed
in
the
future
more
since
the
features
behind
the
feature
flag.
So
I
will
now
go
ahead
and
remove
myself
as
a
reviewer
from
the
samara,
and
that
completes
my
review.
Thank
you.
So
much.