GitLab Community Office hours calls, 26 May 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Contributing to GitLab - identifying an issue, understanding the code & fixing it

Description

This video is part of our Community Office hour calls and highlights how to identify an issue to contribute to, figure out where to apply code changes, and what to keep in mind while contributing, testing, and opening a merge request.

Start contributing to GitLab: https://about.gitlab.com/community/co...
You can check for upcoming Community Office hour calls on our meetup.com group: https://www.meetup.com/gitlab-virtual...

A

Okay, so this one looks like I'm not good. This one looks like it might be good, it's a it's a bug.

A

So this is an error created by our sentry integration, which is our error tracking tool and uh when jlab.com has an exception, it gets logged in century and we can go in there and create uh issues from the error that happened so.

A

We have a back choice here, undefined method pin for no no class. So it sounds like we have an unexpected.

A

An unexpected nail pointer and it's in app mono's integrations from mercy s ruby. Let me see it's client dumping, so let's go have a look at that file. um I'll, go ahead and use the browser.

A

Oh, my that's not good! It's taken a while.

A

uh So we're looking for app models, prometheus.

A

See this is why I use the command p, because there's so many files.

A

I wonder yeah on merger quiz. You can actually use command p to open files, but in the file tree browser it doesn't work, um wait. What.

B

Okay, in the merge request, I didn't know that in the browser.

A

It's extremely neat yeah. Let me show you real, quick, oh yeah, I just did wow.

A

Yeah on the div here I can open up index.html. uh I have another one that was merged yesterday. It has a lot more files, yeah.

B

Even I was checking the mr that you just linked before for 3b driving and even in the overview you press the command p, then yeah command, please, like all the files. There amazing.

A

Yeah like like this one's really huge right see if I want to open scanner.com, I can press command p and type it and open it up that way. So I think that's a really cool feature. I like a lot.

B

That's a great that's a great tweet.

A

All right, okay, so this is where the exception is happening and it looks like prometheus client can return nils. Sometimes so it returns a nail. It should return. Client is false.

A

And that could mean the api urls not present, yeah, there's a bunch of conditions for that, uh but we have an implementation guide here.

A

It says either return an object. The implements the pin method following the no object pattern, I'm not familiar with that.

A

Basically, an object that doesn't know up. I guess.

A

A

Include no method error in the rescue.

A

I actually do not like either of those. If, if I was fixing this, I would.

A

I would just add a.

A

I'll just add this, and this is like this is like a null check. So if metis client is now it's it's not going to execute, pin and it's going to return uh it's going to return nil instead, but the problem with that is that that we we're returning the structured, the structured hash.

A

So we don't want return now we want to return success, false with an error right um so yeah. I can see why they had that implementation plan now, so uh we could do something like like.

A

A

A

A

We can, you know, return false and then something like.

A

Something like that or.

A

Or we could use the rescue suggestion that somebody had like.

A

Rescue no method.

A

And then do the same thing, but you know I don't really like that um because I feel like I feel like we shouldn't throw an exception if we can check it. So I'd rather do something like that and then you know you would want to go update.

A

I mean that you can use this in the web battery.

A

It's slow, it's slow because there's thousands thousands of files in here yeah. I would much rather do this locally yeah. Then you would want to go update, prometheus spec and you would want to you'd want to add a test case to make sure that you check what happens when prometheus client returns.

A

Now uh we call that regression test, because you know, I think my personal opinion is that whenever you're fixing a bug, you should add a regression test so find out what case this bug appears in and then add a test for that and I'll make sure that this bug doesn't come back.

A

Yeah, so that's one for gitlab um anybody wondering anything about that.

B

Any questions, friends.

A

It looks like marco found his murder press link, so let's take a look at that.

A

Are you there, marco.

A

Yes, okay, cool.

A

A

I am not sure where the discussion about the namespaces is. uh Ireland is one of my teammates.

B

uh He's trying to find it now he just texted.

A

A

Oh man, this is big money, huge 120 comment. That's so huge.

B

Well, when you combine lead ticket, which is one of which actually voted as the mvp of this release as well, when, when you have mark and lee working together,.

A

Yeah- it's probably about this, so a timeline category belongs to a namespace.

A

A

I'm guessing the namespace can be either a project or a group.

A

Let's see if I can expand all these threads, oh boy and.

A

Yeah, I'm not sure, but um for if you're wondering about the.

A

If you're wondering about the namespaces thing, um the workspace group is the one who is working on that and honestly, I would just ask them what they think, because they'd be they'd, be the one they'd be the best people to answer that, um because you know it's a work in progress and I'm not sure if it's progressed to the point where we should start using it yet so I would ask the worst the workspace group what they think and just use their suggestion.

A

So let me send you the link to yeah. We have uh we have this this button, a handbook that has all of the team members and you would want to ask uh garcia.

A

This person right here.

A

I know I know their gitlab username.

A

Yeah, this is the manager for the workspace team and she would be the best person to ask about that. I don't expect community contributors to know that, of course, but.

A

I think you should ask her, sir.

A

A

If I can find a discussion, I can go ahead and tag her.

A

This murder quest is so big that the anchoring isn't working right. There goes.

A

Oh, you already asked her.

A

um Yeah for groups for groups- I think we are already migrated to namespaces, so you would want to use the namespace object instead of a group.

A

You know one of my favorite things about gitlab about working at github is that everything is written down. So so you, don't you never have those situations where people are like. Oh, we talked about this in a minute and you don't know what people actually said, but here everything is either on an issue or emerging quest and you can go find it.

A

Yeah for this one, I agree that it should be a namespace and it looks like you already changed it so yeah. So this is good. I approve.

B

Thank you so much brian. Thank you for taking the time. I was really helpful. um I'm gonna go and um crop the video to two places, because um so and then I'm gonna reuse it. That was really really really helpful.

B

Thank you. So much.

A

And you're welcome. um I hope you can find another person to do the next one.

B

I will think around people um for sure. Thank you so much. Thank you again answered. Thank you, my marco, thank you, brian um and yeah. Looking forward to see you in the next session you all and in the meantime, we'll see you online on twitter or discord or yeah wherever we are we're on on gitlab. Actually, sorry, yes,.

A

All right thanks, everybody hope you have a good day. Thank you. All. Bye.