GitLab Community Office hours calls, 19 Jul 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Fixing a front-end bug live during the Community office hour call July 19 2022

Description

During this Community Office hours call, James Rushford is walking us through how he is tackling a front-end issue.

Meeting's Agenda: https://bit.ly/3y8fqZc
Contribute to GitLab: https://about.gitlab.com/community/co...
Join the next office hour call: https://www.meetup.com/gitlab-virtual...

A

B

A

Perfect, hello, everyone hi welcome to another community office, article happy to see you all, uh I'm christopher harakis, um contributor program manager um and before we begin uh today we have a special guest james rashford. uh Before I introduce him right, um I think it would be nice like to introduce ourselves uh briefly. Where are we? I can?

A

I can begin I'm based in in right now: burning berlin, 35 degrees celsius and 38, sorry and melting, uh so yeah, um I'm the tribute program manager and I'm my my role at gitlab is like to help uh people who want to contribute to kids love or they they're, going to or they'd be contributing to make their life easier and rewarding um yeah. So I'm gonna go through the list of people uh here on zoom that we have here so the introductions, so fatima is after me, fatima yeah hi.

A

I'm fatima I am a developer evangelist uh focused on community stuff uh on the community relations team. At get lab uh excited to be here. Gonna stay off camera. It's not feeling well today, after me is I guess we have different lists, um but I will pass it to jamie.

A

Thank you so I'm jamie rochelle. I also sit on the community relations team with fatsuma and christos. I am an evangelist uh program manager and I help with our community engagement in regards to our advocacy program, known as the get lab heroes and our meetups, um and also our beyond code twitter space series as well.

A

And I'm gonna hand it off to marshall.

A

uh Hi, I'm marshall miller. uh This is actually my first one. I wanted to give it a look. um I work in uh in education, um I'm the director of online learning for um college in pennsylvania and uh I'm very excited to contribute, and I want to see um you know we used git lab at our school and I kind of just wanted to see how I can give back and contribute- and this looks like a good way to get involved.

A

Also, marshall want to pick the next person to introduce themselves welcome by the way, welcome you all.

A

Marco, I want to go next. Oh, I didn't hear sorry, uh yes, so yeah, I'm arco, I'm based in italy and I've been our contributor for the past almost four months and yeah. Basically, this is it. I am not a web developer, I'm mainly a developer.

A

Yeah but that's it basically.

A

My next christmas you're after me, so I'm gonna, go to.

B

A

No worries no worries: okay, uh measured, okay, I'm measured, I'm a frontend engineer, I'm based in cairo, egypt here and I'm working with uh established and yeah excited to be here.

A

Do you want to go next, yeah sure uh hi, guys, I'm sridhar. I work as a front-end engineer at uh beacon stack, I'm from bangalore, india, uh I'm a contributor at kit lab excited to be here thanks.

A

Perfect and let's hand it over to daniel.

C

Yes, daniel danielle danielle daniel, as you want uh so guys, I'm daniel benny foseka, I'm brazilian guy, but I'm living in belgium.

C

So I like these changements and I'm here just to change, try to to enter this gitlab world and I'm software engineer web developers with tech, as you want call me, so I'm here to start to learn how to contribute in and get on this gathering. Okay, there is another one. I can see why I can pass my let's go with uh yeah.

C

I don't know sorry.

A

Okay, um they want only to listen, that's okay! I also, if you want to write something um uh itamar in gp in the chat feel free to introduce yourself or in the talk. um That's absolutely fine, um hello from brazil there as well uh they're enjoying from brazil, okay. So with no further ado. Last but not least, also our main speaker for today, james with drumroll.

A

B

Yeah james asked.

A

Me the other day how formal we need to have this call and I'm like not formal at all, so I can goof around all day. Sorry about that. So james. The floor is yours.

B

Cool, uh so I'm james, I'm from australia, but I live in berlin, um so I used to work in advertising sales for like 10 years and then um around three and a half. Four years ago I started to. um I was working on this spreadsheet and I wanted to update it automatically and my friend who works at getlab was like. Oh did you know you can use javascript in google sheets, which I didn't, um and then I learnt javascript so that I could update this spreadsheet and um I really enjoyed it.

B

So I said: can you do this as a job full time and he said that's pretty much what he did as a front-end developer. So um I got a internship as a front-end developer that was around three years ago and I just started at get lab just in april, so I'm new to gitlab, um I'm also reasonably new to engineering. So um please don't mind my mistakes so also. um I wanted to say that I I teach at a volunteer code school in berlin, but I normally teach beginners.

B

So I have done a bit of quite a lot of live coding, but um you're all far more senior than I would normally uh demonstrate too. So, um if I like, don't feel offended, if you feel like I'm um explaining over explaining some simple things um yeah, that's me um show me the jump starting sure great, so share my screen.

A

Also, while james sharing his screen, if you have any questions, feel free to share them on the chat in zoom.

B

A

In the document directly.

B

So, to find a issue to work on, I just looked at this list of front-end tasks and then in the list I found that most of the ones at the top were already um being worked on. uh So what I did was I changed. It changed this to created.

B

um I looked for things that were created in the last couple of weeks, um so yeah created descending anyway, um so I had to look through it before um so I picked something that was reasonably recent. So then the information is going to be up to date and probably nobody is already working on it. So I've picked this task. It's completely separate to what I normally work in.

B

um So it's a good way for you to see how I would tackle a task like this, uh like as a contributor, if you just wanted to pick a task and do it so what this task is is um so when you look at the jobs page, you can see the example.

B

B

C

Happening here, the ash yeah, oh wait.

B

Oh no, okay, so um this takes you to the jobs page, uh there's a filter that you can set here, but it is not connected to the url and what we wanted to do. What we want to do is connect it to the url. It's also not connected to the page. So if you say page two that also does not um stay. So what we want to do is add the search filters into the url search parameters on this page.

B

So um the first thing I wanted to do was I. I noticed that uh in so in trying to tackle this. We want to make sure that I do it. We do it in the most simple way possible, um because if we create uh like a custom solution for every single part, our code base grows unmanageable. So what we want to do is find a way. Is there or think about? Is there a way we can achieve this? That is, um writing as little code as possible. That is our goal.

B

So I noticed that in when you search for issues the url is connected. So what I want where I will start is, I will look at how this works and see if we can use that same logic elsewhere. Now I did run through this before so I'm going to run through very quickly. That's not quite thinking in real time, but uh it's it's sped up for your uh enjoyment.

B

Otherwise, you'll just see me banging my head against the wall for a while. So um the first thing I'm going to do as well before I forget is I'll just create a new branch. uh You can use the branch name here uh and create a new merge request. So, instead of creating new merge requests, I'm just going to take this branch name.

B

And create a new branch so that I don't forget.

B

Okay cool, so uh what I want to know is how does this work and why like? How does it talk to the url? So what I'll do first is: let's um so now we're in the gdk, so this is running locally, so we want to find out. Oh no, that's not good! Please.

B

Okay- let's not do that so I'll show you how I would find.

B

What I want to do is find what is this component called and how does it work so uh it's easier to do in the gdk, because you can use view dev tools, uh so in view you can see that each of so the way git lab pages are set up is a little bit unusual because of the complexity of the system. So there's actually six different view, applications running here, so there's um you can see each one and what we're looking for is this search function?

B

So it's it's actually in this application and then it's called jobs, filter search, so um uh we'll look at our code for jobs, filter search, and that is the search bar that we're actually using. um So what I want to do here is work out. What is this component called because um I don't know why it's not loading in jdk, but I'm not going to try to work it out while I'm presenting, um but what I will do is uh you can usually take like data qa selector.

B

We can just search for this in our code base and we'll probably find it um I looked for it before, so I'm probably going to find it pretty quickly so issuable list route. That is, that that's the component so filtered search bar. This is the component that is using. This is the search component. That's on um the issues page.

B

What I want to know is how is this component updating the url, and can we use that same logic in our code? um So we can have a look at the actual component itself.

B

um So what I'm doing there is just copying the name and then opening the default. The file, um the shortcuts, don't work, because these are all shortened um but yeah anyway, it's pretty straightforward, so you can see.

B

So what we're looking for is like what happens when you do a search and how does it update the url.

B

um So just search in in the um file for url params and we're going to find a pretty good, um pretty good indication. So this is a prop. So what's actually happening is issuable list route is being rendered by something else that is handling the prop, so we can find where that is being rendered.

B

um We rented it in a bunch of places. Let's just look at one and then again we want to find the url, and we want to know like how you, how are you doing the url?

B

So we get a bunch of um utilities.

B

uh So how did these utilities work um so you can read through long story short. It's super complex, how they work um and it's not really appropriate to use the same logic in our search bar, because this is really specific to this issues page. This happens a lot in gitlab, because gitlab is very large and some parts of gitlab are pretty old and those parts are super complex and not super duplicatable. So when we create new things, we want to make sure that it is duplicatable.

B

We can reuse the same code, but in this case we can't use the send code.

B

The next thing I would think about is what is the gitlab ui component that we're using to render search, because some gitlab ui components can affect the url search parameters like, for example, if you look at tabs you can you can access? You can change the url in the component itself, so what I want to do is again find jobs, filter search, and this is rendering uh get lab filtered search. So this is git lab ui component, so we can look at the gitlab ui library which have shortcutted here the storyboard.

B

um So we're looking for filtered search.

B

Okay, so filtered search component and what we want to know is, um can we just add url search parameters to this, um but url is not on the documents page. It's not a good sign. um We can't. We can't do that. So one long term option might be consider adding url parameters to the filtered search component. So then it would work across all gitlab search bars.

B

We can use the same sort of logic, so you can consider this um and I did consider this and then I realized the code is is, is actually quite different in each place. So what I want to work out is how does how does this actually work? So what I want to know is when we run when we change the status, what's actually happening here, so we can have a look at the jobs, filtered search.

B

Component, so here we have so on, submit we change filter job by search filters, so we're rendering the search bar from git lab ui and we're just attaching some um methods to submit sorry.

B

So, um okay, so we're not actually changing the filters in this component, but it's parent so again we're going to copy the name and try to find out like are there? Is there just one parent of this or um is there a few which one are we actually talking about?

B

So we have um so we have jobs table app um and we have um these two, which are both have spec after it. So spec means the tests. So these are the tests to make sure that this works. So what we actually want is this view component that renders it and what we should expect here is for it to render jobs, filter search, which does, and what we want to know is what is it doing when we omit jobs filter by search?

B

What is this method, so we can search for it in the code, and here we can see how the filters work.

B

So um we can read through and understand this, but what I actually want to know is like what is the data structure of filters and how easily can we put it into the search, the url parameters, because, depending on its complexity, it might have a different setup, so we can have a look just adding a debugger and then um refresh and we'll add a status and we'll see what it actually says. Oh no, why did I refresh please.

B

Okay, I don't know what happened, but, uh let's just hope, just tenuously yeah, okay cool, so um we have um filters we can read. I don't know if this is big enough for you guys to read, so we have um id token one. I'm not sure what this is doing.

B

uh The type is status, the value is cancelled and is equal to. So what are we actually doing? With this um information, we can read in our code a little bit easier, so we are checking the type. So if there's no type we're giving a warning okay, fair enough- and if that, if the type is status, what we're doing is we're adding statuses so we're adding to the apollo query the parameters of the parameter statuses and we're just giving it the filter value data.

B

This took me a little while to understand what it's actually doing, but what it's doing here is adding in the status. So if we look at filter.value.data, we can see it is cancelled, so what we're doing is sending the polar query as the status cancelled.

B

So how does this work? We have our apollo query here um and what we're doing is we're so we're adding the variable in here.

B

This is a little bit confusing and again it took me a little while to quite understand, uh what's happening, but uh I I played around with it a little bit here and I realized um so there's a couple of clues. So this is a really confusing piece of code if you're not really familiar to the git lab code base. Even if you are it's quite confusing, um so what it's doing is it's creating an event hub event.

B

So what happens? What is an event hub? It's what you need to do if you're running five view applications on one page and you want them to talk to each other, because it's not usual that we have multiple view apps on one page, we have this sort of custom solution. That says like okay, here is an events hub. It has five children, the children are the applications, um the five different applications.

B

So when you, when you run something like job action performed, then you run this function this. So when this event, job action performed is heard right.

B

We want to run job act, handle job action, so this is super confusing and again took me a while to work out, but I'm going to give you the um the pre-workout, the the fast route of working it out. So I don't know what this is. um So I'm going to look for it in the code base and try to find out where it is so here you can see.

B

So this is where we are action cell. uh This is emitting the um the event and then this is um very similar. This is listening for the event and then this is the test. So what we want to know is like, when are you emitting this um this event right? So what it's actually doing um is.

B

I'll spare you the detail, what it's doing is it's listening for this event, when you click finished and what it does is when you click finished it, um it adds some uh statuses to it in the scope, so we can test it by just adding some debuggers and work out when these have been fired.

B

This is literally what I did um so we're going to listen for it. So when we change tabs, we get fetch jobs by status and we have the scope, as an array of success, failed cancelled. So what this means is um so this.

B

So when we adjust the apollo query by sending it the status of an array of success failed and cancelled, so what it will do is filter for any jobs that are either success or failed or cancelled.

B

Okay, so that is how that is working, let's get rid of those debuggers um and th. This is um what this is. It doesn't matter we'll we'll rush through. We don't have none of time, so uh what I I want to do is work out. um uh So what I want to do is for starters, when I get a filter, I want to add it to the url search parameters so, um and I want to think about the data. How should this be structured?

B

So actually the only information we consider in the search bar is the status you can see that by, if you, oh, this is just dying all over the place. I don't know why, if you um do a search for um james you'll, see an error coming up saying raw text is not supported. uh Please use the search tokens, so we don't actually have to support the raw text. All we need to support is the status, so this would look something like um oops.

B

So what we ideally want to do is have something like this. This is what I did before. Statuses is passed um so when we add a status in the search bar like this fast, we want that detail to be passed to the url parameter. So we do this um fairly straightforwardly.

B

um That says when you have filtered job by search um while we're doing these things. Actually, what we want to do is is in this, so we want to adjust the url parameter here, because this is a failure warning and if this doesn't happen, nothing happens. So what we want to do here is update the search parameters, so we can say.

B

We can do this by working out the current url search parameters, so uh search params are equal to and then I can't ever remember how to do it. Url search params.

B

uh So to read them is get.

B

So this is how it looks um so we have um we're going to have search params equals new search, params.

B

Like this, um so I want to do this in the same way that get lab. Usually does it- and I don't know what that is, so I'm going to search for url search params in our code base and look for um a similar solution, because there's no way we haven't already used url search parameters, so I want to use the same structure.

B

So this is how we've we've done it in um template. Selector blob bundle, these look pretty similar, so we're going to do the same thing so um so the url search parameters is equal to window.location.search, so window.location.search.

B

um In case you want to know what that is, you can have a look in the console, so we can say the same code.

B

um So then we can look at our search parameters and we can say get um we can give it the key, which is statuses.

B

A

B

So now we can read the url search parameters in our code and what we want to do is um so because this might be an array we want to get them and then we want to add to them so um search params dot. uh So if we add to the search params, I don't know how to do that uh so set.

B

um I don't think we can add to it. Oh, we can append it. Let's just do.

B

um Not the same so we can get and then we can add to it. I also don't know how this works with an array and we're really running out of time. So, um but I'm sure you can work that bit out so here we want to add the search parameters and then the next important thing we want to do, which I will live code is how do we read the parameters so in our apollo query, which is somewhere on this page variables?

B

This is variables.

B

Okay, so when we get our variables, we want to pass the variables to our apollo query and that variable will be the it's called statuses.

B

So we can say: const statuses is equal to search params.

B

I'm writing this a little bit backwards, but we'll get the statuses.

B

And then the search frames.

B

Is equal to the new url? How do we do it? Url, search parameters.

B

Yeah and then give it the window location, dot search.

B

So now we can get the statuses and we can pass them to the um the apollo query variables. So with this um now we should be able to read the url, so we can test this because we sort of manually set statuses to pass.

B

Let's hope this actually loads. I'm not sure why we're getting this error.

B

Okay, I don't know why it keeps working and not working, no.

C

You're, let's in your code, you start you don't finish uh your last code before.

A

C

Before that, before that step, you did uh something to set you. Let's, you.

B

Yeah, I'm not gonna set them, I'm just gonna set them manually, so we can test to see if this works, because I think we only have a few minutes left. So I.

A

B

We have time: oh okay, yeah. We have a.

A

Lot of time I mean normally it's like 45 to 50 minutes, but we can go like uh up to the hour like until 7 30.. It's up to us.

B

uh So I'm still gonna finish this part first, because what I want to do is be able to read the url, so we need two things. We need to be able to write the url. We need to be able to read the url and another important point is I'm only storing the state of the search bar in the url, it's important to just have the one source of truth: we're not moving it to the state and then reading from the state we're just reading directly from the search bar.

B

So um we have an error. Let's have a look at the network tab. We can have a look at the graphql actual payload first and see if our status is coming through.

B

So you can see here it it is coming through. So we get the full path and we get the status. So that's coming through here is that clear. That makes sense, and then we can read like what is the problem um message.

B

So we got passed, but it is expecting. One of these so um pass is not actually valid. Let's try success and we should only have success, um but we still don't.

B

I expected that one to work.

B

Oh, we have an internal, we have the same problem as what was happening before okay. It looks like it's running great, so now we've only got success all passed as opposed to. Without um this, then we we have everything.

B

Cool, so our filter is working when we load the page and then what we need to do is we want our filter to be set when we.

B

Want our filter to be set when we update the filters.

B

um Cool so again, we'll do this here, just because it's the only place that we actually do something with the query, and this is just giving you an error. um So once we have our our search parameters, we need to. um We need to get our existing search parameters.

B

Using a spell check extension there if you're interested, I can't spell so existing parameters are search parameters, dot get and then we pass it statuses.

B

Does that spell right or is it spelt the same rather yeah cool? So we want to get the statuses and then we want to change them. So actually we'll just call this, let no we need to add to them and we need to remove them.

B

Okay, so we can't just change it because it will be.

B

We can't just change it because it's going to be an array and we're looking at each item in the array now, so um I didn't get this file when I was practicing so now this is actual live code and uh and if you can can jump in with some ideas, please.

A

Can you try to use this method from the url.

B

Sorry, you broke up there. Could you repeat.

A

Oh yeah and there's a set method on the url search forms.

B

So we can say set uh so we can say um search for ram dot set. um So that's fine. We can do that and we will do that. um So the way this works is then we have our filters, um but what I want to know is um how do we?

B

How do we make filters, um the existing filters and the new filters, and it should be whatever filter filters? Are this is our our list right? Does that make sense? So we can just say, like filters is equal to.

A

B

B

Is equal to an array of the existing filters and plus the new.

B

Filters which is actually filter rather so now we're adding each one as we receive it. But what happens if you remove it, so that is the the thing I'm trying to work out now. So this would work if you're just adding but we're not just adding. We might remove.

B

uh So one thing we can do here is: you can actually only search by one filter, so you can't actually add another. It doesn't let you so we can. We could assu. We could remove this rewrite this code to say um instead of for each, but um here we have the reason why, eventually there will be more tokens available and this code is written to scale for these tokens.

B

um So we need to consider how this will affect the future. um There is some argument to say like um uh let's write for now and not for later, because this was done four months ago, um because when we have new information we might have a different way of thinking about it, um so you could really um rewrite this entirely and then say in your merge requests.

B

I don't like this. How this is done, like don't write code for the future write code for now and then in the future, then write it. You can argue that if you want um like the the good thing to remember, is you don't need this code to be perfect or even great?

B

You need to make sure it's working, because when you push the code in your merge request, you'll have at least two reviewers, um I think for community. You get um like a nice person to to coach you with it. So that's um helpful, but even for me, like I, I find myself like. Oh, I don't want to push yet because it's not perfect, but I need to actually push and then push my code. I mean finish.

B

My merge request, stake my case and then I'll get the pushback from the code reviewer and then once they have um approved, then I will get additional pushback from the maintainer before it's actually merged and we can continue the conversation there.

B

So there is an argument to say that, um but we can give this a little bit more thought.

A

If we reiterate the field.

B

uh You broke up a lot there, but what I think he said was we could save the details somewhere.

A

C

Sorry can I contribute please, okay, james. I think I think this just enough uh use the append method. No, because we are uh inside the for each. We are in a filter specific. So if filters is an a that is treated as an a in the line 138.

C

So now we are in the element of this array. So if we have a status, so we are treating these status, so I think we need to test uh just call the search parents append so to to treat these tattoos.

C

If you have more than one status this append you need to add these more statues or or or remove these statues, because the the value will be statuses. A chooses b, status c, not not separate by by column, but for many statuses, like the api, shows.

C

But if we append after we need to treat to to remove so to delete, there is something to delete. No yeah yeah there is, there is delete, so we.

B

Need to okay, so append will add and delete full remote.

C

Yes, yes, this is okay. We.

B

C

My my my uh my tips, you can add, uh try to append. We see how this works and, if you need to try to remove after we can, we can treat this this merge of statuses. I don't know this is my my guess just to see if this idea really works.

B

C

Instead of filters is yes, it has its future.

B

So now we should be able to add- and we can test this so far.

A

A

C

No there's a neighbor in constant log shown is that rehearsed.

B

And see what we get here.

B

Oh, what is happening?

B

Something is wrong.

C

Bad luck to you today.

B

I did update just before this call just in case.

C

A

Did you try to restart the gdk? Sometimes it actually fixes a lot of things.

B

um I try again.

B

But then we'll have to wait, let's just try and see if it's um magically working it is.

B

Okay, so we have a filter. So what I want to know is, is this part working stature, so filter value data.

C

B

Success- okay, so should have uh we might need to. uh We then need to set it back to the url.

B

uh That is my mistake, so I can't exactly remember how we do this, um because what we want to do is update the url, but we don't want to refresh the page uh how to do this. This.

C

Is like first history yeah, something like this.

B

That's uh that's just google um yeah go ahead.

A

B

And then we want to print the url.

A

B

Enter string; okay, so okay.

A

I can't remember how to do this.

B

C

Well, you can try parents.

B

The reason why we so we should just be able to do like window.location.search is equal to and then this to string, but that will refresh the page.

B

Any other ideas.

C

There is another api because you are using url search parents, you know set bear. No, we don't know, let's search, let's see.

A

When the location search.

C

A

A

A

I've you could try this one okay and how? Where can I put this line of code uh just.

B

C

How does it work.

A

This is a quick and dirty solution. Maybe there's a better way to do it.

A

Oh that, of course, didn't.

B

Work search rams- this is uh this- is this is not right. Okay, let's try here.

B

So because another thing to keep in mind- because this is getting pretty long- we would move this into a utility so that the component is easier to read. But um that's a job for another. When we clean up.

B

uh Okay, let's test.

A

Yeah great cool.

B

And we have the problem that might be unrelated.

B

Sorry, someone else said to me.

A

Yeah I was taking a look at the common utilities on the gitlab code base and maybe there's already a function to update the query. Params right.

B

um I think this is crashing, because this is coming back as null.

A

B

A

A

C

Could you check do that work to see the the requests.

A

C

B

So we'll update it again: okay.

C

What hey mister we did that maybe the previous year, I don't know, was scouted by your test test. No, I don't know that that would be maybe.

B

So let's try the meals.

C

Yes, we need to rim to to do the the management now.

B

Oh so they're all adding.

C

Yeah yeah, it's just pending: okay, cool.

B

So um for the moment, because we only have one, we could just change it to set and set the one and then when we eventually make this scalable, the whole function is going to have to be rewritten anyway, because at the moment it just looks for one status. You can't have more than one so, instead of append, which you should do, which is correct. We can actually just do set because we're gonna overwrite the previous detail, because there is only one possible status in the search bar.

C

Yeah is the only one: okay yeah.

B

Because it's restriction.

C

B

Because it's yeah this is written funny and it does at least there's notes to say why it's written like this, because eventually we'll have more than one filter. But currently we only have one filter, so we can write as if we only have one filter and then next time we'll we'll fix it really come on.

A

So I found the set url params inside the url utility.

A

File; okay, uh that basically has most of the things we are trying to do already implemented.

B

Cool this one, you are our utility.

A

Yep, that's that that's already handling, for example, array of params and all of those things.

B

B

um Yeah, this is a really good point uh and we should do that.

B

uh But for now I just I just want something that works. Yeah.

C

Yeah so then we.

B

Can finish, and one of you can complete the code and get your free backpack unless we all get free backpacks, because we do it together right.

B

A

Point thanks for the assist it's just a friendly reminder that um if you open an mr uh until the end of july and it's gonna be merged um anytime during august, except on the website, slash handbook, you're, gonna get and um backpack.

A

With the brand new brand exactly.

C

Another test: you can you change the the url put the url to see if the four or four four four canceled- I don't remember, do you know to see if the filter will be updated.

B

C

Yeah we yeah, you can do this. We bookmark and test.

B

Let's try a couple times: let's see, what's wrong with my gdk: okay go so one problem here is it's not yes, we're not filling the search bar and also, I noticed if we have failed. If we we update it, this works, but if we clear it that doesn't update the url either so yeah whoever's gonna, do this there's a couple of extra little things for you to do so that you earn your.

B

Backpack uh but yeah, that's um that's how I do it.

B

Shall I stop sharing, or do you want to keep going.

A

And we want to see you struggle.

B

I've had enough struggling, um I mean yeah if there's extra time yeah. I better answer any questions. You have um yeah.

C

I have one question uh you started show us uh you get the the branch name from the the issue this process. This initial process cannot be applied for back end on another another another team or just for front-end team- that we do this. This way.

B

No everything yeah, okay, so you should be out so the button says create branch. So you can create the branch by just clicking the button. Okay, but I found it. It would take a little bit to update and then I run fetch and I can't find it yeah.

C

B

I found it easier to just copy that name and put it in the terminal, but I mean maybe that's another thing: that someone couldn't create an issue and fix themselves.

A

There's also another problem for us contributors, because we can't actually create branches on the main uh only made project, because we only create branches on our forks.

B

A

C

For my part, I have a last question for today uh how I didn't see that, uh but I need to to just add more, but how could the team manage, because we are here uh working together, but uh let let's think if uh marco and and me want to work the same issue, how we we we both create the marriage request. uh How can I work together? How can I control this to not? uh uh How could I say I spend the work work?

C

How can I say this yeah don't spend time and work together or one one person work on these? How how this is managing the project lab.

B

um I can give you my personal opinion, okay yeah, so I I think, because you said you're you teach students right is that right. So I I guess what you're asking is. Can I have a couple of students work on the same topic? Yeah together? That's it yeah. So this is possible. They can have. um You know they can work off the same, get branch they could add commits, but it is so messy.

B

Even when you have professionals working on the same branch, it is just so bad, so uncomfortable and so awful, but just run into so you run into um the biggest problem is like get merged conflicts which, unless you really know get. You can't fix this this. You can't teach students this like give them two years in their first engineering job and then they'll be able to deal with merge complex.

B

In my opinion, that's how long it took me and I tried real hard. So what I think is a far better way of doing it and how we generally do it at gitlab is uh split the task into smaller issues and have one person work on one issue.

B

Okay, so if a task is big enough to have two people working on it split it in two okay, if you really want two people working on the same task same issue, same branch, then they should do pair programming and it's like working on one, it's like working by yourself, but it's somebody else like we're working now: okay, exactly exactly why we're working now: okay, okay, okay, so we do pair programming on the front-end team.

B

We do pair program gramming every friday afternoon or friday afternoon afternoon, european time anyway, um and so this is really useful and it's it's a good way to learn. But I really think that giving students one task with multiple branches is just all kinds of bad ideas.

C

Okay answer: okay, thank you.

B

Because it also means like when you're working on the same branch, you can only change just such a tiny amount, like often at gitlab you'll, see some poorly worded variable or function that you want to rewrite. And if you do that it affects so many other places. It should actually be done in a separate, merge request.

B

So you should fix the your issue that you are working on change as little code as possible and then create a new issue and then fix that poorly worded variable named variable that you found.

A

Also, if I can add one thing on one, you can also create more merge requests based on one issue, I mean, if you want to have only one issue and split it up on more merge requests. That's also an option.

B

Yeah, you can do that generally at gitlab. It's recommended. You split the issue because you can have one issue being epic and then that epic can contain. However many issues you want, if you.

A

B

Can contain epics even.

A

If you have epics yes,.

B

If you have what sorry epics, oh yeah,.

B

Any other questions.

A

Yeah, so I have a question uh so I just uh today signed up for the gitlab uh self-made premium so from where do I get that uh license file to activate uh premium features in local jdk.

A

Did you send me a message? I think? Yes, you send me a message: yeah yeah, I reply to your message. You can try for um for the free trial and when you're done with the free trial in a development guide um in the contributing guide. Sorry there is in the get help section. There is a link where you can request for development purposes for communication purposes and license okay in the documentation.

A

I saw that there we have to set some path to the license file, but I did not receive any license file yet, but have you have you open that issue? I don't know okay, so I still have like 30 days so free trial yeah, so in the contributing guide in the contributing guide that I placed here on zoom. If you go on the get help section, there is a link from where you can request the license.

A

It's just like opening an issue with your information when you do that, I'm gonna take it over and then I'm gonna open another request and then you're gonna receive the license. Yeah sure fine. Thanks always.

A

Any other questions.

A

I don't have any other questions. I will like take the opportunity to thank you all for joining um james for walking us through how to your your thought process actually and everyone for participating.

A

It was really nice one of my favorite office articles so far so yeah. If you need any help in general, let me say help section in the contributing guide. That's gonna get you to all our communication mecca and platforms in the agenda here in the document uh of this meeting. There are also a lot of very nice resources like videos, a playlist with youtube videos on how to get started and also a link to our community run discord platform and yeah just wanna. Thank you I'll! Stop. Talking now.

C

Thank you. Thank you. James.

B

Thanks guys, nice to.

A

Meet you thank you. Thank you, nice to meet. You all and see you. Hopefully next week, yeah another office, article okay, see you.