GitLab Compliance Group - Meetings, 4 Aug 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Approval Gates in Merge Request (Walkthrough)

Description

Demo of the proposed flow for users viewing their approval gates within a Merge Request

Related issue: https://gitlab.com/gitlab-org/gitlab/-/issues/219567

A

Hey team, so in my last video I was covering the workflow for how we would get to the state of creating api based approval rules, as we kind of showed. How do we get those rules to appear in the merge request, approval rules both from a project setting, but also from a merge request setting when you're creating a merge request. So I know we're focusing on project, but this video specifically is geared to focus on what happens after those project rules have been created. Where do they appear?

A

How is that going to inform our users decision making, and so we really focus on bullet one really. All the action is probably happening more within the merge request itself, and so that's what the attempt for this video is is showing more or less.

A

How is this going to happen and show, during the approval of a merge request so again, like last time, simple figma prototype here, I'm going to walk through the different ui conditions that I'm handling, and hopefully this will help clarify what questions you might have or present opportunities for you to help me refine our designs here.

A

So this is very similar to how our existing merge request form is. Typically, you would just see this row for view eligible approvers, but what I'm proposing is introducing another container that would can would hold all the approval rules that a project might have added in their settings.

A

So in this instance, I have been queued to know that there is one approval gate that was failed, so I have added an approval rule with an external api and just like how we would encourage users to pay attention here and say: hey. There are two approvals I need for these rulings. There's also one that's failed, and that would tell me I want to look here and now I can see.

A

I have four approval gates that I've set up and one of them has failed and what we would love to be able to give the users the ability to do is the ability to retry and test to see if their endpoint perhaps has resolved itself, or uh maybe it was just finished building and so to give that that opportunity and allow them to be able to retry and replace ideally that icon with the spinning loader just to show that there's something happening in here and disabling the button and that way users have some feedback.

A

Knowing there's something in the system. That's happening uh in my happy path. It's going to pass so the button disappears. There's no need to retry the link. At that point, it's passed and at this point my error message as well. It's telling me that there was one that has failed disappeared, so I feel good about it there and, lastly, I would love to be able to still know like what these um approval gates are tied to. So that's where these icons come into play.

A

They behave similarly to how our avatar icons work, but this in this case it just shows the link for the url and that's what the prototype ends.

A

This was the main endpoint for the user, for where their journey would end in terms of making the approvals- and I think the biggest concern I have again is making sure this is impacting users ability to merge, and I believe what I saw in the mvc criteria is that these approval rules should be non-blocking, which, in my assumption, is that means, even if something is failing, they can still approve the merge request.

A

It's just there for the ability to create visibility into what might be a good way to check other external systems. So yeah, please leave any feedback or comments and again.

A