►
From YouTube: How GitLab is Triaging and reviewing Merge Requests - Community Office hours Call June 7th 2022
Description
June 7th, 2022
During this Community Office hours call, Brian Williams is walking us through the process of training and reviewing community merge requests.
Meeting's Agenda: https://bit.ly/3y8fqZc
Contribute to GitLab: https://about.gitlab.com/community/contribute/development/
Join the next office hour call: https://www.meetup.com/gitlab-virtual-meetups/
A
Hello
welcome
hello.
Everyone
wishes
for
a
great
gitlab
day,
wherever
you
are
I'm
christos
and
along
with
all
these
wonderful
people
here
today,
we're
here
to
welcome
you
in
the
another
office
article
I
will
with
some
new
faces.
So
why
don't
I
just
like
open
the
floor
for
some
really
brief
introductions,
and
then
we
can
dive
more
into
the
freestyle
agenda
that
we
have
for
this
office
article.
A
So
I'm
christos,
I'm
the
contributor
program
manager
and
my
role
is
to
help
you
all
contribute
have
a
rewarding
experience
and
yeah
make
them
contribute
to
the
open
source
ecosystem
and,
more
specifically,
to
get
love
open
towards
my
passion.
So
yeah,
I'm
really
happy
that
everyone
is
here
for
for
the
same
reasons.
A
So
next
to
my
list
here,
I'm
going
through
I'm
gonna,
I'm
gonna
call
out
people
if
you
cannot
unmute
feel
free
to
type
into
the
chat
since
marco
is
here
and
on
face
muted,
and
I
will
invite
you,
marco,
to
introduce
yourself.
B
C
Okay,
in
show
text
in
the
chat.
I
guess
they
can't
speak
but
and
schulz
says
oh
currently
in
a
meeting-
a
full
stack,
developer
and
love
contributing
to.
B
C
Yeah
gitlab
has
gillam
has
a
lot
of
things
that
aren't
web.
Like
you
know
the
runner
and
there's
a
kubernetes
agent
and
there's
a
few
different
projects
like
that
that
aren't
really
web
but
still
fit
into
the
ecosystem.
B
B
C
Think
yeah
so
I'll
go
ahead
and
introduce
myself
since
I
haven't
gone
yet
I'm
brian
and
I'm
a
back-end
engineer
on
the
container
security
team.
I
work
on
container
scanning
mostly,
but
I
do
kind
of
float
around
in
the
secure
area.
C
I'm
also
a
merger
quest
coach.
So
I
will
I
help
out
contributors
with
their
contributions.
So
if
you
ever
contribute
to
getlab,
I
might
get
assigned
to
help
you
out
with
around
your
quest.
D
Yeah,
I'm
fatimah.
I
am
a
developer
evangelist,
I'm
with
christos
on
the
community
relations
team.
I
work
on
managing
our
community
forum
and
some
of
our
third
party
tools
and
just
kind
of
engaging
with
the
community
and
figuring
out
what
they're
talking
about
and
what
they'd
like
to
hear
about.
I
think
this
is
the
first
time
I
made
office
hours
because
I'm
on
the
east
coast
for
two
weeks,
and
I
can
finally
make
the
time
so
excited
to
be
here
and
learn
from
both
of
you.
E
Or
yeah.
E
A
Perfect,
thank
you
before
I
have
just
a
two
really
small
topics
I
would
like
to
cover,
and
then
we
can
ask,
maybe
brian,
since
they
are
here
a
few
things
if
they
want
to
or
show
us
like
last
time
how
to
contribute
to
gitlab.
It
was
really
nice.
But
what
I
know
why
don't
I
share
my
screen
really
quickly.
Where
is
it?
A
Okay,
first
and
most
important
contribution
themed
months,
so
we
started
introducing
the
contribution
themed
months
a
few
months
ago.
It's
like
six
weeks
now
and
it
used
to
be
a
one
month,
but
now
we
extended
it
to
six
weeks
because
we
understood
that
setting
up
your
developer
environment,
it's
take
some
time
and
figuring
things
out,
so
we
are
organizing,
like
we
have
what
six
weeks
focused
on
one
contribution
area,
pretty
straightforward.
A
This
time
is
backend,
so
the
idea
is
like
we're
trying
to
have
these
office
articles
on
a
weekly
basis,
trying
to
invite
gitlab
engineers,
back-end
engineers,
specifically
maintainers,
to
help
us.
You
know
to
walk
us
through
some
of
their
thinking
on
how
to
approach
and
solving
specific
issues
or
just
like
giving
us
their
insights
on
how
to
understand
the
code,
for
example,
or
approach
approach,
some
bugs.
In
some
cases
we
had
a
really
nice
call
the
other
time
with
brian,
and
they
are
joining
us
again
today,
which
is
really
nice.
A
Thank
you
and
then
we're
working
with
other
people
to
we're
gonna
have
more
maintainers
joining
us
now
in
terms
of
like
how
to
find
issues
to
contribute
to
on
the
contributing
guide.
There's
this
nice
table
some
of
our
product
groups.
They
have
hand-picked
issues
for
everyone
we
have
on
the
on
the
main.
A
On
the
second
column,
we
have
like
the
contaminated
gitlab
guide.
We
have
the
architecture
and
everything
on
the
right
side.
We
have
some
issues
and
for
from
different
product
groups,
you
can
explore
them
and
advise
them
to
work
on,
and
if
you
need
help
the
help
section
here,
which
is
either
by
pinking
one
of
our
mr
coaches
or
joining
our
contributors,
gitlab
channel
or
just
emailing.
A
But
most
of
the
time
the
most
effective
one
is
like
doing
a
gitlab
bot
help
and
it's
gonna
notice
and
notify
everyone
and
we're
gonna
have
to
help.
A
That's
the
contribution
thin
months,
we're
also
gonna
have
the
hackathon
in
the
middle
of
august,
but
still
we're
wrapping
up
the
previous
hackathon
still
reviewing
all
the
mrs
now
another
thing
that
it's
came
into
our
attention
about
the
cicd
minutes
usage.
So
if
you're
contributing
to
gitlab-
and
you
started
running
out
of
cicd
minutes,
we
are
investigating
the
problem
there.
But
if
you
run
out
of
ci
cd
minutes,
please
email
contributors
at
gitlab.com
or
reach
out
to
me
directly
on
either.
A
Git
lab
or
on
guitar
or
on
anywhere
that
we
might
all
be
together,
we're
still
investigating,
hopefully
we're
gonna
fix
it
soon
by
the
time
you're
watching
this
video.
This
recording
the
problem
won't
exist.
Sorry
for
this
issue
is
currently
private.
I'm
gonna
make
it
public.
It
includes
some
screenshots,
so
I
want
to
make
sure
I
want
to
take
everyone's.
A
Approval
before
making
this
this
issue
public,
so
that's
it
for
my
site,
some
house
be
keeping
stuff
so
yeah.
If
anyone
has
any
topics
would
like
to
discuss
or
any
questions
potentially
for
for
brian,
it
would
be.
You
know.
Now
is
your
time
they
are
here
with
us,
so
yeah.
Otherwise
we
can
do
like
another
round
of
picking
issues
or
you
know
something
else,
brian
like
how
you're
approaching
or
how
reviewing.
E
B
I
might
have
a
small
question
that
maybe
he
would
be,
he
knows
an
answer,
and
today
why
we
were
using
doing
our
parenting
session
with
lee.
We
were
trying
to
find
a
way
on
how
to
debug
and
set
breakpoints
on
sidekick
jobs.
Do
you
know
how
way
to
do
that.
C
No,
I've
never
tried
this
again.
I've
never
tried
deep
background
inside
kick
job
before
so
that
that
does
sound
difficult.
I
think
what
I
would
try
doing
is
it
should
have.
C
So
what
I
would
try
doing
is
setting
a
binding
deprive
fit
point
and
then
try
running
the
tests,
and
that
should
let
you
hit
the
breakpoint
hopefully
but
like,
but
like
actually
trying
to
debug
it
when
it's
running,
I
don't
think
there's
a
practical
way
to
do
that,
since
it's
asynchronous.
B
Yeah
yeah,
that's
actually
the
problem,
the
that
we
were
having
because
they,
the
tests
that
we
were
trying
to
run,
didn't
really
cover
the
theme.
The
thing
that
we
were
trying
to
test
so
we
tried
to
add
binding,
don't
pry
but
and
testing
on
the
live
gdk
environment,
so
not
from
the
tests,
but
it
didn't
really
hit
those
those
break
points,
so
that
was
that
wasn't
successful.
Unfortunately,.
C
Yeah
we
can
make
note
of
that,
and
I
can
ask
and
our
beckon
channel
and
maybe
there's
somebody
who's
more
familiar
with
sidekick.
Who
knows
a
good
way
to
do
that?
I'm
not
aware
of
any
way
to
do
that.
B
A
Brian,
would
you
be
interested,
I
don't
know
what
maybe
helping
us
walking
us
through
a
review
process.
A
How
to
review
an
mr,
I
can
get
some
if
you
want
or
want
to
pick
another
issue
to
approach.
I
think
we've
covered
that
pretty
pretty
extensively
last
time
and
a
really
nice
video
as
well,
that
we
created
based
on
your
recording
so
yeah,
I'm
just
trying
to
think
of
ways
or
marco
or
ansvul
or
mehul
what
you'd
be
interested
in.
You
know.
F
C
C
Yeah
so
so,
every
day
the
coaches
get
one
of
these
charge
issues
and
all
of
the
merch
requests
that
aren't
trying
to
get
assigned
to
coaches
so
that
they
can
apply
labels
and
look
for
a
reviewer.
And
I
got
to
sign
this
one
from
bitesto.
C
C
So
this
so
first
thing
is
I'm
looking
at
the
location,
and
this
is
authentication
code,
so
you've
got
u2f,
which
is
like
a
ub
key
and
web
authentication,
which
is
also
like
a
more
generic
api
for
two-factor
authentication.
C
C
C
C
And
so
usually
what
most
people
do?
Is
they
look
at
the
reviewer
that
was
suggested
by
gingerbrot
and
they
use
one
of
those?
So
the
bot
tells
you
how
to
set
that
up.
C
So
we
have
a
thing
called
reviewer
roulette
like
a
rule
roulette
wheel,
and
you
use
this
to
randomly
select
someone
to
review
your
merger
quiz.
C
You
can
just
ping
the
bot
and
you
get
airbot
request,
request
review
and
the
bot
will
peen
a
coach
and
the
coach
will
find
a
reviewer
for
you,
but
you're
totally
welcome
to
select
a
reviewer
yourself
too,
and
if
you
know
how
to
do
that,
it's
it's
probably
it's
more
efficient
than
making
a
post
finder,
making
a
coach
find
a
reviewer
for
you.
C
So
if
you
use
roulette,
you
want
to
select
the
project
up
here
and
we're
on
gitlab,
but
all
of
the
pretty
much
all
together
projects
should
be
in
here
or
most
of
them.
So
you
should
be.
F
C
Bunch
of
different
reviewer
categories,
depending
on
what
you
change
and
if
you
set
up
danger,
it's
able
to
automatically
detect
who
needs
to
review
the
merger
press
based
on
what
files
you
change,
and
so
it
will
show
all
the
different
roles
who
need
to
review
the
margin
quest.
C
We
don't
have
danger
here,
but
I
know
that
since
it's
touching
front-end
files,
then
we
need
to
find
a
front-end,
reviewer
and
it'll
show
all
the
different
engineers
who
are
able
to
review
front
end
here
and
you
can,
if
you
want
to
you,
can
click
spin
the
wheel
and
pick
somebody
randomly,
but
what
I
usually
like
to
do
is
I
find
someone
who
doesn't
look
like
they're
busy
like
who
doesn't
have
a
lot
of
mud
requests
assigned
and
I'll
pick
them
so
like
daniel
tian
is
out
on
parental
leave.
So
don't
want
to
pick
him.
C
A
lot
of
the
engineers
on
here
don't
have
very
many
reviews
like
sam
beckham,
looks
like
he
has
the
most
murderess
right
now.
It
looks
like
maybe
he
was
out
of
the
office
or
something
he
got
a
few
accumulated.
But
you
can
look
at.
You
can
look
at
like
the
there's
statistics,
for
how
many
merchants
people
get
over
time
so,
like
doug
stool,
gets
like
two
a
day.
C
C
A
Can
I
ask
something
really
quickly
yeah
sure?
Is
it
this
available
for
community
as
well.
C
B
C
A
I
was,
I
was
confusing
it
with
the
new
review
roulette,
which
is
like
automatically
trying
to
find
maintainers
and
assign
them
reviewers,
which
currently
is
not
open
for
community
marks.
They
don't
they're
not
doing
it
for
community
wars.
Thanks,
sorry
for
interrupting
yeah.
C
Yeah
this
page
is
this
page
is
pretty
much
the
viewer
relay
when
dangerbot
does
relate.
It
actually
reads
data
from
from
this
website
and
it
uses
it
to
find
our
viewers.
So
there's
a
there's
roulette.json-
and
this
has
all
the
data
that's
being
used
to
populate
this
page
and
danger
actually
reads
this,
and
then
it
randomly
picks.
Someone
from
this
big
json
list.
C
Right
so
so,
if
you
find
once
you
find
a
reviewer,
you
can
just
copy
their
username.
I
actually
added
this
button.
A
few
months
ago,.
C
And
you
can
go
over
to
your
merger
quest
and
pin
them
and
just
ask
like
hey
semester.
Can
you
please
review
this
merchandise
and
then
you
want
to
assign
them,
I'm
not
totally
sure.
No,
we
can't.
B
C
C
A
I
think
we
can
no,
you
can
apply
labels.
C
But
it
would
be
cool
if
you
could
do
like
get
that
and
reviewer.
C
C
And
and
then
that'll
that'll
get
you
a
review,
so
you
know,
since
you
cannot
sign
people
do
that
for
now,
but
I
think
it
would
be
really
great
if
we
could.
B
Also,
the
roulette
is
also
useful
when
danger
bot
tries
to
do
his
best
to
pick
the
best
reviewer,
but
if
you,
for
example,
in
a
hurry
and
you
need
a
review
as
soon
as
possible,
you
can
use
the
roulette
to
find
someone.
That's
I
don't
know
if
he's
just
starting
in
the
morning,
maybe
he's
a
has
more
free
time
and
you
can
ping
him.
C
Okay,
do
y'all
want
to
look
at
anything
else,
or
do
you
think
that's
good
like?
Was
that
useful.
C
D
I
didn't
know
about
roulette,
so
that
was
really
cool.
I
don't
know
a
lot
about
danger
about,
so
I
appreciate
the
life
of
you
thanks.
C
Yeah,
I
I
do
want
to
show
you
another
merger
quest
real
quickly.
One
second
give
me
give
me
a
minute
to
find
it.
A
A
A
That's
that's
something
that
we
always
also
like
struggling,
sometimes
we're
trying
to
assign
people
to
intuitive
years
and
mrs
and
we
don't
know
their
availability
and
some
people
yeah.
So
it's
always
like
a
struggle,
and
it's
also
it's
different
from
community
on
mars
because
all
of
these
people
review
community
mars
but
yeah,
that's
gold.
Thank
you.
Brian,
for
sharing.
C
C
This
was
part
he
did
some
work
to
make
topics
you
know
on
on
a
project.
You
can
have
topic
labels
that
kind
of
integrate,
indicate,
search
terms
that
you
can
use
for
that
project
that
doesn't
have
any,
which
is
interesting.
C
These
are
pretty
much
keywords
that
you
can
add
on
to
your
projects
that
you
can
search
by,
like
you
might
put
your
language
like
ruby
or
go
or
whatever,
and
then
it
should
it'll.
Let
it
show
up
on
the
explore
page
so
like
here
I
can
do
getapp.com
explore,
explore
project
topic
go,
and
this
will
show
me
some
projects
that
have
the
code
topic.
C
C
C
Is
you
get
a
review
from
a
viewer
first
and
that
person
will
give
you
suggestions
etc
and
once
the
reviewer
approves,
then
they
ask
a
maintainer
to
review
it,
and
so
you
need
a
reapproval
from
each
reviewer
and
you
need
to
put
an
approval
from
each
maintainer
and
once
you
have
all
the
maintainer
approvals,
then
the
last
maintainer
to
approve
the
merge
request
will
merge
it.
So
this
one
had
three
different
roles
that
needed
to
review
it
and
it
also
updated
documentation.
C
So
we
had
to
get
a
technical
writer
to
review
it
too.
But
but
technical
writing
reviews
are
non-blocking,
so
we
can
merge
it
without
technical
writer
approval
because
they
can
go
update
the
documentation
later
but
yeah.
If
you
look
at
some
of
the
files
that
were
changed,
real
quick,
we
have
some
back-end
here.
C
So,
like
the
topics
controller,
some
of
the
models
so
controllers,
if
you're
not
familiar
with
rails,
these
are
common
rails
concepts,
there's
controllers,
which
handle
like
the
parameters
and
stuff
from
an
http
request
and
then
there's
models
which
interact
with
the
database.
C
C
C
Yes,
so
so,
if
you're,
if
your
model
depends
on
the
database
change,
you
probably
have
to
have
a
migration
of
two
and
that
needs
database
review
and
then
you've
got
the
documentation,
change
the
documentation
that
shows
up
on
docslab.com
most
of
these,
not
all
of
them,
but
most
of
them
are
located
in
the
gitlab
repository.
C
C
C
C
This
is
a
big
huge
file
that
contains
every
single
translatable
string
in
gitlab,
so
every
single
one
of
these
messages
it's
possible
to
create
translations
for
these.
So
pretty
much
every
time
you
add
a
stream
that
the
user
will
see.
C
It's
probably
gonna
end
up
in
this
file
and
we
have
a
whole
different
program
where
people
can
contribute
translations
for
these
strings
so
like,
if
you
know
russian
or
german
or
like
any
other
language,
you
can
take
these
strings
and
add
a
translation
in
your
language
and
it
will
start
showing
up
in
gitlab
when
you
change
your
language
settings
the
we
we
rely
on
contributions
for
that,
for
the
most
part.
C
And
if
there's
actually
not
really
any
front
end
changes
here,
but
pamela
the
views,
the
these
are
kind
of
unique
and
that
they're
they
are
considered
both
running
and
back-end.
So
these
two
files
are
probably
what
is
triggering
the
front-end
review
and
yeah.
These
are
weird
because
they're
they're
a
mix
of
both
ruby
and
html
and
css.
C
So
you
know
this
is
this:
is
a
css
class
and
then
you're
able
to
call
ruby
code
from
in
here
and
yeah?
I
I
don't
understand
it
super
well,
but
it's
it's
a
hybrid
thing,
so
that
usually
gets
both
back
in
and
in
front
of
the
review
yeah.
So
for
this
major
quest,
let
me
see
yeah
there's
this
picture.
You
said
here
where
I
started
asking
for
views
from
everybody,
so
yeah.
C
If
your
merch
request
is
ready
for
review,
it's
usually
a
good
idea
to
add
a
comment
saying
so
or
use
get
that
bot
request
review
because
it's
not
always
obvious
if
you're,
if
the
magic
person's
ready
or
not-
and
you
know
I
picked-
I
picked
reviews
for
each
of
those
and
then
the
technical
writer,
a
technical
writer
only
needs
one
reviewer.
C
Most
of
the
time
we
have
two
but
for
technical
writing,
there's
one
yeah,
and
so
so
everyone
kind
of
added
their
approvals
in
this
thread,
and
you
can
see
you
can
see
when
the
reviewer
approves
they,
they
request
a
review
from
the
maintainer,
so
they
just
kind
of
pass
the
baton.
C
And
you
know
each
of
the
and
they're
they're:
either
they'll
either
approve
it
or
they
will
leave
comments
and
ask
you
to
look
again
and
usually
when
they
ask
you
to
look
again,
you
will
have
to
request
a
review
from
the
same
person
again
after
you
make
changes.
C
So
if
you,
after
you
address
the
comments,
you
can
just
pin
them
and
they
will
take
another
look
at
it.
Some
people
like
to
use
the
ping
pong
pedal
because
you're
going
back
and
forth.
So
it's
like
you're,
like
you're
playing
ping
pong.
C
Yes,
so
we
got
approvals
from
most
of
the
maintainers
pretty
quickly
front,
end
approved
database
approved,
and
then
we
were
just
waiting
on
back
in
the
person
who
got
picked
for
beckon
review
was
out
of
the
office,
so
we
found
somebody
else
and
they
went
back
and
forth
a
couple
times
and
then
they
merged
it.
C
So
yeah
that
that's
what
the
review
process
looks
like
most
of
the
time.
Your
changes
are
to
be
small,
so
you
might
only
have
one
or
two
reviewers,
but
this
one
was
really
big
and
you
know.
Sometimes,
if
you
touch
a
bunch
of
different
areas,
you
might
have
to
have
a
bunch
of
people
review
it.
B
I
might
have
a
question
about
the
having
a
single
merge
request,
touching
both
backhand
and
front
end,
because
lately
I
discovered
that
that
is
not
a
really
good
practice,
because
the
deployment
is
not
really
synchronous,
so
it
could
cause
some
problems.
C
You
might
have
servers
with
different
versions
running
at
the
same
time
and
if
the
front
end
expects
so
the
front
end
and
the
back
end
might
not
be
on
the
same
version.
When
you
do
this,
because
the
front
end,
you
know,
sends
requests
to
the
back
end.
It
can
hit
any
of
these
servers,
and
so
you
could
be
talking
to
two
different
versions
of
gitlab
at
the
same
time,
on
the
front
end,
so
we
actually
had
a.
C
Yeah,
this
documentation
tells
you
what
you
need
to
consider
with
that
kind
of
stuff
when
modifying
javascript.
C
C
B
B
C
B
Yeah,
the
the
sad
big
quotes
there
thing
that
I
discovered
when
we
talk
about
this
is
that
a
database
change
could
take
even
three
milestones
to
get
deployed,
because
maybe
you,
if
you
have
to
change
a
column
and
or
drop
a
column
on
a
table,
and
you
have
to
make
sure
that
everything
is
updated
and
that
could
be
take
taken
care
of
on
three
milestones.
So
three
months.
A
Thanks
are
there
any
questions
for
brian.
C
A
Pleasure
pleasure
having
you
and
thank
you
so
much
for
being
here.
Thank
you
all
for
joining
again.
If
you
happen
to
run
out
of
ci
cd
minutes
in
the
next
days,
there
is
a
public
now
issue
into
the
agenda,
feel
free
to
add
a
comment
there
with
a
screenshot
of
your
usage,
we're
trying
to
address
that
right.
Now
again,
we
are
wrapping
up
the
hackathon
by
the
end
of
this
week.
A
Maybe
we're
going
to
give
an
extension
for
reviewing
all
the
open,
mrs
because
we
have
a
few,
mrs,
that
had
to
be
like
broken
down
or
they
had
to
be
reworked,
so
yeah
we'll
try
to
evaluate
the
situation
and
see
by
the
end
of
the
week
and
yeah
I'll,
see
you
all
again
next
week
with
another
topic.
Hopefully
another
gitlab,
remember
not
that
we
don't
love
seeing
you
brian.
A
We
do
we're
trying
to
engage
more
gitlab
team
members,
more
maintainers,
so
yeah
until
then
be
safe,
happy,
healthy
and
I'll.
See
you
all
online
okay,
bye.