GitLab Create Code Review Group, 15 Apr 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: GitLab 13.12 Kickoff - Create:Code Review

Description

Quick overview of the upcoming GitLab 13.12 work for the Code Review Group.

Planning Issue: https://gitlab.com/gitlab-org/create-stage/-/issues/12822
Planning Board: https://gitlab.com/groups/gitlab-org/-/boards/2159734?scope=all&utf8=%E2%9C%93&label_name[]=group%3A%3Acode%20review&milestone_title=13.12

Display change that made thread outdated: https://gitlab.com/gitlab-org/gitlab/-/issues/24468

FY22-Q2 Large MR Effort: https://gitlab.com/groups/gitlab-com/-/epics/1426

Label to track: https://gitlab.com/gitlab-org/gitlab/-/issues?label_name[]=OKR%20FY22%20Q2%3A%3ALarge%20MR

A

Hi, my name is kai armstrong and I'm the product manager for the code review group here at gitlab today, we're here to talk about the upcoming gitlab 13.12 release and what the code review group has going on. So I'm going to go ahead and share my screen and we'll jump right into it.

A

So here you can see the release board for the code review group um I'll, put a link to this down below and I'll link to the planning issue. So you can see everything that we looked at and everything that we discussed. I do want to just talk about two things and that'll be all we're covering for 13.12.. The first is something that we talked about for 13.11..

A

um This was to show the change in line um in the merge request when the diff was updated, and so- and we talked about this before how it's hard to see. You know what someone changed when you've left feedback on something we wanted to show those changes in line. We didn't have a chance to get to that in 1311, like we planned and so we'll be revisiting, that in 1312. um just wanted to make sure that everyone knew it was still on the radar and that we're still coming back for it.

A

The other thing I want to talk about is what we're going to be doing for the bulk of q2 as a code review group, and so one of the things that we've been hearing in recent research we've also heard about it in previous conversations, is sort of the term largemr and it's an ambiguous term, but it can mean lots of commits.

A

It can mean lots of files that have changed lots of lines that have changed lots of um actual large file sizes that have changed all inside of a merge request and the impact that that has on your experience. Inside of the merge request.

A

We've done a lot of things over the last year in terms of improving that performance, but we're really going to take a harder look at this large, mr piece, and really focusing up on the 95th and 99th percentile of mr. So the the biggest of the big that we see across you know some of the most active projects on gitlab.com, so we're starting on this, and this will be an uh a q2 effort.

A

It'll extend well beyond that we're sure, but we just want to get some bass lines going in q2 and and to start that off we're going to be working on defining a large, mr and so I'll link this issue. This is of interest, so people who are interested in how we progress on this. You can understand how we're thinking about a large, mr, what we think that data looks like and what we think the size of that mr looks like so in this thread you can already see.

A

We've got some conversations about what those sizes are, and actually we've got data down here. That shows what we're thinking about in terms of where the 95th and 99th percentile are in terms of files and lines and the number of commits in those, and so we're really going to be working on building a samplemr that crosses the bridge on all of these things has enough discussions and other things going on.

A

That's representative of the real world, but you know sort of the most extreme cases we're seeing of the real world um and then you'll be working on performance improvements for that. So we've got some performance improvements already in mind of things that we want to try out and test in 1312.

A

But I don't want to talk about those yet because you know they may or may not become reality. um So this is what we're focused on as a code review group you'll see me talk about this a lot probably over the next two or three releases, but I wanted to give you some insight into where we are in this process and what we're doing so.

A

That's it for 1312 for the code review group I'll link to both of these things down below I'll, also link to the label, we're using. So if you're interested in tracking this over the period of time, you're able to take a look at that. But thanks and I think 13.12 is going to be the start of some really interesting stuff here and then we'll continue that on through the 14 series upcoming in june. So thanks for watching.