►
Description
Annabel Gray, Product Designer on Create:Code Review, reviews a few ideas on how we could restructure merge requests.
Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/355574
A
Hi,
I'm
annabelle
gray
and
I'm
gonna
walk
through
what
we
came
up
with
this
last
milestone
for
the
restructuring,
merge,
request
effort.
So
we
have
some
things
between
this
issue
and
mural
and
figma,
and
it's
kind
of
hard
to
figure
out
what
the
outcome
of
that
was.
So
I've
written
down
the
three
hypotheses
that
we
established
a
few
milestones
ago
in
the
workshop
they're
here
and
then
underneath
I've
just
kind
of
added
all
of
the
general
concepts
that
were
discussed
and
worked
on.
A
A
A
I
ended
up
putting
into
the
beautification
of
the
ui
effort
last
milestone,
and
that
was
just
a
reshuffling
of
elements
on
the
page
that
I
believed
were
and
positive
design
updates,
so
they
made
it
in
and
that's
why
it
looks
like
this,
so
the
page
doesn't
look
too
different
in
this
design.
One
concept
that
I
was
playing
around
with-
and
this
had
to
do
with
the
filtering
hypothesis,
was
filtering
out
the
comments
within
the
gitlab
project.
A
A
I've
got
reviews
as
a
separate
concept
now
which
I'll
get
into
later,
but
I
think
we
probably
also
include
commits
in
here-
and
this
would
be
like
the
meat
of
the
overview
like
this-
is
where
you're
seeing
your
code,
reviews
and
comments
and
whether
or
not
it's
been
approved
or
changes
have
been
requested
and
whether
or
not
that
user
added
commits
after
and
the
first
review
and
that
kind
of
stuff.
And
then
the
bot
comments
would
be
the
the
gitlab
bot.
A
That's
like
hey,
you
didn't
add
this
label
or
make
sure
you
had
a
change
log
entry,
here's
a
requested-
or
here
are
some
code
violations
or
others
like
suggested
reviewers
and
all
that
stuff,
all
the
stuff.
That
kind
of
clutters
up
what
you
really
care
about
when
you
come
to
look
at
the
merge
request
would
go
in
that
tab.
A
Metadata
actions
would
be
so
and
so
added
a
label.
They
added
some
time
tracking
and
they
changed
the
milestone
again
and
useful
information,
but
not
necessarily
useful
to
see
every
time
you
come
to
the
merge
request
page
and
then
all
activity
would
just
be
a
combination
of
all
of
them,
and
here
I've
also
added
these
badges,
which
kind
of
pertains
to
this
hypothesis.
Differentiating
new
items
will
reduce
the
time
for
sasha
to
find
items
that
may
require
their
attention
so
figuring
out.
A
What's
new,
since
you
last
looked
at
a
merge
request
or
an
issue
is
a
problem
that
has
kind
of
plagued
the
lab
for
a
while
and
it's
a
difficult
problem
to
solve,
but
it
it
would
be
really
useful
and
some
different
products,
like
slack,
have
that
little
notification
bar.
That's,
like
you,
know,
five
new
messages
in
these
channels,
since
you
last
opened
the
application.
So
this
would
be
kind
of
like
that
in
this
case,
just
pretend
that
five
doesn't
exist
on
the
first
one.
A
But
you
see
there's
12
here
and
42
here
and
if
you
clicked
on
that-
and
you
saw
them
actually
just
clicking
on,
it
would
basically
make
that
badge
go
away.
So
the
badge
appears
with
the
number
of
new
items
and
as
soon
as
you
click
on
it,
then
it
goes
away
and
you
come
back
to
it.
If
there
are
new
items
since
you
last
clicked,
then
that
badge
would
reappear
and
that's
kind
of
a
quick
and
easy
way
to
get
some
of
that
functionality
in
there.
A
Other
things
that
you
see
here
are
this
is
an
outline
kind
of
in
the
style
of
google
docs,
where
you
have
like
an
agenda
item
or
if
you
have
an
agenda
and
you
have
headers,
it
shows
all
those
headers
on
the
side
and
you
can
easily
scroll
and
navigate
between
the
different
sections.
So
in
this
redesign
the
this
sidebar
is
no
longer
fixed
or
sticky
it
scrolls
away.
A
So
if
you're
scrolling
it
it
scrolls
away
just
like
this,
but
this
would
be
the
new
like
fixed
sticky
element
and
it
would
dynamically
update
as
the
merge
request
evolved.
So
you
would
see
like
review
from
user.
One
in
this
case
would
be
paul
and
you
would
click
on
it.
It
would
scroll
right
to
that
and
then,
if
you
wanted
to
know
what
the
security
findings
were,
you
click
on
that
and
the
page
would
scroll
to
that
specific
widget
and
also
you'll
notice.
A
A
It
will
never
change
depending
on
how
many
widgets
there
are
or
how
long.
The
description
is
always
at
the
bottom
and
also
it
kind
of
makes
sense
chronologically,
you're
you're.
Looking
at
the
merge
requests,
you
read
the
description,
you
might
look
at
the
metadata.
You
look
at
all
of
the
reviews.
You
see
that
it's
been
approved.
You
see
the
pipeline
has
passed
every
time.
That's
passing
you
see
that
this
is
all
good
okay
and
then
you
merge
here
at
the
bottom.
A
So
yeah
that's
another
change
about,
I'm
not
sure
which
hypothesis
that
belongs
to,
but
you
know,
would
I
don't
know
if
they
all
necessarily
need
to
to
map
directly
to
a
hypothesis
and
then
other
things
have
just
been
shifted
like
these
have
been
moved.
I
don't
know
if
that's
a
good
idea,
but
those
are
the
the
two
main
sort
of
new
features.
Actually,
that's
not
true
backing
it
up.
A
The
review
feature
I
mentioned
earlier,
so
I
also
wanted
to
add
reviews
as
a
general
concept,
and
this
would
be
like
review
rounds
and
each
review
would
become
its
own
special,
like
special.
Its
own
singular
object.
So
right
now
we
have
batch
comments
but
they're
just
literally
batch
comments
where
you
post
a
bunch
of
comments
and
that's
that
in
this
case
it
would
be
like
if
you
wanted
to
ask
for
someone's
review,
you
might
click
a
button
that
says
request
review
and
you
would
type
the
message
like
hi.
A
Can
you
please
review
this,
as
users
usually
do
if
you're
requesting
reviews,
they
tend
to
write
a
message
to
maybe
highlight
some
certain
points
or
some
questions
that
they
have
and
then
that
reviewer
would
come
to
it,
see
that
box
click
review
and
then
they
would
do
the
batch
comment
thing
review
all
the
things
and
then
when
they
submitted
it,
it
would
attach
it.
They
would
combine
with
the
original
request
into
this
lovely
little
review
round,
and
it
would
also
give
maybe
a
little
summary
of
what
that
review
encompassed.
A
So,
in
this
case,
there's
one
you
know
two
suggestions,
one
nitpick
and
one
question:
this
has
a
few
other
things
that
I
think
are
super
cool.
This
depends
on
conventional
comments,
also
being
built
into
the
product.
So
in
my
head,
I'm
envisioning
like
if
someone
types
nitpick,
maybe
it
auto-completes
and
it
automatically
becomes
that
conventional
comment,
and
it
will
be
added
in
that
way
to
here.
A
We
could
say:
maybe
only
questions
are
blocking
or
something
like
that,
and
so
that
would
have
to
be
addressed
and
that
would
block
the
merge
request
but
nitpicks
not
blocking
because
they
don't
need
to
be
that's
kind
of
the
whole
point
of
the
phrase
nitpick
and
then,
if
you
expanded
it,
you
could
see
so
this.
This
appears
like
this
and
then,
if
you
expanded
it,
you
would
see
all
those
files
that
were
actually
commented
on
with
all
those
questions
and
stuff,
and
then
you
could
also
click
on
these.
A
That
would
maybe
take
you
to
the
changes
tab.
I
don't
know
about
that
one
yet.
So
in
this
case,
this
lovely
check
mark
means
that
this
review
has
been
addressed
and
then
it's
been
re-reviewed
and
you
can
kind
of
link
the
two
in
some
way.
That's
not
this
ugly,
and
so
that's
the
review,
rounds
concept
and
very
broad
strokes,
but
I
do
think
it
kind
of
belongs
in
this
restructure,
because
the
mr
feels
a
little
bit
incomplete
to
me
without
a
proper
review
flow.
A
I
think
that
kind
of
yeah,
so
you,
if
you,
if
you
go
to
the
issue
and
read
all
of
the
other
items
that
we've
added
here,
you
can
kind
of
get
a
feel
for
what
we're
working
on.
In
addition
to
the
three
hypotheses,
one
of
the
things
that
I've
noticed
a
lot
and
it's
come
up
a
lot
in
research
and
just
general
user
feedback
is
how
cluttered
it
is,
and
this
doesn't
really
pertain
to
a
specific
hypothesis
other
than
sasha.
A
Our
persona
might
find
it
easier
to
review
if
there's
less
clutter
on
the
screen.
So
that
was
kind
of
the
jumping
off
point
where
we
decided
to
remove
the
sidebar
where
we
removed
the
branch
widget.
Maybe
to
the
top.
I
remove
some
fixed
elements
and
just
a
general
like
cleaner,
look
to
the
page,
so
you
can
really
focus
on
what
you
want
to
do,
which
is
review
the
code
and
that
doesn't
necessarily
belong
to
a
hypothesis,
but
it's
something
that
should
probably
be
prioritized
nevertheless,
and
then
yeah.
A
This
is
the
mural,
where
we
kind
of
looked
at
and
explored
quite
a
few
concepts,
and
these
are
really
interesting
features
that
are
like
real
features
that
will
take
a
long
time
to
design
research
and
implement,
but
they're
they're,
just
taking
that
whole
merge
request
experience
to
the
next
level,
so
also
really
cool
and
worth
looking
at.
That's,
oh
sorry.
This
was
so
rambling.