GitLab Create Code Review Group, 16 Feb 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: GitLab 14.9 Kickoff - Create:Code Review

Description

Kickoff for the upcoming GitLab 14.9 milestone

Better defined mergeability - https://gitlab.com/groups/gitlab-org/-/epics/5598

Finish a review with a comment - https://gitlab.com/groups/gitlab-org/-/epics/7362

JetBrains plugin see issues - https://gitlab.com/gitlab-org/gitlab-jetbrains-plugin/-/issues/9

A

Hi, my name is kai armstrong and I'm the product manager for the code review group of the create stage here at git lab and today I want to talk about what the code review group will be up to for the upcoming 14.9 gitlab release. So let me go ahead and share my screen.

A

We'll walk through just a couple issues today, so the first one I want to start off with is an epic that we've talked about before, and this is about mergibility in uh merge requests and so there's a lot of front-end and back-end logic that goes into determining whether or not a merge request can be merged.

A

And so we've been working on refining that over time, uh the backend team's gonna get back into this effort, uh hopefully towards the late end of 14-9, and really we're working here to build a new framework for how we do all of the checks and all of the information that goes into that and then we'll be porting uh existing checks into this framework and hoping to improve the reliability of the merge button and making sure that it's active when it's supposed to be inactive.

A

When it's not supposed to be and that we don't get stuck in states that can cause weird issues with just hanging or no feedback in the ui, so we'll be picking this effort back up in 14.9, it's really important to the central reliability of the merge request, and so we're really excited to get back into this one next one I want to talk about is a new feature, uh so this is a design that came out of the design, work that we're doing here and we'll be starting the work on this in 14.9, and so when you're doing a merge request review.

A

One of the things that's common is that you create a review, which is a series of comments that aren't published until the very end and oftentimes. At the very end of that review, you might want to leave a wrap-up comment that says: hey thanks for the contribution.

A

I left some points on xyz I'm going to go ahead and improve this and move on right and so in the submit review button. That's down here in the bottom, we're going to change this to be a pop-up that gives you this option to comment and then, while you're commenting, you can either just leave a comment or you can go ahead and approve that in that comment as well, and so this really expedites the review process here and allows you to submit all your comments.

A

Get that final piece of feedback and then go ahead and approve it and keep the ball moving forward on this. So this will be a nice little enhancement to the merge request, review flow and we're pretty excited about this one and last one I want to talk about is in the editor extension category, and so um gitlab has a vs code extension that we work on for vs code and it allows you to interact with gitlab and merge requests and many other things in gitlab with vs code.

A

We're also starting work on an extension for jetbrain. So we know there's a lot of jet branch users out there, a lot of people that use those ides for uh the various languages they work in, and so we're going to start working on this and we're we're down the path a little bit.

A

We've got some of the bases in line and so sort of the first thing that's going to happen in it is we'll be able to show you all the issues, and this is just a small step on the way, as we continue to iterate and build on this.

A

But I just wanted to highlight the progress we're making on jetbrains and know that we know you users are out there and we're excited to start working on this for you. So that's what we've got coming up in 14.9.

A

If you have any questions I'll put links to these down below the video or you can reach out thanks.