GitLab Create Code Review Group, 18 Jan 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: GitLab 13.9 Kickoff - Create:Code Review

Description

Create:Code Review Planning Issue: https://gitlab.com/gitlab-org/create-stage/-/issues/12785

Release Board for 13.9: https://gitlab.com/groups/gitlab-org/-/boards/2159734?scope=all&utf8=%E2%9C%93&label_name[]=group%3A%3Acode%20review&milestone_title=13.9

Custom commit message when applying a suggested change: https://gitlab.com/gitlab-org/gitlab/-/issues/25381

Improve performance of discussions in merge requests: https://gitlab.com/gitlab-org/gitlab/-/issues/209784

Request Re-Review from Already Assigned Reviewer: https://gitlab.com/gitlab-org/gitlab/-/issues/293933

Proof of Concept for interacting with existing comments in VS Code: https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/269

Merge Request Reviews in VS Code: https://gitlab.com/groups/gitlab-org/-/epics/4607

A

Hi, my name is kai armstrong and I'm the product manager for the code review group here at git lab and today we're going to talk about 13.9, kickoff and what's coming up for code review. So let me go ahead and share my screen. Real quick and we will jump in um this- is code review, 13, 9 planning issue. You can take a look at this and see sort of everything that we've talked about and what we're looking at and what we'd like to work on.

A

um There's a link to this board that you can get to from that issue. So you can see sort of everything, that's in the milestone and everything that the code review group will be working on. But let me talk about a few things, so the first one up is adding a custom commit message when applying a suggested change.

A

We've talked about this one before we're getting a lot closer on it, some of the details around making sure that we're including the proper variables and that those are expanded when you try these commits um just to make sure that we're giving you the right experience when you go to apply these suggestions, so we're gonna continue to work on that. Hopefully we'll get this across the line in 13.9, but be on the lookout for that one.

A

I also want to talk about a performance improvement that we've been working on for quite a few milestones, and so this has to do with the performance of discussions um in merge requests, and so we've been doing a lot of back end work on this and we're ready to sort of bring that back in work into the front, end and sort of action on an n139. So um there's a lot in this issue and you can sort of read through and and see the history here.

A

But um you know performance is a real concern around the merger request and we just wanted to highlight that we are working on this and this is um hopefully going to be a really nice noticeable improvement in 13.9 uh from a feature perspective on reviewer. So we ship reviewers in gitlab, 13 7., it's on by default, so hopefully you're using that feature in a merge request and if you have any feedback, feel free to.

A

Let us know um in 13, 9 we'll be working on an improvement there to request a re-review from an already assigned reviewer and so um I'll go ahead and open. This there's already a draft tomorrow in progress to add this functionality.

A

So what this would do is it would list out everyone who's, reviewing a merge request, who's who's been added as a reviewer, and if I make changes to my merch request- and I need you to take another look I'll- be able to click a button over here on the right side in the sidebar that will re-trigger a notification and a to-do for you saying hey, I need you to come re-review the merge request that I've been working on, and so we think this will be a really good improvement in continuing to help improve that handoff between um the authors of merge requests and those reviewing it and and helping deal with those signals back and forth.

A

So this is one of the first steps that we're going to do as part of reviewers and and the additions on that sidebar. But um we're really excited about this one hope to get that one in 39 as well.

A

The last thing I want to talk about is um I just briefly wanted to touch on the updates to doing code review envious code. um It's the through the gitlab workflow extension that we have, and so we've been adding improvements there. If you have the latest version of the extension and you open up the webview components, you'll be able to actually see all the diffs uh comments on those disks and other things.

A

Inside of that extension, what we'll be working on in 13.9 is proving out that we can interact with existing comments and make new comments via the api inside of vs code, and so this would actually allow you to comment on a diff. Send that comment back to the gitlab merge, request interface, and so you could see the comments in both places so that way, when you're working through your code review, if you do that in vs code, you can have sort of all of those features in both places.

A

So we're really excited about continuing to work on the code review experience inside of vs code I'll link, this issue down below also put a link to the epic, so you can sort of track along all of the progress there, but I'm just moving along nicely. So that's it for code review in 13.9. I'll put links to all this down below if you've got any questions or you've got any feedback for us. Please feel free to reach out thanks for watching.