GitLab Create Code Review Group, 14 Apr 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: GitLab 15.0 Kickoff - Create:Code Review

Description

Code Review kickoff for the upcoming 15.0 GitLab Release (our best yet).

1. Merge requests that require my attention: https://gitlab.com/groups/gitlab-org/-/epics/5331
2. Automated attention request improvements: https://gitlab.com/gitlab-org/gitlab/-/issues/357269
3. Restructure MR merge widget: https://gitlab.com/groups/gitlab-org/-/epics/5589
4. OAuth for GitLab Workflow for VS Code: https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/221#note_885722819

Code Review 15.0 Planning Issue: https://gitlab.com/gitlab-org/create-stage/-/issues/12986

A

Hi, my name is kai armstrong and I'm the senior product manager for the code review group here at gitlab today, I'm here to talk to you about what's upcoming in the get lab, 15 uh release and what the code review group will be working on. So I'm going to go ahead and share my screen and I'll walk through just a few things that we're excited about.

A

So the first one up is merge, requests that require my attention. So this is something we've been working on for a few milestones now and we've talked about in other kickoff videos we're getting really close on this. And if you were on gitlab.com about two weeks ago, it was on for a few days and you got to experience sort of what we're after and what we're doing here.

A

So we're really excited about this feature and bringing the ability to sort of tell people who are involved in the merge request, whether they're a reviewer, an approver or the author or other people that the mr is waiting on them and that it needs their attention in order to keep moving that mr forward.

A

So some of the feedback we got while it was on for a few days, was that there's a lot of automation that we built into attention requests in order to make that experience more seamless as part of the review flow, to either request attention or remove attention from people that are participating based on the actions they're taking, and so we're we're going to make a few tweaks here and remove some of the automated behaviors and add some additional ui elements to make it more clear.

A

What's going on, and so we're going to be working on that right at the very beginning of the 15.0 milestone to get that shipped and then we'll turn this back on gitlab.com and hopefully we'll have this on entirely for the gitlab 15 release towards the end of the month.

A

This is the first thing we're working on um keep an eye on it for gitlab.com and then certainly keep an eye out for self-managed releases. uh Following that, the next one we're working on is also something we've been talking about for a while, and this is restructuring the merge widget, the mr merge widget, and so this is the actual widget area um where you click the merge button, and so it's currently it's sort of structured like this.

A

Where you hit merge, you can delete source branch, there might be squash, commit messages are down below and there's sort of all these. All these things happen um below the fold of the merge button, and what we're changing here is where we want it to work more like a form, but also be significantly more informative about what's going on and allow you to select these options ahead of time.

A

Tell you what's going to happen? What issues might be closed and then click this merge button. So we're really close on this one as well, and hopefully we'll get this into 15., and this will really improve the experience and the information architecture around the merge button, so that you know what's going to happen when you click that and there aren't any surprises or anything that you weren't expecting to happen there.

A

The last one I want to talk about is for vs code, and so this shifts gears a little bit. We have a vs code extension called git lab workflow. You can get it in the marketplace uh if you're not using it check it out already, but um one of the things that we know is it's it's a little bit challenging to get started when you're new to setting up this vs code extension and that's because of the way gitlab integrates with it currently, which is through a personal access token.

A

So when you get the extension downloaded, you have to go and create a personal access. Token in your account, you have to apply it to the extension and then everything will work after that. We're going to change this for gitlab.com and we'll we're going to continue to iterate on this and and work to roll it out in self-image as well, but during 15 we're going to be working on supporting oauth for gitlab.com.

A

So if you are a gitlab.com user, when you open the extension you'll be able to authenticate to gitlab.com click, a button we'll take you to gitlab.com, ask you to authorize the application once you authorize it, you can come back into the extension and it'll already be connected and ready to go, and so this will sort of simplify the steps to do this, and so this is sort of a proof of concept that was done, we'll quickly sort of go through this, and you can see um how we allow the extension to use the authentication we go and we authorize the extension.

A

We ask for the permissions that we need. We authorize and then you're good to go and the extension automatically loads into the gitlab workflow area and everything's connected and ready right there.

A

So this is going to be a huge improvement for new users getting started as well as existing users. If you want to switch your authentication methods over to this, as we continue to expand this into self-managed, we hope this will help make it a lot easier for self-managed users to adopt this as well. So that's what we've got coming up in 15.0 for the code review group. If you're excited about any of these things, let me know I'll have links to the issues that we've talked about here down below and also the 15 planning.

A

So you can see everything else that we're working on in code review. So thanks for watching bye,.