GitLab Create Code Review Group, 23 Nov 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Approval Rule testing with Suggested Changes Author

Description

Testing to see how approval rules are enforced when author information is tracked as part of suggested changes in Merge Requests

A

All right, so I'm looking at james's, mr to add author information, to suggest it changes um as part of the process. So I'm just gonna share my screen. I'm gonna run through this uh he's running his branch now so solve that that issue from before.

A

To start, I guess I'm gonna we'll start and we'll change we're going to go to users. So actually we'll start here.

A

uh We'll just confirm that the settings are what we think they should be.

A

A

A

So we've got prevent approval, merge request by merchant quest author and prevent approval of merge requests by merge, request, committers.

A

We'll leave both of those on for now and then we'll go and pick a user. So this project's got like three users in it: one developer, one maintainer and one user. Obviously,.

A

All right, so we are we're gonna impersonate, this user.

A

A

What's happening now, I can't impersonate users.

A

Okay, I've been logged out.

A

A

Okay, all right so we're now impersonating them.

A

They can't do anything. Let's go make a merge request.

A

A

All right, well, you're, gonna! Do the file um that's round number three all right hit file!

A

There's a change! Another change!

A

I'm gonna change this! I don't change it all right! We're going to create a merch request default I'll start image.

A

A

Energy, queen all right.

A

It's got one required approval so we'll get to there.

A

Okay, we're going to now stop impersonating create an emergency quest. We know who the author is we'll go back, we'll get our maintainer to review.

A

A

Super slow should speed this up in in post.

A

A

Measure quests so we're here we're on round three.

A

So, as you can see,.

A

A

A

So it's checking approval status, so I have the ability to prove it can't merge it because not approved. So what I'm going to do so we're going to go suggest a change because.

A

Okay, so we we're suggesting a change to this line.

A

I know from another one if I were to apply this change myself. That would instantly make me a committer that I wouldn't be able to prove, but what I want to do.

A

Is I'm going to go back and get my other user? Now? The original author of the merge request.

A

Impersonate them.

A

All right, so we are.

A

Slowly, getting there slowly slowly, slowly,.

A

All right round, three, all right, so we have in this merge request uh three year back. So this is the original author, I'm logged in as roger, and if we.

A

Look requires approval, merge can't merge and it requires approval. Still here's a suggestion. We're going to apply the.

A

Suggestion all right, so we've applied it that resolves the thread. All threads are resolved, we're going to go back because now we need to go, get get our person to approve this change.

A

Go live back in as the other.

A

A

All right and we're coming back to that invar, so we're back to impersonating the maintainer, the maintainer and load up. This merge request.

A

A

Before we had the ability to approve and if we'd approve we could have merged, so, let's see if we still have the ability to approve it or if we've lost our approval abilities now we're checking approval status.

A

So I can still approve this, even though I authored a change in it.

A

So we'll double check that so um we authored it we're good. We approved we're gonna merge it.

A

A

All right merged sue.

A

So, let's check the commits and see if they reflect accurately the suggested change path there. So.

A

Yeah, so this was.

A

This is the original commit that we did.

A

Go back, this is different, so this is saying it was one suggestion in one file, even though we know this person didn't so it was. We should see authored by committed by. So that's the new. That's the new functionality of this change, which allows us to see that those were authored by someone committed by someone else.

A

So that happens there and then the merge commit was done here. Just double check the merchants so.

A

um Yeah- and that was all right there, so we go double check. um Reviewer leaves a suggestion. The author applies it reviewers prevented from so it did not impact that, so we should be good there. So um yeah thanks.