►
From YouTube: 2023-03-22 Code Review Weekly
Description
No description was provided for this meeting.
If this is YOUR meeting, an easy way to fix this is to add a description to your video, wherever mtngs.io found it (probably YouTube).
A
All
right
welcome
to
the
code
review
weekly
for
March
22nd
Andre.
You've
got
the
first
one
up
so
take
it
away
sure.
B
I'll,
take
it
thanks.
Guy,
so
I
want
to
bring
this
topic
up
here
for
a
discussion,
essentially
because
yeah
when
we
picked
it
up,
there
was
a
bunch
of
discussions
happening
in
there
and
I
couldn't
distill
it
properly.
It's
essentially
something
that
is
happening
when
we're
creating
diff
notes
on
NMR,
and
we
have
the
white
space
changes
disabled
and
what
I
missed
was
that
in
some
situations
it
was
an
error
right,
3
500,
but
not
all
of
them.
B
So
there's
still
a
lot
of
cases
where
the
files
are
valid
or
the
I
guess.
The
diffs
are
the
same
two
white
space
and
non-white
space.
So
I
guess
those
are
fine
and
others
are
failing,
indeed,
between
500.,
so
the
action
there
is
as
an
interim
solution,
is
to
mitigate
the
errors
which
I
understand
it's
going
to
like
prevent
the
failures
by
disabling
the
comments,
but
in
essence
we
would
be
removing
the
ability
that
they
currently
have
successfully
comments
on
some
files.
That's
the
transients
aspect
to
this
bug
is
that
correct?
A
Yes,
I
think
in
yes,
in
some
cases
with
that
setting
on
we
don't
have
the
data
to
make
a
comment.
In
some
cases
it
will
work
depending
on
what
the
difference
of
the
white
space
changes
are
and
how
it
regenerates
the
diff,
but
and
not
in
all
cases,
and
then
I
think.
The
related
issue
is
that
in
other
cases
you
also
can
generate
a
four
to
two
error.
A
When
you're
hiding
white
space
changes
as
well,
so
sometimes
they
can't
necessarily
like.
Sometimes
it's
a
500,
it's
an
outright
failure.
Sometimes
it's
a
four
two
two
and
then
there's
a
smaller
case
where,
like
I
guess,
it's
successful.
B
Okay,
thanks
so
I
totally
understand
that
there's
a
well
it's
the
definition
of
a
transient
error.
Right,
sometimes
it
works.
Sometimes
it
doesn't
in
this
term.
In
this
time
we
do
have
some
knowledge
on
what
are
the
situations
where
it's
possible
now
when
we're
starting
to
have
an
a
difficulty
to
understand
not
to
understand,
but
it
feels
like
we're
up
after
assignment
after
signing
this
and
discussing
this
with
Phil
and
and
the
the
whys,
and
what
we're
doing
here,
it
does
feel
like
we're
trying
to
ship
something
as.
C
B
Interim
that
could
well
I,
wouldn't
say
delay,
but
essentially
it's
going
to
take
us
longer
or
to
take
a
long,
so
I
think
it's
a
while
to
get
the
solution
sorted.
So
why
not
start
right
away?
Try
to
find
a
solution
instead
of
like
removing
the
ability
of
them
commenting
on
certain
valid
scenarios.
So
it's
I,
don't
know
exactly
what
the
proportion
is,
and
that
depends
on
the
Mr
like
for
some
users
who
have
that
option,
disable
the
show
white
space
changes.
B
They
might
not
have
a
trip
this,
because
the
files
are
the
same
and
he
was
Phil
shared
a
periscope,
dashboard
I,
don't
know
if
I
I'm
not
going
to
share
it.
I,
don't
know
if
we
should
put
in
a
recording
I
couldn't
even
the
agenda,
but
just
this
would
affect
a
lot
of
users
right.
B
B
Could
we
find
a
better
mitigation
where
we're
like,
detecting
that
this
will
have
a
problem
and
not
losing
the
data
to
have
data
loss
is
a
problem
or
essentially
start
using
the
capacity
we
would
do
to
use
to
do
this
to
start
discussing
a
solution
for
packet
and
front
end
to
kind
of
like
come
up
with
an
actual
solution.
So
my
call
out
here
is
try
to
rethink
the
scheduling
of
this
and
potentially
replacing
it
with
either
a
softer
mitigation,
or
essentially
just
finding
a
solution
for
the
problem
at
hand.
B
That's
that's
the
point.
This
agenda
item
any
thoughts
on
that.
A
Yeah
I
I
I
get
the
concern.
I
think
the
problem
is,
is
when
back
end
looked
into
this.
They
don't
they
don't
have
an
answer
like
they
don't
like
in
terms
of
like
like
starting
work,
I,
don't
we
don't
have
an?
A
We
don't
have
an
answer
for
it,
because
the
diffs
the
problem
is,
is
that
the
diffs
are
like
fundamentally
different
right,
like
white
space.
Isn't
a
cosmetic
change.
It
is
actually
a
different
diff.
A
And
so
we
don't
have
matching
data
in
all
those
scenarios
to
deal
with
like
how
comments
display
and
that's
where
this
like
falls
apart.
Right,
like
if
we
say
it's,
this
line
in
this
line
for
this
diff
and
then
I
view
an
MR
in
a
different
way.
A
B
A
A
What
they're
getting
back
right,
like
I,
think
commenting,
is
and
I
you'd
really
need
to
ask
Mark
like
you
would
be
the
better
person,
but
in
my
I,
think,
because
comment
data
contains
old
line
and
new
line
positions
and
Old
Line
and
new
line
positions
for,
like
all
of
the
Shaws
like
it's
multiple,
like
parameters,
right,
I,
think
it's
like
four
or
five
things
that
actually
go
into
positioning
a
comment.
I,
don't
know
that
we
technically.
C
A
Like
I
think
that's
where
this
like
doesn't
work,
I,
agree
that,
like
we
need
to
to
fix
it
without
a
plan,
though
the
risk
is
that
we
leave
users
in
a
unhappy
state
for
longer
right
like
the
right
now.
We
know
that
we
get
fairly
regular
reports
of
users
hitting
the
500
error
right
like
it's.
A
It's
pretty
regular.
There
lots
of
customers
right,
it's
definitely
increased
recently,
but
it's.
But
it's
frequent
enough
that,
like
this
is
a
problem,
and
then
you
compound
that
with
like
the
four
to
two
error,
which
is
also
fairly
frequent
and
I,
think
also
related
to
White
space
changes.
If
I'm
not
mistaken,
that.
A
B
So
here's
what
I
propose
I
proposed
using
this
issue
as
sort
of
a
spike
with
the
end
goal
of
shipping
and
litigation
for
the
data
loss,
but
leave
it
open
instead
of
being
something
like
disabled
comments.
That's
the
expected
outcome:
I'm
gonna!
B
If
we
don't
do
that,
do
we
start
a
mitigation
where
the
500
happens
but
does
not
eat
up
the
common
or
the
batch
comments?
It's
also
mitigation.
We
want
to
avoid
the
data
loss
for
sure,
but
I
would
like
us
to
try
at
least
going
into
this
without
a
closed
solution
right
away
and
because
it
feels
I
think
we
don't
understand
that
it's
a
drastic
measure,
but
instead
of
going
in
there
with
that
assumption
that
we're
disabling
the
comments
for
everybody
that
has
that
option,
disabled
I'm
gonna
poke
around
a
little
bit.
B
We
might
end
up
getting
a
milestone,
compromising
and
having
to
shake
the
same
thing,
I
hope
or
don't
I
hope
we
find
something
else,
but
it
doesn't
do
you
have
you
have
a
problem
with
that?
Okay,
like
Pokemon,
trying
to
find
other
ways
to
get
around
this.
B
A
I
think
like
what
you
mentioned
about
potentially
like.
Oh
maybe
we
like
attach
the
comment
and
just
show
it
not
like
in
the
file
or
at
the
bottom,
like
I'm,
not
sure
like
foreign
ux
would
love
that
I
also
don't
know
about
saving
them
from
the
500
right.
I.
Think
the
risk
of
saving
you
from
the
500
and
retaining
your
data
is
that
I
didn't?
A
What
do
you
do
right,
like
the
different
when
we
saved
like
we
did
this
with
search
right
like
where
we
now
rescue
the
500
and
like
say
hey,
you
just
need
to
do
something
different
like
the
problem
here
is
like.
If
you
leave
a
comment
and
I'm
like
you
need
to
do
something
else
to
get
this
done.
A
B
Here's
what
I'm
thinking
you
know
I
have
that
experience
with
tools
that
import
photos
from
your
phone
to
your
computer
I,
it's
normal
for
some
photos
to
fail
to
transfer
but
they're
still
in
the
phone.
Essentially,
instead
of
assuming
that
the
batch
comments
or
the
publishing
of
a
comment
is
like
success
or
failure,
it
could
be
something
like.
Oh
your
review
was
posted
43
comments
were
successful,
two
failed,
but
they're
still
in
draft
mode.
We
didn't
delete
them
as
drafts
now.
B
I
understand
that
that's
much
more
easier
said
than
done,
but
I
feel
like
Presque
is
some
easy
ways
to
rescue
them
from
a
potential
failure
on
the
500.
B
If
you're
prepared
for
that,
because,
for
example,
what
I'm
thinking
exactly
on
the
front
end
is
in
the
contexts
that
we
do
the
publishing
of
a
comment
there's
a
moment
that
we
clear
the
local
cache
of
the
local
storage
of
the
draft
comments
you
have
not
published
yet
so
there's
a
moment
very
clear
that
once
we
get
to
success,
so
we
can
ensure
that
we
get
a
success
before
we
play
with
that
cash.
B
When
you
publishing
a
comments,
so
yeah,
basically
I,
don't
think
we
will
find
a
solution
here
on
the
call.
Essentially,
what
I'm
asking
here
is
just
we're
going
to
take
a
little
longer
looking
around
and
see
if
you
can
find
Alternatives
and
we'll
discuss
it.
Of
course
we
do.
Actually
it
just
feels
feels
off
going
in
there
again.
I
don't
want
to
discard
the
work
already
done
by
Jay
you're
right,
like
they
already
popped
around.
They
were
trying
to
find
a
solution
in
that
and
Mark.
B
Well,
I
I
I'll
be
transparently
and
say
that
Phil
wasn't
particularly
excited
for
at
least
willing
to
say
all
the
comments
right
away.
Yeah
I
mean
that
might
be
that
he
needs
to
put
it
on.
A
I,
don't
love
it
either
if
we
have
a
better
solution.
Fine,
my
I'd
say
my
concern
with
spending
time
investigating
right
now.
Is
that
we're
already
like
a
somewhat
capacity
constrained
right
like
we
didn't
build
incapacity
for
this
and
like
in
particular,
Phil
has
other
things
going
on
this
Milestone
to.
B
A
A
Where
is
the
capacity
to
investigate
this
like
if
we
can
time
box
it
to
like
spend
a
day,
if
you
can't
find
anything
easy
great,
if
not
then
like
okay,
and
if
the
concern
is
like
the
other
option,
right
is
put
this
in
with
a
feature
flag
turn
the
feature
flag
on
on
SAS,
don't
enable
it
by
default
and
like
let's
wait
and
see
like
how
problematic
and
like
maybe
we
can
turn
it
off
gradually
or
something
right
like
that,
gives
us
a
way
to
back
out
of
it
without
needing
to
like
unwind
it
completely.
A
If
we're,
if
we're
that
risk
concerned
about
it,
I
think
you
know
ultimately
like
we've.
A
Do
it
yeah
comments
right,
I
said
ultimately,
like
I
think
we
all
agree
that
there
is
something
fundamentally
wrong
in
the
underlying
like
comment
piece
here.
That,
like
is
creating
all
of
these
challenges
between
different
diffs
and
versions,
and
all
of
these
things
and
like
we
need
to
figure
out
how
we,
how
we
do
that,
but
I
I
tend
to
believe
that
that's
probably
a
a
much
larger
effort
than.
B
I
think
you're
on
mute.
Sorry,
I
was
muted,
yeah,
I
think
that
works
for
me
and
I
think
we'll
take
a
look
to
see
if
we
can
come
up
with
any
other
Alternatives
and
then
we'll
be
chatting
about
this.
But
if
we
do
do
this,
we'll
always
be
behind
the
future
effect,
so
we
can
control
you
of
course.
In
case
we
have
a
riot
on
the
streets.
We
can
react.
Much
quicker
right,
I
think
I
think
that's
all
I
have
for
this
point.
B
So
are
we
thanks
guys
Amy?
You
have
next
question.
C
C
C
A
Yeah,
this
is
all
our
idea
and
design
that
we
gave
to
verify
to
go,
validate
and
deal
with.
Okay,.
C
A
Part
of
a
larger
concept
that
is
legitimately
Auto
merge
that
code
review
wants
to
do,
but
this
was
a
okay
that
needed
to
be
solved.
First.
C
A
And
from
a
ux
side,
Pedro
has
been
involved
in,
like
the
the
refinement
of
like
the
last
minute
changes
to
designs
that
we're
making
so
okay.
If
there
are
questions
there,
then
I
think
Pedro
Pedro
is
I,
guess
technically
the
ux
dri
here,
because
I
don't
think
Ithaca
is
on
Pipeline
execution
anymore.
So
I
think
a
lot
of
this
belongs
to
Peter
too.