GitLab Create Editor Group, 24 Aug 2023

Previous Meeting

Next Meeting

⏯

youtube image

►

From YouTube: Web IDE Maintainer Onboarding - Aug 2023 3/4

Description

In this session we pair some more on a Web IDE issue.

A

Thanks for hopping on the maintainer onboarding, we have one more after this one and right now we're just pairing up on issues. I have a good feeling about this I'm feeling sufficiently caffeinated and we're so close to wrapping this one up. So I feel like uh we're gonna, possibly get this done um all right.

A

Hopefully, then flash any secrets just that, let's, let's be optimistic. Okay uh here is the merge request that we were working on and we push the commit over in the last week's APAC hours, where um we dropped in the Quarry that um Aaron graciously provided and we're gonna end up using this to detect whether the ref we have is a branch, a commit or attack.

A

um Oh yeah and I think we also added this method to our yeah yeah. So we had a discussion of like we need to add a new query. We still have this like deprecated client thing and from the um mediator command. The start mediator command. The only client we have in scope is the deprecated client.

A

So do we want to refactor everything to using the new client that we want to try to use, or do we want to use this deprecated client? um We landed on. Let's just solve the current problem at hand. It's okay for us to add a change to the deprecate client, we'll refactor. All of that later, um so we didn't get sidetracked and um which is probably a good thing.

A

So now I think um we just need to consume this thing. We did do some of the renaming and commenting that um that you left in some uh of the asynchronous comments you left from this Mr Aaron, um and so we can uh I'll, probably ping you to take another look at it all together, to get more of your thoughts to see if this is in line with your thinking, but I think we're ready to move forward. So let me go ahead and check out this branch.

A

uh Okay, let me go here: let's see where I'm at all right, let's go to man! Oh no I just need to go to the branch I'm working on.

B

A

All right, we're so close, so close, uh so I think the only thing we're missing is um so we still have some types that are failing, which tells me where to pick this up. So let me run yarn clean.

A

And then yarn builds yes to get the pipes that are found. It's probably a way from I could do this easier in the vs code, but I'm not gonna worry about it. Okay, great good, that's project Branch! So this one thought I had um so the last change we made was adding this to the client. This fetch ref metadata. That's what I was calling it so I can now call client fetch ref metadata. That's great um I kind of want to move this little bit of logic into its nice own, testable function of.

A

You know I, don't know, get get lab, get ref.

A

I don't know um I'm gonna call it uh uh that raps info such a bad name, I'm, just going I, don't know I'm, just gonna call it wrath. Okay, um I get really: uh oh wow. Okay. What are we doing? Man all right? So if I have a ref, that's like this and I have a client which is our git lab deprecated client.

A

Let me see what it's actually called: oh deprecated, git lab client yep. That's right!

A

Let's go! We can import you right. We can figure it out right, we're smart enough to do it. uh You know you're, not smart enough, yet because we're not now the JavaScript, yet okay, but now we're smart enough to do it. No, not quite yet um all right, I'm just going to copy you, then all right, you don't need this thing all right!.

A

So I kind of want to create this function for given our string, ref yeah, given this ref name thing that we end up with, given that um let's build the uh get lab ref, what did we call it? Yeah I think we call the gitlab ref yeah. Let's build a git lab raft that we expect from maybe fetch ref isn't the right thing, but since we're dealing with the client, that's kind of why I called it fetch, uh okay and then we'll also taken the practice for fun. We don't need any.

A

We don't need the full config. Maybe it's worth us just taking in the project path, because I think that's all. We really need all right for right now. I do I can't stand how erroneous everything looks so I'm just gonna return, no like that.

B

Oh geez yeah all right, I'm.

C

Gonna, let that be yeah I.

B

C

Gonna say promise resolve without handle it.

A

C

What did you say again for Noel? Could you change the the null to problems resolve? Oh.

A

Yeah, that's a good idea. Yes, I could do something like this. um Oh yeah yeah, that's a great idea. Yes, yes, yes, yes! Yes! Yes! Yes, yes, I, see what you're saying.

B

Come on come on come.

A

On come on, come on give it to me all right, still not giving it to me. That's fine uh I, don't I don't need it. This is my OCD kick in it. Let's, let's just be at peace with the errors. I have to accept it. I gotta be.

A

Why am I? Why am I fighting the errors? Errors are just a natural part of the cycle of life and I need to just embrace it, um but that's fine! So here, instead of doing branch, we will await something like fetch, wrap. Geez I want you to be smarter, like it's. Not it's used to I feel like it used to help me out a little better than it's helping me out right now, uh so I'll just type the stuff in uh coming from utils. That's enough and that's fine.

A

Why are you not happy? Is it because typescript kind of freaked out I think types good, I think my typescript server is freaking out I? Think that's got to be it! That's. Why I'm not getting as helpful information as I did so I went to restart TS server, which I find myself having to do every once in a while I, don't know if I find myself using vs code having to do this, given that it's a separate, uh separate service like TS server I'd.

A

Imagine you'd have to do this as well, if you're on jet brains or something like that, but that's generally pretty helpful if you find like wow well, I thought you were. You know smart friend, typescript you're, not acting so smart anymore, usually the TS server kind of has to kind of have to restart it, um but now it seems a little better um great.

A

All right. uh Look at that! Look at that! Oh yeah, brilliant, okay, and so now we get this refi thing.

A

um Oh, but that's already a thing here: oh geez, um wait! Is it a thing? No, it's not a thing. Yet it's just not reference. Okay, um but then here's the interesting thing it's like based on the ref, oh yeah, I, think I. Think we added this thing where every ref could have a just a shot, yes cool, great and then I can just return to the refs brilliant all right now we just got to focus on that utility function that we're going to implement um sound good, okay,.

A

um I have something going off in the back of my head. Like don't forget this thing, but I totally forgot it I would so we're gonna keep moving forward. It's important I'll! Remember it uh uh all right! So the the strategy here is: oh yeah yeah. um The strategy here is use um ref, metadata, endpoints to jeez. Look at that suggestion.

A

A

Yes, all right, uh jeez, all right all right! This is making me feel insane. This is like um the shine uh right. uh I don't want to give away the shining, but when uh yeah this is making me feel like The Shining, um all right I can all right I've. This is so throwing me off, but I'm gonna try to keep moving forward.

A

um I'm gonna use it to get uh an object uh of metadata and then use the metadata to um or yeah what kind of just kind of like non-actual switch but switch on the metadata uh to return a specific type of git Lab Rats. uh That's our goal! Okay! So let's get the metadata metadata equals client dot. uh That's ref metadata.

A

B

A

Ref, okay, and so now we get this um oh, like I, got to make all this Ace.

B

A

Because then, I need to await this thing, all right. So now, I have all this metadata. Suite, okay, I gotta go back to this algorithm. We were talking about over here.

A

So we were at uh where, if we pass in a branch name, tags will be null.

A

And we will see it in Branch names right, that's kind of how we can determine that's. So if we're a branch hangs will be null and we'll see us in branch.

A

Just if we're a attack.

A

That's! Oh sorry! If we're a tag, that's the only time tags will be not empty right.

A

So, if we're a tag, tags will be not empty, like that's enough to determine that.

A

um So then, if we're a full Shaw.

A

Yeah and then I guess we get to see else Workshop right. That's probably.

C

Good enough yeah, it's essentially else if it's click commit ish I feel like I posted, like the the dictionary definitions of what like the GitHub references or the get get references, I.

A

See it's probably worth doing an elsif, because um you know what I will say. We should probably do an elsif to check that this was passed because then, if it's all, if it's all in all, we probably need to handle that, like you pass in something completely erroneous, uh I also were a Shah um or else if um it resolves to something it's not an empty Workshop. Something like that.

A

um Okay, let's try it out so.

A

um If tags will be, oh, the last commit will be. No, so we'll still get the whole thing. It's this last commit bit that's what we were noticing.

C

Yeah I think the graphql so I I aliased it so like the web underscore IDE underscore underscore Alias like that refers to just like hey. We can quickly grab the like the keys if we're gonna do like object.keys to iterate over but I. Think if you go back to the query, it's like it tells you the graphical type name, so I guess the yeah. The graphical type name was a tree.

C

So essentially you get back a single tree, object, yeah, but because that I'm doing the query four different ways, because they're like depending on the arguments, it could be a difference, um then I have I just Alias them. Essentially. So like a way, that's it's a simple prefix for the I.

A

Think I think that makes sense I think when I was when I was a little, what I wasn't so what I was a little confused about is what do I need to check is null and it looks like it's not this bit, but it looks like based on these responses. It looks like I need to check that the last commit of that thing is null.

C

Yeah so I think you always get back a valid uh tree object. Yeah.

A

C

If there's not a valid tree object, there would be an error in the graphical errors response that.

A

Makes sense um so if this is um so I'll just check the truth, yeah there's something a little more giving so I want to do like uh geez uh uh I'm, giving you something like this I don't know. If that's right, maybe it's not maybe there's a better way to do that, but.

A

Yeah I'm doing something like this.

A

If we don't have a tag and uh data, Branch names, dot.

A

There's not a contains, is there that's kind of lame. uh I could just do a uh well, it includes that's the one, that's the one, that's it! That's it! That's it yes includes. Is it yes, all right, laughs, all right? If we don't have a tag and Ranch names includes ref, we are definitely a branch, so we are returning. Oh look at that sweets.

B

What's wrong with you.

A

Oh I need to go look at the type we have it's not just like that, but then we got the whole. So then we I, so this is this- is the bit that I was like.

A

Maybe we could do this better, like maybe we could do this all in one round, because so previously I got this whole API response from give me the branch information and it contained a bunch of stuff but oh, come on, give it put me there put me in uh I want to go to yes contain a whole bunch of stuff like web URL, oh and I guess I was using, can push protected.

A

I think I am using that um yeah.

C

We kind of we cannot buy account, Bush, I, didn't know exactly what use cases we'd put this object through, but I think uh it might have been three or we might have had to go grab the branch of the project, foreign.

A

So I think that's what we'd want to I think that's how we're gonna need to do this, though yeah so we are, we are detecting that so part of me was thinking. um Please stop. Okay, part of me was thinking.

A

um Maybe I wouldn't need to fetch that and I can fetch all the information as I fetch that metadata from the graphql like I, could fetch all of those permission stuff as well in one pass, but I'm thinking. Maybe I can't do that. We'll just we'll go ahead and do this to determine what it's going to be, but then I'll also have to still fetch the the branch information and that's fine.

A

B

Let's see such project Ranch.

A

Yeah, we'll just do something like this I think it'll be open.

A

um Okay, so then, otherwise, if we have um all right, so let me let me go back, though, to.

A

Okay, yeah, we should still be fine, uh because I was thinking all right. Well, my thought was just now is okay, but wait. Do I need to do like, can push and protect it. Do I need to do that for tags as well, but I realized. Wait. You can't push to attack, that's always gonna, be I. Don't I, don't need this information for tags and commits so I think the only time I need to make a second request is: if we are a branch, I need to go ahead and make that API request.

A

The other ones I think I can just create here. So so here, if we're a tag, I think we're ready to go. I'm just going to return type tag. Name is the ref that we got and Shaw is.

A

Is the oh? Oh yes, yes, yes, yes, yes, it figured it out. It knew what I needed web ID tags. Less!

A

Oh, come on! It's not letting me finish. It uh sweet! That's great!.

A

Okay and then the last thing, I guess what we could do is.

A

um Do we want to check if we're empty, maybe just leave it as a to do of like yeah I'll, just leave it as a suit right now check if, um if commit actually exists, so we'll just assume that it exists right now and so we'll return type commit and we just get the shot, which is going to be um we're going to return the full Shaw that we got from here. We could probably just return the ref, but it's possible. This is a short one or whatever.

A

So, let's just do the full one and paste like.

A

Okay, I think I think I think this is it I think we can build now yeah and.

C

Not to distract you much a lot of comments in the code review, but uh essentially the result is, if you like, give nonsense back an invalid rough. You get back uh null for the last commit of everything, but the head and head points to the last commit on the main branch or the default branch. So, in a lot of comments of that, oh.

A

How interesting that's, maybe not like the best default Behavior right, oh wait, wait! But head is because we're saying oh, but I pass right right! No I'm not am I. Oh this one I see it says. Yes, yes, because we've hard-coded one! Yes, yes, I see that I see I thought it was like saying like, even though I pass in a bogus ref. It's like oh we're, just gonna default you, but it's not like that. Also yeah.

C

Yeah, no yeah, I, guess I, don't know if we need that had one but I think last time in the last onboarding goal we talked about, if we have like reference for creating a branch off of something so I think that's why we added that underscore underscore had one so I guess we should be mindful when we're using that and maybe, if we're not using it yet we can remove the query for now. Yeah.

A

Yeah, that's yeah! That is interesting. That's a good point, and maybe maybe we can I'll add a little comment there too. So when I'm doing a Polish once over, the Mr I can figure that out um do we need really need this one? Maybe not. um uh This will always return.

A

B

A

Did you see it's suggested an e, never mind I'm I'm, picking on it now uh all right, so I could get a failure here. We are in. Let's follow this, so we are in um vs code extension web IDE. This has to do with checking out a branch.

A

um It looks like oh yeah. We changed this to be just the ref, but we somehow just need to pull out the commit ID, which is great because we move that to a property that they all share called Shaw. So I can totally do that. We can pull out Shaw a netid from ref.

A

Oh great we're building now all right now we're ready to run it and it's gonna fail like let's they haven't run it yet, which is maybe a little concerning, but that's all um I'm gonna go ahead and start my GDK over here, um so that I can test it um with passing in the access token and stuff, uh since I can just pass up my GDK access token.

A

um So let me go ahead and start the GDK. Hopefully that starts up soon and then up here, I'll start the web ID um example project.

A

So there's there's two things to keep this thing logs. Two things one is for everything it serves and then one is for when it's doing a build based on the Watchers.

A

uh While this is building a slight note on how this is this runs is the main task that's executed is the make example project and so make is really good at determining what it needs to build, um but the Watcher is implemented with this thing called nodemon, which is just looking for any time.

A

Any one of these changes we're just going to rerun the build, so I could be changing a JavaScript file that has nothing to do with it and it'll be like okay, we're going to run, make build again, but make is good at knowing it that actually needs to do its thing or not that's kind of how the the watching that is Works um cool. So all of that built successfully that's great, let's open up Chrome and go to the project.

A

Let me see if GDK has started yet: oh no little guy, all right, we're just going to run it without the access token for right now, um while that's starting and see what happens, okay, it failed and that's fine! Oh no!

A

A

B

Your course, too,.

A

Your Corey's, too complex man.

A

That's weird I'm.

C

Running a more complex query locally, though that's interesting! Okay, let me can I see the quick query. Let's uh in the code base, I was looking at the brand. Maybe have you changed it locally at all, yeah.

A

Let's, let's check it out um uh uh here we go.

A

It must not like have to do so many tree, because I think.

C

Whatever those extra variables I think the extra I I didn't have I, don't think I have a variable project, specifically I hard coded something literally, that extra variable puts it just over the complexity.

A

Really, okay, well, I, think I think we're already possibly not needing this one. So let's remove that and see if that solves a problem, but hopefully like all right. Here's the side. Note, though, is.

A

Okay, thinking of the full stack.

A

Is this our best bet like is, is this like? Is this actually making like three requests to giddly under the hood.

C

Well, potentially, I wonder: does it make sense to ask like? Is it a feature request to ask for a tree's endpoint that takes a multiple like multiple and compassionated or whatever, or not, even if it's positive like if it like, has a like a strict limit of, you can only ask for, like this subset of trees, initially uh yeah, let's.

A

Let's yeah: let's try it with this bit and see if it passes, but then maybe, oh, no, oh geez, that that didn't help a lot.

C

It was dropped by 13.

C

I'm surprised. The variable is affect the query that much.

A

We can try to hard code it and see if that helps too I I. Don't I have a feeling.

C

I'm running against.com and not like in the Explorer top that's.

B

C

Like I I added referrals in the same query and I still have had, and it didn't I'll I'll add in the it's interesting yeah I guess we're I, guess I'm, probably really close to the Limit as well locally, but because I'm not quite hitting it.

C

It's still feeling I hit the limit the other day, but then I just moved stuff. So let me see I'm just gonna add in my path.

C

I Wonder if.com has a higher query limit for some reason than.

A

C

A

Well, I'm actually hidden.com right now, but maybe though, since it's kind of sees it's coming from a third origin and not like, maybe it's being a little bit more restrictive, uh let me see, are we? Are we yeah all right, I'm gonna, try the let's try the.

C

Yeah, that's if the slash like.

A

A

um Why don't you like? Why don't you like Discord, what's going on uh I gotta, do something like that's Wrath, um obviously mean right now.

C

A

Something maybe something changed, wow, it's a good thing. We um it's a good thing that we have. uh What's the word took a week to implement this.

C

It's funny yeah, it on.com. It still works for me. I guess, when's. The.

A

Last time online.com, but it's still working for you. Oh sorry, but.

C

A

Interesting, so if I get rid of Branch names, it's okay.

C

A

If I get rid of one of these.

B

A

Okay, yeah: that's.

C

A

C

That's weird I guess yeah, maybe like maybe having the three trees in one query, is gonna cause it to be too complex.

C

I wonder what team on Zachary we can probably like Reach Out.

A

C

I think for the scope of this, though, do we want to to simplify the queries? We have the branch names done separately from well? No, no, we need the branch names within the same.

A

Let's see, let's see if there's another, let's see if there's another Edge uh um here um looking at I want to go to projects.

A

I feel I I was so um I have a tendency to like oversell things. uh I'm now remembering hopping on the calls like.

C

A

Gonna get this done I'm, so we had to even run it, and now we kind of run into like oh yeah. We're gonna need to do this, maybe a different way.

C

I'm surprised, we have the query.

A

I wonder if using um no, not patch I, don't know if that's gonna, do it uh paginated tree.

C

I'll probably increase it, because you'd have to ask for more uh you'd have to Traverse more in the graph.

A

Yeah, it's nice that tree returns last commit uh that's cool I, wonder if there's a maybe there's like a commits or raps or no lips.

B

B

A

um um Considering.

A

C

Am I there's there's a deprecated field, that's marked as experimental, so I was introduced in 6. You know, though so I don't know if it's deprecated or if we just tag it as deprecated, because graphql that's just.

B

What that's I think we use the deprecated, sometimes to kind of like mark them as Alpha, like um kind of like you know, still being tested or like still experimental experimental.

B

So it's not really duplicated.

C

Yeah so that would be commit references then commit references is available in the project level. Yeah.

A

So I have um I, have a new thought.

A

A

Do why do I care that it's a tag versus a commit I, don't think I do.

C

Yes, you only care about actual branches, I suppose yeah.

A

Like are we a branch or not a branch yeah.

B

um One more thing, I I had in mind was: do we need to like do the three trees um in the query? I mean the um the differences that we are best in different rif type every time, but like.

C

Yeah, so if you leave yeah go ahead, I was gonna, say right. So if you don't pass rough type it will, it will include uh it. Will it will include objects that are not tags or heads, the other ones, just filter it and then like if you, so, if you had, you know for a fact, it's a brunch for tags. You know for a fact: it's a tag. We, as as Paul mentioned, we made all care about tags for now, and then uh rough also includes something. I may have added out of my comments.

A

All right, here's, my idea and I I think.

A

um I think my um I think I like this, because it's going to do the most optimal thing for the majority of use cases. uh But let's assume we're a branch and try to fetch project Ranch.

A

Like if this works we're good to go, then otherwise use a fetch, ref metadata.

A

um To determine if we're a to get the to get the shot, because that's really the only thing we're interested in that so I just need to get the shot of whether I'm a short Shaw or tag I'm gonna go make a request to get that and then based on that shot, I get back. I can see, am I part of that shop, then I'm a commit if I'm not I'm attacked like that's. Maybe that's good enough.

C

A

So we'll have I think um I think so the get ref metadata will just need to have I'm kind of thinking. Just uh just tree last commit shop, and we only use it for if we have a non-branch ref.

A

What do you think.

A

Yeah, okay, let's uh and.

A

Will it work if I do if I do, should I do heads or should it will it work? If I just do this one or do I need to pass ref type.

C

Yeah I guess one of the things we mentioned and the call was that it'd be nice to have like where to Branch off of and like the default name. So I guess in my the query: I'll try to try to be optimal like getting as much information back as possible, but I think we could probably update get rough metadata to return uh if we use the branches underneath repository and then use the search term as just the rough I think that only returns back a single object like especially with the limits that we've had set.

C

So you could potentially say Branch names and then tree of rough last commit shawl.

A

Can't say that again sorry yeah, oh.

C

A

Think I think I see what you're saying.

B

A

So you're thinking we would still maybe want to make this query. First.

C

Yeah, well, um what additional information do we get back from the project? Branch, query: I! Think we can do it all in, like a smaller graphical query, essentially,.

A

A

Maybe we can yes, that's a good idea. That would be the ideal I'm now concerned, though, about this complexity thing we ran into I'm.

B

Gonna, try not to worry.

C

B

C

um A little surprised that sometimes like it was yeah I I, wonder if I I think I have like the like next enabled so I'd get the next version. So I wonder if maybe you don't have that enabled and somehow the something some complexity rules changed.

A

I, don't know maybe yeah, maybe it just doesn't like me: uh I am looking for um like even if I want to just tell if it's protected yeah.

C

I, don't think I even.

A

I, don't think I even have I.

C

A

Think I have that information.

C

So under a project there's a push rules uh prop.

A

Yeah I, don't think push rules is, oh, maybe.

C

Though it might be brown Jewels rather yeah, there's Brown trolls and then the dots there's.

A

There's a branch rules, you're saying so I can go.

C

So I think you want Brown tools and then is protected and name.

A

uh But what's tough is like this isn't going to um like this? This can contain like.

C

Naaman is productive is that is that sufficient.

A

Not necessarily because uh what what this one actually does, um let me go back to ah what this is actually does is is going to use because name can be a wild card, so it's detecting for this specific Branch, so that logic is owned by the back end and is going to put your specific users privileges next to it as well, so protected can mean that as a maintainer, that's okay for me, but as a developer, it's not okay! For me, so all of that logic is like yeah.

A

We need the back end to give us that permission, logic which I don't I, don't I'm not seeing a graphql endpoint for us to be able to do that. There's.

C

A under Repository there is, and current user push to brunch.

A

Oh really, that's it that's the one. We have that.

A

All right, uh okay,.

C

So repulsory blob we have to get Blob.

A

So I'm here in.

C

Oh, it looks like it's a couple of us done. Oh.

A

In repository, I was in um yeah.

C

Oh, you can rough, though, to this okay, so blob's rough.

C

Let's have to get pots.

A

Yeah I don't know, maybe yeah.

A

I'm, not I'm, not yeah. Do you see any other possible fields that could get us what we want.

C

Yeah, it looks like it goes down through blob yeah. It's on, like I need to figure out how to play with a blob endpoint there's like a blob field. So there's definitely under repository blob. There's a Canon current user pushed to brunch.

A

Oh man, that's interesting. Wait.

A

That's that's really interesting to put with blob.

A

um Because, like that's not going to be helpful for um empty projects, uh because you really need it just for the branch, but I could see it being helpful because at the blob level of certain blob can be locked but for the web ID is like well, we really need the for the whole branch and then maybe maybe possibly.

A

um Fetch the locks differently- um yeah, that's that's interesting, I, don't know if I don't think we're gonna be able to to do this at the blob level.

A

Okay, um so our options are this I'm assuming I'm, giving up on finding the perfect graphql field that we can use. um Ideally, we could just make a back-end update, but that's going to actually delay everything a little bit so I'm we'll do that. Iteratively.

A

The options are this: is we can make uh this request first and then, if we're a branch name, do the branch stuff.

A

Or we can make just the branch request, just assume we're a branch only and I kind of like doing that, because the majority of cases are going to be that, and so it's like we'll do the most optimal thing for majority of the time and then just fall back to here to get the shaw: whenever we're not a branch.

A

What do you think.

C

Yeah I think that makes sense just hit the minimal amount of information for the most common use, because, okay.

A

uh Let's, let's do that um so the first thing is we're going to try to do the fetch Branch first, but the issue is I, don't quite know, what's going to happen, if it's 404s, like I, think it's gonna throw an error.

A

um So we could do something like this.

A

um I really want to I really want to see what kind of error it is um and then return null.

A

um But if it's not a 404, if it's like a 500 or something we'll just blow up uh and somehow we'll we'll return a rejected promise for that regard. um But then we'll be able to do something like if France return, type branch.

A

And uh man yep yep, that's what I want to do. Yes right.

A

Okay um and so then otherwise,.

A

A

We'll just assume.

A

All of this so I'll go to.

A

Yeah I'm a little my I paused and thought like if I request the tree on the back end, it shouldn't be actually like getting the whole tree but I'm concerned that maybe it is like, and it's doing more than just checking for the commit. You know what I mean so I kind of wonder. If maybe, instead of using the graphql API, we should just use the rest API so I'm just requesting that maybe the graphql API is doing more. Ironically, am I too worried.

C

Yeah I think we should probably like look at these queries and see you.

B

Know and like Reach Out reach out to the.

A

C

But I think that's after this.

A

Let's yeah: let's take a quick um yeah. Let's, yes, you're right, okay, I'm gonna! Add it to you.

A

So I'm gonna go back to all right. Let me go back to here, though, so we have. Oh I, do need to re-introduce the project path. Variable.

A

Project I think this is how it's done. I think it's something like this.

B

C

Foreign, oh interesting, were you authenticated already.

A

C

So if you're authenticated, it should be 250 complexity. I, remember seeing your uh the like the complexity Level under that. Oh.

A

You're right because I'm on uh I'm on um how interesting that must be it, because.

B

C

Good authenticated.

A

C

200 for on off and 250 for.

A

Authenticated, okay, you found it yeah that was it yeah.

B

A

Was interesting.

A

A

So all right now I'm thinking.

A

Okay, that does bring up the question of like okay. Do we want to go back and use it, because I think you can only use the web ID if you're authenticated, but I think a lot of me is like we were so close to that level. It's I, don't we're very close: anyways yeah, okay,.

A

There's multiple ways to do a thing.

A

uh So this should all be working as expected. We changed this so that the result now looks the same. I just want to double check that so that's great.

A

So if I have the branch, I return, the branch otherwise I'm going to get the metadata from a weight client, that's wraps metadata project path, graph, okay, um so I need to still check if it actually exists, but we'll deal with that later um I was talking about I could just treat it like a commit, even if it looks tag-ish we can just call it commit, but if I feel like maybe there's a need for me distinguishing between the two I could check on the string, I mean what do you think.

C

I think having the raw tag available. So if we want to propagate that in the UI later.

A

Would be good, I mean that sounds helpful.

A

All right, so, let's do then um I think it was something like this. uh Let me add us is, is taggish.

A

uh Rap string full show string uh so I think um maybe I could do this as isk fetish, uh return of Wrath or no bullsha starts with ref right. Something like that means we're committish.

A

A

If raft on length is greater than six and full Shaw starts with ref or something does it make sense? What I'm trying to do.

C

Yeah, technically, you can pass it like a different one, but I know I butcher, the like the like short, commit things all the time, yeah so I think that might be too limiting for users that.

A

Right, that's probably a good point. um I feel like it's incredibly rare I realize there's the edge case of like your commit. Is you know? Oh, oh something, and then you happen to tag it. Oh, oh.

C

Yeah I'd, probably just put a notes on this like make sure you've checked that this isn't a brunch or a tag reference before using his committish.

A

Yeah I'm not exposing this one, so I'm just going to use it locally, but like um uh I'm gonna, just add a comment of note: there's likely an edge case here, where it's technically a tag but still matches the shaw.

A

We're not super interested in that case, let's just we'll just just treat it.

A

B

You know something like that.

A

Is committish uh rest metadata? Let me go ahead and pull some here above this little shop or I'll. Do like this metadata tree last commit.

B

A

Otherwise, we're attacked.

B

Why are you so upset.

A

What are you upset about? It's expecting a name. I think. ah Yes, it totally is. Thank you. Thank you. Thank you. Yes, yes, go type script, all right, what's wrong with you! Oh it doesn't like.

A

Okay, all right, let's see if this helps at all all right, we're building.

A

Okay, going back reload around the thing.

A

Oh, we pulled stuff hooray, all right. Let's try getting it something! That's the commit uh um giving it this one we're refresh we're gonna, give it the commit and I should hit my debugger.

A

Oh yeah, all right: what is this error.

A

Oh error has a status 404? Yes, yes, yes, yes, yes, we got like matching on the error message, all right. If e dot status equals 404, you turn null um I'll go ahead and we'll go ahead and let's play wow, do all this again, but.

B

A

E dot status equals 404 return null, otherwise I think I want to throw e again and we should just die. So um it might be kind of weird that I'm using a weight with a DOT catch here, but I just I I, think doing try catch would be harder to read.

A

Okay, let's see if this works.

B

A

It doesn't man.

B

A

Oh I didn't like it didn't like my I, didn't like my condition.

A

What come on, it's probably e dot response status is: that's probably what it is, um but I'm going to add.

C

B

A

In case all right we're right at time, I'm gonna try to I really want to see this successfully, but if you gotta hop off, feel free to hop off.

A

All right here we go all right. What is e, if I go to the console and I do e dot status? That was enough.

B

A

B

Say I have to go, see ya.

A

I'll see you, oh no, it is the message. Oh geez, look at that.

A

Some reason the message is this: Json.

A

Stringify thing.

C

A

A

C

A

Want to see it pass uh to do um candle other bees that are we're going to go ahead and do Json. Rs e Dot message.

B

A

I wonder why it was like that I wonder why it's.

A

Sweet look at that: oh yeah business. Finally, we're loading all right cool so now, I think the next user flow to check is that yes, Coley can commit to New Branch I. Don't need this drop down, then, when I'm doing that and just double checking that all of this works as expected, and that's really exciting, so cool all right, hey thanks for hopping on helping out appreciate it catch you later bye.