GitLab Ecosystem, 27 Nov 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Integrations deep dive (frontend) - Ecosystem:Integrations, Nov 2020

Description

@justin_ho explains the frontend side of GitLab Integrations to @tomquirk

0:00 - intro, overview of what the Ecosystem team owns

1:20 - the integrations listing page
3:30 - integrations form Vue app code
4:00 - integrations form Jquery code, event hub, form validation
5:37 - entrypoint for bootstrapping the Vue app
7:13 - integrations form UI - what parts are HAML, what parts are Vue
8:15 - settings inheritance

12:30 - Jira Connect App setup
14:45 - Jira Connect App overview, how it works
18:30 - Jira Connect App page-specific CSS
21:30 - Jira Connect App code
22:00 - Styling the Jira Connect App (Atlaskit, gitlab-ui)
25:00 - Vue in Jira Connect App
31:04 - Jira Connect App - how different pages are rendered

32:05 - Mass integrations overview
38:40 - Integrations form - differences across project, group and instance-level settings.
43:20 - Integrations form - Parsing the dataset, how default settings and custom settings are reconciled/inherited
48:50 - Dynamic Fields Vue component, integration-specific fields (e.g. Jira, Slack)

51:08 - Jira Issues tab in GitLab

53:00 - final questions, wrap up

A

B

Looks like we're wrong: okay, so uh just a quick intro, I'm justin and I'm here with tom, and we will do uh walkthrough of basically the whole front-end ecosystem code and let me start sharing my screen.

B

Okay, so where should I start, um I'm doing something here? Okay, so the ecosystem team handles uh pretty much all integration with third party services and um basically uh for for the past few months, our focus has been around jira slack and um this uh epic called mass integration mass integrations. So what what mass integration is is allows you to set up integrations at the group or instance level.

B

So let's say you have like 50 projects you can set all them up in one go instead of going to each each individual project and setting up individually.

B

um So let me start with showing integrations so you've probably seen this list view. So it's in settings integrations- and this page is the integration listing.

B

It has, it hasn't, really evolved. Much since I joined there has have been like improvements and making it like more gitlab ui, but it's still pretty much in hamo um in here. We have mostly had like copy changes and stuff.

B

There were a few plans uh improvements to this page but like it, kept getting pushed back because of higher priority stuff. So, for example, we have like uh um proposals to split this up into two tables. One is for the active integration, since one is for the integrations like uh possible integration that you can have.

B

We had like something to make just this prettier, like with uh the company's logos and stuff yeah things like that, and also making it searchable like uh by probably adding view on top of this.

C

Yeah, that's what I was going to ask this is this is all in hamel and maybe eventually one day it'll be in view. Yeah.

B

Yeah, so um the push has not been there to to move this to ammo, that's hard to view and um yeah it in hamburg. Just works right now. It's it's quite basic as well, so you know there's not much push to do yeah, so all of these integrations share a common page which is um in here uh the integrations form.

B

So it's it's how it's called in the code. Let's start computer.

B

So you have so I I created this particular integrations in here. I have like this specific edit folder, which is meant for this. Edit page, um we were planning of having like different pages as well. You know like, for example, the previous one is index, so each will have a different view.

B

Entry point yep, so we have this edit, oh by the way like. Let me just mention this there's some legacy jquery code in here um previously it was used uh to save and test integration it um it. It did much more than pre than now like most of it is already like refactored, and now it's doing like some very simple javascript stuff.

B

The only reason that we have this code right now is this. I would say this code, which is this dot check validity. um This is using jquery, which is, you know, required to do the front-end validations.

B

um Definitely like. I intend to move all of this to view eventually, but just like just taking it slow because it works right now, it's not too complex and it used to be much worse.

B

um So this connects back to the vehicle. So if you see, like the view code, basically emits some events here, like the test integration, you use the events up here and then just it calls like the code from here, which is this for testing yeah and then sometimes it like dispatches back some uh ux code, so ux events to save the state.

B

Okay. So you have this entry point. It's always a bit complicated.

B

B

B

uh Let me just open this: it's not to exactly related this, but I'll open this anyway, and we.

B

B

But this is um the basic there's one off.

A

B

Okay, so this is the the form page which is in ammo, so you have uh this column four eight here layout, so this part is, I think, you've you've gone into this, but yeah. If you look at the form you have.

B

Let me go back to jira, so you have this 4 8 layout, so this is in hammer. This particular field is in this particular like div, is in hammer as well and like the rest of it is view right.

B

So you have the same email here and.

D

B

This you have this shared partial, which basically just renders the form right. um So this is the entry point. Sorry, this is the entry point for the whole view app, and here we have like uh it, acts like an entry point, but it's used for data passing only so. This is related to the mass integrations where you can overwrite the settings on the project level.

B

So in here I have like this is the project level and I have some settings for from that that inherited from either group or instance, levels yeah. So if, if I select this, everything gets disabled and you can only save this and, of course, if I use custom settings these are overwriting. So let's say I want to change something.

B

The state here is, it will change back, for example, the 88 changes, and if I change it back it, it stays like this, so you can change it.

B

C

D

Are disabled those disabled settings.

C

C

If they exist, they get passed in by that other element that you said that was in the conditional in the hammer.

B

Yes, so so there was this requirement that we need to like reset all the fields and show the old settings or like the default set things.

B

um Yeah I like to change something by mistake right so yeah change this to hello, and um I don't want to change it now. I just want to go back to before settings. If I click default settings, it has to clear up clear out all the existing settings and apply the older ones.

C

Yeah, no, that makes total sense and then at this point, do I have to click um save settings again.

C

I'm guessing sarah yeah.

B

Yes, so um it allows you to you, know, test it out and save before you actually use it.

B

Another thing to note is um um okay, so a few things that we're going to work on eventually, so I just want to mention them. um One thing is we want to have like masking fields, so um so let's say you have like one group integration and like a project integration, and you have a password or api token.

B

Of course it's hidden now, but let's say you want to hide the web url as well on the group level, you will be able to see it, but on the project level um users will not be might not be able to see what it is.

B

So it will have to do something like both in the on the back and front end to make that work. Well, so that's one thing: um another plant thing that we had initially was uh perfumed inheritance, so this is like in the whole form right like. If you, you either use the default settings or use the custom settings, but we want to have like inheritance on the field level. So that would probably work and look something completely different and we might have to kind of rework the build store.

A

C

B

D

Cool thanks a lot. That's uh that's good to know. Hey.

B

Yeah, so this is just a high-level view: go to like go into more details later but, let's add I'll, say important piece of code, which is the geoconnect app.

B

So I see like you've already picked up a few stuff. You've definitely seen it, but uh let.

A

B

um I'm trying to find like this documentation that I have.

B

Probably somewhere.

C

Yeah is that the one that is in the handbook.

B

um Okay, so I'm referring to this one this one. So when you work on loco with uh with the jr connect app, you have to do quite a lot of, I would say setup.

B

uh I personally use ngrok, for example, and I have to connect my local, um my local jdk post it on the internet like have it like with the internet connection and have here connect to it.

B

So I'm using this like sample jira environment, you can sign up for one yourself: they they give it out for free for the birth.

B

And so basically, it looks something like this, so it it's only for jira cloud for the classroom, dot, net gear installations and it allows you to install the the gitlab for jira app.

B

So I just use the staging one, because it's already up and running, but if you're working on your own local, you just need. You would basically upload the app and like paste in some url here, like that. Everything is in here.

B

um It's a bit involved so, for example, if, like I, I use the free version of ngrok, so the url changes every time. So you have to that's what I was gonna ask update it every time yeah. um When I usually when I work on this, I just don't turn off my laptop and and you rock, I just leave it open, um but of course just signing up for a premium version would be easier yeah. We should look into that.

B

Yep, so this is the jira connect app how you set it up there. There is a bug here that doesn't unload the css, but it only happens on staging and production, but anyway it look. It already looks much better than it previously did so it all it says like I'm signed in um and I can link namespaces here. um Let me just sign out here, so you can see the actual flow.

B

So this is how, when you first set it up, it will look like. Obviously it should work should look much better if uh all the css loads everything's like centered and looks okay, but um what happens is so. This is an iframe, so we render our page inside an iframe. So there are quite a few limitations here.

B

So when you click on this, it opens up a new tab back to our uh our website, and here I just logged in my staging account.

B

So once the user logs in we render this like kind of a blank page okay, so you have this blank page and that's a saying, like you're signed into gitlab, and here I use this um param for return to which is sent to the front end, to generate this button, which is which just like opens up the jira connect app in a new tab, um and you have this sign out button here.

B

Pretty like simple stuff, I would say, and then you're back here right in here you can, uh you just have to key in your namespace. um Obviously this is not the ideal ui. You have to know what the namespace name is.

A

Just find something that will work.

B

B

Try this yeah it basically refreshes. The page adds the name space and uh it now should work. If you pin something wrong, let's say hello, it will warn you like it's an alert that you know it's invalid in space.

B

uh If you don't feel anything, it's a validation here. um So definitely there are like improvements coming this ui. uh We want to have like a model that lists the namespaces, so you don't have to kind of search for which namespaces.

B

But still work in progress, I think, or coming in the next few milestones uh yep.

C

Answer so just to just jump in um the css in this iframe, like the styling of this iphone right now. Is that just like an inline style, or something like that.

B

So we use the page bundles css, the page, bundles uh page specif specific css. um Let me just open it, so it's.

B

B

So um you know, there's this push to kind of separate us, the css for each specific page. So this is using exactly this. um So, as I mentioned, we have this page and this page, so these are two completely different pages by the way 100 comp different.

B

um So this is using jr connect users, so you have like a very basic, like you know, margins and stuff to center everything, and this is using the jira connect.

B

So there's an the issue with uh staging and production right now, uh we've I already diagnosed the issue, which is when you try to load this right. Our st is this your connect right and if you look at the headers, we have.

B

Yeah access controller origin, so we have this header, which only allows the css to be loaded on our domains, but this is an iframe, so it's loaded inside the classroom uh domain, so the css just doesn't work here. So um I have this, mr, which is still very um working progress. I would say I'm just testing out some stuff, but we're trying to inline the whole style sheet here.

B

Yeah, it's a bit complex here right.

C

B

We'll still compare the starship but we'll inline all the styles back in the in the page.

B

C

B

C

Yeah, it's interesting though so, but the like, for example, the.

D

C

The blue button- that's there, for example like where is that style coming from, if not from this uh external style sheet? Okay, yeah.

B

um So let me just walk you through the code here I opened this earlier right, okay, so this this particular page is uh inside the jira connect folder and you have subscriptions index. So this is this page right and by the way this is the show which is this page, like user show, you know.

B

So this page is rendered using a separate layout because so it's completely different from our application layout controller.

A

B

Yep and then we have this layout japanese layout, yep, okay, so this is how this looks like you have.

B

Basically, this is the magic here atlas kit, so we are instead of using our gitlab ui, we're actually using atlassian, cy kits, which is.

B

A very, very simple version of a pattern library, so that ours is the reduced ui package. So it's this, which only includes like things like buttons links um a table, but that's it like it's very basic, um so I think I I worked with ip some time ago to uh it's. I still have like this open thing um to add our gitlab ui webpack.

B

To this page, um obviously, there's some complications in this, but basically what this mr does is it. It adds it love you why the whole package I mean so it adds all the css stuff for the lovely one.

B

So if you look at.

B

The css here um I actually have something that is really semi-working, but you have to import each uh ui element as you use it. So so I tried like importing the whole the whole library right, but um what I realized is it's a lot of css and um in here we use like only like you know, and we have a model and an input field that, like that's it and for that the cost of the css was like almost 40 kilobytes of compressed css, which was a lot and that's.

B

Why there's this comment like we should only import what we use. So, for example, I saw you were working on adding an alert.

B

So if you want to add like the gitlab ui styles, you just need to add, like the gitlab ui4 alerts,.

C

Right and I'm guessing that I mean we just have to check whether the the atlas kit version of alert is in that reduced css bundle that we're, including.

B

Yeah, so um there was discussion yeah. There was a discussion if we should use the atlassian design, specs or use our own good luck, ui, and I think after, like some back and forth and like just looking at like what other apps are doing, we just decided to go with our own gitlab, ui, yep, and also we have. We now have view in this app.

B

A

B

It should be here integrations uh connect index yep, so we actually already have a few like, although it's not doing much, it's it's just an empty app, um but we we have view, and uh we have the styles for gitlab ui. So we can actually use gitlab vr components here right, so it makes much more sense to just go with like our full normal development mode. Instead of having to you know, use something external which we are not familiar with.

B

Although the guidelines kind of suggest using the atlassian kit, um our designer libor decided that you know it's just better to use our own, because that's what others are doing anyway. So.

C

Yeah yeah so, but to use git lab ui components in this view, app we'll well that that'll um like we'll need to use the gitlab ui javascript package right.

B

um We are so whatever you import here will get compiled by webpack. Got it right: okay, yep so like. If you use buttons, it will just add buttons. If you use like you, know just standard imports, it doesn't import the whole like js, bundle, awesome, okay,.

C

That's good to know.

B

Well yeah at least that's uh it's supposed to work. I hope that it still works last time I tested it yep um yeah. So this is the entry point for the app here and if um let me just check that it's still working um yep, if you look at this, there's like this still like this empty div, which is the view app, um it still renders just an empty div. So it's no harm here.

B

So the plan is.

C

B

C

Yeah the plan is to like pull all this into the viewer.

B

Yes, exactly um yeah, there was obviously something scheduled for 137, but since I just started like working on, I still haven't uh looked into it.

B

B

Yep, um so that is the issue for um changing, so this is currently a text box and a button, so you have to kind of type it in so the issue to improve this is in here.

B

And we have some um proposed improvements here, so this like. Basically, it could be a model and.

B

Yeah, so this is the current state, and this is the improved state. So there's a button, it will become a button and you just hit add namespace, and it opens up this, which list lists all your groups of groups and your individual namespace as well yep and, for example, let's say you want to add something you just like just click link which is like you know, much easier.

B

That's awesome. It's um it's mainly front and work in here we're just like changing how it looks and nothing on the back end, because the link button here is pretty much the same as the current the current um uh uh linkedin space button. Here it does the same thing just that it already knows which uh what to populate in this like text, field.

B

Yep any questions so far.

C

No, that's super. That's awesome. That's a very informative um yeah. I guess wrapping it all up. I guess uh it'll be nice to have it all in view. That'll be a good uh productivity boost and yeah. I don't know.

B

Yeah, so we already have view or just like, we just need to move everything there. um That's something for, like. I don't know two or three marks or something so we'll get there um but yeah. So this is uh pretty much the page right now, like everything, is ammo and uh well.

B

No translations or anything um yeah, so this is the jira connect, app know so index.

B

Yes, here some of the css yep, um okay, so just to contact switcher a bit again I'll, go back to.

B

Oh, let me just quickly show I think I've already showed you, but just just again, this is the a special page um which is like slash users and it's it's kind of like a blank page, and it just has a text and uh yeah there's like pretty much no value in having it in view, because it's way too simple, yeah that definitely makes sense.

B

And uh here you have like the jira app link, which is uh the workaround with return to so when you try to sign in, like you already passed, we already passed the url in the.

B

Yeah yep, so, let's context switch back to mass integrations, which is um most of the work for what's most of the work for last milestone.

B

So for mass integrations, you have two levels, one is for the on the group level and one is on the admin level.

B

So this is the admin url, and this is the from the admin like we used to have some other settings right here.

B

um So we moved all of them to mix plays, for this also worth noting is uh you've already seen it, but we have these service templates, which was the kind of the old version of this level integrations.

B

And, um of course, we have this deprecation message, which means eventually, we will deprecate service templates right and, um for example, if, if you have a instance, level integration, the service template will be disabled and you can only use like integrations if you're looking down at the url, just links back to integrations.

C

Got it and the service templates is a like a plan for when we're gonna just totally wipe that out.

B

um 14-0, which is you know, the standard for deprecation.

B

Initially, we plans to deprecate them much sooner, but I think firstly, it took us quite a while to to get instance level integrations up, and then we thought that let's wait for a major version to deprecate them and also like there's, there's some work planned for allowing users to migrate.

B

So let's say you already have like a service template and you want to set up an integration.

B

There should be some kind of you know not this one. There should be some kind of uh button or way to click. You know, move this to integration and what's the difference out of interest so yeah, okay, so service templates are well templates, so they so you can save this right as your it. It works something like issue templates where you have like a basic version of an issue and then you create the project integrations based on this.

B

So the difference is it only works on new projects.

B

So, let's so, you have to create a service template first and then you have to save each individual project and then let's say you want to change all the projects right uh service templates cannot do that. If you change the server template, it does not retractively apply to all projects as well.

B

So it's a very different way of working, for example, with the instance level integrations. So if you have projects inheriting that instance they're configuration and you save the instance layer integration, it will propagate all the way to all the projects.

B

C

No, that makes 100 sense and uh for the children of this, uh of like the admin, so groups or projects. I guess they have to opt in to like enabling the integration right or as or is it automatically activated.

B

It's automatically propagated.

C

Or automatically propagated, but is it like if I set a set up my jira integration at an admin level? Is it automatically like enabled uh at for every project or do I have to? Yes? It is okay, cool.

B

Yeah, so I think that that was pretty much. The point of you know um you being the admin of you know 500 projects, and uh you just want to set it up for everyone yep and um it would. It will just work across the whole uh pretty much instance. If, if you have this like this admin level,.

C

Awesome, no that definitely makes sense cool.

B

And uh if you make a mistake and like fill in, like I don't know, uh let's say for jira you're feeling like the wrong url and you update it here. It will update to all projects as well.

B

Obviously, on the project level itself, you have the option to override the settings. Let's say you for a particular project. You want to use a different jira instance that works as well.

C

Yeah, that's really cool.

B

Yep, um so I think the the main difference, of course, is on the back end on the front and they look pretty much the same.

B

Obviously the form doesn't look that great here, but the foam. It's the same thing.

C

Yeah, the form here is still using that same uh like this is still the view app right.

B

um Yes, yes, this is still the view app. um The basic form here is the same uh yeah. Let me just show you the code, because it's easier and just give me a.

A

Second, okay, so uh this is the connect.

B

C

Yeah, so that they will they all use that yeah. They all use this powerful app.

B

Yes, they always use this partial, but um there is also this shared. Slash, integrations form right, shared slash implications.

B

I should just call it edit.

B

So, on, on the background, like you, have this uh integration integrations actions which is used for the group and instance controllers, and both both of them render. This shared integrations edit, which is this it's a very simple, I kind of partial that does render the form the form renders this service settings. So eventually, I want to move this service settings back to the form here.

B

If that makes sense,.

B

Because it is very simple right, it only has like some basic integration related stuff, so all of them will use the same partial um yeah. I'm not sure why I haven't done that probably forgot.

C

B

C

B

So all projects group uh instance and even service templates, we use pretty much the same. uh Ammo templates or hammer partials.

B

Yep and yeah, for example, project is, is not using this for them at the moment. If you look at the projects, uh yeah.

C

It's got a services.

B

Controller, it uses its own set of views right now, so the edit is not rendering the shared version. This is because well because it just it's not done.

C

Got it so it can be in theory,.

B

Yeah- and it should be quite straightforward- we just need to make sure that the the project layout is the same. uh Where is it.

A

Projects, projects, services.

A

B

Yep, so if you look at.

B

This form in this form.

B

ah Yeah, almost um it's actually this. So if you look at these two, yes wait; no, they are. They should be almost the same this and I think this wait yeah. So you have. This is the column here for eight, you have the form and run during the shared service settings, and when you have this project level form you have the column, four column, eight, the form and rendering this series settings.

B

Of course there are few like this and this that need to be kind of reconciled to make sure everything still works. Fine.

C

Yeah and I'm guessing the uh the little status indicator icon.

B

I think this this room moved in one of the one of the designs, so eventually I would actually just don't need this at all.

B

Got it got it yep. So if you look at this on the group level- and this is on the instance level- so you see like uh the design just doesn't have this, and we have this here.

D

B

Yep, so this is like.

B

The basic code um in terms of okay: this is the hammer part. I think this is the easier section to look at. uh Let me just go here.

A

B

Here so here we have like the view section, which is quite complicated outside to compare to other view, entry points, but what we we do basically is we have two different um entry points for the default settings and for the uh custom settings.

B

Like uh just 70 seconds,.

C

Yeah now I remember you mentioned that previously.

B

Yeah, so you have, we have this basically replicated data here.

B

And in here we basically parse this data back to props.

B

B

And it's basically just called twice and you have this uh default props default state and like custom states, which then becomes like the basis of our ufx state.

B

Yeah, it looks something like this so default state custom state and if we're overriding or not- and these are used for the action buttons.

B

So in getters we have this most important, which is the prop source, so it checks. Are we inheriting or are we using custom settings and depending on which we just get this default state? So this that's why this prop source is used. This is the basic the base uh component and it's used a lot right, so it's used as the source of all the information.

B

In here I think it's pretty standard view code. You have the override drop down.

B

um You have some fields which are specific to one or two integrations, so you have like the zero trigger fields which are different like um so, for you have these trigger fields from here to here, so they only make sense for jira like if you click on this. It has the comments detail section here. um If you don't select anything, it will not show any of the fields, extra options.

D

C

Do we save? Do we like store the fact that the user's using custom settings in the database, or do we just figure that out based on if there's a difference between the settings and the default settings.

B

Yes, it's actually stored so.

B

A

B

Inherit from id right, so if you look at getters right, that is.

D

B

Is uh so it? Firstly, it has to have like a default state which is like there should be some something that is set up at the at the parent level, and you have this, which is inherit from id it's passed from the back end. So, okay, let me just show you this services helper right so in here we have like all of the service related stuff.

B

So the paths so all these have to be scoped on the project group or instance, level. So you have edit test and then you have this. The whole form data here which is used for view. um So you have this inherit from id right and it tells you is this integration inheriting or is this uh using default settings.

C

That's great, I didn't know about that services helper file. So that's good.

B

Yep um we, I was just initially adding it, uh you know to the handle, but you know like it just gets out of hand like once. You have.

B

This yeah, so some of the fields here are specific for jira, like uh you know, just commit events, merge request events uh enable comments, so this is enable comments. It's like enable comment here. Command detail is um here, so these are fields only used by jira.

C

B

C

Yeah and so for um for other integrations, these will just always be undefined.

B

Yep and um so, for example, these fields where it are what the front end calls dynamic fields. Let me just open it.

B

Right so you have the drop down. uh This is the active checkbox, uh zero trigger fields for jira the trigger fields are, uh let me just open up slack, so the trigger fields are these fields, so these are passed from the back end and the front end just generates them.

B

So these are what kind of triggers does this integration use and you have a checkbox, an optional kind of description to the checkbox and like just some help, text.

B

Then you have these dynamic fields, so after the triggers, you have all these fields right, you have like macbook, username or something something and uh depending on the integration, you have different fields like this section right um and all of them are passed from the back end and um in dynamic fields, dynamic field.

B

You have a bunch of this code which selects what kind of field is this and what it should display uh if it's a check box sure check box if it's a drop down so drop down, et cetera.

B

So this is kind of a dynamic input field. um This kind of pattern has not been used and anywhere else, but I think it's uh you it's a good kind of candidate for being moved to a good labview component or something or or at least a view shared if it's used somewhere else. But I think here is the only place it's been used so far.

B

um Yep, so after this you have a jira issue fields. So this this is a jira issues, integration, which is like something that looks like this. It's it's it's actually, quite uh it's completely separate from our normal geo integration um yeah. So it allows you to view issues from jira um premium and, above only.

B

It's quite cool, so if you click on each of this it it, it shows you the ui that looks like ours, but you. If you want to do anything to do with the issue, you have to actually open up jira, of course. Ideally, we want to be able to do more stuff from within uh gitlab, but this is where the embassy stops right now.

B

So these are these fields where you can enable your issues until then, you have to pass in a project key all right, so your issues fields and then you have all the like saved test and cancel buttons.

B

So just save comes with a confirmation, if you're on the group, or instance level. So you have like this confirmation here.

B

On the project level, it does not have this confirmation, let me just see it straight away.

B

um Another thing is I'm working on the reset button, which is also only for the group and instance level and, like you, just click, there's a reset button here with awesome model.

C

And what does that? Do that? That just wipes the whole integration.

B

um Yeah on the group point and instance, level what it will do is it will delete the record from the background.

B

And also it will delay like all related.

A

B

Or related project integration.

C

A

B

C

No, that's super helpful, though I've definitely learned a lot um yeah. I don't know if I have any specific questions right now,.

B

Yeah yeah, it was definitely like a lot of information.

B

So I'd like to digest it first and uh if you have any questions, just feel free to ask.

C

Absolutely no, I mean I've already had a chance to go through a lot of the stuff, but that was super helpful. Just for uh consolidating.

C

Yeah, that's really appreciate that um yeah I'll definitely have a few questions uh around these issues for the rest of the milestone, um but yeah I'll. Let you know man. Thank you. So.

B

C

Awesome that sounds good justin, really appreciate it again and uh yeah soon.

A