►
From YouTube: Frontend maintainers weekly 2020-05-28
Description
On this call, we discuss guidelines to review GitLab UI Merge Requests.
B
B
B
What's
going
on,
I
started
so,
first,
first
of
all,
many
of
the
things
that
I'm
going
to
talk
about
here
are
jaws
are
covered
in
detail
in
the
contribution
guidelines,
documentation
of
UI,
so
I
highly
recommend
to
read
some
of
these
documentation.
I
particularly
fond
of
the
first
three
ones
are
in
new
components:
I
mean
CSS.
B
B
B
They
would
cipher
design
system
I
highly
recommend
to
get
familiarized
with
all
of
these
pages,
because
not
only
from
the
point
of
view
of
reviewing
I
did
not
do
a
merge
request.
If
you
are
ever
using
pajamas
component
in
each
lab,
these
guidelines
will
make
you
more
effective.
I
will
doing
so,
so
it
is
highly
recommended
and
in
the
context
of
reviewing
kidnap
UI
mesh
request,
if
some
of
the
changes
may
break
some
of
the
expected
of
the
expectations
that
are
specified
in
the
design
system,
so
I
recommended.
B
So
if
you
see
that
a
pajamas
component
is
added
or
updated
in
bottle
designer,
very
sorry
very
sorry,
a
reminder
in
the
linear
unit
there
if
we
are
modifying
a
pajamas
component,
a
probably
signer
that
is
in
charge
of
designing.
That
component
will
be
mentioned
here.
So
I
highly
recommend
to
follow
this
recommendation
and.
B
B
Then
you
open
the
epidermis
view
I
clipped,
so
this
is
very,
very
helpful.
I
think
that
you
can
give
a
permission
figma
to
review
the
designs
that
are
probably
Center
is
making
sure
that
your
work.
So
this
is
pretty
much
the
same,
and
the
cool
thing
is
that
you
can
go
here
and
see
each
variation
of
a
component
and
see
what
is
a,
for
example,
the
space
in
between
it
takes
and
a
and
the
container
of
the
takes,
and
there
are
many
details.
B
B
Usually
you
need
the
best
way
that
to
understand
the
code,
what
is
happening
and
a
change
in
ownership
ways
when
you
can
play
with
all
of
the
interactions
that
are
happening
in
the
components
also
is
it
is
way
easier
to
understand
CSS
when
you
go
to
a
dual
equip
inspector
and
you
see
how
each
rule
applies.
What's
one
element,
so
it's
like
it
really
improves
the
way
that
you
see
understand
code
and
also,
if
you
are,
you
know
you
care
about
accessibility.
B
It
is
also
we
have
tools
within
the
base
rate
books.
So,
by
the
way,
video
apps
work
is
familiar
in
we'd
love,
you
I
miss
requests,
so
you
can,
just
you
know,
go
to
a
view
up
and
it
will
open
an
instance
of
history,
books
and
I
find
that
very,
very
useful
to
not
have
to
have
to
shake
locally
a
branch,
and
then
you
know
start
up
the
base
variables
base
rate
book
service
service.
B
Some
plugins
is
very
with
plugins
that
we
are
using
to
to
very
some
flights
and
when
there
are
accessibility
issues
in
a
cup
point
that
you
can
use,
and
we
also
have
other
cool
plugins.
If
you
want
to,
for
example,
this,
how
a
computer
component
looks
like
when
the
viewport
changes,
for
example.
Here
you
could
say:
hey
I
want
to
test
this
in
a
in
a
small
break.
Point
I'll
see
if
the
date
picker
is
working
correctly,
so
yeah.
If
you
care
about
you,
know
evaluating
how
components
working
in
a
lot
of
those
different
environments.
B
B
I
I
put
an
image
here
of
the
piece
of
a
specific
city,
calculator
the
rest
online,
and
you
can
see
like
the
how
you
know
how
a
specific
a
selector
is
and
they
hire
the
specificity
is
the
mostly
the
more
difficult
it
is
to
two
over
five.
So
it
is
very
important
to
keep
the
industry
City
low
and
the
second
most
important
rule,
in
my
opinion,
is
using
integrating
mixing
as
much
as
possible.
The
reason
is
that
it
really
mixings
are
based
on
the
design
system
guidelines.
B
B
Okay,
so
I'm
gonna
take
three
seconds
to
check
what
I
was
like
showing
here,
but
at
some
point,
I
jump
into
figma
and
I
was
like
this
playing
how
you
can
see
a
lot.
A
specification
of
a
component
here
also
I
was
demoing,
some
other
plugin
things
in
history,
but
Lexus
II
really
want
and
also
how
you
can
switch
between
great
phones.
B
B
B
A
B
So
let
me
go
back
to
the
visual
studio
code
here.
So
I
was
talking
about
the
three
main
things.
I
was
saying,
hey
as
much
as
you
can
ensure
that
we
are
using
utility
mixings,
because
those
are
basing
the
in
the
design
specs
as
pajamas,
especially
in
the
foundation.
So
we
have
like
a
color
a
color
scheme,
color
palette.
We
have
some
typography
specifications.
B
We
also
have
some
layout
the
specification
that
say:
hey
you
know
the
spacing
between
some
tags
and
something
that
is
very
close
early
actually
component
should
be
two
pixels
of
four
pixels,
so
the
it
remixes
are
based
on
those
guidelines.
When
we
are
using
them,
we
are,
we
are
bearing
to
those
rules.
At
the
same
time,
we
should
also
acknowledge
that
there
exceptions
there
are
things
that
are
very
difficult
to
implement
with
reading
mix
and
we
cannot
use
them,
for
example,
even
in
the
past
in
the
past
component.
B
This
little
note
this
is
a
very
complex
shape
and
we
couldn't
wouldn't
be
able
to
to
render
that
using
utility
mix-ins.
So
in
those
case
it
is
fine
to
make
an
exception.
At
the
same
time,
there
are
components
with
many
variations
like
the
bottoms
or
the
badges,
and
they
shared
like
some
external
structure
like
they
will
be
there.
Five
variations
and
the
515
have
a
background.
Half
a
quarter
and
half
a
shadow,
but
all
of
those
three
properties
have
different
values.
In
those
cases
it
really
makes
things
make
the
code
look
they're,
both
and
I.
B
D
B
B
B
You
know,
depending
on
the
type
of
of
change
that
you're
making,
and
it
is
not
the
only
the
work
the
burning
like.
Sometimes
we
are
creating
a
mercy
quest
with
a
commit
that
is
marked
as
a
feat
or
a
feature,
and
that
will
create
a
new
release
in
the
WI
on
every
slumber
and
that's
not
necessary
when
you're
just
making
changes
in
the
documentation
of
keylock
UI.
B
B
So
last
point
probably
the
most
important
is
the
thing
breaking
changes
in
good
luck,
you
guys.
So
what
is
a
breaking
change
is
basically
that
sometimes
we
make
a
change
in
a
developer
component
and
that
is
breaking
the
digital
application
and
it
is
breaking
other
applications
as
well,
because
there
are
based
on
rules.
I
think
that
the
customer
portal
is
using
the
map
UI
and
also
the
X
tiles
page.
So
we
have
to
be
very
careful
about
that.
B
C
B
C
A
People
makes
it
hard
you
put
this
down
on
quote-unquote
paper.
Is
that
the
interface
of
a
component
and
and
is
way
more
than
just
the
props
you
pass
to
it?
It's
the
display
context.
Sometimes
we
could
even
have
coupling
and
test
like
some
inner
inner
values,
and
we
shouldn't
be
doing
that.
But
it's
it's
good
to
know
that
a
breaking
change
isn't
just
the
pure.
You
know
input
that
we
give
just
to
this
view
component,
but
yeah.
It
can
be.
A
B
Right
that
I'm,
you
know,
I,
don't
I
with
these
recommendations,
I'm,
not
trying
to
say
that
we
should
be
responsible
of
touching
those
situations
because
we
are,
we
are
looking
eat,
lap,
UI
in
the
context
of
an
application.
That
is
huge
with
many
features
and
we
will
never
be
able
to
catch
a
lot,
a
lot
of
situations.
What
I
think
that
we
can
have
as
responsibilities
issues
like
knowing
that
we
have
some
problems
with
rules
of
thumb
like
hey?
Maybe
we
change
the
structure
of
the
internal
structure
of
components
equivalently.
B
B
So
you
have
some
examples
of
breaking
changes
here,
the
the
one
that
I
think
that
we
should
care
the
most
about
is
about
when
we
are
changing.
There
is
a
merge
request
that
is
changing
a
component
that
is
highly
used,
for
example,
bottles
drop
down
smaller
labels.
If
you
see
something
that
is
changing,
that
is
probably
probably
batching
like.
We
are
not
considering
a
lot
a
possible
way
in
which
the
up
component
is
used.
B
If
you
see
up
a
class
selector
that
is
removed,
also,
like
that's
probably
a
reason
for
our
taste
wouldn't
be
left
to
break
because
and
by
the
way,
I
think
that
they'd
be
one
of
the
best
way
to
fix
the
problem
of
braking
test.
Winning
it
lab
is
actually
providing
better
tests.
Indeed.
So
if
you
can
go
and
write
a
test
that
is
not
making
assumptions
about
the
internals
of
develop
UI,
that
will
be
right
because
in
the
way
you
are
you
know
you,
you
are
not
breaking.
B
B
Alrighty
Emery
said
that,
but
we
have
intake,
they
create
integration
branch
shop,
it's
very
easy
just
to
to
start
the
job
and
that
will
create
a
branch
and
upgrade
that
Bishop
Twi
I
mean
it's
gonna
trade,
you're
gonna.
You
know
it's
going
to
stop
the
package
that
that
is
generated
by
bit
by
SS
request
will
appear.
I
mean
that
way.
You
can
do
some
smoke
testing
to
detect
potential
liabilities.
So
it
is
very
commanded,
it's
very
easy
to
do
it
so
I,
don't
see
it
every
official
lot
to
do
it.
D
My
only
comment
is
just
to
note
that
that
example
Enrique
used
about
the
changing
the
class
name,
was
why
I
posted
to
front-end
maintained,
there's
like
last
week
and
was
like.
Please
don't
push
things
so
I
can
untangle
this
knot.
It
was
precisely
that
that
we
were,
depending
on
that
class
name,
so
definitely
keep
an
eye
out
for
it
on
both
ends,
because
they
can
cause
trouble.
A
D
There
the
tests
broke
okay,
so
there
was
a
capybara
test
that
was
relying
on
the
GL
legend
class
and
the
classes
remained
at
lab
UI
because
we
got
two
different
kinds
of
legends
and
then
it
was
compounded
by
also
the
chore
M
ours
that
we
do
to
push
through.
The
lab
UI
changes
to
update
that
somebody
went
on
vacation
and
had
one
assigned
to
them
so,
like
a
whole
log
jam
of
changes
backed
up
behind
that
one
failure.
Oh
yeah.
A
Now
that
yeah,
but
that
can
be
painful
when
the
versions
just
keep
stacking
up.
I
did
leave
one
question
on
here,
because
we
currently
have
this
mixin
component
class
style
for
styling
things
for
view.
Components
and
I
know
that
it
sounds
like
there's
a
bit
of
history
to
this,
but
if
we're
adding
a
component,
that's
definitely
only
going
to
be
used
in
view.
A
A
B
Think
that
is
any
squirt
resistant,
definitely
changed
my
mind.
A
lot
regarding
supporting
hammer
from
the
context
of
lead,
lap,
UI
I
think
that
it
is
not
well,
it's
been
unsuccessful.
In
the
first
place
we
are
not.
We
don't
have
cases
where
we
are
taking
the
CSS
of
GWI
a
mission
in
it
effectively
in
the
context
of
panel
I.
A
Yeah
I
realize
I
have
an
RFC,
a
I
said
it's
gonna
create
last
week
and
then
I'll
create
this
one
today,
I'm
gonna.
Do
it
right
now,
so
you
don't
hear
anything
from
me.
Then
something
happens,
but
no
thanks.
I
will
pay
an
RFC
for
that.
Yeah
I
think
it's
worth
us
revisiting,
because
if
there
is
an
issue,
if
there's
a
reason
but
now
doesn't
seem
like
there's
a
reason,
we
should
totally
change
it.
Thanks
good
I
think
so.
C
B
I
I,
don't
know
what
he
said,
rules.
What
is
the
best
place
to
publish
up.
I
was
thinking
that
maybe
I
could
just
create
a
memory.
Question
get
lucky.
I
am
I'm
already
within
the
dogs,
but
I
haven't
made
my
mind
about
that.
I
I
could
be
very
happy
to
you
know
with.
If
you
give
me
some
recommendations,
oh.