GitLab GDK and Gitpod walkthroughs, 13 Sep 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: UX MR Review of Runner Group using GDK

Description

Gina Doyle (Product Designer, Verify::Testing & Runner) walks through an MR Review (https://gitlab.com/gitlab-org/gitlab/-/merge_requests/70151) for the Runner Admin area using her local GDK.

A

Hey everyone, I'm jen doyle and I'm a product designer for the testing and runner groups. Today, I'm going to be reviewing a merge request around something that we're adding in the runner admin area, and I wanted to show the process that I go through when I'm reviewing one. So this one specifically is around um specifying a project or restricting a runner to a project and updating the alert to give you like this thing was saved, which we do everywhere else.

A

So what I'll do first is I started gdk, which I've already done, and that brought me to this, so it's my own instance of get lab and then I'll go into the admin area just to give a reference on what it looks like today.

A

If you were to go to a runner, um we would have to go to a shared one.

A

Well, actually, it could be either but we'll take shared one, for example, and this is the area that we're looking at so you would enable, for example, gitlab org you're about to change this to a project runner, and then you say: okay and today you're not given a confirmation that this was saved like we do when you edit description for example.

A

um So there we go so we're looking to get this same alert when you restrict it to a project.

A

So what I'm first going to do is go over here and see the branch that this is running on and there's always this instructions of how to set up and validate locally, which I usually follow. But first I'll go here and check out the branch.

A

So I'm just gonna copy this command and I'll bring my terminal over here. So right now we're in the jdk folder. So I'll just do pwd. I list out the folders. So I'm going to go um back a folder.

A

And actually now that make it, then cd gitlab.

A

And then run these commands.

A

Okay, so we switched to it and now I will.

A

Go back and say: okay, start okay, so I'm gonna refresh my local instance.

A

All right so now, theoretically, if this worked, which hopefully did, I should be able to see exactly what miguel was looking at.

A

Runners just to check out his instructions again visit the admin section, runner select a specific runner, so I'm going to select this one and then, under the section, research projects select a project by enable.

A

So let's do this.

A

Okay and I got it um so that's a simple idea of how I am usually reviewing and from this I'll, just check like break points, make sure that it makes sense make sure it's dismissible, which it looks like it is, and I'll probably do it to a couple other of the specific runners, and I might just want to check even the shared runners are working the same way once I'm done I'll. Come back to this, mr and just leave my comments for this one specifically.

A

Actually it's a little bit different, because there is something that miguel has pointed out. That will actually have to be created as a follow-up to for a ux debt um issue, because the changes saved alert isn't the right styling. But it's not blocking enough to be able to uh not approve this. Mr, so thank you.