GitLab GitLab Runner Open Office Hours, 25 Jun 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: GitLab Runner Open Office Hours - June 25, 2020

Description

This months office hours feature team member Steve reviewing 2 Community Contributions. One a small change to our Helm Chart and another a small feature improvement to the gitlab-runner itself.

There was also some other discussion around how to test MRs, how contributors can make MRs easier to test for reviewers, and the etiquette of updating someone else's MR for them.

The MRs discussed are:
https://gitlab.com/gitlab-org/charts/gitlab-runner/-/merge_requests/240
https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/1325

A

All right, happy, Thursday, June, 25th everybody. This is Renard open office hours, I. Think our sixth version of this the prison- something like that.

A

So usual, we're gonna record this, and then we will post it to your YouTube playlist afterwards, and the intent here is really just to help. Anyone do could help anyone making contributions they want to run or whether that's a brand new contribution but haven't made. They have questions about something they're thinking about, or just some review or questions like that, so that myself Elliott the engineering manager for the matter team, Steve Peter of gurgi three engineers, Darren Eastman, is our product manager and Ray from our community relations team.

A

Yeah anything anyone else has to add before we started so there's no key members on the call right now. We've had some technical problems and those unlikely to change at the last minute. So hopefully, that's not solving any problem.

A

But if no one comes on have any questions we're just going to do some live reviews of a few already submitted to Mars right.

A

Aaron Steve anything you want to add all right, see. Buddy you got a couple of Mars picked out already.

B

Yeah so I decided to take a look. Do you have turkey.

B

During office hours, so I picked up too much requests are 30, easy and so I show my screen and the first one country entering the sanitary century DSM. So basically, what this is doing is inside of Kayla Bruner. We support Sanchi and the way that, if any errors happen, we reported to you century and what we mean by her here.

B

As log levels, so if we log something at an error level, we end up sending it to you century Islam and is quite useful. For example, we use it for our looked at concert runners every time. For example, a new error comes up right. We got a new century error and then we can say: ok, let's triage it. That's just an e regression. Event is like that time. We can see. Ok, for example, this spiked up it's happening 10 times more than usual, because essentially gives you all that information.

B

So this is quite useful. People can hook up their own century and you.

C

Do just by setting up essentially.

B

Dsl I would just basically just URL, so basically, this is what it's doing here now.

B

C

Global section.

B

Part is a special port and your honor so, for example, simple runner, config.

B

When we say the copper part, we mean this part here, I'm done here, we have each registered owner. So at our end result our hand. Chart basically will generate this one. Essentially, yes, it was, but as we now have charges on Yemen and it's generating a kubernetes deployment and all the kubernetes structures and then registering and then doing get a cube up like keeps it the other way.

B

Go changing charts.

C

B

Let's take a look at the changes first, so this I think and you filled in the values of the amplifier I, know: I'm not familiar with your own chart. The values document file is our configuration file for D I'm sure, so everything that is comfortable for the hand chart for the runner hand chart this year. So, for example, if you want to change what image we use, we want to change. For example, the number of concurrent jobs that it can run and.

B

So, just adding a new key code- son Drew Pearson- satisfy- and it's good that it's nothing it's right next to the other configuration. So the concurrence concurrent check interval vocabulary affirmative all part of the global level which are listed here, and so we have century 80s and what's the only one missing from that, so it's good that we're adding it and in time job. We have compassion that for every configuration we have configuration field we link to some documentation. So, for example, here we're link to the purple section.

B

Sometimes you need to keep an artist documentation so and sometimes AWS documentation as well. So this part the value, so TLC is fine. Now the global configuration part is stored inside of config, not called conflicted on. So basically what happens? Is we spin up the pod for Kayla Brianna? We put in this conflict optimal and then we register in your honor.

B

The global configuration will not be overwritten even with already exists. You cannot overwrite the proper configuration. That's why it works this way. That's why we do it this way, and here it's basically adding one more ting to the global configuration. So if Center dear son is to find let's define Jeff the first thing that I do so. This seems fine and well, but first thing I like to do is actually since hand is generating like kubernetes deployments and kubernetes config maps, and things like that, I like to actually run it so.

B

For testing purposes.

B

We can see that it actually populated it, but for some reason.

B

I see what's going on here, so we're checking your value stocks and tree as present vivid this we're just using.

B

B

C

B

B

Hadn't installed, so it starts to place the recognizes cluster.

B

And we validate that.

A

Thank you personally and.

B

Registration because.

B

It will automatically register a a runner when deployed stores. You can not have it not register or honor and use an existing runner to define this. You can define it in your own artillery. We.

C

B

A different value of technical illustration and your honor tokens, and sometimes you might have values of Yama file inside of a gates repository, so you do get ops, for example, unlike storing these kind of passwords in here is not idea, so we do support specifying these inside of Cuba naughty secrets, but that's another discussion. It's all documented and our kubernetes installation dogs. So if you're interested in that, you can find it. So we are updated to kick up the URL, the registration token and we added the sent radius.

B

C

What we expect from this is.

B

That it's going to generate a conflict on the file and it's going to define the.

B

So here we can see that our pot is starting up.

B

Let's give it a second.

B

A

B

Refreshes every two seconds.

B

Might be pulling the image that's what's taking so long.

B

A

B

It seems to know what command yeah now, it's running, I'm, not sure rotated wrong. So if we accept the side of pod and so by default, our heart runs Kayla Bruner, a small studio, so not as fruit but as a Catholic runner users I'm under Pickett LeBron a loser. So knowing that config Tom on file by default goes to our home directory.

B

And a hidden file to the runner and then connected, we just cut it. We can see it is all the configuration that is generated by our 100, so we can see that century DSM was updated properly and everything is correct. So the only thing that we need to change from this merge requesters have values of yes,.

B

So, unfortunately, we will not be merging this one.

A

I mean this is maybe going down a path like a bit of a philosophical situation, but is there a reason you don't want to just apply the suggestions? Yes,.

B

C

I can't plate a suggestion.

B

Okay, that should give me an apply button for some reason, but it's not closely.

A

Was showing out my name, Darkmoon yeah.

B

But the reason I don't usually apply suggestions automatically, especially for code as a few things. This is Sir community contribution. So it's clear to me that the user wanted to fix something on his own time. So.

A

If I, just like.

B

Fix something up mess with his code with Dirk. Oh sorry, it might not feel like it's a nice thing like overstepping on their work, so I always allow users to fix their own mistakes or improve it, their own code with my suggestions, but it's mostly asses if you like, if you're out of time or you don't want to spend time like just let me know and I'll fix it myself, that's mostly for community contributions for other internal review starts.

B

Another discussion, I mean personally I, don't like using the apply suggestion president generates a bunch of comments, and then you have to remember to squash comments when you merge and it ends up missing as well. I'm, like f like for some people at a nice time as well, because then remote and local are two different, are no longer in sync, and also.

A

B

Sometimes some people and signing commits and like applied suggestions are no sound comments. So that's the whole californica Lee, but for come here is contributions. I live I like to give suggestions for them to be clear what the diff needs to be, but it's up to them. If they want to click the apply or just push it functions, just give them an option to actually affix their code. So Devon converging I mean.

C

I agree with Steve I think it's just good etiquette, I mean you're I mean even though it seems like a like an obvious thing to do. I think it's just a good etiquette, just making a suggestion and not like writing it for them. I think that's a good way of doing it. I mean it introduces a slight delay, but unless it's like really urgent or critical that we want to have a release, I think this is the right way to do it. Yeah.

B

And I've done some cases. For example, there were some networks or some codes that I did not agree with, for example, but I still merge data as this and then opened up personally for comment. Hey, there were some changes that I wanted to make, but weren't relevant to like this much personal were very nitpicky, one of the things so I just because it's always a balance right.

B

If it's something that's not working or if it's just a piece of code that you don't agree with, but still works and like it's still readable it just, for example, I, don't know you wish there was an extra whitespace in some place, for example, I'm, not gonna emergency press because of that white space, but I might open up another mess.

B

A

B

Case-By-Case basis yeah.

A

Those are all the reasons and I can agree with the etiquette part, pretty sure I just think.

A

It's it's really easy for people to I think to interpret it either way like when you see this is like its own. If I was the contributor in the second, you know, depending on how I feel about it, I could I could see going either way. I mean, like oh, come on, like when you do that.

A

You know for the same time like yep, I'm signing or, if there's like a sense of ownership and so I just curious, um look I've seen you go through that process when it's more of a gray area or its imperfections, oh yeah,.

B

Yeah and like weirdest, one, for example, such as a small change, I, always let the user that we know. If you want me to fix it myself,.

B

Yeah, maybe he.

C

B

A

Yeah thanks for walking through kappa, yes,.

B

And I like to sign myself cuz, I'm the reviewer and walters. Does he house do you take action on it? Just so I know like when I'm skimming true, my marriage requests. I know if I need to take action or someone else needs to take action so yeah, that's it I, usually look at any labels. We have so this correct.

B

Preemptively signing a milestone just because it's a small change any longer time. Thirteen touch it.

B

And I also like to restore my knee trust discussed before so this seems to be.

B

Has any other questions.

B

What's your preference doesn't happen in purple so we're using doing another hand charting or a I.

A

Think that's dinner. Oh I, don't know it kinda nice to have like maybe a whole hour of looking at home curtain. Seeing I you test them.

A

But at the same time, they're a little bit less interesting.

B

A

Just pushing the ammo onto it off your program, yeah.

B

A

Mean either way, if do you think you could get through 1325 in the remaining time, I.

B

Think so, yes, I, feel I feel like it's love, running someone with your ways because I know. Oh.

A

B

B

Society was not the one who review just the first time. I do have some idea about what does this do, but I I usually always look at what the previous reviewer commented on. Just might give me contacts why things change and also things that Lieberman already thought of so.

B

So weird issues like this one always requires a ton of research. Why things are happening that way and I've rated on this on my own time. So I don't know boy here this seems to be sold so.

B

B

So let's take a look at the code, so I love that there's more tests than the actual death. That's always nice to see.

A

There's a comment you.

B

C

B

One thing DS, like personally I, wouldn't make the slower-paced order not exported a specialist. Mr. just my tests.

B

They wouldn't be available to everyone, of course, but.

B

So it's a carbide sense, okay, so we're creating a constant there's like four months in and basically.

B

That's being passed to these tests.

B

Let's see a package like my ID wasn't resolved into Cisco package because.

B

So, every time it's a multi bites, it's passed again, utf-8 characters.

B

B

B

Right, well not for me to go if it starts with lowercase. That means that it's a private party, we were method. If it starts the tougher case, it means it's. A public patent.

B

Here, I'm leaving one comment for all these and I could leave a comment for each line, but that that's that's family and if sometimes it gets a bit overwhelming, like sometimes I am too receiver of it, and it's still a bit overwhelming getting ten comments. The same thing.

B

So, let's go to the first model to create this time.

B

So test.txt efforts to fight multiplies, it's gonna update the name to a utf-8 character.

B

Right fire, it's gonna write to a fire, especially under thinking. So, let's see where it is being used.

B

Test set create so okay, so just creating a bunch of okay, now I understand what motivates this day. Okay, so basically the sub create is just generating a bunch of paths right so, for example, and swimming fire and we're creating a simplified that is, for example, new sibling and the motorbike one, which is a GF, a partner back to small, for example, there's doing a bunch of DOS. So let's look at the death one more time, so here's a playing the name ready to fire before it was just returning to smile at exe.

B

It's also right in the fire.

B

Look at why it's the.

B

Same thing here.

B

So look the TSP community children. Yes, they were before just.

B

So this is checking but to get tired Crixus. It does not create one as it was to for for just fine checking ticket directory, but.

B

Then the Forester gender stop right here. It's multibyte things that entities to read it. That's fine, so everything seems fine to all the questions I have is here.

B

Sometimes I do leave a question and like remove it before I submit my review. It's mostly more of a mental note that my factors I.

A

Like your, um it isn't, this is your very personal thing, but you very much flag that the sort of feedback you're giving that issues suggestion question. Yes,.

B

Darkness are truly something that was added to our handbook recently.

B

Decided for code review.

B

But basically suggest you to.

B

It's called confessional common format and it's this one. It's a beaut article basically suggest before you're, trying to make your comment a bit machine, readable right. So first you to find the intent of it give a summary of it and then a body so Dan. Thank you can parse it into you. So you have a label. This subject decoration if it's a block in question or a non-blocking question and on discussion.

B

These are like praise. For example, if you want to say hey, you did a real good job of adding tests, for example. So you add praise if it's in that big, if it's a suggestion, if there's an issue, for example, for this century DSM, we have a tissue because there's an extra issue happening if I want to improve the code quality. Sometimes it's mostly a suggestion.

B

If I'm thinking out loud, it's mostly a thought for a bit sure that we have to do something so I highly suggest start using this, like I find it quite nice using it.

B

A

Yeah I don't have a link to that and I mean yeah description. Yeah.

B

I suggest and want to look at the code review guidelines every one of the block who reviews code follows these. So if you want to like maybe speed up the process or you just definitely a good resource.

B

C

A

B

That comes to mind is: why do we need to check the fire? Is it because the file already exists, and is it because it's not being cleaned up at the end of two tests.

B

C

If it starts the case.

B

We will not do it. Part of this merger has an inkling defense, we're already being written in a master branch. So I will not ask the, for example, for this once you update the test so one because it makes the merge per speaker and it's trying to do two things and three second each contribution. So this should not be inquiry. We should not be greedy or forced to prove our code quality.

B

So I leave that for now and now here we are creating a bunch of files so before you used to create the test by the sibling at this directory under, despite not retaining, say one two, three four and four four single bytes and what device they're maturing does the five six, because now we're generating is expires that make sense and now we're checking to us file archive 3 this one, that's correct, okay, so one thing I see as, for example, we're using strings right. So here has probably just got a base that this one.

B

So it would be nice if these either are strings or are constants sorry. So we only have one a very special distance C to f8 and like what runner team does not are all English speakers. They don't use these characters, so it's not really familiar with us.

B

So one thing we can do before giving this obsession.

B

Since parts here is after me, we can try.

B

B

So this one is just being used.

B

Create test fire I like this, why we should use constants or something right up, because it's so hard to go through five, and let me just try to treat it so just one is for create this fire for move device, so I'll create just by step. 0 1 to.

B

See assignment okay seems too fast. Let me make sure.

B

B

So here we very much like using these characters here, so just watch I. Imagine.

B

Yeah create this directory. That's why it's it's giving this forward slash here, like this.

B

And that's why I am verifying directive if it's a small TIFF I actually enjoy doing it. Just because it gives me about my understanding of what the tests actually doing, especially, for example, dis code I have not reviewed in a really long time and it's fairly old code like three years old at this stage, so yeah I wasn't even at work when this most recent I don't know what is quarries and so for me to have me understand what is going on.

B

Sometimes I end up changing the users code and try to improve it and that's why sometimes therapy takes such a long time just because I'm not fond of it go please.

B

And this is fine, so.

B

B

Just probably not Connecticut merchant animals, but it was a good example of why sometimes things take so long.

B

I'm also enjoy doing giving down teeth, so if they want, they can just apply, and it's also, if I'm not very clear what I need.

B

This extra time, Oh.

B

B

It's punchy thanks.

B

Case we are actually here to sell frozen setbacks, truck.

B

You saw inside their time stuff.

B

Okay, so it's a extra metadata for the flag.

B

So for soon to be fine.

B

So this one is the same thing for.

B

For this case, so let's take it.

A

All the time see if you look five minutes off.

B

So yeah, what is left is.

B

Then what I usually like to do as well as doing some men watch me so I'll probably get lucky. I am a fight that will say that five with utf-8 characters like this one, for example- and we actually make sure that we uphold it or not, and I.

C

B

A before and after which, like before it wasn't working now, it's working so I make sure I understand the actual problem that the user is describing. So it's a lot of manual manual QA and make sure the tests are there and then the code itself is very simple changes. Just adding in you had a utf-8 and I checked this header beforehand, and it does seem to be correct.

A

That's a great point like you're, gonna, you're gonna, add a cookie lab CIA animal file and do this manual testing. If someone wanted to help you out by getting you started with that in something like here's, the Gila epsiode animal file that I did I try. This were then I tested those that was what's the best way to attach that don't work, requests like you're, not gonna, include it as a file as part of the merged. Your questions.

B

Yeah so let's see if I could.

A

Use a snippet or just like yeah.

B

I, usually so what I usually do the end of the request this I actually have the murders have came to mind to give you an example of what I expect, unlike what would be really helpful.

A

B

So, for example, just for me this one I get lucky I am if I wasn't provided to you right so I manual, QA here so, for example, a snippet pick up see: I am in five. This is the one I Ron and is to Java, so what it would have been nice, for example, for this very personal to call out turn at any point in time or anyone else, but it would be nice right, for example, here too, we also updated the title to ask the specific question like how to test us quick.

B

So, for example, that's.

B

Just a small description, for example,.

B

And even that that just gives me a section to you just paste go to my local JDK I played up update. My catalepsy I am in fire and trying this to actually us about so having like singers, got a base command or like some steps on how to us. It's always helpful, especially on strangers. Shoes like this. That's something not very cool.

A

When you're applying those would probably get lever under exact, you know me.

B

Know I am I, I enjoy actually going into a get project. Okay, so I have one project called playground on my local JDK and.

B

It has branches here that are doing different things. Well, as, for example, if I want to test something you about, artifacts I have them for third fence I'm. Just one is just.

C

Talking to Archer so I like to do a full.

B

Ant vantastic with, for example, and it's also hard for a caustic LeBron- are exact grants locally. But, for example, if I want to test with kubernetes or with.

C

B

Or something like that's them, I can do that and it gives me a better understanding of the flow of the user, but sometimes, like sometimes certain looks, are not printed and I'm doctor exact so and exact side. So it just gives me a better view of what take show user.

B

A

Right, you're probably finish it.

B

C

Appreciate this contributors sticking with us for about a year or over the air, oh yeah,.

B

For sure for sure, thank you so much whoever you are I mean I know we.

A

We're still still trying to grind through that back on top of the ears cool, okay, great anything else, you wanna know.

C

I think we're good. Alright, thanks.

A

A lot Steve and I'll post a few tips and there's a certain process.