GitLab Group Conversation, 26 Mar 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Pair Programming - Let's write a pinning test

Description

**Result:**
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/27691#pinning-tests

**What's a pinning test?**
https://wiki.c2.com/?PinningTests

It's a "temporary" snapshot test to pin down behavior that gives you confidence in refactoring. The book Working Effectively with Legacy Code explains it best.

**Does GitLab not have good enough test coverage?**
We are committed to good test coverage (at all levels of testing) and improving this every release, but tests can't prove the absence of bugs (only the presence of them). Whether there is or isn't existing test coverage, adding a pinning test (which doesn't take long) can further help us refactor confidently and quickly.

A

I already mentioned: okay, you asked you think aspect is, is the best way to do it, I already voiced a concern that you know view rendering, especially of conditional it's like empty comments and stuff in there, so it might be a bit trickier.

A

B

Could be so the way yeah I would like to just use ideally could just use just two caps, because we want to capture a snapshot of what does this part of the page look like when we had him and then we want to capture a snapshot of what does it look like at? When few renders it's tough and if we're dealing with JavaScript, we can just use just create snapshots and call it a day if we're dealing with Hamel I was my first thoughts was technically we could use jest.

B

Maybe we could use jest like fetch, you know a requests who are locally running GDK and then like find the elements from that response or whatever and like, but the more I thought about I was like I think it's gonna be simpler to capture the right snapshot from Hamel using capybara.

B

But yeah it's I, imagine there's gonna be some differences, and so, when we capture snapshot, we can filter out some of those differences and we can look for regex patterns to just completely remove an either or to clean it up. If and so our goal is to set up a what we say can we use.

C

Capybara to compare screenshots because we can ask capybara to take screenshots right and we everything it lab UI to do like it should look the same right but the same data. To look exactly the same, so there should be zero difference in pixel right.

D

B

That's another approach to is: we could look at this from the visual perspective and take visual screenshots use. Copy borrow, take screenshot differences.

B

My goal is to look at it from the HTML and just did we render all the right data attributes that I pass everything correctly through it and I I'm uh I'm up for either one I, don't totally I think if we take a visual screenshot, we could be making it more harder on ourselves of because that takes into account like browser configurations and stuff when we want to compare to screenshots and things so capturing that Oracle consistently might be a challenge, but these are good. These are good. These are good questions.

B

Let me share my screen and I was gonna, write down some approaches to this, so let's do a little bit of planning and then we can kick it off. Oh.

B

Man yeah, if like it, isn't like a huge donut.

B

That looks nice. Have you seen the office episode of pretzel day, okay, well, I'm, just gonna make that reference to myself.

B

So here's some approaches to this. So the goal there's a big factor: let's create a initial, commit to turn down the board's.

B

B

Then in the next commit, let's do our refactor and that's what we already have an mr and then let's create a commit to clean up, and the goal is if this has a passing pipeline, because there'll include this. This pinning test.

B

Then I'm fine, removing my pinning test cuz, that's not something we want to leave around because it's not like a really great test. They test internals they're, really messy, but it gives us a lot of confidence that we didn't leave. Anything out of. That effect like to the point where you need to manually test things and so approaches to this I was planning on using. We could use copy, borrow and r-spec to create it. So we can use this to create snapshots of HTML.

B

We also talked to you you mentioned hey, we could create actual visual snapshots.

B

A

Be it could be piggy bank off the existing tests and essentially creating snapshots and Oddie because they exist like 25 that do integration tests on those could be just you know, do the snapshot at the end of each of those tests and then basically pin it yeah and one thing by the way is you can actually start off the Ammar because we've put to change behind a feature flag, so you can even do it in one run. Theoretically, you could yeah.

B

Oh yeah, that's cool, that's a good point add so we could add pens, oh yeah, so we don't even I, see what you're saying add pins to the pre-existing tests. Yeah, that's what something we could do.

B

Another thought I had was so one thing is you pin it and that's just we're just gonna take you know we're taking HTML. Writing it to a file. The other thing is asserting like that. The snapshots are the same like if I take that again like did it match and what's the difference, we could try to do all that asserting in capybara r-spec itself, but because I don't feel super confident in r-spec and I. Don't know what the capability is. The capybara are I'm almost suggest. Let's just write.

B

Toothless's have capybara just write to files and not do any assertion, but, let's add a little bash script that does the diff of we can move those files to like an Oracle or something and we'll add a bash script. That checks did our new snapshots match or Oracle whatever.

C

Correct me, if I'm wrong, but I respect friends, that's sequentially right, so we could like run the since we have a feature flight. We could like turn off the feature flag, run all the tests and save all the stuff and then turn on the feature flag and compare against what we saved in one run.

B

Oh yeah know that and that's interesting too and yeah I'm, not so man entirely sure I don't put a lot of thought in what does it look like since we did feature flag, this I think that does change.

B

I could change how we approach it, but yeah, let's get started with it and please direct me if you guys see some opportunities for making this better, but right now the goal is because we have to capture a camel I. Think using capybaras gonna be the the easiest in my opinion, especially because we have some pre-existing capybara tests already setting things up, we're gonna, just gonna right we're in capture HTML, just write it to a file.

B

I'm gonna say: let's, maybe not do any visual snapshots right now and let's use a bash script to actually do the dipping and see what happens all right. Let's check out that wrong place. Let's check out that Ammar go over here to front-end pairs man. This has been the subject of front-end pairs for a few days now.

C

Yeah a few engineers somebody saw it's.

B

Worth it for all the reasons oh I'm in good LabVIEW, I closed it I.

A

Did a fourth push on that branch, so be careful if you're not the right way, thanks.

B

D

E

I have stuff I can reset then.

C

B

Awesome all right so because this is behind a feature, flag sounds like I can start I, don't have to do any reverting or whatever I can just start capturing Oracle right away, right, nope.

A

Because the future flag is on by default and actually my ideal on nico and my idea was hey: if we turn on the feature flag by default and all the tests work, then they should have enough confidence. If we have confidence in the tests, I might have revealed something about my confidence in our tests. To be honest, like I have a lot of confidence in those tests, because there are a lot of tests, they are compared to our actual common tests that we have for the community. So that's a good point: yeah, more confidence. Okay,.

B

Well, well, did we have our they feature Spencer they are. We have Hamill test its feature, okay, its future. It should be good Nathan. Do we may at the end of this it could be anti-climatic and there's no differences.

B

Let's see what happens be.

A

Interesting, it's an interesting exercise at the least yeah. There should be differences because I actually fixed one, but let's see if we can find it otherwise I invite you to find that part. Okay, all.

F

A

He's on a feature, specs I posted him into the front end here in China how sweet yeah they had pass.

B

To them Oh brilliant, okay, yeah, let's jump into let's jump into one and I'm yeah.

D

B

Awesome: here's Boyd's awesome, okay, so yeah we could. We could try to attach something onto here. um I would want to just do something clean like copy this set up and then just start playing around with our own one cuz I I would I would.

A

Also recommend going into the boats spec, because this thoughts- maybe maybe okay- this is more meaningful to us. Okay,.

B

um So, let's create one: let's call right: let's create one call the boards boards pen, spec.

D

I'm gonna mostly just copy this.

D

B

Before here's some context that here we're visiting the board page.

B

Maybe we should be a maintainer or something maybe we should be cutting this.

C

One that makes sense.

B

C

Board for Oakland project, isn't it feasible for normal user as well I think.

B

So, let's see what happens, we may have to tweak it a little. So let's do that so here we are. We visit the board page great, so let's also open up or it's the the board.

E

B

Hamel file that were curious, isn't.

C

It down there show.

B

Okay, this it yeah I, think oh wait. um Okay,.

B

So I was thinking, I, don't know, I'm a front engineer, I, don't know a lot of art, spec I, don't know a lot of copy borrow. This makes me nervous I'm, not in my comfort zone right now, but I was excited to realize that there is a part of copy borrow. That's already writing to the file system, but that's how little I know about Ruby and everything is I. Don't really even.

C

B

How to write to the closest and the part of copy bar? That's doing that is the capybara screenshot Jim that creates those HTML screenshots when something fails and stuff I took a few minutes to just look at this and it seemed really trivial.

B

So I was gonna um piggyback off of this and see how they're creating their screenshots. So they end up. Creating this thing called a saver which maybe we could create ourselves but I, think I'm gonna. Oh man, look at this cool github feature I.

A

Know I know: okay technically feature. We.

B

Do and I am aware of that as well. Yeah I really work, it does I, think I think you have to kind of squint at it a little bit. So it looks like there's another gem called this a screen saver.

B

This is where we actually get our savor. Let's see what this is, if you guys start going too good at this, 20 sounds like that.

G

Sounds like Amazon related to me. It does I agree.

D

B

That see what's going on here.

G

Yeah look require AWS SDK as three okay.

B

That's not what we're doing is.

G

It we're not together sounds like something saving something to an s3 bucket. Maybe.

B

Oh yeah you're right, okay, no, it looks like, but we only do that unless we have s3 empty thanked. Otherwise we use the saver thing. Oh look, I'm gonna jump to their definition. um Sweet save current path. We can save the HTML.

B

Capybara has a save page. Oh.

C

Wow can't we ask this gem directly to save the HTML so because it's actually when we make an error, it takes a screenshot both of the picture and the HTML right. Yep.

B

And I was gonna just so and I think again: yeah we could just use this to save HTML I was one to maybe not do the whole page and just do the bit that we were changing. um But what do you guys? What do you all think do you think we should just get a copy borrow screenshot like we can or do you think we should.

G

um Let's, let's try it, we could probably do something like within, like a certain section of the code. Odhh, like you know how r-spec or whatever like within element, do end yeah.

B

We want to try, we could do it looks like it looks like we can natively just yeah we might be able to. This sounds like this is an element that we can pass into it. I bet we can select some sort of element that we're looking for yeah.

H

B

I'm gonna try using this capybara thing is that just a global that's locally available, whereas capybara coming from.

C

B

The module name what's this, even though it actually this attribute reader thing means it's just like a problem. It is oh look this is it it's something that we get in our construction? Oh you're, totally right, um okay, I gotta go back to our constructor, who constructed this again. Where do we get that thing.

B

You new saver, we pass and we're spreading some args see. Where do we call new saver? Oh it's just capybara, it's the module Mike. If that told you that all right yeah so it looks like we need to see, is the module? I, don't know I guess maybe they're doing this so that they can. You know test it nicely. It looks like we just do: capybara, safe page. Let's see what happens, it saves thanks.

B

Maybe we should do like some sort of wait for requests. I, don't.

H

B

It saves things capybara, dot.

B

H

Not right yeah.

B

All right do you know, does anyone know how to get the path to this specific Ruby file.

B

Maybe I can look at r-spec. Maybe it's different in mice are.

A

You looking for, like the rail rails routes, I.

G

Have no idea, oh you're, are you looking for like the browser path or are you looking for like legit farm.

B

G

Path, this boards, all the way to fourth fence back route to file patent respect. Current underscore path is for the route browser path, but I'm not about file path. There's.

D

E

A little better wage.

D

And building something it's, they uses the file to grab the past.

B

E

Like there's a file thing.

B

See what this thing does I know can just be copying code from the internet.

B

B

All right, something tells me I, don't have any of this running. Oh.

B

Okay, so I go through a little song and dance every time. I check out a new branch. I have a script that I shouldn't just keep to myself, which removes our cache, folder and installs yarn stuff and then runs bundle and then I run GDK start and the JDK only part of the JDK I guess has to be working for the capybara to start up, but I'm not sure what parts that is so I just kind of globally started.

C

Do you need the GDK running hope they are expected for the future test? Yes, right, yeah for.

B

The feature test yeah because it does something with Postgres I'm, revealing a lot about my knowledge here. So please help me out. If you have more complex into it, I am.

G

The same boat with alright.

B

Yeah so back Enders are gonna, watch this and be like. Oh my god, people shouldn't do that I'm, just joking we're gonna execute. Have you guys heard of still talking about how I don't know a lot about rails? Have you heard of spring?

B

Yes, all right if you just feel like jumping out a window, because your tests are way too slow. um Your feature test when you're running copy, bard stuff, try adding spring to your instruction and you'll, soon be jumping around with joy. At the 5 seconds it shaves off Oh was that what MP was talking.

G

About Nico the beginning on the call- yes, oh I, misunderstood.

C

But you, you also need to use spring restart or stop if stuffs are not working properly because sometimes free interesting. It.

B

Was it called you just run spring restart? Yes, I. Do you know what what's an example of an issue that will come up, I mean.

C

You're. Writing your test and you're kind of confident that they should work, and this doesn't work for. Some reason is because freeing as like pull the panel piece of the puzzle together, wrong yeah.

B

Because it caches because I guess it caches everything to see this perverse um process and yeah, it's possible I guess I can make a file change that it didn't pick up in that cache or whatever um I. Imagine that back Enders that are changing more and more Ruby files, it's more relevant than maybe, when the only.

C

Animals how it's probably.

B

These test ones, what you say at the animals.

C

Files to count don't know.

B

C

But if you are working only on the test, that's that's better.

B

Yeah on the topic of me not completely knowing what I'm doing whenever things like tests aren't working and I feel really confident. I should I just turn off my computer and turn it back on I'm like let's try all of this. Let's try the whole day over again.

C

Next step is go to sleep yeah.

B

Whatever it is, I'm not gonna admit that I wrote my code well, the test is obviously well.

C

We could have used fibers here, I think.

B

Cypress I can't wait for the day that our front end feature specs or not doing as much as it's.

G

Doing right now, I can't wait until the day we have no more hammer.

C

Because hey you just did a movie I know.

B

C

Ban, this is true, I'm.

B

Thinking that this is coming from the hopper, is it no? It's not no.

C

He's usually defined at the end, okay, there you go and it did to wait for the question.

E

It looks pretty and you.

C

Can it won't wait for requests? Thank.

B

You now you'll see the power of spring baton hang in there.

B

Instead of taking like a minute, it's gonna take like 10 seconds, maybe I know I I talk things up too much, sometimes.

G

So where was spring implemented here, I thought it was like legit. You had to put the keyword in there. Oh I.

B

Just um you add it: it's it's like a wrapper for your Ruby, um so it's I, guess kind of like no daman yeah Ramallah arguments given to expected zero to one. Oh, we must be using like an old cut or a different copy for our version to do this safe path thing because they did I saw that they did this version match. Does this only won't version? One can do this well, I! Guess we gotta save the whole page.

B

That's weird! That's fine! Let's just try saving the whole page while it's running, maybe I can do some research on that.

E

E

E

Charlie page this asset house, this set the ones I checked based and that doesn't make sense.

B

Okay, I guess it has to save the whole page. That's colitis I mean we've the rest of the patient and change. So, oh cool it did something. Did anything change? Did we actually save it ready to go old sitting here? This thing features pens look at this. This is our snapshot.

B

C

Okay, yeah: we can we put this to our utility file and salami to every feature. Spiking. This folder.

B

Can you describe what you're talking about so.

C

We already have a lot of specs right rhymings, just like every least and 25, or something like that. So if we make this a utility file and just slam it in all the specs fully to help us, we will capture a screenshot for every configuration in the current features back so.

B

I I was thinking about this on the side, while I was talking after the ten minutes ago, it up and I would rather for us, because we have existing tests. If we just go off of our existing tests, we don't have. We have very little chance to capture something that our existing test might be missing. So what I'd rather do is just look at our source and we're gonna see some of the rails conditions here that we need to that.

B

We need to check if and there should be less than that then are then peppering it throughout our other existing tests.

B

You do you feel. Do you feel like that beef? Do you feel like that's all right or yeah,.

C

Yes sure there's a chance, we will capture, probably so underneath it, but it's gonna be another lot as well right compared to what the future tests are testing because we don't know all of them like in Gmail, right.

B

And some of them are testing because we only changed like this block, and some of them are gonna, be testing things that really we have a high high confidence remain the same. So we want to make sure that things like this. This are caught and we don't have a lot of compliments, but that condition is actually tested. Yet.

B

So that's that's my that's my concern so I think I don't want to spread this to everything, but I do want to borrow a lot from the other test as much as we can. Okay, okay, but here we have a. We have a and I. Don't know! Why put it to us, because I did go up a directory if you're cool with it living in that directory. I guess we could just put it here, but I, don't think I want to wait.

B

Another three point three seconds so believe we leave it in pens for now, but I'm gonna rename this now I guess we can just call this few yeah, let's go ahead. Let's go get a certain name. It just call this one to be full of one it working gives 10, but then I'm gonna, add manually, add one to Oracle, I'm gonna, add a prefix called Oracle and we're gonna save it out and then we're gonna recreate.

B

Then we're gonna turn on the feature flag and recreate and see that so, let's call bond double exact spring r-spec again, while this is running I will gracefully delete this.

E

C

Do you want r-spec to compare those file? Oh you prefer to do that outside of it I. Don't.

B

Know how to do an R Spec, so I was gonna use bash for it.

C

Can't we just import them after they everything and like at the point that they are stream right.

B

Yeah I don't know if there's like a dysfunction, because I can just use dish locally, get good, pretty output, yeah, I'm gonna. Try that it's doing it in here but I.

B

What is what does everyone else think.

B

Okay, this is not helping my confidence.

B

Yeah we could try it here. I always want to get like an actual like a unified disc put. So we can easily read it and I. Don't know how to do that in r-spec. I do know how to do it in bash. We could like call from here. We could look up and see hey. Do we want to see if we get a unified dish in our spec and that might be cool? Do you want to do a little bit of research to see if we can get that this output in our spec, or maybe.

C

We can start to fish I ate her I think I approach. Here, that's what I write yeah! We got to dance with Besh, okay,.

B

Cool so I'm gonna rename this to.

B

That or cold, maybe I, don't know that sound cool, and then we want to turn on the feature flag right, I'll turn it. Oh it's on base that ready. Okay. So then this is the pen. We're gonna have to switch them, but anyways. So how do I? How do I do that again? Dude, yes,.

G

Dub feature flag and then the name of the feature flag and then put it to false yeah.

B

Okay- and we have the name of the feature flag is I- should have had this open over here same.

C

Board they next ojs I, think I.

C

See a she boards, but this probably written with the underscore down yeah.

E

She's, oh, it knows the other one. It's.

B

True, just oh wait: it is true, okay, yeah and if you guys have real, if it jumps out to you, maybe we could do this in just one go the feature flag on and off that'd be interesting too I.

B

With pinning tests, since we plan on removing all this, it doesn't have to be perfect.

B

G

Wait is this: a licensed feature looks like it might be under EEE that.

C

He's both ladies a CD parts, an oniony parts, okay,.

G

Because we may need stub license features as well, we'll see.

B

We have two files now, let's see, if they're any different.

B

Here we go so the Oracles on the left and the pen is on the right and there's a beautiful output, and that's see how readable this is with stratagem.

B

F

Gonna, be okay, I think, I think that we can do pool there's. If you you double color.

F

Oh, is this because you're on Mac and it's not jeah new version, never mind continue.

F

B

Can't use them diff and it's gonna kill.

D

B

Alright, so, okay, so the random pores are different. That makes sense.

B

Here's some common differences and I guess ya, be interesting to run these through prettier.

B

Do you think that would be? Do you think that would be worth it or.

C

Both of Dage came out to a good year, so they're both the same form, yeah yeah well,.

B

Pretty you're actually making pretty well. Maybe these need to end in HTML for a prettier to read them and understand them correctly.

E

B

Right: let's try all right, I love this okay, it's prettier in actual script or am I gonna, be running the bin right now,.

B

Okay, it looks like I can run it. Like this side. Note I'm gonna rant on something. If anyone ever wants to create an mr. That removes this dot from the end of PS went I would love that, but that's why I can't just run yarn run es line for a specific file, because this is wrapped. This is blocked that hole Bend. As now we run this whole script. I was looking to see. Do we have a prettier script, so I'm not I, can't run this on specific violence. um It's.

H

Just a dot, it's.

B

A dog that's messing it up, because this runs it for the entire directory. So it's really slow.

B

But you have to be careful, though, because it's like this is gonna, be referenced by CI and other things and so um yeah. That means you.

C

Need to move the dots to the CIO, basically right, yep or everybody's reference, yeah yeah.

D

B

Fun stuff yarn run prettier for this specific file. Let's see what happens.

B

No parts yet okay, they all right and that's cool, we're just gonna rename this to dot oracle dot HTML, but these actually they need to be different because we had. This is with the feature flag on and then we we did. The awaited yeah the peonies they'll be GL one. The Oracle is the one with the feature flag on, because that's the first one did right. So this one really needs to be ten, and this one needs to be the Oracle which is which.

E

Okay, great, let's see.

E

B

Yeah you're right I was skipping a step.

B

Did something oh gosh, it didn't write it. Okay, I hate to pipe it yeah. Do you pipe it or is there there's there's a command I think for actually writing it to the file video. What do you say.

H

E

Okay, brilliant.

H

Or if you have it in your deist code, you can just run it in the file. Oh yeah.

B

C

Yeah, like with the quick comments right format,.

C

B

C

Gp41 this thing yeah.

B

C

Like to capture.

B

The way to do this on a CLI, so I mean we can do it. You know double right rather than W.

F

B

It takes the short form.

F

B

Is this you're not taking the, or is this actually prettier, yes to anything, ugly yarn will pass anything I did it, it looks like it did it really awesome? Okay,.

D

E

B

Was taking a while for yeah great so now we can bend. This piece does even know how to dip files and vyas code I'm used.

H

To using them right.

B

H

Click right click on the sidebar on the file.

E

This is my thing.

H

No, no in the side left sidebar click on one file select for combat six.

B

Words, what am I doing here, it's like forget, you know.

H

That 100 people now.

B

What do I do? Click.

H

B

Was selected whoa, that's great.

B

Okay, great so here's the here's, the meat of it. Look at this look at this. That's awesome: okay, cool! We have some SVG differences, which is expected. There's one interesting thing here where this div as a can admin list before and here it doesn't. What do you think that's all about please on the right, then you won't build. It says: Oracle, the Oracle has an admin list and well Ken does not.

B

Should we look at the mo file, uncie yeah, let's.

C

B

That's a great idea: I can maybe I should look up admin oak, an admin list.

B

Don't know what I'm doing maybe I need to search everything and.

E

C

I became a pro/con and this SSC that's why it's missing.

B

But this if this should have become a prop, because we are still we're doing a full mount and everything before we're we passing us incorrectly. Maybe or are we not capturing us like we should be? What's can add minimus I mean if this.

C

Is probably removing it from the data spec now right, because it's a prop for the component, maybe.

B

But you should have been doing that when we, because this is still a view. So if you're not familiar with the history of this yeah.

C

Yeah you're right before it was view, but if now we define it as a prop, it will be taken away. Did we just? Did we just defined this? Oh we did it.

C

Is not a because this is one of the thing that we did to remove the brand Arif right because removed around the reef. We had to bring some logic inside the single file component.

B

So my when I'm, not when I'm not captioning, is how come this worked previously. What was the goal.

C

So before there was around the reef that would not look like pre. Instead, the the HTML at all right, the more capital.

A

C

We don't that run the race, because it's.

C

Very, very, very got it this, since this modified the original file to add the probe right when you run it with a feature flag. Oh you still get an empty Advent attribute because the component doesn't have the problem. Maybe we've got mr. gravity meet up, okay and we probably.

B

Updated word data. This board data have can yeah.

C

There you go Line six I see.

B

B

I'm still a little confusing, what's happening here, because I thought this still looks like we're doing view and a Hamel, because.

C

This is this: this is the old one, since it is a feature flag in both right you, so you still have the open light.

B

Still have the old template: this is the old template. Where do we actually mount this thing? Where do you actually know next yeah.

E

B

G

Okay, I think I see makeup. So what you're saying is that what the Hamill's still behind a feature flag and the new feature flag has view is.

C

That you still need both just then with the new feature flag with the FSOC. You just get the entry point and sokka waited at the side, so you can use it in your prop, while the old one is actually loading. The full markup template gotcha gotcha.

C

So if now you empty the market of that show dot, HTML not mo the new one will still work and the old one will not have markup.

C

This is probably maybe why we should have actually rolled back the commits the past. That makes sense change.

B

Your clothes off I see what you saying it's it's our Oracle isn't actually testing master just just by.

C

A little bit, it's just to really those two two props and the definition on top I see.

B

You saying yeah yeah, okay for fun, then I am gonna roll, it back and we're gonna. Do we're gonna create that pinning test before our before we've made these changes just so, we can see what see what happens unless everyone's like hey this. You know this difference doesn't mean anything chill out. I mean at least. We know that the decisions is something that we.

C

Were trying to get right.

B

When we were kind of expecting so and that make sense yeah, so that's cool I lost her I lost my comparison, Allah cool, and that was the only difference right.

C

B

So all these are trivial. It would be nice if somehow we could trim this worried about that. These are yeah, then I'm, assuming we don't need to worry about these other than icon classes. Changed is I, see issues of concern, I.

C

Think is being changed to GL, icon tolerance or he's just using the same component. Oh cool yeah, all right same type of icon, sorry got it got it cool.

B

Where does it select the oh yeah there's where it's getting the.

C

So at the end of the you stays wait and the icon was I, see wait. So it's the same. Yep.

B

Got it, and so this is different, we've establishes because we didn't run this Oracle before we introduced some changes. I see correct, which does mean that there's a change when this feature flag is off to what master is doing, which is adding this attribute there, but which is harmless. That's something that you could tell me like. Oh um yeah, and it's more icon stuff. It's.

C

Probably not harmless, but we just spent office I didn't think. If that's a security issue like we have leaking equality shouldn't my design, I mean it's just a disinformation right can admin list. It can be a secure dish right. We are not leaking any info. A template, no.

B

C

Yeah that sound but I, don't think it's security.

B

Issue because it's the users receiving this information and they should know we would you know, even in the view world it's ended or even in the view world it's in some JavaScript property somewhere. This is your thing.

B

The only thing I'm concerned about is that this isn't a valid attribute and that's I'm I, don't think it's a huge deal, especially that we have high confidence, is gonna work, we'll probably not can turn the feature flag off unless we want to spend some time resolving this difference, but it does bring up something interesting of when we're doing this pin. Since we didn't introduce a feature flag, pens, yeah, it was confusing that we did run it not on master and now there's a feature flag.

B

Technically, if we were being really cautious, we'd want to run it with both feature flag on and off to make sure that we didn't mess up to off version at all, which is.

E

Something was not anticipated.

B

But interesting discussion nonetheless,.

B

I was going to create some more pens. Do you guys have any other thoughts yeah? We definitely need to fly out or in some cases, right yeah. So, let's, let's figure that out going over to our main thing here we want to look for. Although the Hamel stuff that's happening.

B

E

B

If this is just a trivial like we're just throwing it, this is doing condition. That's what I'm really concerned about, if we're doing condition, if we're ejecting different values, this I'm not concerned about, because we're just throwing in a tag and we've already concerned. We've already know that we're doing is tagged correctly. I guess I'm really concerned about seeing different conditions, and we can borrow those conditions from other specs for sure and I think.

B

That's, that's, probably a wise idea, but this one I'm concerned about of if I can admin the lives at first, as if I can't wait, are we doing.

C

B

So here in our pen, I am a developer. Does that mean I should be probably not adding being able to end right, yeah, correct, so I would expect to not see in my Oracle I, probably shouldn't see or delete.

C

We should see, cannot release default also on the original on the Oracle right and.

B

Something tells me it was true.

C

Yeah I think it was true. It was I.

B

Don't want to I, don't want to think about this.

G

In the context of this pin in the spec, didn't we run the user as a maintainer I started to, but then I think became a developer. Oh sorry,.

C

Sorry, okay, can we look at that board like that boolean Commission on the board HTML, it's on Talk I'm admin list top of this yeah you're in the correct file? Oh thanks! Yes,.

B

Or not, oh, no, it is in a different file. It's in the show, I think gay over here. um Here we go, can add men list, oh yeah, yeah I think we meant to do something like okay. This is always going to be true, yeah and I'd like to prove that something's wrong with the pinning test. But let's not worry about that, but I think we want to do this right.

C

Yeah, this is discussion that we had on yesterday: FL okay,.

B

Humble then yeah just does it make sense why this was true when it should have been false.

B

Because I think over when we dude can and then list or wait, wait. Oh wait. Wait! Wait!

B

What's going on here yeah. What do we at Harveys? How we want to do this? Oh! This is a really. This is a big challenge. I see the challenge here, the plot thickens, because oh my gosh- we're not mounting to here we're mounting to here, but we are trying to replace Ord component.

B

So what uses this thing again? This is our main target. What's using this again bender components for our show distance. Oh it's! Coming from this template thing! Oh that's right! Oh that's!.

C

Right is there right, you were touching the right piece in omnifile extending late, okay,.

B

We're I think we're gonna run into a weird issue with this, with this property, so I mean, let's reverse engineering. What was going on here, but the reason and correct me if I'm wrong on any of this nico.

C

But the reason why we needed.

B

To inject this, as a property is kind of riddled throughout this component for things like can we add men this list, so we need to move these conditions over to few to make things more complex. It's not like. We can just throw a data attribute on to the our mounting element. This mounting element takes a whole nother, like view template as its child. So what we're trying to do with cannon and list here is.

B

We're trying to pass a.

B

Landscape function down the script. We want this to be evaluated by JavaScript, but I think it's coming across as a string and I think I think it's gonna be anything streaming, so we can actually I think I.

B

Think we getting a roof, that there is something problematic by.

B

If we, if we added a test for the maintainer, and we can does.

C

This mean that all those feature tests that we have are not covered in this case or.

B

C

B

Could dive into that, but I would I would be not surprised if that was the case. It gives it where we can say. Sorry, no.

C

B

If I seem paranoid with, like you look at all this like man, why is Paul doing you know so much? Why is he being a little anal retentive about this? It's because I don't have a lot of confidence for our some of our testing stuff I, add either level and we could try to crock of whether something is being captured correctly or not. But sometimes we just rock forward to something exists, and we haven't done the other case of like.

C

If it doesn't exist, and so.

B

Whenever I do these refactorings it's nice, that's one layer of net is our existing test cases and it's a good light and it's a good net, but I don't have I, don't trust it as a I. Don't completely trust I want to do this. Pinning test is an exercise that this is another net and, as you see like some things are kind of popping up and now we're asking some some interesting questions of.

B

Is this even getting passed down correctly, I'm, not entirely sure, so, let's just for fun to do the same Act rather than trying to drop all of it. We can use this to help us and I. Think, let's look rather than doing a before do here.

B

Let me yeah, we've just called this default, and then let me do one with as maintainer the maintainer should be able to admin the list right. We would expect these should be different right.

D

B

Let's check it out so.

C

To be honest, my expectation is that that admin can admin list is support, it goes to was a probe, but they rendered HTML is correct. It's just a gimme biggest.

D

B

Can be there hanging out.

C

Yeah because then that's SFC parse it correctly so when it goes through the proper component, it parts it correctly, but that's maybe I'm. Oh no,.

B

And I hope no and I. That could be the case. I think we.

D

B

Know we're running to the end of this. Let's check out what happens, and so I'm gonna run it with the feature yet so we'll run with a feature flag off will capture the Oracles will run prettier on them.

E

C

E

It while it's trying to write to race.

C

Condition I know.

D

B

Yeah and if I was smart to I I'd be able to have a context for if this is true, when we have it rights to the right thing. Oh, these are gonna, be renamed wrong. I'll. Let me see if I can change it for disk I'll, but spring probably is already all right. This comes from me, okay, right so.

B

Yeah, let me rename this.

C

Off now right, so those are article. These are Oracle's. You write. Thank you.

B

Okay and then, let's run it with the feature flag on.

B

And while that's running, let me free to use that.

E

Okay, my computer is kind of spinning. Now it's doing something over here. I expect a spike into the moon.

B

Sweet all right and I got a pretty of those things. I probably could pretty up the whole directory. Do you think, do you think that'll work I'm? So unless you listen, you think I could do something. Do you think I could do a.

C

Hey you then yeah.

E

C

E

B

Does the blob spreading right, yeah, cool I, guess so, we'll see so I want to I want to first compare that the maintainer and the default Oracle should be different right.

B

They seem yeah well.

C

They're any different, because.

B

Of the different projects that I'm frustrated myself.

B

But these would also have that can add than thing right. Okay and.

B

I should expect one of them to be able to delete something right.

B

I would expect to have like a board, delete I, don't see it other than in the CSS, which means two or over here do I have them. Let's compare the maintainer, Oracle's and pens.

B

Well, usual, it's the same stuff. Isn't.

B

So I wonder why this can delete things not showing up.

B

Do you think this is a we need to just I set out manually, see what makes show up.

C

But a maintainer cannot win right. There is no other role there, I, don't.

B

Know, let's still search for that board delete here, we go here somewhere, we're actually we're looking for how did they set it up?.

C

It's a maintainer.

B

Oh sit in a model thing, no, it's not is it? Let's see.

E

Is this another yeah I guess I think.

C

C

You can check for the component inside this young jail morality. Oh.

B

Well, that's probably why it's not showing up sorry.

E

C

E

Do you know what's going on.

B

Look oh, this is just a this. Is a component.

C

Why there's a dead weight.

E

C

E

Some good questions, I.

B

Don't know, let's try writing this manually. Examples thankful. You.

E

Have 2gb carry.

B

B

Yeah, it's a researcher.

C

So there is also this condition with the list type. Not all the lists can be deleted. Just oh.

B

Yeah and our list doesn't I, don't think- may even have any list in this example that we have. So maybe that's what's going on. Oh no, but we should have oh yeah, but that's a so. Let's see over here on board, delete and that's a good point. Yeah.

B

E

Haven't even created some lists new shoes, most recent listing issues, I.

E

Think, that's those probably don't know.

C

Yeah, there is no list good catch Oh.

B

Missing labels.

C

That are adding you to, since you are at it. Why don't you duplicate the default I'm that as a maintainer and just each of like on and off so one man spectrum generate all the template that we need yeah. That's.

B

Gay again, do you think, should we do this a shared example thing or shared.

C

Is I think I just don't know, I'll write it I.

B

Think you could do some. Let me look at example. First reason yeah, so you do like shared examples, run pens do and then we gain passed in like a thing to it.

B

And here's the type and we're going to.

A

Write this right.

B

There's the type of it so we have the default.

B

Yep and I'm gonna do something to where I am we're gonna, let it be the project, meaning.

D

That was always the same.

B

D

B

We could probably do some of these with the other things as well, but I won't.

A

Worry about that.

D

B

And then we could do context and.

B

Are you include examples or it's a cone.

E

License it behaves.

C

E

Like yeah, if they is like one pence.

B

Somethin tells me I'm abusing something here, but it's gonna have to stick.

D

So the pen is that one.

E

And the Oracle.

E

B

Yeah I should be both cool I know all right. Let's see what happens, did I change anything I didn't change again. I was going to manually test.

B

B

B

B

This one probably have some board stuff.

D

B

This is the delete button that we are expecting right.

B

Yep or delete yep, yeah and you're right. This is not showing up because we didn't have any lists our test. We're not good enough good call me good sorry about that, which means that we might not even been loading that yeah. It's a good thing that we did this now. We probably don't have much more interesting pens when we run this, let's run it again, let's see what these are like and then we can call it and I see that.

C

What do you say, yeah your Easter? It wasn't the other 1000 you're.

B

C

C

Oh everybody left I.

F

Was three yeah I saw that to be fair and I apologize? I'm, not really here I'm, just it's nice to have some coding going on in background.

C

This comedy channel I.

F

Don't know what you use the Discovery Channel for, but it's not bad for me, it's been. It's been really interesting so far when I have been paying attention.

B

Cool yeah now I know it went a little over and these things usually do but we're at the bitter end and we'll kind of retro this a little bit, maybe for five minutes. If you have some time Nico, let's.

C

See what these yeah yeah I don't know. This is actually very interesting activity for me. Cool.

D

B

And start out, HTML, oh I gotta do right.

B

You know yeah, but you can see this batch script is pretty tribulus. We're just gonna run this specific art spec, then we're gonna run prettier and then we're just gonna run div, and if we were like with any kind of snapshot test, it's good to get rid of noise. So we could do like some sort of regex replacing if you wanted to and actually have a pipeline green here. But since this is something temporary, we don't have to over think it all right enjoy yeah, just eyeballing it as it's good enough to, but.

C

You know a good action point from this will be that we come up with something like to facilitate a speeding best like guidelines, or do this and do that. This works this out doesn't work. I, think you need to get pets.

B

And helpers for it, something like this to wear that would.

F

Be a girl, yeah, maybe I mean so I did I used a pinning test for a view component that was relying heavily on a store and it received a mutated objects and I was changing the the API contract basically, and the set of helpers you need for that is very different. This.

E

F

Context-Specific yeah: do you think.

A

That it's not a bad idea, of course,.

F

It's just you know, maybe.

B

If there's, if there is anything that you know, someone feels passionate about, you know oh I've written some code, I want to put it somewhere, consider putting in the playground and a playground project.

B

It may be as part of our pin it's something we can just include, and maybe it's even just some like bash scripts or ode scripts, or something that we can include anything commit and then then remove it later or something is.

F

This I again I missed the beginning of this, and maybe you mentioned this during the call as well, but you said that this will be temporary. What about making this part of the history? As in? Where you add the pin test? Yes,.

B

And I think it's a great idea. um Yeah I really like that. So when I say temporary I mean not to monster, not mask not in the head. Offense like it's, not gonna, be it's not, it doesn't block pipelines. But yes, let's put it in the history for sure I think it's fate idea. Yeah.

F

Well because at least at least then it's somewhere and then you can point to that commit rather than saying here's some helpers, you can say here's a commit right that you can reap repurpose, that, if necessary, yeah.

B

You know that's a good again I'm, overlooking there is some like man, I wish. I guess more will not be I need to let it make all these things, but it's a Vanagon typically, but this looks good I'm looking at the as maintainer one and then let me look at this one. Did we find that the leaky no I, just like scrolling I'm, like yeah.

C

There is there's.

B

I think some more thing: oh the delete one yeah yeah.

C

B

We would suspect not just see it right, the board, the one good eat, wait, oh, it is yet. Are we in admin? No, this is not an admin. What is content in.

C

Both 18 both versions right.

B

All right we're gonna have to have to check this out. Can I see this as if I'm signed out you know if I can see it? Maybe let me sign up I.

C

Wonder what it will take to run healing tests on each and every page of term I have a small dream in my drawer, that is to fry the everything that is in named ojs all that JavaScript that runs on every page and just like jQuery that attach itself left and right and this kind of stuff, yes, yeah I, am so afraid to touch it. Because you know there is no tests for that right and.

B

For this, this strategy pen test is when there is no test like we're. Gonna we're not gonna, write good tests, we're just gonna, totally pin it down, and it's helpful for some of those areas of our code base sort of like that. Just one, thankfully, isn't isn't really a lot like that, but all right, I think I'm in as an admin I'm gonna pretend to be a user. That is a guest, then maybe as one as a developer, we do have the feature I mean Gustavo is definitely yeah.

B

Gustavo should not be able to delete things from the board. So let's pretend to be cast out.

B

Don't have to actually click on them. Okay, then impersonate.

C

All right, Toby, by the way, the.

B

Name, I know I know, but that bothers me about it all right. So the Szabo cannot see this, but the can you.

C

Check in the markup, if he's dead and just disabled, oh that's a good.

D

B

Okay, I wonder if developers can see it I think that's probably what's going on two priests lymph.

C

King I believe me: Stan, the handle okay, I, know man I.

E

D

E

We got her singing.

C

You should have famous file shortcut there.

B

Is so there is like a ven mode and I, don't know how to activate it or really how to use it. um There are like you, can you can activate them mode and do like lots of dishes stuff who uses it all the time I think um Dennis King uses it a lot of it, but I don't know how to use it. So it looks like developers can see this, so so it is legit unless, unless that's not how it is on master but I, don't think you change anything like well all right.

B

Let me just for fun. Let me see what it's like then well, I guess I'm a maintainer here. Can you see if, on our get lab on words, can you delete lists on our boards? Me go check. Yeah, yeah, I'm, the only known month.

C

F

That's a that's, probably a rarity running being a nun.

C

Yeah no I can't you can't no I mean. Maybe the group.

C

Can verify that we are checking the same I think we.

B

Are but I don't know if I can share this screen if there's yeah I'll just cut.

E

It out, if there is anything.

B

A

B

Me sharing my screen. That's.

C

Good but I do I, do see different stuff than your cover to you. Do you see the delete list button but I, see open and closed list may be a mom.

B

All right, I would.

E

Really like a date, I.

B

Would feel better about our Oracle if we actually ran it on the head of our merge base before we did things.

C

Yeah we pretty badly factor introduced the delete button for people that they can't believe right. Yeah.

B

Yeah because we already touched some things around it so I think I think that's I think that needs to happen, but we aren't. We are at time so I'm gonna do that asynchronously. You know: I'll push up, I'm, gonna, I'm gonna forcefully.

C

Okay, no no I do see the button I do.

B

C

But it's weird I had to go to the group not to the project to see the delete button that.

B

Is weird because I seen on the project? No.

C

No, the URL just say you see you don't have groups at the beginning, that's weird yeah, then this is actually the border. They usually work from. Oh, oh.

B

Wait wait. We can all look at this board and it might be that yeah.

C

Exactly to say, I can delete here. No, you can't so I see open and close, and you have linked a request, but because you are filtering for it right can you remove all everything from your search edit board, though that's weird I.

B

Can't don't want to remove it. I'll start camera screen again.

B

Okay, if I remove everything from my search, I'm Indus I'm in this special board. But let me go to like I'm gonna, go click on Dennis's thing and see what.

C

You get so this is a view. It I'll bet you can share. So this is the board I'm talking about that goes there in the chuckling man, oh yeah,.

B

Well, you need to have a list right. I do have to take this. Oh I, don't see those lists.

B

All of this I think I feel bit we've.

B

We wouldn't have to poke around at, like still when legacy code gets really legacy on and not like get labs code. Here's legacy, but there's were definitely unfamiliar with it and now we're trying to capture what are the requirements and stuff. If we ran our Oracle on master, we would know for sure. Yes.

C

B

Think that's the best the change I'm gonna make so that hey, we know for certain. If there's no diff can have I think we can move forward some confidence as marks and let's leave this in the commit history, but the way I'm gonna organize the commits and I'll share. My screen is last, but so I am gonna. Do a forced push with this, but the way I'm gonna organize the commits is.

B

Though here's what we have currently, however many commits we have I'm gonna insert before it set up the pins as Oracle's.

B

Then we do this currently thing and then we're gonna run it both with the feature flag on and off. This is gonna, give us different context and so then run with FF on and off, and so this is. This is the branch. This is a commit. We could do some manual checking of because we we could spend time like actually simply get a green pipeline, but let's not worry about that.

B

Let's just do manual checking of the diffs between these two snapshots, but this is the commit that we'd want to check out and we'd have the tens and the oracles and then we're gonna do a cleanup. So these are the these. Are the new commits that we're gonna add so.

F

That third, one in the list, just so I guess I understand your plan- is to have that such that someone can check out that commit locally and then run the test, run the run the pin test and then flip the feature flag and run it again and check that it actually passed. Yeah.

B

They actually won't even need to run it at all. My goal is to I mean I was gonna, run it I, guess they could run it. I was gonna, run it and then just commit these files as well. So they can also just manually check it, but it makes sense yeah. They could have run it, but will will mean we already have where if the feature flag is on and off so rather than Oracle pen, this would just be FS.

B

F

I just write out the pins. These pins are in version control, yeah.

B

And that's I was thinking, let's put them in version. Control agreed I. Think that's the right idea. Oh yeah, since we're gonna clean it all up, anyways yeah, that's that's the cool! So hey! This is a lot of fun and this actually was a lot better than I thought. It'd go so I was nervous about spending an hour. Writing files in Ruby, so I'm glad that this one better than that, but yeah. If you have any thoughts or comments or I'm ready to close.

F

It out know for me, it was a good, definitely might be. What do you think of just selling the idea of pins in the next front-end meeting I said it.

A

F

Be facto something legacy: yeah I.

B

F

B

I'd love to include your example, and maybe we should maybe we can add something really to the front end guide' or one of our this. This is cross front end, but maybe we should add something to our developer guide of hey, try doing pinning test. Here's some examples that we include link to this video and a link to you had an example and I have one from the past. That might be really cool.

B

Would would anyone from the audience be up for like just spinning up that quick, mr and then you can ping it to me and we could marry something. Sorry, an Emma against a dog adding to the guide, maybe something about pinning tests and then we'll announce that in the front end call thank.

C

B

That make it as messy as you want, just if you find a good place, that's the hardest part, all right, cool, well, I'm, looking forward to it, and thanks for hopping onto this, and thanks for being interested in this, this normally for driving intensive thing, yeah, hey you guys, take care, see you later you cheese,.