►
Description
Javier Garcia and Tyler Williams from the Digital Experience team do pair programming to address accessibility concerns in the Slippers navigation component.
Link to MR: https://gitlab.com/gitlab-com/marketing/inbound-marketing/slippers-ui/-/merge_requests/55
A
Hi
everybody-
this
is
javier
and
tyler
from
the
digital
experience
team
and
we're
going
to
be
talking
about
accessibility,
work
related
to
slippers,
navigation
and
whatnot.
A
I
had
started
an
issue
for
implementing
an
nbc
one
for
navigation
since
we're
going
through
a
bit
of
a
redesign,
and
I
had
gone
through
in
in
the
past
iteration
gone
through
an
mvc
one.
We
have
some
accessibility
issues
that
tyler
has
brought
up
so
eloquently
in
the
code
review,
so
we're
gonna
go
through
and
pair
program
and
try
to
see
like
how
we
can
resolve
these
issues
in
a
way
that
works
well
for
people
with
screen
readers,
because
that's
important.
B
Yeah
cool
well
sweet
to
get
started.
Do
you
have
any?
We
can
like
link
to
the
mr
in
the
video
if
you
want
to
jump
in,
but
do
you
have
questions
about
the
stuff
that
I
wrote
down
before
we
hop
in
yeah.
A
Let
me
just
like
pull
it
up
real
quick,
because
I
jump
in
yeah.
So
let
me
just
share
my
screen
because
I
think
that'll
also
help
for
the
people
with
that
point
of
view
of
just
on
an
engineer
trying
to
make
some
ui
improvements
all
right,
so
I
think
this
makes
sense
like
essentially
like
because
you're
just
like
hiding
and
showing
two
navigations
like
I.
I
understand
that
I
just
didn't
know
how
else
to
do
it.
If
that
makes
sense,.
B
Yeah
yeah,
so
the
thing
that
I
would
do
I
I
so
I
think
display
none
is
good
for
so
you've
got
like
the
two
navigations.
I
think
that's
super
reasonable.
That's
that's
actually
exactly
what
display
none
is
built
for
is
like
we
have
these
two
things
and
they're
like
the
data
and
semantics
of
them
are
different
and
like
on
a
mobile
view.
We
want
it
to
be
this
way
and
on
desktop
view.
We
want
it
to
be
this
way
and
so
display.
B
None
is
good
there
because
you,
like
literally
rip
it
out
of
the
dom
and
like
that's,
that's
good
so
like
I
actually
wouldn't
change
it
for
between
for
going
between
the
mobile
and
desktop
views,
but
I
noticed
that
the
and
here
let
me
I've
got
my
storybook
you
I
don't
need
to
share.
I
just
want
to
double
check
them,
saying
the
right
thing,
so
the.
B
Yeah,
so
the
so,
if
you
bring
it
to
yeah
navigation
and
then
like
pop
it
out
to
its
little
iframe,
okay,
on
the
right
hand,
yeah
one
more
left
that
one
cool
this
I
just
this
makes
it
easier
for
me
personally
and
then
you
know
inspect
it,
bring
it
to
a
mobile
view.
Let's
start
there.
First.
B
Sure
yeah
cool
awesome
and
then
so
click
the
so
actually,
first
right,
click
and
inspect
on
the
the
button
itself,
like,
let's
just.
A
B
Want
to
see
the
markup
and,
what's
going
on
here
and
then
yeah
underneath
so
yeah,
here's
the
first
so
here's
the
first
thing.
This
is
like
partially
accessibility
and
like
partially
just
like
seo
and
like
our
strategy
around
the
nav,
my
opinion.
I
think
this
is
like
generally
like
what
most
people
do
like
the
idea.
B
With
navigation
is
like
it
should,
it
should
be
persistent,
even
if
you
can't
see
it,
it
should
be
in
the
dom
somewhere,
because
then
for
seo,
like
site,
crawlers
can
know
like
what
we
have
in
our
nav
right,
because
we
use
our
nav
to
communicate
some
things
in
seo
and
then
also
again
for
like
people
who
are
on
screen
readers
and
like
not
consuming
it
like
the
way
that
you
and
I
are
looking
at
this
right
now-
we
want
to
give
them
as
much
opportunity
and
like
leave
the
stuff
in
the
dom
right,
and
here.
A
B
Even
using
this,
like
you're
like
hiding
and
showing
you're
doing
the,
I
think
v
if
in
view
which,
like
rips
it
edges,
replaces
it
with
a
comment
so
instead,
like
the
first
place
to
start
would
be
using
v,
show
the
v
ship,
but
the
v
show
directive
uses,
display,
none
and
then
display.
None
is
also
a
problem
because
with
display
none
much
like
that
comment
there
that
the
comment
line
that
pulls
it
out,
it
also
gets
ripped
out
of
the
dom.
B
I
think
seo
will
still,
I
think,
some
site
crawlers
will
still
find
it
and
get
it.
So
that's
good,
but
if
you're
on
a
screen
reader,
you
won't
have
access
to
it.
B
So
here's
the
solution
for
like
so
you've
got
a
nav
bar
and
you've
got
like
the
whole
like
an
entire,
like
all
your
list
of
navigation
items,
but
you
don't
want
them
all
showing
at
this,
like
all
at
once
or
even
by
default,
whatever
we
can
use
absolute
positioning
to
just
kick
them
off
the
visual
screen,
but
leave
them
in
the
document
right
in
like
in
the
actual
dom
tree
so
like.
What
I
would
do
is
like
that,
and
let
me
look
at
it
on
my
screen,
because
I've
got.
B
No,
it's
all
good.
I
think
you
driving
is
good.
I
just
want
to
like
speak
clearly
and
make
sure
I'm
saying
the
exact
right
thing
yeah,
so
the
the
div
or
even
the
header
is
probably
a
good
thing
so
like
we
could
make
the
header
like
a
relative
like
positioned
relative
okay,
and
then
this
your
secondary
div.
That
says
slp
mx16,
which
is
what
contains
like
when
you
click
the
button.
Yeah
that
thing
yeah.
A
B
A
B
Its
positioning
between
relative
and
absolute,
so
when
it's
like
the
hidden
class
on
this
is
that
it's
absolutely
positioned
and
we
can
put
it
like
top
zero
left
zero
and
then
transform
negative
one
hundred
percent
negative
one
hundred
percent
right.
So
it
just
like
goes
to
the
top
left
and
then
just
like
shoops
up.
Does
that
make
sense,
yeah.
B
Worries
in
mobile
drop
down,
okay,
you've
got
the
div
vf.
Mobile
item
is
active.
A
B
And
so,
instead
of
using
vf,
I
would
set
it.
We
could
actually
set
up
a
class,
so
use
a
cl,
so
change
vf
to
class
and
do
the
colon
class,
because
we're
going
to
use
some
javascript
to
be
like
dynamic
here.
A
B
Yep
cool
and
then
so
by
default,
it's
slp
absolute.
B
Cool,
oh,
you
wanna
put
this
in
backticks
for
now,
so
we're.
B
A
little
interpolation
here,
okay
and
at
the
beginning
of
the
before
after
the
first
backtick.
Okay,
what's
that
data
that
you're
using
is
it
mobile?
Active
modal
mobile
item
is
active
yeah,
yeah,
okay,
so
test
for
the
truthiness
of
that
do
like
a
little
ternary.
B
B
Space
and
then,
if
it
is
active,
oh
and
I
always
do
this
backwards,
yeah,
if
it
is
active
so
now,
you'll
do
like
you
can
do
like
a
single
quote
for
a
string
return.
Okay,
do
like
slp
relative
slp
relative,
so
like
this.
B
Space,
colon
yeah
space
and
then
slp
absolute,
so
this
so
we'll
probably
end
up
like
pulling
this
into
a
little
like
computed
function
or
something
right.
But
to
start
we
can
start
simple.
I
think
you
have
a
typo
in.
A
A
B
I
just
do
this
because
I'm
like
I'm
optimistic,
I'm
like
I'm
optimistic
that
we'll
only
ever
need
this
expression
and,
like
I'm,
probably
wrong,
you
have
a
typo
and
mobile
item
as
active
by
the
way.
Mobile
item
is
but
yeah
so
here.
So
basically,
if,
if
the
active,
if
the
active
data
point
is
true,
then
we
want
it
to
be
positioned
relative
and
if
not,
we
want
it
to
be
absolute,
and
here
it's
already
going
to
get
complex,
so
we
want
to
put
it
whatever
the
top
zero
left
zero.
C
B
Yeah,
it's
like
yeah,
it's
the
and
it's
like.
I
never
know
the
hot
key
to
bring
it
back.
A
Yeah
I've
had
to
do
something
with
like
the
dom
like
something
with
the
cache
and
the
dom
like.
B
Sure,
okay,
cool
so
yeah!
Obviously
I
broke
all
your
styles
sorry,
but
this
is
good,
so
click
inspect
into
it.
Okay,.
B
Yeah
yeah
and
then
toggle
that
button.
Let's
see
what's
good
yeah,
it's
still
doing
vf
interesting.
You
know
back
to
the
code
yeah.
I
think
we've
still
got
the
v
navigation,
mobile
drop
down
class.
B
B
Yeah,
because
that's
what's
well,
this
will
be
a
little
bit
different,
but
that's
fine!
Let's
start
here.
A
B
Oh,
you
want
to
make
that
closing
quote
a
backtick,
not
the
double
quote,
but
so
one
over
one
to
the
left,
one
to
the
left
yep.
This
should
be
a
backtick.
B
B
There
there
we
go
yep,
perfect,
okay
and
then
change
it
to
you.
Have
the
vf
make
it
colon
class
yeah.
B
B
All
right,
so
this
now
should
do
we're
expecting
it'll
still
be
a
little
wonky
you
might
have
to
like
reload
reload
yeah,
okay.
This
is
exactly
so
that's
happening
because
you're
going
from
absolute
to
relative,
and
so
the
div
isn't
getting
the
like.
100
percent
width
like
when
it's
at,
like
relative
divs
span,
100
of
their
container
absolute
divs,
will
be
zero
by
zero
unless
they
have
content
inside
and
then
they'll
be.
However
much
their
content
is
right.
B
So
that's
so
we're
getting
the
right
class,
and
this
is
perfect,
and
so
now
the
other
thing
we
want
to
do
in
that
same
file
where
you
just
the
one
you
just
modified
yeah.
So
it's
absolute.
We
also
want
to
transform
it
back
100
in
either
direction.
B
A
B
The
absolute
one
yep
you
can
write
be
like
so
so
a
space
and
then
slp
transform.
B
Okay
and
then,
what's
the
tailwind
translate
x,
trans.
B
Translates
do
negative,
100
percent,
so
I
think
it's
like
yeah.
It's
the
negative,
translate
full
yeah
and
then
same
for
the
y.
B
You
know
I
learned
on
a
podcast
recently.
Maybe
you
already
know
this
and
like
I
if
you
need,
if
so,
if
you
lose
your
auto
your
auto
fill
on
that
drop
down.
If
you
hit
control
space
it'll
bring
it
back,
control.
A
B
A
B
B
Yeah
all
right,
perfect
boom,
so
toggle
the
thing
off
and
now
go
into
the
dom,
and
I
want
to
show
you
why
this
is
like.
So
we
can
like
verify.
Yeah.
B
It's
still
there
right
so
like
a
site,
crawler
would
see
it.
Someone
with
a
screen
reader
could
see
it.
That's
the
big
thing,
so
we
just
use
absolute
positioning
you'll
end
up.
You
may
need
to
like
do
like
overflow
hidden
on
the
container,
which
is
that
header
and
that's
appropriate,
because
it
it
also
like
denotes
like
hey.
This
is
the
this.
B
Is
the
container
we've
got
stuff
that
like,
if
we're
absolutely
positioning
it
like
it,
should
it
should
be
hidden
because,
like
that's
a
so
like,
that's
really
the
hidden
thing,
if
you
do
like
overflow
hidden
on
this
it'll
be
visually
hidden,
it'll
denote
that
you've
got
stuff.
That
shouldn't
be
shown.
If
it's
like
you're
saying,
like
hey
we're
going
to
do
something
to
this
right,
but.
B
Yeah,
the
other
thing
too,
is
this-
makes
it
like
easier
to
run
into
so
like
we're?
Gonna
have
to
do
the
integration
of
like
the
writing,
the
javascript
right
and
you
can
just
toggle
your
class,
your
class
list
here.
Okay
right
so
wait,
cool.
A
B
Yeah,
because,
like
it's
working
fine
for
us
now
but
like
when,
like
if
you
like,
put
it
on
like
a
desktop
and
you
didn't
have
overflow
hidden,
you
would
get
like
a
side
scrolling
bar,
because
the.
B
Me
go
find
that
for
you
right,
so
you
don't
see
it
in
the
mobile
view.
So
much
and
also
I
guess
it
wouldn't
because
where
you
have
the
separate
mobile
you'll
have
to
like
duplicate
this
in
the
mobile.
So
but
that's
fine
for
now,
and
I
think
we
should
just
talk
about
mobile
because
everything
we
do,
we
can
keep
it
short,
but
everything
we
do
here
will
still
basically
be
the
same.
A
B
Yeah,
so
that's
the
toggling,
the
like
menu
itself
right
there
and
then
there's
still
a
couple.
Other
accessibility
things
I
wanted
to
to
cover
yeah.
Let's
see
what
else
you
have
written
down
here,
and
this
will
also
you'll
also
want
to
kind
of
carry
that
over
to
these
drop
down
menus
right.
The
things
that,
like
the
top
level
buttons
that,
like
click
to
open
and
stuff,
you
want
to
do
the
same
technique
and
it
but
it'll
work.
Basically
exactly
the
same.
B
A
B
So
this
is
what
so.
Here's
like
the
because
it'll
get
tricky,
and
I
don't
think
we
should
do
everything
on
this
video,
but,
like
here's,
how
I
here's,
how
I
think
about
navigation
navigation
for
like
sites
like
this
is
one
of
like
the
most
interactive,
like
elements
ever
and
it's
persistent
and
is
extremely
important,
and
so
I
think
about
it,
two
ways
or
I
think
about
two
two
particular
things
that
are
inside
navigation
bars.
The
first
is
interactive
elements.
B
In
my
opinion.
I
have
like
a
strong
opinion
on
this
and
it's
like
mostly
around
semantics,
but
you
can
do
the
links
correctly,
but
I
think
that
basically,
you
should
either
have
buttons
or
links,
so
it
should
either
do
something
or
link
to
something,
and
so
these
top
level
ones
versus
like
product
solutions,
pricings
partners,
the
drop
downs.
In
my
opinion
they
should
be
buttons
and
what
you
get
out
of
that
is
a
button
is
automatically
tab
focusable.
So
you
don't
need
to
do
tab
index
gotcha
right
and
it's
the
same
thing.
B
And
then,
if
you
make
everything
inside
it,
a
link,
same
deal,
tab
focus
works,
and
so
you
might
not
actually
need
to
do
tab
index
on
these.
However,
for
some
of
these,
what
you
end
up
doing,
if
you
want
to
like
you
end
up,
if
you
look
on
like
line
12,
you've
got
the
unordered
list.
There.
A
B
Or
maybe
the
the
list
item
itself
there's
a
chance,
depending
on
how
this
all
shakes
out
and
like
how
you
need
to
like
group
it
up
by
divs,
you
may
need
to
put
a
tab
index
on
list
item
because
list
items
aren't
focusable
by
default,
but
you
may
want
it
to
be
like
if
someone
like
tabs
to
this
list
item,
it
opens
right,
and
so
you
may
want
to
just
add
tab
index
equals
zero
to
make
it
focusable.
A
B
That
slp
absolute
right
so
also
so
not
only
do
we
want
it
to
be
or
sorry
on
the
relative.
Not
only
do
we
want
it
to
show
when
someone
has
toggled
this,
we
also
want
it
to
be
relative
when
someone
has
focused
or
to
oh,
so
it
is
in
the
slp
absolute
because
this
is
this
is
where
it
gets
super
tricky,
so
line.
B
Where
I'm
getting
to
yeah
line
11.,
so
I
would
say
so,
it'd
be
like
space
and
be
like
focus
colon
slp
relative.
So.
C
B
Yep,
okay,
perfect,
so
that
so,
if
you
can
do
since
we
can
do
focus
within
with
tailwind,
I
don't
think
you
actually
need
to
do
the
tab
index
trick,
because,
basically,
the
idea
is.
If
someone
focuses
on
one
of
the
buttons
that
you
can
click
or
one
of
the
links
you
can
click
to.
A
B
This
menu
to
appear
so,
if
you're
like,
if
you're
on,
because
the
other
thing
too,
is
it's
not
just
screen
readers,
it's
like
if
you're,
if
you
can
only
use
a
keyboard
if
you
can't
use
a
mouse
and
you're
looking
on
even
on
like
desktop
like
you
want
to
be
able
to
tab
into
every
item,
and
if
I
were
to
tab
into
the
deepest
nested
link.
B
B
Yeah,
because
you
wanted
to
be
specific
too,
so
it's
like
open
the
open,
the
overall
navbar
open
the
sub
menu
and
use
focus
within
there
yeah.
So
that
is,
I
think,
that'll
actually
fix
it.
This
is
much
simpler,
with
focus
within
it's
much
much
simpler
than
what
I've
had
to
do
in
the
past.
I
think
the
link
I
sent
you
to
the
last
mega
nav
that
I
did
at
my
last
job.
B
I
had
to
like
basically
like
listen
for
focus
and
keyboard
events
and
like
toggle
classes,
based
on
like
I
had
to
do
a
ton
of
like
add
a
ton
of
tab
indexes
and
add
a
ton
of
event
listeners,
because
it's
like
keys
and
presses
and
all
this
stuff.
But
the
nice
thing
is,
if
you
change
those
top
level
items
to
buttons
to
enable
the
drop
downs
so.
B
Yeah
yeah,
if
you
make
that
a
button,
now
it's
focusable
and
you
can
get
all
the
get
all
the
good
all
the
good
clicks
and.
B
B
Sorry,
I
didn't
realize
we're
in
the
drop
down
one.
I
want
this
on
navigation
mobile,
so
you
can
keep
that
actually,
no,
no
keep
that
keep
that
focused
within
colon
slp
relative.
B
Okay,
cool
and
then
go
into
navigation
mobile.
The
file
to.
B
A
B
B
Yeah
yeah,
there's
yeah,
now
there's
like
a
bunch
of
cleanup
and
that's
why
I
said:
hey
sorry
to
throw
this
this
wrench
into
your
day,
because
it's
like
a
lot
of
the
styles
you
had
in
there
are
just
gonna
break
because,
like
buttons
and
anchors,
like
behave
very,
have
like.
B
But
I
do
think
it
is
like
the
right
choice.
No.
A
B
I
don't
think
so,
and-
and
I
also
you
know,
I
would
have
pushed
back
on
that
because
I
think,
like
the
things
we're
talking
about
are
like
it
really
is
accessibility
problems
and,
like
I,
don't
think
it's
appropriate
for
us
to
like
kick
accessibility
improvements
to
another
or
like
for,
like,
I
think
you
know,
80
of
them
like,
I
think.
Sometimes
there
are
like
some
small
violations
that,
like
you
know,
most
accessibility
experts
will
say
like
hey
if
you
can
get
to
the
low
hanging.
B
Fruit
like
the
stuff
can
come
later,
but
for
this
thing,
especially
because
it's
so
prominent
and
it's
so
like
like
yeah,
and
it
is
fundamental
to
the
experience
it's
also
not
just
like.
Oh,
this
is
on
like
one
or
two
pages
and
it's
extra
content.
It's
the
navigation
like
like.
If
we
do,
if
this
isn't
accessible,
people
can't
navigate
the
website
and
that's
just
like,
and
I
think
that's
like
an
unacceptable
state
to
be
in
so
yeah,
but.
A
B
Without
focus
within,
you
have
to
like
start
listening
for
all
the
tab
events
and
then
like
toggling
classes,
based
on
what
they
tab
to
and
if
it
is
in
fact,
like
a
focusable
element.
Yeah
it'll
be
hard,
it's
hard
to
say.
If
that's
there's,
probably
a
couple
cleanups
here,
but
I
think
I
think
you
get
the
gist
of
like
what
the.
B
B
B
Yeah
you
want
to
make
it
focus
within
the
and
this
itself
nope.
No,
this
will
be
fine,
yeah,
yeah,
you're,
good
you're,
good
sorry,
I
I
started
the
thought
that
was
wrong.
A
B
It
took
me
like
a
week
to
adopt
it,
but
once
I
got
it,
it's
just
like
changed.
My
life
changed
my
life.
A
C
A
B
B
Sorry
in
the
inspector
you
have
the
button
class
highlighted
in
the
markup
and
then
down
another
line
here
into
div
class.
B
It's
got
the
I
can
see
the
here's,
how
we
can
test
it,
expand
the
stiff,
expand
this
dude
and
then
hop
into
something
yep
and
then
on
the,
but
so
on
that
button,
right
click
and
for
state
focus.
B
Cool
and
now
click
on
the
the
container
div,
so
a
couple
lines
up:
one
more
yep
and
see
if
this
is
relative.
C
Okay
does.
A
B
Here,
oh,
it
might
be,
I'm
looking
at
tailwind.
We
might
need
to
enable
a
plug-in
for
it
that.
A
B
Default,
the
focus
within
varian
is
enabled
for
the
following:
core
accessibility
is
one
of
them.
B
B
C
C
B
Okay,
yeah,
I
think
it's
just
a
core
one.
So
if
you
do
in
the
tailwind
config,
okay,
scroll
plugins
at
the
bottom,
there
line
195
and
then
do
so.
It's
it's
a
require
statement.
So
take
the
quotes
out.
Oh
yep
require,
and
then
it's
just.
A
B
B
I
don't
use
enough
of
these
plugins
to
actually
know
tailwind,
css
accessibility,
plugin.
We
might
just
need
to
extend
it
in
the
in
the
variants
yeah
if
you
go
to
back
to
the
back
to
the
config
yeah
and
then
yep
variance
extend
okay,
I'm
put
this
in
our
zoom
chat
gotcha.
So
within
that
you
want
to
do
scale.
Colon
focus
within.
A
B
Yeah,
you
might
need
to,
you
might
need
to
kill
the
server
and
restart
it,
because
I
think
I
think
sometimes
with
the
storybook
or
with
the.
B
B
B
C
C
B
Okay,
cool
so
now,
yeah
well
yeah,
keep
it
hidden
and
try
and
focus
in
on
the
thing.
B
Open
it
up
in
the
elements
panel,
this
yeah
body
root.
There
you
go
and
then.
C
B
Papa
down
in
that
div
yep
that
one
and
now
on
just
grab
a
random
element
that
can
take
focus
state
like
at
any
button
yeah
and
then
force
state
to
focus
or
state
focus,
okay
and
then
go
up
to
and
then
check
that
div
and
see
if
it's
the
container
div
see
if
it's
relative
now
see
if
the
style
has
been
crossed
out
like
yeah
scroll
down
to
see,
if
it's
like
see,
if
it
even
knows
that
it
has
that
attribute
on
it,
I
don't
think
it
does.
I
don't.
B
B
A
B
A
A
No,
that's
not
it
is
it
like,
because
I
think
like
intuitively
just
like
from
looking
at
this,
I
would
think
that
it's
like
position
focus
within
you
know
what
I'm
saying.
A
B
Oh
no
you're
super
right.
I
I
understand
now
yeah
focus
within
apply
to
utility
yep.
You
can
atta,
you
can
apply
it
to.
A
A
Let's
get
into
like
you
said
one
of
the
divs
right,
one
of
the
buttons.
B
B
C
B
One
above
two
above
sorry
this
one
yeah,
okay,
yeah,
hey
it
got
relative.
So
now
here's
the
other
thing
we
need
to
change
to
is
because
it's
got
the
transforms
on
so
turn
off
the
transform
in
the
inspector
just
to
make
sure
I'm
right
before
we
write
the
code.
B
See
yeah
yeah,
yeah
cool
so
same
deal
with
the
focus
within
so
we
need
to
in
extend
you
want
to.
Probably
probably
what
we
can
just
do
is
extend
transform
to
take
focus
within
so
yeah
copy.
This
into
so
next
line
would
be
transform.
B
Yeah
yeah,
but
we
can
okay
so
now
in
navigation
mobile,
so
save
that
we'll
probably
need
to
restart
again,
but
here
it's
also
focus
within
colon,
transform
dash
none.
So
this
will
make
that
translate.
Stuff
won't
work
anymore.
Okay,.
A
B
Yeah
you
can
do
that
that'll.
Do
it
too,
so
you
can
even
test
this
without
doing
what
we're
doing
before.
I
bet
you
can
just
tab
into
it.
So
click
on
the
thing
hey
look
at
that.
A
B
Awesome
so
yeah
just
now
we're
going
to
do
that,
mess
up,
stuff
like
etc,
but.
B
Cleanup
yeah
style
cleanup
make
it
look
like
it
was
looking
before,
but
you
got
it.
I
mean
that's,
that's
that
I
like
that
solves
eighty
percent
of
my
concerns.
One
other
thing
came
up
for
me:
the
button,
the
toggle
button.
Do
you
have
an
aria
label
on
that.
B
B
Yeah
and
just
call
it
like
aria
label
yep
and
just
call
like
navigation
toggle
or
like
toggle,
navigation
or
toggle
navigation
yeah,
because
I
think
what
it
does
usually
is
like
the
screen
reader.
You
can
just
write
it
as
a
sentence
because
the
screen
reader
announces
the
aria
label.
So
if
a
person's
going
through
it
it'll
say
like
they'll,
get
to
this
element
and
it'll
say
like
it'll
literally
read
that
text
string,
and
so
I
think
you
could
even
say
this
is
a
button
to
toggle
the
navigation
and
like
that
will
be
extremely
clear.
A
Yeah,
I
think
this
is
us
this.
We
should
use
this
as
an
opportunity
to
call
out
that
like
when
we
you
know
previously
when
it
was
just
like
brandon
and
lauren
like
doing
this
entire
repo.
Like
doing
this
level
of
detail
to
accessibility,
is
like
so
much
harder
when
you
have
so
many
requests
to
go
through.
B
All
the
requests
and
all
the
deadlines
there's
only
two
of
you
doing
the
thing
and
it's
like,
and
you
got
to
catch
it
too
right
because,
like
you'll
just
you'll,
even
if
you
know
to
do
it,
even
if
you've
got
the
time
like
you'll
forget
or
you'll
miss
it
and
like
that's,
you
know
it's
it's
unacceptable
to
have
an
inaccessible
website,
but,
like
also
it
is,
I
think,
perhaps
understandable,
to
end
up
in
that
state
like
when
you
don't
have
the
tools
at
your
disposal
to
like
get
it.
There.
A
Yeah-
and
I
think
that
this
is
like
going
through-
this
has
been
awesome
because
it's
educated
me
a
lot
about
accessibility.
It's
not
something
that,
like,
I
think,
like
a
lot
of
people
say
that
it's
like
really
important
but
like
in
practice.
I
think
there's
like
a
lot
of
knowledge
gaps
that
people
have
like
at
least
for
me
myself
personally
like,
and
I
think
that,
like
stuff
like
this,
has
been
really
helpful
so
yeah.
We
should
continue
to
do
stuff
like
this
and
focus
on
that.
So
yeah.
B
Thanks
for
taking
the
time
so
yeah.
B
I
really
think
that
this
is
that
this
is
fixed
up.
Then
I
there's
still,
I
think,
there's
a
couple
like
other
suggestions
olympics
but
like
this
was
the
blocking
stuff
for
me
like
it
just
needs
to
be,
it
just
needs
to
be
tappable
and
like
that's.
Basically,
that's
basically
it
like
if
this
is
tappable
in
both
directions,
right
like
forward
and
backwards,
and
it
goes
in
the
and
it
goes
in
the
order
you
expect
it
to
go
in
then
like
that.
A
That
makes
sense
right.
I
think
that's
that's
a
good
way
of
like
I
don't
know
if
you've
like
felt
this,
but,
like
I
think,
like
at
a
certain
point,
like
accessibility
comes
down
to
like
a
basic
understanding
of
like
semantic
html
and
cement
like
semantic
css,
and
I
think
that,
like
a
lot
of
people,
I
I
I
I'm
not
convinced
that
a
lot
a
lot
of
the
ways
that
people
traditionally
learn,
html
and
css-
really
reinforces
that
precisely.