GitLab Issue Triage & Merge Request Walkthroughs, 1 Apr 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Demo for merge request - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/27892

Description

No description was provided for this meeting.
If this is YOUR meeting, an easy way to fix this is to add a description to your video, wherever mtngs.io found it (probably YouTube).

A

Quick demo of the license management refactor just to show that the four areas that license management was used in still works, so the first place we're going to take a look at is the license compliance page, which is under security and compliance. And we see here we have tech, tanam project and policies, I'm gonna, open up the debugger and then refresh the page. Just so we could see any console errors that may come up.

A

So we see here the page is loaded under policies. We can search.

A

We can change the policy, we can add one.

A

And we can remove one. So the next thing we want to check is the license compliance section in the mr widget. So we go to an interesting mr again, open the debugger will refresh the page to see if we could catch any console errors.

A

And we see that the licenses are loaded, so you click expand. We see the licences listed here, so we want to deny a policy or deny license. We see that that updates it's a little slow, but it updates and same thing just switch over to allow.

A

And then the grey ones have run categorized, so they don't have a policy set. So we'll go ahead and set one.

A

And then manage licenses right now is just a redirect to the next area area. We want to verify that words, so this is the same screen that is shown under the license: compliance page under the policy tab. There is a follow-up issue to deprecate this and remove this, but that's gonna be done in a follow-up issue because we still have links. We still need to audit other places in the application that link here.

A

So before we remove it, you want to make sure that the links have been updated, so we'll go ahead and do what we did before and test that we can change the rules. You see that that works, that we could remove one that search works.

A

Let's add a new license.

A

So that's been added, pagination, worse and then going down the list here. The last place to check is the pipeline view, so we just need to go to an existing pipeline and it's under the licenses tab. So I'll go ahead and open up the console and also refresh the page.

A

And here we see list of licenses, so this shows the licenses that have been detected in the mirth request and then the status icon here represents whether that met it will match it up to an actual license policy. So it will tell you whether or not that detected license is allowed or denied into the project, so we'll go ahead and change this to allowed, and this change is in line and then for the back flip this other one to denied again these are and categorized.

A

But if you take action on them, they'll change and manage licenses will redirect you back to the screen we had seen before. That's pretty much it as far as I know. These are the only places that we see the UI in terms of in regards to the changes that we made in this refactor.

A

Most of the changes were centered around renaming directories and then updating the file pass for those imports and renaming a couple of variables, but yeah. If you want I, have preserved the commit history feel free to squash those commits once you feel comfortable with merging this merge request.