GitLab Monitor:APM Team, 22 Jul 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Monitor:APM Weekly Meeting - 2020-07-22

Description

Weekly meeting for the Monitor:APM team

A

All right welcome everyone. This is the monitor, apm weekly meeting for july 22nd. uh So there was a I'll point. Everyone to the agenda, there's a number of items on there for the read-only section, just kind of announcement thing so remember to look through that, um and then we have one thing on the agenda so far. So that's was for dove if he wanted to kick us off.

B

Yeah, so it actually came up during a discussion that issue that I think nikolaj open and it evolved into this discussion that I've opened, and I want to get your thoughts so today we basically redirect all of our users to the edit page when we click on the edit dashboard, so that we redirect the user to that page to update the ammo, and we were thinking about maybe changing this behavior so we'll go to the web ide. You can read through the original discussion. Why? uh Why? How did we evolve into that like thought process?

B

Basically, um I'm not sure why. Originally we we direct our users to to the edit page instead of the way by day.

B

Maybe it wasn't the decision that we actually gave any thoughts around it, and so I see that both mikolaj and urban urbana plus one for that, like I think that, like we, we need to make sure the the behavior will be consistent across across the board. So every time we will redirect our users to our repository form dashboard, then it should end up in the web id.

B

So there is an issue there. I just want to bring this to your attention.

A

Yeah, I think that I'll add my vocal plus one that yeah, I think the web id makes, uh makes more sense than directly to the edit page. I'm not sure what the history was behind that why it goes to edit, but um I think it would be fine just to switch it over.

C

I give it like a brief look before the meeting like I don't know, 10 minutes before and I haven't found any issues like regarding to the permission or anything that drives a red flag for me. From now on. It wasn't very in-depth analysis, but it seems that it should be any problem to change edit page to web id.

B

B

That was it for my side.

D

All right, amy yeah, so I am working on the index pages for the new directory structure that I've set up, and I am trying to make clearer on the metrics dashboard page why this is different from the metrics dashboard and I need to figure out exactly what to call it. Do we have a preferred name for this.

D

Custom dashboards user created dashboards.

E

Well now we call it custom dashboard.

E

Yeah amongst ourselves, we've been calling it custom, dashboards. Okay,.

E

C

E

That's we can, we can definitely rename it if it's if there is a better yeah.

B

That's what I that's what I think also that, if we think of like uh aligning on terminology- and we want to change it yeah, I don't think custom dashboards, something someone you know. Okay and.

D

B

About like a different name, I'm also last one for changing it.

D

I wanted to make sure that we settled on something so that I could be consistent and then a quick follow-up, which I don't expect we'll have much discussion here for matt and for dolph.

D

Do we have any already written wording about.

D

The things that we're offering at a high level, because that that main operations page has nothing right now. It's always had nothing, but we really should put something there, and that page feels more like a high level marketing page to me, and I'm wondering if we've got wording, we've already written that we could steal, which page are you saying just slash operations.

D

It's going to introduce metrics alerts, incidents, a lot of different topics, but none of them in a great deal of depth. That's why it feels like marketing writing to me.

D

If you have something or you know of links, just send them to me. I'm not quite ready to tackle that page yet, but advanced warning never hurts.

B

Yeah, maybe maybe we can look to some of the you mentioned marketing. There is a marketing page for operation. Maybe we can look at those and see if it makes sense like highlight high level features that we have, so we can tie into that. Okay, all right.

D

That's all I've got.

B

Cool, I just think another another issue, more related to the back end, and probably most of you saw it matt, I'm not sure if you had a chance to look at it, because you were off when I opened it and just going through and listing the what I believe are like major changes to our architecture or major changes to our project. I believe things that we should start look at like some of them needs like a spike issue. Some of them.

B

We already conduct the spiky issue and we probably will start like prioritizing and what we're not sure, if we'll have time to do that in this year, but like.

B

Those are like significant issues that I would like to see how we'll be able to accomplish, and throughout the year um yeah. So you can. You can read through that and because I saw that, unfortunately, I'm not sure if it was recorded so sorry for dragging you to that discussion.

B

uh There is an ongoing discussion around storing dashboard in in the database and like there is an open issue, and so I also wanted to get like the team opinion.

B

So most of the discussion is in there is in the issue, but if someone want to like verbalize or vocalize some of his thoughts around that I'll be more than happy to to discuss this originally, I opened this issue because I wanted to better understand how we can treat our dashboard the same, and it's also also related by the way amy to real question about custom, dashboard and user dashboard further down the road. They will all be dashboards. That's that's my aspiration that it's not a custom dashboard and it's not a default dashboard.

B

It's not about out of the box, but dashboard is a dashboard, no matter what- and that was my issue. This is why this is how I start and it evolved into: why won't we store uh the dashboards in the database base, and so, if indeed this is something that eventually will.

B

Solve that problem, then maybe this is something we should start looking at and just you know throwing it in the air as a discussion item. If you have any thoughts around it, you can put it on the issue. We can talk about it now.

C

So regards to the uh storing the dashboard in the database, uh as I mentioned in slack, we will have the um sprite meeting, because uh I remember reuben asked for uh synchronous call last time uh and I schedule it for the next week this week. I I'm not able to uh put my focus uh on to that because I'm doing the s3 shadow, uh so I didn't have.

B

C

To prepare uh correctly for that meeting, that's why it's! I moved it, it's all good! So for putting you on the spot, I.

B

Didn't notice no.

C

B

It's a dislike message: yeah. We can push it for the next meeting and it's a good. It's a good reminder for us to go really to this issue as well. So thanks.

C

So uh I've invited the apm backend team, uh also matt, clement and udov. If anyone else wants to participate in this discussion, around storing dashboards in the database uh feel free to reach out to me or any other invited person and we're gonna add more uh people to the group. I just don't thought that um there'll be much interest out of the back end uh side around this mother, so feel free to just tell me if you want do.

B

You think someone from the health team doing someone from the health team is also interesting.

C

I uh directly uh asked better to hand over this message to the health team that we're planning to move this and, as far as I know, he did, but there was no sign of interest in the issue, so I'm sure also clement is, as far as document is also part of the health team. So uh I guess there is like some multiple connections to the health team.

C

So I don't know I can ask peter again if he wants to participate.

B

Yeah, okay, I'll, ask I'll ask kenny, I don't know if you want. I know that he had some question. He had like one one thoughts, one thought so maybe you would like to join. Maybe I'll do that.

E

uh Just one thing I want to mention is that, since we I think we are, we want to continue allowing users to uh define dashboards in india repository via ml files.

E

Even if we store the entire dashboard in the database, it won't solve the problem of of editing out of the box dashboards because well, we still want to allow users to define custom dashboards in their repository.

C

So the main, uh the main uh reason which I thought that would help this help: okay, just just a quick head up for this ama coming next week. The main idea was that um when we will create the project and repository entries in the database, we can also uh plug into that process and create the dashboard entry for such project.

C

So we are, we are not supposed and we cannot create the file in the user uh project.

C

Therefore, we cannot create their own version of the out of the box dashboard, but we are able to create the database record and if we will move the dashboards from the like the dashboard says from the repository to the database, we could create out of the box dashboard alongside other user created dashboards that would appear later on uh and that dashboard could be entered either via ui, like from creating the custom metrics or even if we expand this, to be able to create whole custom dashboard and also we could plug into the um post commit pipeline which was described in the issue.

C

So so whenever is, there is a change to the dashboard directory, um but github the search dashboard directory. We could ingest those files and move it into the database, so that was like the main reasoning and that's why I rise this discussion around this issue about being able to modify the out of the box dashboards.

E

Oh, yes, I see a pointer. So if we change the source of truth from the files to the database, then yeah yeah, it would help make uh out-of-the-box dashboards.

A

Editable just backing up a second, I put this in the agenda, but I'll vocalize it as well. The the I had a question. I see dove's answering it right now, but the the issue that has all of the large epics for her the back end team. I was just wondering if there's um actions we want to take or if there's some outcome, that both of you were looking for. Yeah.

B

I didn't I didn't come forward. I mean when I created this issue. I was you know I was reading through like several responses from multiple threads, and I just want to have like a single place where we can see like all the like the big things that we want to do you know. Maybe there will be some outcome out of it. I'm not I'm not quite sure yet where we're heading, but it's always good to have like a single place, because I kind of realized okay.

B

It needs like it's a massive effort behind that.

B

So, if you are aware of any other, obviously I think you know, at least for me. It helped me like understanding, okay, so what I was coming from from I'm saying. Okay, if I want to plan like the next like three to four iterations, uh what are the things that we need to focus on and then understand? What is the user value because, like there are some? There are some items there that I'm saying okay, they are important, but they are not like blockers like, for instance, users today can create dashboard.

B

Okay, it's not like the best experience, but they create create dashboard but, for instance, they cannot plug in multiple promoters instance. So, like one of the issues there is, how can we support multiple parameters? Instances uh so like when I'm when I'm thinking about okay? What's like more important for the user now and then it helped me say: okay yeah! I want to start dashboard in the database and it will be like great experience if, if we can make like custom and out of the box dashboard, editable and everything, but then.

C

Again, we have.

B

This another big task around, like the multiple promoters instance, which is completely different, but it's it's mainly like a back and walk. So for me it helped me like prioritize, what's what's more important, why uh and and like? Basically, that's that's that's that's where I was coming from. So there's no like expectation from this. Just like go over there see if it makes sense, you know and add more issues if you think like add more in the description and then then I'll schedule things the way. I believe it should.

A

All right thanks, yeah, that's what I was expecting, but I was making sure that you weren't waiting on me for something else on that. So thank you.

A

All right uh is there anything else, other topics people want to bring up.

B

Yeah, I just want to congratulate everyone for a great release for 13.2. I think it was. It was a massive effort from the entire team and yeah. I just want to call out everyone. You know on the hard work with them.

B

A

Great all right thanks everyone, I think that'll call it there, then so have a good rest of your day and we'll talk soon. Bye.