GitLab Pair Programming - Frontend, 11 Sep 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2020 09 11 FE Pair Programming - API requests that return JavaScript??

Description

In this video we pair on grokking some unusual API requests that also return JavaScript. We also discuss the best approach of unraveling this complexity.

A

So ip uh has been recently pinged on a list of some inline javascript, that's being we're fetching javascript asynchronously, and then we eval it and we're concerned about using eval uh because of security reasons, and it's also maintainability reasons so yeah. There's is this the list of of yes. So.

B

um So it's it's! It's a bit weird, because the list I have in mind is a bit different. Oops clicking the wrong link, so new html html save.

B

I don't see really how this is concerning, like some yeah, okay, I was more thinking along the lines of these weird files, so we have these um find. Let me just look for them yeah. So we have these weird files, so we have files that are js files and uh that are either generated via hummel or erb, and I was thinking along the lines of those weird files.

B

So, for example, we have like this right, which basically escapes javascript whatever renders something into a members list, and then you know replaces like a list item with that. Member.

B

Oh man, yes, and, to be honest, like I don't even know when it's executed, I assume it has something to do with the rails, ujs logic, because all of these files or a lot of these are like update.js, show js destroy.js right, which seem to kind of have a connection to these interactions. You know, if you delete something, I don't know. If we want to look into those we could, but it might be a bit of a rabbit hole and we won't know what we find on the other side of the mirror.

C

Well, um you know.

A

Sometimes tumbling down the rabbit hole leads to interesting insights into the world around you and yourself. So, okay,.

B

Let's do it, let's do it okay, um meanwhile, my gdk is updating gdk. Okay, do you want me to do me to drive I just updated yesterday? uh No, no, it should be fine, it shouldn't take long. uh I also think it should just be working.

B

um It's like how would we, like I mean update.js, are these just automatically loaded somehow.

A

So they're going to be rendered, so I would look for I would do a group global grab on render dot star update.js. ah That's that's! That's smart!.

B

Update dot js right yeah, something like that: oh gosh, uh maybe without updates somehow, like maybe oh uh yeah, it wasn't that smart, uh but it should be in hammer files right.

B

Okay, these don't look like they even loaded them. Like that's one question too: are we sure this is even loaded? This is a very good question. Maybe it makes sense to copy the path and go down the history route.

B

You know yeah, maybe look when they were introduced like they. They probably are a bit older.

A

History, it looks like it was, I imagine it was just part of improve member services, move, update.

B

Action huh format js render shared members update. So if this is gone like, if we can't find this at all ah there, we do it format js. ah This is the reason why we didn't find it um so.

A

Oh wow, so if you go so for this endpoint yeah, if we some, where request update.js.

A

Yes, we will return that javascript.

B

Yes, so, and it looks like it's just like in the normal groups controller or whatever right, I'm I'm. I'm scared.

A

Ipm and I like it, so let's keep going.

C

B

C

A

Yeah, that's that's so um so I'm wondering so. This could be something that we we fetch in an eval, that that could be a thing that we're doing there, but I would expect to see at least like update, just maybe at least update.js somewhere in the code base.

A

um Let's search for it again yeah I just did a project white search for it. I don't see anything. um The other thing is we could try running. You know our members and just um try to update a member and see if that javascript ever gets pinged in the network or if it gets loaded or something.

B

I assume it just gets loaded if you actually update something. Oh request, this. Okay, that's a good sign running just takes a startup just takes a while, especially for sharing via zoom right.

B

To be honest, like to be honest, like I, I just assumed that if you update a team member, it does its thing right so because it's like tied to this update root right. It's like hey. We have it here in the root and we have respond to format. You know shared team member updates.

B

And I I just assumed that you know this is oh.

A

D

A

Be, oh, so I'm trying to think what is what is the point here? What I? What I guess might have been the point here and you might have already picked up on this, but I'm I'm just not realizing it.

A

It must be after we, so this update is like a post, so it must be after we've done the action. This is the response we get and then we're gonna like update everything.

A

Oh, and so then, is that what they were talking about this, like we have these um global evals on these ajax. Oh.

B

And so now the tricky part is because we don't you probably don't use vue for these, um the tricky part might be so. Let's, let's try what happens if we delete update okay, what's update so post?

B

Okay, this doesn't load anything update.js, maintainer.

B

No, maybe removing someone, okay, removing someone completely reloads the page.

B

So I assume it's adding someone to a project or change changing their.

A

Changing their um like on the drop down, there would.

B

No adding someone also.

B

Wait a second if you change the drop down. Yes, oh wow! What no I'm not? What did I do? I didn't want to navigate back you're saying if I'm changing in the drop down like the the role, I mean uptake action membershipable, it's a very funny. Word members and requesters find new membershipable current user member params. To be honest, like this sounds like a little bit like if you update your own membership.

A

Like we could look at where that concern is yeah yeah is that did that not do anything, or maybe it is like your own membership.

B

B

A

B

A

For references to membership.

B

ah Group and project okay include membership actions, so update should be like. Okay, it's included. Okay, so memberships require access. Level expires at update parents, so update members update service new, execute member find by id. So it's definitely updating new current user update params. What is current user? Why ah update service? Okay members update service update, params, execute member member equals okay.

C

It's like super weird, so we do we even use. um Do we even use update.

A

B

Yeah, so it's the response on our post, beautiful.

A

You mean look at, but it's not gonna. Do anything. Look at the first line right, that's not even a selector and we're not even doing anything with it. No no.

B

We're doing it if you, if you look at it, it's returning a list item, then it's rendering.

D

A

B

And okay, but, to be honest like this is bad, so does this mean that if someone.

B

Could somehow escape here right or maybe has like a stupid username like script, whatever right.

A

A

The if we had um if we didn't put the escape javascript here, yes.

E

A

Bad would happen. um We could verify that this thing is being run by like maybe we want to add a console log to that javascript and like because, if it's not being run I'd say, let's just remove it. Let's not even try to like.

B

It's definitely run you think so yeah, yes, because it completely updates like this line right like.

C

B

It like, if, let's see it's project, number eight right, let's break on node removal.

B

So if we now do this, you can see that it mutates the body like break on sub pre-modification right, but is that is that this script.

A

That's being run, or is that, like its own update thing.

B

I mean that's easy to check. We can just comment this out right, like we can just delete it.

B

Excuse me, yeah sounds like more than just your family has a cold, um I'm I'm I'm over. It.

A

Me in the cold we're.

C

B

B

So what are these posts response so they're now empty right.

A

What does it do? Yeah? I don't know if it's being run.

A

Okay, but uh but I really just don't know.

B

Okay, let's, let's try the good old console log.

A

Oh, what's that uh a 404 looks.

B

Oh yes, this fall falls just like for oh hi. What did I do.

B

Oh redis, what no.

B

No, I don't want to pause on dom. How do I get the debugger breakpoints removed.

C

B

Yep, it's definitely run.

A

B

But my question is like we're changing this here right and it's just replacing you can see the the eye can actually flicker right, sometimes yeah. So it's replacing the complete row right.

B

But why like, as is this view- or is this ah maybe maybe it's about the expiration date.

B

It's not view, it's definitely not view. Is it.

A

No, it doesn't look viewy. um Can you give me a selector for the drop down or for one of these rails? I was going to explore j.

B

Is edit member form? Okay, wait view is detected on this page, I'm sure it's.

F

B

It's also like we have also have like a view.

C

B

Bar yeah remove member model, so apparently the the removal model is view like yep.

B

What is this a frequent icon, search.

B

Twice: okay, um yeah, so the selector for this one for the drop down. You said: yeah yeah, it's it's js, edit member form.

A

Trigger, oh, oh, this is this a rails thing.

B

Yes, this is a rare ugs.

C

Thingy, oh, does rails like handle this javascript yep.

B

B

Put this is the the put remote true uh this remote. True is the thing that causes it.

A

That's the thing that causes it where, where else do we do this remote true often.

B

Just I uh currently have an mr that replaces not that often.

A

It's a little often considering you know how this is, like. You know, fundamental reactive approach like for us to unearth this would you know somewhat requires.

B

To be honest, sometimes it's really nice because uh some models, some will actually just give you a confirmation model. Yeah yeah data confirm this is the one like if you, uh if sometimes it's just like it just works, sometimes- and you know to be honest, like sometimes people are even using it in view files.

A

You just search, maybe remote. Oh yeah,.

B

Because I have seen it like in in view files like method delete stuff just replaced one recently, but you know to be honest, like I am a bit how we would need to refactor this into view right. Yep.

B

Or you know, I actually don't care about the security aspect that much I care about a different thing, and that's that thing.

B

I hate that thing. I want to get rid of that thing. What do you.

A

Have against the the u.s currency system? um Yeah, no yeah! I I don't.

A

I would be sad I would be. I would be um remiss if we came across this and the thing that we did was use document create element and query selector. Instead, instead of replacing this.

B

um Well, the thing is: it's just rendered like it's just rendering like this thing and to be honest, like.

A

This is this: is this the whole? Oh, no, no wonder.

C

B

Shared members, member yeah, so wow, you know, and just I get shot us when I already see this right like it's, you badge. Oh, we have an it's. You badge. ah It's you, um nice.

A

Yeah, you bring up a good point, so here's another approach to this yeah, um because there's actually there's a couple performance hits happening by doing it. This way uh one is like our you know. Oh I guess we have a whole bunch of um conditions, so the return body isn't going to be so huge of that one javascript string but like we don't really need a return body, but that is you know, that's going to take up some bandwidth of how long it takes to update um you.

A

Also, uh um I don't remember what else I was gonna say but anyways, so that we don't have to move all of that over to view, and we could still do this in a vanilla js way. What if we just put that um template or that handle template? uh Oh no, but I guess we can't. We don't want. I guess it's in hamlet. I was thinking.

A

Maybe we could put in a template script or like and then reference it from the javascript to like render or update or do whatever it needs to do, um but I'm realizing now that we'd still have to do some rewriting of it, because we can't like generate a handle script on the front of them. I'm just now getting back. Things are coming to me. No.

B

A

B

um Yeah, I think you know that's.

B

To I think there are different different concerns here right. It's also interesting. Wait list item name, so it's actually not even replacing the whole thing. It's just looking for this one thing. That's called list item name. We could do it so ah so yeah, it's just basically taking this first, oh wow,.

A

It's taking the whole thing, but yeah yeah.

E

Imagine there's a lot.

A

More con, it's a lot more conditionals than it actually is content. What do you think of all this jackie? What would what would you want to do.

D

Yeah, I'm still I'm still a little confused how that what's happening after that whole page.

D

Oh that's the list item. That's replacing the page. I don't know it's just so confusing.

A

It is confusing, um but.

D

Lucas's main goal is to get rid of jquery right.

B

Yes, that's my main goal.

D

In all of this confusion, yes, you could start there and see what it looks like.

B

D

B

I mean getting rid of jquery is probably like pretty easy here, because it would just be like.

A

Here's the thing.

B

A

We move this to view like it's a it's a big template, but it's a big win. If we move it to view we we also get rid of jquery and we don't even need to do this because everything's reactive anyways. But the thing is you.

B

Just you also need to move all kinds of other stuff to view and in maybe in the back end, because I don't know if we have like these methods right.

A

We can just we can just form post them, we can, we can we can we can. We can still use a form and we can still you know, programmatically submit the form like you can still do. That.

D

F

D

New and post to the same form.

A

Yeah, so that's another, that's a good point, though ip is like yeah, so these aren't making ajax calls. These are like asynchronous form. Submissions um that rails is like handling.

B

Right, that's that's what the rails javascript is doing under the hood. Essentially right, it sees. Oh. I have one of these forms with state with data remote, whatever I'm now going to add an event handler here and by adding that event handler. You know, I will then do the thing and I will execute whatever javascript I get back.

B

That's essentially what's happening right. um To be honest, like one of the things that I already would consider is a win. If that thing didn't return any um javascript, but just return the html and then on the javascript side. We did things, but it would mean that we, you know that basically moving changing this to actually return the html like hey. This is the new user object and then do the thing in javascript. It's just just moving the thing by one layer.

A

That's a good, um I think, that's a good approach.

B

The problem is, I don't know how to move it.

A

Right off the bat, oh, oh, I think I think I know how and I probably don't, but let's try it.

B

um And let me just I have this one: merge request open that that replaces the jquery rails, ujs thing.

B

Replaces this one? So let me just show you something: there's this much request open that.

B

Why is the pipeline? Failing again, um I hope it's so you can see exactly this is like. Oh, where do we have the form stuff? There is like no, the confirm it's essentially similar with the firm model but ah form submit.

B

Oh that looks cool, so this is even wait form submit in it as it's javascript members yeah. I'm isn't this the page we're currently looking at yep. It is yep.

B

Toggle date input what is get member list items this.

B

Wait so it's actually looking at that drop down menu and then when does it submit the form?

B

I'm, oh, okay, so this is actually doing the thing right, and this is why I'm concerned- because I have this, mr, which basically moves the stuff over and then, if we now touch the stuff again in another, mr, we would potentially run into conflicts right, yeah, that's just but wait. Member like.

A

Is this the thing jsx's yeah this? This is the thing um and I think that form cement is called like for either.

A

um Oh, is it it's one? Is it one form wrapping both of those inputs? Yes, okay, yeah, so that form submit is, is called um whenever we need to trigger one of those things.

A

Yeah like on drop down clicked on line 20 24, slash 25. um So when we call the form submit- uh and I think I think we'll be- I think- we're not gonna affect it too much.

A

So here's here's the thing, though, like um if you go back because I I want us to use our time effectively. Yes, it's still a little smelly to be returning. You know this kind of html from the back end, because you know the back end technically has multiple clients than just this one thing so yeah we're getting rid of the javascript, that's returning, which is a big deal, but we still have the only reason we're doing this. Javascript return is because we still have this underlying problem of reactivity.

A

For this thing, um and even if we move it to html or we get rid of jquery or whatever, like that, underlying problem is still there, which is hurting maintainability, which jackie brings a good point. I have no idea what's going on. um I I think uh our time might be best spent trying to move this over to view, even though it's going to take longer uh because there's going to be.

D

A

Much higher reward.

D

Understand the benefit of what it's doing now, not being in view like, I know it looks big, but I think.

B

I I think my concern is what you're mentioning that these forms are so complex that moving it to view is a big undertaking, and I wholeheartedly disagree with you that, because by removing jquery, we get one step closer to removing jquery and literally looking at the methods like changing these three lines to be not jquery yeah, just getting you know, doesn't change doesn't leave this code necessarily worse is not.

B

A lot of effort will still function the same way um using native dom apis, and we could eventually get rid of jquery, because if the viewer effect of this is not done within the next, you know that's your point months. It will still block us. You know I.

D

Can tell you that right now I am, do you know the invite member.

E

D

One I'm I made a view of that. It's almost ready for a review, so this is oh nice yeah. So I replaced that in view already and it it's taken a couple weeks, but.

E

D

I don't know if it's going to replace it, but it's going to be triggerable from any page yeah, no, the need for that top part. There.

A

Yes, okay, gotcha, that's a good point uh and I think yeah whatever we do, we should do incrementally and I think yeah you're right ip. If, if it's a really low hanging fruit that we can just get rid of jquery here, if we plan on removing it all together later, that's yeah long term.

A

I don't know if we can do line four um without jquery.

A

Oh, you can just create an element and then set its html. I guess yeah, okay, yeah. That makes sense. He literally just wants.

D

To get rid of that.

A

B

Yeah uh document, what's like create element, yeah create element div. Oh.

D

Yeah, actually I I have a great if com can we do the next one after this, because I know I'm going to have this problem of getting.

A

D

In the invite members page there's a user search, that's.

F

B

Document query selector.

A

uh um There is like a replace node thing function in vanilla, js. Oh.

B

A

Replace child yeah, you you give it for the parents. You then pass in the old and new child.

B

uh Let me just like.

A

Replace what we can do.

B

Okay, let's replace it, then it's easy. Then it's like const.

B

Old node equals this one yep uh oops yeah, you know that's right, old node is this one, and then we do old, node parent uh here it child and then it would be. What was it? Oh, oh replace!

B

A

Forced to stream don't.

B

Be so optimistic.

A

B

uh New old, no old node, that's always the problem old node and then it's just like.

B

B

So this is one where I'm not optimistic, because if we are looking at locals time ago, oh this is really nice local time ago,.

B

It's probably like a local time ago: yeah. It expects to be handed jquery elements right. Let's.

A

Let's, just let's just have it, take both and just wrap it in jquery like that's, and then we can still play with it.

A

What do you think.

B

um So you're saying in this one: oh god, where is it now update gsm? I would just do oh, but now I'm confused like how is the api of that time ago, thingy uh wait what what you could do? No look it's not. This is like weird because this is like the second parameter of that file is like should be a boolean.

C

A

Weird yeah, it.

B

A

Don't do it, I think, that's why that time is changing. um You know like when it was so many minutes ago. You really noticed it because we would change it like every minute, because those times aren't.

B

It's also not working redeclaration of const node, oh gosh, because this basically happens in the global scope right.

A

B

Yes, this happens on the global scope, so if you have variables it was var before and not um you.

C

Know I guess so this.

B

Is even bad but the bad better! Worse worse! Oh god see my! You didn't. Have your coffee yet and I'm already.

A

Function statement requires a name function statement. I don't know why it's doing that. um Oh, I think you need to uh you need to immediately invoke it like. I think.

C

A

And I think you need to do function, you don't need the arrow thing. I don't know if that'll work, maybe it'll work. I haven't ever done immediately. Old node parent is undefined. It's parent node, the the right key keyword is parent node.

B

Yep huh expires intended, so it does seem like we don't even need to update.

B

We don't even need to do the time ago thing. Oh, ah the tool, what I love these states. If you end up in something like this.

A

Yeah, I I think I think it's no harm keeping it, um but I see yeah you're one to get rid of jquery completely here on this page. We would need to change local time ago to accept I'm just saying: let's just have it just wrap the arg it takes in jquery, so they can do that.

B

You know, to be honest, like this would already be an improvement for me and I would not touch the local time ago and I would pro rather go down the rabbit, hole and fix the local time ago in a different one. Okay, so we spent 40 minutes on on changing three lines.

A

I know I know, I know you hate jquery ip.

B

D

How he feels about it, yeah.

B

What are you looking for? It.

D

Is bothering me that this functionality isn't just you.

A

E

I still feel sad.

B

Yeah but I guess.

E

C

B

Think it's interesting, uh I will. I will have a look, because there are not that many of those right um and just replacing replacing jquery in there will actually help us.

B

Do one thing: it will we we can stop exposing window.dollar, and that will mean we can remove jquery from our main.js, and that means the sooner we start getting rid of jquery in our other javascript, the more likely it is that jquery suddenly disappears from our main.js bundle and is actually just loaded on the pages that are utilizing jquery, which will be a benefit for especially you know, newly written code that just uses vue so um yeah.

D

But issue: that's like the the exit, the justice of it.

B

So the thing is, we haven't created issue there's an epic regarding jquery.

B

There's an epic, but we haven't created issues yet for the individual jquery usages, because currently 400 files used jquery um and it felt like a bit of an overkill uh to just create 400 issues. But it's a good point. It probably makes sense to create you know one for hey: let's remove jquery from the global scope as a first thing. You know what.

A

Do you think of um yeah there's we have 400 files that use it. What do you think of creating issues per um like top level? Javascripts folder like saying oh, we're going to remove it from javascript's clusters and remove it from javascript.

A

When we do this, it's really nice, seeing you know community being able to pick up and that's how I think we're really able to get.

E

A

These large scale changes done because we can include. We can include tricks like this. So here's. How do you, here's, how we can get rid of replace with and then a community contributor can just get going? um Yeah! That's cool, yeah, hey ip! If you're happy getting rid of jquery here, I'm I'm happy for you.

B

Let me jackie, you, were you were asking about another thing and we just skipped over you. So oh skipped over that which, which search were you talking about there.

D

Is a um hold on, I meant to look for it. There is it's on the same area. It's in the same area on the same hammel, page, okay, um it'd be an invite member yeah.

D

Is there any in there.

B

D

B

No search for, like the user, select tech, maybe.

D

A

Oh select two we'll have jquery yeah, it's it's gonna, be a beast. Getting rid of jquery we do need to iden. I imagine we have is that epic already identified like all of the libraries that we need to replace with non-jquery equivalents and stuff. Well,.

D

I, the next issue I'm working on is replace, is putting this in.

A

D

A

D

No idea how to do it, because I can't just copy this, because it's all so.

A

I'm I'm so glad you brought this up um in ide world. I think it was in the ide. um No, it was in approvals. We had a need for using select two in a view app, so I wrapped um yes, so, like you can you can um you can wrap like vanilla, js or jquery like base components and a view component?

A

um So there's a.

D

Is that a possibility for putting that into view.

B

Yes, it's a it's also, a good first step because you, basically, if you have like a select two behavior, you can basically just have it, move it and then uh refactor it. It's it's a really nice way to do it. Let me just.

D

Select two somehow, in a view component, you said.

A

Yeah, it would be in. um Let me see if I can find the name of it. uh I think it's select two yeah yeah um is this it. I think this might be it.

D

We're using it already.

A

All right give me a quick second. uh I had to. I had to do this as well, with the select too uh yeah we have it.

D

I never would have even thought of that, but, okay, so.

B

Here you have a view file that imports select, 2 and jquery and then, basically on mounted, it creates the select 2 and on before it's destroyed.

B

So if it's unmounted it just uh uh yes does its thing and that template is actually really really tiny uh and, as I said, you know, it has the big benefit that we can get rid of uh that we can, you know, basically implement a new approval, select that's completely based on gitlab, ui or whatever, and then swap out the files and uh basically leave the api to be the same right.

A

Yeah so check out this check out this thing, jackie um and you might find there's another abstraction where we can just put a select two wrapper into its own bucket yeah into its own component, because it looks like I was looking for something slick too specific, but it looks like this has a prover specific logic, but it's not much um so it looks like we could abstract this to.

D

Mean that we can build this component or something and then we can use it from any component, but we can also delete all this, because we can go into the hammer and put the view component. There.

A

Yep, what's really nice is that select two becomes an implementation detail, and that means we can change that implementation detail later on. The downside is we're kicking the can down the road, we're not gonna, be able to replace jquery until we actually fix this. I mean this is gonna, make it easier for us definitely.

D

Okay, well, I'm gonna do that next, so can I bring you guys you both into that, if yeah sure.

A

Especially bring ip into it,.

B

If I'm still here um the thing with select 2 and that's what I mentioned before is like eventually, you know it's fine, that's in implementation detail, and but if we remove it from the global scope, we are able to have people not suffer through loading jquery and select two on every page right.

B

So this still doesn't use global scope. Jquery you're talking about this is.

A

B

So this is like nice right, even if we have remove jake, all jqueries and select twos and this one stays. That then means that, just on the pages where the approval select is used, it will be loaded right. But right now because we have like main.js, uh we do import jquery and then you know window.jquery and window.dollar in the global scope um to do remove.

A

B

A

Exactly so, let me ask you, then, so we can take a take away from this. Do we have an epic just for global scope? Jcorn?

A

This is a very good point um and if not, I would suggest doing that, because the scope of remove all of jquery is so large. That's a little daunting, but maybe just global scope. Jquery um we can. We can really focus on that and be able to like lower issues.

B

There are multiple efforts: uh the the global scope, one is probably a good one, because I think the only the only global scope that we have is actually that stuff like. I think I need to check. That's a good call out. I will make sure to create a few issues and I will present them in the next front-end call.

A

Cool yeah um that'd be awesome if you want, um if you create it, um and if you want me to create like the underlying issues under the epic like, I could do that if you'd wanna. However, just let me know if there's anything, I can do to help.

B

A

Thanks um yeah thanks. Well, this is cool. This was fun. This was a good conversation and, uh and it was good um exercise one little.

F

B

Yeah, I don't know it's, it's like it's also something that we should probably forbid uh in general, like we often add stuff to the global scope, um so, for example, for example, in these utils earlier we have these common utils and earlier this year I found like because we add some of them also to the window. I believe- oh yes, yep. uh Obviously it's somewhere else. I know what you're talking about yeah, so we have like utils that we add to the global scope, and then you know having a look at it.

B

We found out hey, they are put in the global scope and it's basically their only usage of it and other than that. They're never used again, and so it's like oh good, they're, never used again. Maybe we can just delete them and we were able to delete a bunch of helper functions that nobody used right.

B

Sometimes you know um I don't know about. You know certain helper functions. Sometimes we also have helper functions here that are called common utils and they are actually just used in one place, and you know then off you can ask yourself, you know, is it? Does it even make sense right, yeah.

A

Anyway, that's a good point: um yeah! Oh yes, there's another bad boy, no anime, disable that rule um yeah. That's a good point! I uh got globals and singletons and it pains me I'm actually gonna do this today, you brought it up. um We have like a design patterns uh page in our front end guide and the only design pattern in there is singleton.

A

I'm gonna just delete all of that um yeah. This is a good. um This is a good conversation. This is this was really helpful. I'm going to hop off um ip jackie, it was great seeing you all and and thanks for driving.

D

Both I'll see you hopefully next week.

C

Yeah cool see thanks. You all.

D