GitLab Pair Programming - Frontend, 30 Sep 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: FE Pairing - 20220930 - Fixing rspecs and jest specs

Description

In this session, we work on fixing some rspecs and jest specs.

A

Hello, everybody and welcome to this week's pairing session and I have brought along a little something that um made me pull a couple of hairs, but, um let's, let's see see, what's actually yeah so I was working on an issue which is rather straightforward. I said um it is so what you need to know is um I've been working on the redesigned login page and there is a feature called the design and text which is basically just a text.

A

You can configure it in the gitlab admin panel and will then show on the um yeah before you log in basically on the login page. So this was working so far, so good ish it turned out, and there was the issue that was reported. As this thing is trying to fix.

A

um You can actually see it here, pretty good, so um we do have a setting which basically says log in Via passport enabled and if this setting was set to True, which is the default and everything was working as expected, once this setting was turned to false, the Simon text would also be gone, which would be a bug. So autism are oh I've, been working on an MR to fix that and the fix is actually working out kind of nicely problem with that is.

A

This is obviously a test Gap, because this went through on the on the first ride, without any any no human or machine noticing. So, um while I'm working on this I'm actually introducing a text that this thing still works would be a very nice thing so um from where I'm currently at I do with my GDK running, and it's actually doing the right thing. So I am pretty sure that this works, and this brings me to the test I'm currently working on or trying to set up.

A

um It is kind of hijacking and already existing text, which is okay. um This is nothing more than a scribble at the moment, but um these led up things should be arriving, probably can remove those those as well. There might be some unneeded cylinder, but um I. Don't think that is the main problem so in. In short, let me get this up.

A

This test is currently failing um because it is, it is expecting to it is setting design in text and then checking that the actual render results does have the same text still um while we have been disabling the other sign-in methods which is actually taken off, um which is setting the setting to folds and we're just what I just spoke about. Okay, so that's that's kind of it in a nutshell, and what I expected to be is I do have the suspicion that this set.

A

This line is not quite doing what it's supposed to be for whatever reason- and this used to be working for me- I, don't know why it kind of stops. But um web driver headless like that. That was a thing. I was able to run an rspec test with this program and it would just open up a browser for me. I could actually see stuff so if it renders or not, but for some reason it stopped working for me, and it will now just run it in headless mode. Basically,.

B

Why do you feel like you need to see stuff like? Are you micromanaging your tests absolutely hold you, they couldn't see anything. Do you not trust? It.

A

Absolutely not no.

B

A

That's that's I,.

C

Know um when it.

B

Has failed you're, like um yeah, that's kind of when you want to pull your chair up and read over their shoulder and like really check everything the test is doing, but what's tough is like. Usually the test is just doing its job. You know, um uh let's try.

B

Let's try this out, um yeah I, don't know if line 53 is going to be what we want. So I feel like it's important to note here that we're in a Hammel spec.

C

B

Rendering Hamilton specs usually.

B

Are not dealing with like all of rails were like, which usually, like controllers, are mm-hmm, so we usually have to do things like where we allow view to receive stuff. We.

C

B

A lot of this stuff in animal spec, ific application setting I'm not sure about. So let's can we jump into the actual ammo that, for this thing,.

A

uh Sure sure um that would be.

C

This one I suppose.

A

B

Okay- and we are at.

B

um As possible is markdown field being um stubbed.

A

Fairpoint is.

B

That reference is that referenced anywhere in in our Hamilton spec.

A

No, it's not um It's Quickly.

B

Yeah, let's yeah: let's try that out. That's a good idea.

A

That's well! That's really good enough right! Yeah um field.

A

So this really should should pass at least otherwise we're having some different issues.

A

Did I make any stupid typos or something.

C

Should be okay,.

C

B

Invented too much on line 23. I.

A

Do agree well, something's, changed. That's already partial success.

B

No it's. It looks like um we're running into something's, very wrong yeah. These things should print out to a picture like do you. If you go back you to the um yeah, if you scroll up oh like when we sorry when it runs, you should get an output of the screenshot of the failure.

B

A

That make sense. Oh um yeah, it does I just killed that I'm. Sorry, that's uh um what I did as well was to put some just.

C

A

um So I just put the text over here as well, and this will actually make it run. So, let's let this fail for a second but I. Oh I,.

B

Think, yep and I think that's related to it too. So we're only on line 53.

B

um Do you see a line 53 of the test? We only set it for this current application settings. Part of.

B

um So we might need to um maybe on line 21 of our Hamill. We need that drill down property before referencing sign in text.

A

uh How would that look like I.

B

Think it would just be just what you've done except gitlab current settings Dot current application settings, DOT sign in text. So sorry.

C

I'm lost: can you repeat that.

B

um You have you're drilling down from the top little C current settings. Yes, yes, yes, yes, yes, yeah! That might be related to it.

A

Is it? Is it just a point or a code? This is a point yeah, okay, gotcha.

A

Oh okay, so let's give everyone a shot. Well,.

B

um Yes, yeah: let's try it out yeah! You got rid of that. Let's quickly.

A

A

um ah Okay, because of the changes I did in the template that okay, that just kept me but yeah that makes sense so good. um Let's see if this thing passes, 50 great.

C

That wasn't visible before right, even though you hardcoded it.

A

um It's the the actual variable um value was visible, but which was just gun, but now we hard-coded this text, okay, so that is what we're now seeing. So that is as expected, it.

C

A

Screenshots Paul help me out.

B

uh Oh, you know what it might not be doing that if these aren't like feature specs I mean uh yeah yeah, it's probably not going to do screenshots, because it's not PG spec. Sorry about that. um Okay, if we go back so it does look like we stub the feature flag, restyle login page to.

C

B

False on line 36 or true.

A

um Both of them that's why we are getting two failed tests, so it would actually probably be okay to get, might be okay to get one failing test at this point, but both of them. So we are looking for those.

B

Yeah, let's do something: that's fine! Let's, oh what we're gonna say.

C

What does the stuff do.

A

um Desktop- and this is just setting the um the restart login page, um true or false, depending on which the duration we're in that's all, it is.

B

um The other five I had is there an ee override to this thing.

A

B

Not to the ham not to that one but to the actual View.

A

So there's also an ee template or an ee spec, to say the least, but.

B

Should we devise sessions, can we look for device sessions new.

B

Okay, this is one there. Okay, that's fine.

A

That's a good question um I think might be on cine is here, but this looks to me that we are having some kind of ee only features like um third-party providers that we only support in ee or something yeah and those tests are then living in this. That's what I think it is yep.

C

C

And then there's a spec for e and normal.

C

Is that right, yeah yeah yeah? So why would ee be different if it's the same animal.

B

um We usually don't like duplicate the base, Behavior spec in EE. Will the main intent here is we're going to test a CE thing under the context of EE. So when we, when we run tests for ee, it runs both the CE and ee spec. So the same, the same thing may have two tests, uh because we also support just the CE version of gitlab, which gets rid of everything EE, and so that won't run any ee tests.

B

And so these two tests you'll see this happen, a lot where the ee tests will be different than the CE test and that's expected because we're testing this CE thing under an ee context, and we only are concerned about what is different with the ee context, because okay, the base test will get will still get run like we don't need to duplicate those.

C

The Hamel file, like it's one version but there's bits in it that say if it's ee do this yeah.

B

And usually in haml you'll see it like a render if exists, so that's usually the condition that I guess uh maybe previously was here before we did uh a redesign. Maybe it's in some uh some shared thing, uh but you'll usually see like a render if exists.

C

So then we'd split it out to an ee version of that Hamill block. If the changes are significant enough.

B

I think so yeah, and for this one um having a little bit of context into this one, this one was is in that situation, where um uh I think we wanted to test at some level of like integration like rendering this root view rendered these wherever it was. We wanted to confirm that at this root feel we got these placeholders that the JavaScript was looking for, um which is an ee only thing. So, uh okay, yeah thanks.

B

It's probably one of these partials that we're rendering has got to have the condition in it, and this is just happens to be running things in integration, I think I, think that's good, um or maybe it's even the layout. That's doing this, uh oh, and maybe that's where we're failing actually um well.

B

uh No before we do that. Let's try this out on line 20 above line 20.. uh Can we add a binding dot pry uh above line 20.

A

B

I haven't ever I, don't know if I've ever tried this on uh Hamill and you'll need to do a dash thing, because we're running Ruby.

A

Yeah sorry, um sweet! Okay, let's run this yeah I. Is this going through it fine.

A

B

Like a debugger yeah.

A

A

Well, I guess we'll figure! Oh.

C

A

Yeah yeah I'm positive, let's see there, we.

B

Go yeah look, look at look at how pretty that is um so now, let's run the future, enabled thing and see if that's true.

A

B

Just want to we want to, we want to get the the right one.

A

B

It's not can we oh, but we might not be on the right test because it's going to do this for all the tests right exactly so, let's, let's just focus on the tests that we actually need. So we can exit.

A

Okay, uh I've got an idea how we're going to do this.

B

When we run it, we can actually say like 52, like line 52.

A

um Yeah, but this was still in the loop- that's kind of this thing because we're going to be going through this so um but yeah you absolutely right.

B

um We might need to keep exiting like.

C

Oh okay, oh I'm. Sorry.

A

Yeah: okay, um 52 one more time.

B

Can we go back to um yeah, okay, all right.

C

A

uh huh Let's see, are you having a laugh.

B

B

A

Where to oh sorry, if.

B

You go if you go back to your terminal, um you can do next next.

C

Yep, where are we going to yeah.

B

We can just exit now.

B

Okay, oh not not, control, C! Well, that's fine! Let's get rid of our binding Prime and, let's see if it passes.

A

Well, we haven't changed anything heavy, no well, we do. We do have changed the the flag values, but still then I would at least would it would have expected to see one passing test.

B

A

We we actually changed this. This is when we changed yeah.

B

But it wasn't passing right one more time. Can we go ahead and resurrect line 24 there.

A

B

A

B

Got rid of that thing, yeah.

A

Maybe that was it.

B

B

Okay, let's, let's bring back the flag values.

A

A

B

We um yeah and if this fails um once.

B

Oh yes, yes, this is gonna fail. This isn't doing what you think it's doing, yeah since we'll always fail.

B

um Okay, well, then, sorry, sorry on it, I I gotta go now so yeah.

A

I was just about.

B

To say you next week so what's happening here. This is why we always want to try to do like parameterized, specs and jest. We always want to do like parameterized specs in our spec. Creating this each deal will not behave intuitively, like you think, because this is going to create two before dues.

B

And so what's going to happen, is we have a before? Do that's setting the flag to true and then right after that we have a before dude that's setting the flag to false for all of them, so.

A

Oh, oh, oh, oh! Oh! Oh! Oh! Oh! Oh! Oh! Oh! Oh! Oh! If this is what I think that is, that is very, very bad news. So let me propose the following fix. Then, what do you think about that?.

B

You just said: before: do the truth, you just want it to be true, like we should just have before day trip. um It's not that bad till um there's a number of ways. We like parameterize, a spec in our spec.

B

um You can use parameterized specs, which is really cool uh or.

C

Oh shoot, but here's the thing.

B

Is this isn't testing what you think is testing you here. I would read this and I'm almost expecting it to test that the sum visible text is visible for both the flag on and off, but that's not what yeah. It's only going to test it with the flag on understood.

A

Understood like the reason why I'm reacting the way I'm reacting is, let me just quickly like we have have been doing this uh quite a lot, and this is actually. This is kind of the whole test suite for the redesign login page, it's based on and I. Don't think this was testing what we expected this week.

B

Oh, no, not sorry! So can we go back to yeah? That's not great. um Never,.

A

Mind: okay, that's uh let's fix it in here, so we can pick it up.

B

So the fixes, let's use, parameter specs, because primary specs are cool, um so uh I mean that's. The only reason to use them is just if you want to be treated. You know like you're in the end crowd and not you know, made fun of then you got to use parameterized, specs I. Definitely.

A

Want to be immune, quote: okay, you.

B

Want to set up the cool kid lunch table, they're gonna, ask you! Oh yes. Obviously that was my experience. um So, okay, what you do is um there, let's just look up in Google real fast, because that'll that'll help and this will be help us- do the full development life cycle of Googling things um parameterize, our spec.

B

That's just good enough.

A

uh Not really parameterized I.

C

B

Is that it? Yes, so you see you have a where and.

A

B

Have with them and whatever you've declared in the where the with them those will be in scope in the um it context, things can get really fancy here. Okay, um you can also create a table like syntax, like we do in just here. um So if you keep scrolling down there's a number of different other syntaxes.

C

B

Like a hash syntax there, um if you keep going down, you could do.

B

Gotcha is that do they have, um if you do a search for table on this page.

A

B

Yep, so you have to add this using to the top, and then you could do a cool little table like table thing, which is nice catch.

A

It okay, but not to put this off, but this will probably be good enough for our use case. Yes, 100 like ourselves like super simple, so what do I copy the describe is something we're already having. So we.

B

Would wanna whatever we're going to parameterize? We would want to wrap in a context, because it's the context that we're parameterizing like so in this case I would I would have something like I would create a context like with feature flag parameters or something maybe and so like on line 33.

B

But here's a big question I have for you before we move forward. What is the expectation for when the flag is false? Do we expect it to show up.

A

uh Yes, yeah, but.

B

All right 20 seems to imply that it should not show up lunch money of the Hamel spec of the actual Hammel.

A

um Yeah, that's right, um but this whole thing doesn't show up and once the flag is, um is false and I'd argue that not that I really know where this would be coming from, but I expect for the flag off yeah. We are rendering rendering this somewhere else. So that should be okay.

B

If we go back to this, can we go back to the sign up box.

A

B

That's also checking the feature enabled right.

A

um Yeah, it is.

B

Can we go to the other one this one, because.

A

B

Chicken food- this is the layout which is awesome. This.

A

Is something else.

B

If we go back to, can we go to the.

B

ah Yeah so interesting, okay, yes, let's go back to our spec. um If you scroll down, we don't want to do subject render because what's happening, there is we're calling render at the very top. If you go to the top what's happening there is we call that body the render with the template and the layout, but then we overwrite it by calling render again without the layout and that's why it's failing with the flag off where.

A

Do we see the first render method, because.

B

I, don't so on line seven, you see how we declare what our test subject is and ah there we go okay and so what's actually happening. If you scroll down with by saying subject render you actually are rendering it twice, but the second time will overwrite the first one and we'll lose the layout, so this should pass with both on and off, but we're still not testing what we think we're testing.

A

Yeah we, we still don't know right. Okay,.

B

Yeah, so for all of this yeah, let's create a new context called feature flag with, like let's create a new.

A

This flat block correct.

B

Yeah yeah yeah yeah, whatever um I, would call it with feature flag, prams or something I. Don't know.

A

I'm sure you name me: okay,.

B

Yep and so we don't want the sub- um oh wow, okay,.

B

um Let's move that subject to the very top on line seven, we want to move that outside of the describe like that. Subject sounds like we want to use that all over the place I mean we don't I'm, not when I, say I'm. Sorry, when I say very top, I meant.

A

A

B

Okay, so here let's we can get rid of everything inside of our new describe.

A

Inside of our new desk.

B

um The new one, which starts on line 34.

A

Yeah wait a second ah there we go okay. Why is um this just completely threw me off so okay, never mind um everything in here. Basically,.

B

Everything and everything so all of that described we can get rid of all of.

C

That that's about it.

B

There we go so we'll use where and um we can call our parameter of that variable whatever we want to call it.

A

B

Is kind of after correct yep, and so we won't call it something like where.

A

uh A B for now should be.

C

A

B

Call it like FF underscore state.

B

Yep- and we only need one parameter right now, and so this is what's. Cool too, is like if we had different values for different on off States, we'll be able to co-locate them associate them.

B

um That should be good. We might need to wrap each one of those in an array, because this technically expects an array of arrays, but I. Don't I think it should be smart enough to figure it out. Let's.

A

See, okay, so that would be if them do.

B

um Yep and so then we'll do with them do and then we'll create a new describe.

A

B

um And we'll call that um uh we'll call it with flag equals.

A

um How do I put available in there? Yes, I'm gonna, get that.

B

C

B

Give me a quick second.

B

Oh cool? Yes, yes, yes, yes, we can add. um Yes, yes, yes, let's see that we can add a case name to our parameterized spec thanks. We don't have to worry about wrapping in another. Describe so case. Names is a special um sorry. Case name is a special um parameter.

B

There we go so we can, uh we can add case name to the front of our list of parameters in the where so we'll do where colon case name, comma, colon, FF, state.

C

A

Okay, underscore name right.

C

B

And so now we'll definitely want to do a raise, so we'll need to break up true and false into their own lines.

A

Gotcha and these will be living in a race.

B

Yep and we'll start with, and then those arrays the first item will be so we should break them up to their own lines, and the first item will be with feature flag, true with feature flag, false, like we'll just whatever in this string. The.

A

Okay, gotcha um yeah.

A

B

Yeah we can get rid of the comma on after false yeah, okay, so then we don't need describe. We get rid of line 42. We don't need to describe.

B

Yes, but we will add a before due.

A

B

Yep yep and then the stub feature flag thing goes in there and all of our tests that we want to test. Both cases will go in there.

C

B

We'll just reference it like a variable FF, State yep, just like you did yep, no, no, no, no, not a symbol, yeah yeah yeah just like that, and then all the other tests we want to throw in there. So that's that's! Basically how you'd want to do a loop through values when you have a before, like that, we want to do that. Yeah.

A

I can't believe this was not doing what I expected I'm. Sorry, that's all right, wow, that's quite something.

B

Okay, you could run into the same situation and just too like, if you use just an array to do for each and then you created like a before block on each one of them. That means Jess is going to create a before, for it's gonna create those befores that will run for all the tests. So you really want to make sure when we create befores that need to be scoped. We got to lean into the test framework.

A

I still have fully understood why this is the case, but maybe I just need to accept it.

B

um Part of it is because uh the tests Frameworks do two passes. They do one pass to create all the it and before blocks and then we'll do another pass to actually run them, and so, when you have a look here, yeah gotcha.

A

Yeah, so it's always, the last value will be taken for every.

B

Run yeah because we created two of them and so then for every single one of them. It's gonna, do it it's! It can get that can get an early. So you want to make sure these things are contained.

A

Yeah yeah and I kind of expected it for um to basically Loop. Where do we have an example? Is this yeah here here we go um to basically loot this set. This run this and.

C

A

Do the same thing again, but that's just not what it does. Yeah.

B

Can you um so we'll want to uh copy over the.

A

For resource on newbase.

B

Of his scroll up.

B

uh We need to do this thing as doing on line nine. We need to do that for all of them too.

B

um The stub device and disable captcha, not necessarily the marketing text, one but the stub device and disable capture I think we want to do well below our subject- let's just let's: let's put it up there, so they're all sharing it, because we need to do it for all of them. If you scroll up.

A

uh Yep, oh gotcha, so that was just then go.

B

Yeah, okay, yeah, so we we don't want to do the stub feature flag, one or the allow git lab. That's one. We don't need to share yes, yeah, but those ones. Let's share them. Yeah. Let me get rid of those lines. Yep yeah.

C

Let's see what happens.

B

And we might need to include all the ldap stuff too. We might need to move that to the top, maybe through the shirt yeah, if you need to just put it like above line six. Oh look, yeah nice.

B

Are you feeling good? Where are we in I am I.

A

Am I um yeah I'm, pretty good I'm, currently just thinking about how to to handle this, but um I'll probably be fixing this file and then just open and issue for yeah Essence. That probably be the most um yeah.

B

On 35, through 43 the line 35 to 43, that's the main block that we had to use to replace line 63 through 64.

A

uh No, that was too quick for me. One more time line.

B

35 through 43 is what we use to replace 63 through 64.

A

35 to 43 30 35.

B

To 43 the the describe yep yep yep, that would be so when we have other instances of this. This is basically you could just replace that gotcha yeah. That.

A

I'm aware of okay, I, don't know too much about the YouTube effective. Whatever we're too much is about potential tests now broken yeah. That would be. That would be excellent. Yeah.

B

A

B

If they're broken, like that's, actually a sign that they've they're probably legitimately broke like yeah, we should do that to see if there's some issues with the flag being off I, think that's the situation that we'd most likely run into um so yeah now I think we just want to move in the other describes, which should be good. I am yeah. Awesome I have to run to the restroom real fast I'll, be right back gotcha.

A

I'll I'll try I'll see what I can do.

A

That is some interesting news on a on a Friday. Are you used to live at streams? Do you have any questions on this awesome yeah.

C

Sounds like you've got some issues to make there. One more time sounds like you have some issues to create the.

A

uh To create the the what.

C

Like um to fix all of the problems, um because this is the same problem in a bunch of your Tech tests, right yeah.

A

Exactly um not what I worry about um is um fixing what we just spoke about, um we're probably easy, but um so this has just uncovered that we in in the initial test Suite, we are actually having a lot of blind spots.

A

um That's that's coming it and we'll we'll be seeing what.

C

Is happening, it's actually a really good opportunity for like um Community contribution Center, because this recording shows how to fix the problem yeah. So we could create the issues and then tag this recording and say all of these tests are broken. If you want help in writing it, you can look at this video, absolutely.

A

That's that's probably yeah yeah. We probably should do this um because it'll probably be the be uh hopefully Good, Enough tutorial for any community that you're really watching this now um to actually set this up and and see, see what's happening in there and yeah good news is this flag is not still Pro for quite a couple of months. I'm still, so that's a good thing.

A

So, let's try to get this thing fixed um describe. Marketing text has a stat has a set of flag to false, so I don't worry about this too much describe side.

A

This is what I added, and this is basically doing the exact same thing as a buff. So I don't care about this anymore, but I do care about the ldap. This is what we need to move and I'd argue the tech manager- and these are just helper functions, so how we, this is rubbish.

C

C

A

So that's this thing with copy and pasting huge code blocks. This will now hopefully be all green or otherwise I'll be pressing command c. A lot.

A

Yes, awesome, okay, so no no bad surprises in there I'm um thinking about the um what I, what I just said regarding the the need for refactoring um will probably be all right. This still needs to be done as we just displayed it, but um I'm just thinking about if all of those, if they're I don't expect any really bad things to be uncovered here, because we are already live with this thing on com and in the release and the feedback we're getting is not a minor.

A

So if there would be anything really really big in there, we probably would already know so. That's at least a little bit of a relief here.

C

That's good to know.

A

C

um It still works, there's just no test covered Sarah.

A

Fossil test coverage well.

C

A

um Yeah, just for for one side of the Boolean, that is basically what it is: yep um speed. Okay, that would be it I suppose this test is now fully reflected.

A

um Let me quickly skim through one time, but this is looking very, very good.

A

Awesome I, don't have anything more to add to this. So I don't know about you, but I am tempted to kind of kind of close this case. Do you have anything to Japan today.

C

um About 10 minutes, but uh I am a bit stuck on something. Maybe yes but that's for testing. It's a salon theme. Let's see it.

C

um Let me just make it share appropriate.

B

C

C

C

By roll is not a function.

A

um I think you do have some problems with your microphone I'm afraid! Oh sorry, better! If.

C

I move it closer.

A

A

uh It rather sounds like some technical.

C

Hello, um hey how's, it going yeah.

A

um Real quick for you Paul, so you're not fully fully confused um on in our spec land things that we can. We can create, uh managed to refactorize it um all green. So um thanks so much for the help that was nice and yeah. We're now on uh on some other tests, uh James just brought along nice.

B

Well, this is this has far too many parentheses for our spec.

C

Cool, so what I'm doing is uh so that my test is failing here, um I just added this to test it. I don't need it, um but this this should be so find alerts. Tab does wrapper.find, byroll, yep and I'm. Getting an error wrapper.find by roller is not a function, which is strange because in this described block it works perfectly fine here, where we're doing wrapper.find by roll.

A

C

And I I just can't okay can.

B

We jump the mount component.

B

Do we need to use the mount extender thing.

C

No uh I checked our docs and it says that it comes.

B

Oh, something happened to your mic: James they're, trying to cut you out.

C

All right, I'll use my system, Mike, okay,.

B

All right, um they were, like you said too much went to the doctor.

C

uh Yeah I'd say that um cello amount uh should be from view test. Utils um I can find me if you wanna, because I I use the same example from the docks.

B

C

So rapper is from: do you test for utils, either from Mount or map got.

B

C

Cool and you wrote that oh.

B

C

Hilarious, um uh oh also, it's working in this description yeah, but it's not working here.

B

That's weird: do we have any tests focused right now.

C

B

Do you mean folks, but you don't have you don't have only something yeah.

C

B

um So, let's try, if we put fit on line 109 instead of it.

C

B

What what happens.

C

um Like around the test again, is that what you want yeah.

B

Let's try that out: let's see what happens.

C

I'm in JavaScript, debug mode but I, don't think there's any uh breaks so.

B

One past and one skipped: oh because he.

C

uh Yeah there's two called this yeah yeah.

B

Can we jump to the amount component again.

B

B

Can you scroll up just so? Is there anything else on the terminal that we should scroll up to.

C

B

Information: okay, if you scroll down this, that's where it's failing, if you keep going down, um so what is that calls? Your update expected? Oh expect, an assertion it didn't even get to run for us to search okay, let's, let's inspect our wrapper, um can we can we, like console log, wrapper right before this one, maybe yep.

C

Yeah, we can also put a break point and that.

A

Might be yeah that might have been Thanks for reading my mind yeah, it is you'll, probably make things a lot easier.

B

Well, you know how helpful console debugging can be absolutely. Why not.

A

Do both since the 90s so.

C

Like rapper is.

C

I I, don't know why I can't like access this terminal. Like might.

B

Need to go to debugger.

C

Maybe, oh okay, cool great! So thanks so.

B

If we do wrapper.findroll, that's not working foreign.

B

uh Okay, you're saying the other one does work yeah, that's two! Well, it works here. All right. Can we we gotta, we got I gotta, it's not that I. Don't trust you, but I.

C

Gotta see it that's.

B

Can we um yeah, we can go ahead and keep playing or yeah get out of that and can we change the fit from 109.

C

And just that change exists to be false. Instead,.

B

Of trying to we'll have to move we'll have to move the fit or the 109 will be done when it gets run.

C

C

Yeah, so this this one should fail.

C

Assuming it's working properly.

C

um They're, both family.

B

Could this be? Could this have to do with.

C

B

All right that is helpful, that they're both failing.

C

Yeah but maybe it's the docs are wrong and you think you're.

B

Right extended, I, think you're, right, I think I think find my role, maybe used to be a thing.

C

What is it extended? Rapper.

C

B

You do a search for shallow mount extended, you'll see it.

C

Shallow man extended yep.

C

Yeah so, instead of showing my extended by using instead of shalomat by using Shadow, now shallow mount extended right.

B

C

Great morning, okay, cool so just need to update the docks.

B

C

B

Yeah, it's not, it does seem like it's not finding them so, but at least it's finding them trying.

C

Yeah, it's not finding that tab, because I changed it to purposely fail. Oh.

A

B

C

When you, it was running okay,.

B

Cool cool- um well, that was, you, might need to um I think what I'm also saying is, and we might not be able to use shallow mount extended and you might have to do the full Mount extended.

C

C

I don't think so, but.

C

I, don't think so, but I can solve that by myself. I was just stuck on this pit. Yeah.

B

Yeah, that's weird yeah: can you check out the docs like so what was the dog yeah and who wrote that.

C

B

That yeah, because we.

C

Don't use find boat roll very much and pathetic uh suggested a couple of times recently.

B

um Can you share your screen to yeah.

C

Sorry there you go it's just trying to uh yeah this. Is it.

B

hmm um I see so.

B

uh Interesting interesting, interesting, yeah, so I think maybe the best got updated um and they're just they're just got out of sync: oh but see it says rapper already says on line 2016.. So that comment is just confusing. We just don't need the comment on line 203.

C

uh uh Yeah yeah yeah, it might have just been that one line.

B

Yeah, okay, cool yeah: um if you want to open up a doc update to just remove that comment, um you can ping me and I'll be able to merge it um that'd be cool all right thanks thanks for bringing it up and finding the discrepancy in our docs. That's confusing! Sorry about that. Of course, I'll catch! You all later awesome.

C

um Yeah right um on so are the same before Paul uh I think this would be a really good opportunity to make some uh Community contribution issues um and Link this video to see how to fix it. Because yeah Nick said there was a bunch of these tests that are going to be failing.

B

C

B

C

Then, if we already have a really solid example of how to do it, if someone's looking for like how to get into aspect testing, it's a really good opportunity for that.

B

That's a great idea, yes about the rspec yeah. That's a great idea. I, like that idea, cool.

A

um Yeah I'll try to come up with some issues: ASAP and I'll ping. You on them James yeah,.

C

No worries open me if you want help with them or anything like that, guess.

C

Yeah, like everyone.