GitLab Pair Programming - Frontend, 4 Jun 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: FE Pairing - 20210604 - It's time to get Danger-esque!

Description

In this session we pair up on creating a Danger rule for a recently added job with a quirk. Here's the MR we worked on https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63234

A

Find another file that references them.

B

I started recording you, chad,.

A

So, did you hear that.

B

Yes, I was trying to see it like yeah. Do I need to add this to some sort of entry point um and I couldn't find anything like.

A

B

B

I have there's another crazy idea.

A

um So there's also a directory a top-level directory called, so these are all under danger and yours is under danger too.

B

It is under danger. Yes, let me let me check out this branch. Starter, css, yeah, okay,.

C

Can we know if there's a way to run this locally, or is this I just don't I don't know, I know.

D

There is, um let's see, break danger.

A

There's there's a danger rig.

D

Yeah, so if you do bin rake danger underscore local. uh However, I imagine you'd probably need to explicitly set this as a local reg task somewhere, but this is. This is going to be reading from like the mr title, so I don't think it's going to work. We'd have to stub out those things.

B

Maybe maybe that's okay. Maybe we can just throw them out real fast and see if it's even picking it up.

A

So the plugin that you've import danger files, so I found like, if you look at the uh top level danger file. You can see how it includes this.

A

That line five, that get live, danger files, which is a gem and in there you could see the there's import, plugins and import danger files which I clicked through to and.

B

What was the run local thing.

D

If you do bin slash rake and then new word danger, underscore local okay,.

B

B

D

I can't see where you're typing.

B

I'm sorry, I'm typing all the way down here and it's probably really small.

D

Oh, it's it's the zooms like toolbar, getting in the way, which is annoying. uh No, it's fine. I can see it now. It's gone away, uh yeah, so that should run it. The local tasks anyway,.

B

See what happens? Do you have to specify one as a local task? Is that a.

D

Yeah, let me have a quick look, let's see where that's.

B

B

It's taking some time.

B

I've noticed like if I run um left hook, it'll uh run danger locally. Is that what this is doing.

D

B

Oh only the following danger rules: how does it know that those danger rules.

D

So if you go to tooling slash danger, slash project helper.

D

E

D

List there, so if you add, presumably the name of your, what is it, what have you called it? um Startup css.

B

Yes, let's add that, let's see what happens like that, and it should blow up because it's like trying to do mrt, presumably yeah, um here's the other crazy idea. The idea is, if we make a change to a startup css file, we want to run both jobs, the as if foss job and the other job, rather than danger. We could try to solve this from the ci perspective, yeah, which, which I tried to do originally, um but failed.

A

So I don't think you can have this one run locally. First of all, because it's it's has to be run in the context of an mr, because there's no title to modify right.

B

Right, I'm just trying to see if it's even picking this thing up or like even running at all right now,.

D

B

I don't know I, but then I'd like to also see if the all changed files works. I don't know if that, if that is working, I don't know if that is that just change files. It also include added files.

B

I uh uh I clearly don't know what I'm doing.

C

I think, at the very least we.

D

C

Some logging to see, if we're even in this file and then maybe log, has startup css changes and just let the pipeline on that.

B

Yeah, it looks like we are in the file, which is cool, so that's working, oh you're, looking.

D

B

Sorry, yeah no you're good, so I wasn't here uh and I am in so I'm gonna say.

B

Start startup css danger file enter.

B

We've got changes.

A

So the all changed files like- I think that is that's only going to work in the context of an mr. I don't know what it does if it does local get or it has to compare some raft to another ref right.

D

I'm going to guess it's going to do like a get list, get changed files since merge base, so we might need to be on a branch.

B

A

Through to it and see what.

B

It does, oh, I think I oh no. I didn't find it. Oh, oh! No! I can't find it. I bet it's in our gym. Yeah, chad. It.

D

B

One nothing me on his ide game. Just click through to it, I'm trying to click chance.

E

Not do anything uh yeah.

D

Should we should we all upgrade to ruby mine.

A

Gonna, I'm gonna try to I'm gonna try to I'm gonna.

D

A

Yes, if you want to be as productive as you can be, while writing ruby. This is for.

B

A

I would say: I'm not.

B

Gonna say with.

A

Javascript I.

B

Can click through javascript? Don't, as you could be?

B

Don't start this on my javascript with mine.

A

I'm joking, so I'm like I'm trying to look for it. uh I'll change files.

C

The other thing I've done too, when working on danger files is that, if you don't want to run it locally, you can just edit the pipeline to only run the danger uh job and then at least the pipeline is pretty quick because it you still have to push in between the tests. But if we can't.

B

Get around the pipeline to only run danger. The pipeline can only run danger. Oh yeah, you have to edit the gitlab yaml. Oh let's do it. That's a great idea. I guess. What's.

C

B

Is about how how long this would all take, so how would I do that, where you mean.

D

Yeah, the gitlab ci file is huge. It's not broken out into multiple things, so I have no idea. I can't remember how I did it, but.

C

Yeah it's I did it once before, and it it's changed since then, but there is a way to do it. I think you can basically just yeah. I can't quite remember I.

B

Probably could just.

C

Get rid of all the includes or something.

B

Yeah yeah yeah yeah, I'm liking. This approach.

A

So it does look like uh there's a local implementation for that I'll change files underneath like it knows that it can run locally. I just can't find it.

D

And what does it do? Chad.

A

uh It recursively does diff for file, which is danger, file get plug-in, which is added files.

A

I just saw a reference to local. Does.

B

It include, um does it include, uh removed and added files.

A

Added files and modified files.

B

Yeah, so it includes all this stuff- okay, that's great, so yeah. I guess I guess we could try to try this out. I guess probably the issue, maybe was I wasn't adding this to the right entry point. Maybe I need to put in a ci when any rules or something is that I wasn't adding it- is that the issue yeah. That's.

D

True, there is feature flag there and ci only rules.

B

Okay, let me just add this, then that's probably all I need to do.

A

But I think you could add it do you want to run it locally all the time, um maybe.

B

I mean that, would I don't know the the: if we were going to run it locally, it would look different. We would need to.

B

Just somehow double check that both files have changed, um or I don't know- I really don't know, because the main output of this rule is.

B

We want to um warn or not warrant, we want to actually change the mr title to run both jobs when one is changing.

A

Right so the question is: does is that all changed files used in any other one? That is a local rule? If the answer is yes, then let's check that.

B

Out you should.

A

Be able to as well okay.

B

That's a good question: let's try that there's the rules all changed files.

B

uh Duplicate yarn is whoa, so maybe maybe the all change files has a different implementation. If it's a merger, class or local.

A

Yeah it does. I just confirmed that oh.

B

You rock chad, sorry, but I'm sorry, if I uh didn't.

A

What is the so? The tooling danger is the thing that danger project helpers. What has that.

A

The tooling and helpers like that has the list of for each one. This array you're, looking at on the right, that's tooling, danger project helper.

B

Yes, I think we could have it run in both because look here's a little thing, that's saying like helper, are we in ci, so we could do just a warning if we're not in seat like we'll, do a warning if we're not in ci or something um saying, hey, make sure you've you've looked at both. You want to do that.

D

I like it because this is going to be run by uh uh left hook, pre-push right same yep.

B

Yep, let's do it.

B

Okay, so this is all if we are in seattle, this whole updating the file, and I can do if.

B

B

Yeah else we just worn that's a thing. I can just warn like.

A

A

So yes, uh karma at least is in local rules and it uses all changed files and others.

B

A

So seems like you should be able to have this one as well cool yeah. I just.

B

Saw that in duplicate yarn dependencies too, and so I'm gonna, I'm I'm kind of using how they do something a little different in ci versus otherwise and that's uh I think, gonna be really sweet. So I'm adding it to both.

A

B

A

Finds the merge base and looks for changes basically and then the ci it does it via the api right.

B

Wait do I need to add this to both or do I or do I just add a ci rules, a super set of.

D

B

E

B

D

It's not quite like that right, like what, where is that you see? I only rule.

B

Oh you're, so right yeah right only ah yes. Yes, yes, so rule names, if we're in ci we're gonna run local and ci only. I was about to add it twice. Thank you. Okay, totally right, I'm just going to add it to the local rules, because we can run it locally, which is great.

B

Oh, if we're in ci. We do this thing. Warren.

B

That's the way the news goes, we'll see what happens.

D

Is that a rick and morty reference you bet it is.

B

I've been watching a lot of rick and morty uh for I've been having it on, while I'm like waiting for r, spec and stuff. So it's I, it kind of helps my productivity watching something. While I wait for things to look, it's better than me getting distracted, often something else anyways.

B

uh I want to change a file, so we can actually see if we've got here. So let me open up a style sheets. Startup thing.

A

I think you may need to commit it like it's actually doing like a ref log in a and a get diff against the identified merge base. So, okay.

D

So yeah you want to be in a branch as well, presumably not.

A

Just a branch and have a change committed on the branch.

B

Okay, let's, let's try it out, so you want me to to commit this one.

D

Right to a new branch, yet oh.

A

I am to a new, so you are in a branch right.

B

Yeah, of course, because this.

D

B

Mr branch, yeah yeah, just not on master, that's what was it right? Yes, okay change, startup, css to trigger danger.

A

Don't you already have that committed on there didn't I already see it. One.

B

I didn't pull it down, I'm just doing.

A

B

One okay: I know I'm lazy that was me using the web id to do that.

B

um Okay, so I'm gonna run this locally.

A

The worst thing about it is, it doesn't have a collapsible sidebar.

B

Couldn't it I couldn't agree more with you chat, that was that was chad's uh first thing. That was that the first deliverable tasks that you were working on and a gitlab yeah and it's and it still doesn't- have one chad quickly learned all of the uh um obstacles and our code base, specifically with the id and merge reviews. That's the way the new goes all right, so this is working. That's great!

B

um I just didn't add it to this thing, man. I thought I knew there'd be some sort of entry point. Okay, that's great! So now we just think of an actual warning for this right.

D

So in ci, what it's going to be doing is actually modifying the mr title. If, if it doesn't already have the necessary flag in it and also trigger a new pipeline, run.

B

Yes- and this is copied from- and maybe we want to abstract that while we're here, but this is copied from the feature flag, one uh which I'm assuming works. So that's an assumption.

B

Do we want to abstract this, or are we cool with duplicating it?.

D

Twice is fine in my opinion, for now, but let's get it working first right.

B

Sounds good to me, so um I have added it to here. That's the only change here and here's the danger file, I'm going to get rid of my puts. This is working.

B

And you're adding or removing a feature flag. Oh wait! That message is bad. uh You are changing. uh Startup css files.

B

The mr title needs to include run as a box. We may have updated on that before you to ensure everything is covered. That's beautiful!

B

That's copied over okay, an actual warning. You are changing start up css! Please.

B

Be please make sure to update and check both ce and e.

A

One thing to put on your to-do list: maybe whenever I do things like this, I also like to add the implementation of this file itself to the list of changed files, because then, if you don't have it exactly right and you change this file to do something different to fix the bug, you also want it to make sure that it runs.

A

D

Know, if that's true in this case, but this danger file.

A

Yeah exactly like.

D

A

A file that says check some other files, but then there's a bug in the logic to check the other files. You want to be able to commit a change to that file and then have it start doing the right thing because then you're like oh, I have to make another branch to do this other thing and do other stuff. I don't know if that's a pattern for these, but yeah, I think about that, would be interesting. I don't know.

B

If that so like.

A

If this failed, that's a good point, I don't know, but the fact that you can run it locally. I think eliminates the need for that. Okay,.

D

So, coming back to the the warning at the bottom, there um please make sure you update and check both c and e. Well, if you do push with these changes, you've made changes to startup css and you do push this very danger file is then, going to modify your mr to make sure that foss run as if foss is done.

D

E

So, in a sense, there's.

D

Nothing to do right.

B

D

For the committer.

B

I don't know I'd like to keep them on their toes.

B

Maybe um and that's a good, that's a good point, uh because because the reason why I I'd rather have this like multi-leveled, like we make sure we're having oversight here, uh is because this these api updates could fail and then we wouldn't be able to hold their hand and.

A

So I don't know: why is that outer? Why is that an else? Oh that's announced for line six okay, never mind. You can also write specs for these there's spec tooling,.

B

Oh yeah, don't don't uh danger, don't make me nervous?

B

Do you think this is good to push? Do you want to see what it does on ci or dude? Should I update this at all.

D

Have we made it only run danger in ci.

B

I was thinking of just cancelling jobs. It's going to let it try to do this thing. I was just going to cancel jobs like if you cancel the fixtures and stuff, then then the main test won't run danger, always runs pretty right away pretty quickly.

B

You know, maybe I don't know, let's see what happens. uh Wait for danger to run then cancel the pipeline um all right. I am going to push this as a fix up to this one.

B

Okay, let me go ahead and also uh rebase.

A

Can you bring the code up in one of those windows just to look at? Why you're doing this.

B

A

A

B

um Cool, I am going to double check because I'm beginning about to be a force, push and double check that nothing has been pushed here by anybody.

E

B

B

What do you all think of me sneaking in another change in this.

B

C

What change do you think.

B

So glad you asked nathan.

B

So I saw elsewhere in our um one of our shell scripts. I saw us do this interesting thing which is like? Oh, this looks like a multi-line line, string, that's great, but it like automatically trims all white space and like it doesn't look good when it outlines.

B

So I have a stash to just use echoes here and stuff. uh Do you think that would be a good thing to do on its own tomorrow or would you would you show me an answer here? Do you think that's I think it's small enough to.

C

I guess personally, I do it in a different, mr, but okay.

B

C

Makes sense I'm also.

B

C

B

I think it makes a lot of sense.

B

All right here we go, we have.

B

Major lives here.

B

I guess you know, I suppose we could do the we don't have to do the else with the warren we could just warn before we even hit to the. If, um like maybe we just always warn.

C

Does the warren get printed in the mr that block that danger? Does I think it does? That would be nice, it would be. It would be kind of nice to for them to know, because I remember when the feature flag, one started, everyone was asking in slack like. Why did my mr title get we'll get changed because that feature flag? One doesn't right, but I don't think.

B

Now that we're talking about it, I wonder if oh yeah we're not even oh yeah you're right.

D

All right, I'm gonna do this.

B

If you are on an ammo, we will try.

B

The ominous the ominous wii, the bot, referring to itself in the multiple pronouns.

B

All right danger is doing its thing.

A

Say they that would be even more ominous.

B

They'll do it for you, I'm totally going to.

B

uh Yeah, you didn't that's a that's interesting anyways, all right! This is taking a little longer than I was hoping, probably because we're running all these other jobs. Let me cancel some.

C

Jobs, I think canceling other jobs affects the speed of like the danger one.

B

This is, um I think this is pure, uh like uh taking snake oil, placebo bills, you're.

A

Saving like 0.003 cents, there.

D

Well, no, we are.

A

A full pipeline.

D

Is like the full pipeline is like eight dollars or something like that or fifteen dollars yeah with the aspect test, so canceling the early ones, which would make the later ones also get cancelled, we're saving real cash. There.

B

It's real, I'm.

C

Wondering if, if do we like rate limit on like per account like, if you only have one job running, will it run it faster than you have 80 jobs? Then I doubt it, but.

B

I have noticed gitlab ci is really fast, not on the gitlab project, like I'm, I'm always impressed with I push and like if I'm using pages, it's like odd. It deploys like almost immediately I like that. We've separated our heavy heavy, build runners like our heavy project from the rest of gitlab.com, because it's uh the rest of gitlab.com. So it's pretty nice.

A

Yeah, you can, uh I think, it's just based off of your runner pools and you can assign different things to different pools. So, whatever you have in the pool that will use.

B

This, oh then I can't oh no. How did I cancel this thing? What oh.

A

Just rerun that one, but.

B

I didn't cancel it. uh I've canceled one of it's the. How did I can't I didn't.

B

What I'm sorry guys.

A

I think you should just let it run.

B

I know I know I was really trying to.

B

B

Sorry about that.

A

So is our time collectively now worth more than eight dollars that we've.

B

Wasted yeah yeah everything in.

A

B

Even perspective I was, I was trying to save the company um eight dollars. I ended up spending eight more dollars trying to that's a. I don't know what happened. Yeah.

A

That's how I spent a good part of 2020, making the www.lab.com pipeline faster. Basically, that was the summer of 2020. For me,.

B

The summer of 2020., that's uh it's a it's a big deal. um Ours has gotten a little. I've noticed. Sometimes ours finishes sooner than I would think it would be.

A

Like 2019, there were periods where it it got to like 30 minutes and then we like chiseled it down, and I got it under 10 right before cool. They disbanded that and put me on the editor team. But now it's like creeping back up for some unknown reason, because I tried hard for months to get the right metrics, but yeah.

C

A

Got them so I don't know why it's speeding up again or slowing down again yeah.

A

I don't have the metrics for the individual job times and apparently they're really really hard to get so I never got them.

B

B

I've seen I've seen uh I've seen some charts for our pipeline jobs.

A

Yeah I've got charts but like to know why it's slowing down, I need to know on an individual job level which ones are getting slower like the whole thing is getting slower. I know I just don't know why. Oh that's what I'm saying I've seen individual job charts.

A

They may have the data for the main one, but not for www. Yes,.

B

Yep that makes sense. This reminds me.

B

I haven't checked out our just speed reporter in a while for measuring the speed of our jest tests.

B

This will be fun, there's so much to do with gitlab. If we ever have a pairing session, we're like I'm, not sure what to do uh remind me that this thing exists and there's always thanksgiving.

C

I see some of my tests on there. That's your fault check, those out.

B

There's a lot of ide tests on here so yeah. uh If it's slow, it just means you're testing something important. That's right!

B

um Yeah! All right is this thing still doing it. Oh, it succeeded uh what?

B

Yes, all right, dangerbot change the title. I think I think we're in.

D

Did it did it trigger a new pipeline.

B

Oh, let's see, let's take a question: uh I'm gonna recrush that I'm gonna say no.

B

D

Does it need to trigger any pipeline or does it it does, because I think the pipeline takes the mr title? Well, I don't know, actually- maybe I don't know when.

A

D

A

Like this, unless you explicitly do that, it's not going to because there wasn't a new commit yeah and we could oh wait but wait. It's doing both.

B

D

So but if you go to the danger file for the startup css, um the api post, that one yeah it's it's posting to pipelines, the pipelines api, which I think starts a new pipeline, or at least it's request to start a new pipeline. Let's, let's have a look at that.

B

I don't know, I don't know what happened.

D

What do you think.

A

D

A

Up css one surrender.

D

uh Danger, startup css slash, danger file. Why don't I see that okay? So if you post um according to this, if you post, which I think is what the script is doing, it's posting to project slash id slash pipeline. Oh no! It's not, though,.

A

What oh, what's the one that you copied from like this? Is yours right, startup, css, yes,.

B

The feature flag.

A

Okay, that's what I was trying to remember. I wanted to see that one.

B

I have, I have a crazy idea.

B

Maybe we don't need to um start a new pipeline because maybe we can just bail danger, we can update it, but then fail it and say we updated this for you, but you need to you need to restart the pipeline uh because we ran this and we noticed you didn't have this in the title.

A

But um you can do it like the future flag, one does it, but maybe it doesn't do it. I don't know like it. Does I'm looking at it well.

B

That's what I'm saying, but maybe maybe it's not working like maybe the feature that's where I copied this from, but it didn't work in our case.

A

You have the pipeline post in yours at the bottom. Yes, yes,.

D

Can I suggest that you actually execute that post yourself in curl or something like that and see what it does.

B

uh Yeah you're gonna ask me to share my my secrets. uh I think I'll have to be uh I'll I'll, try it out, though uh I'm gonna try it on a different terminal. uh Let's see if I can.

D

Do that, I wonder if clicking the run pipeline button does exactly that api request.

B

Yeah, I don't know, let me let me curl this, uh how do you make a post request in curl.

D

uh X post, I think.

B

D

Yeah post capitals- I don't know if it needs to be capitals actually, but.

B

I some memory is telling me it does not need to be captioned api with v4. That's how it works right.

D

B

D

D

uh In the chat, I've posted the the path you want. Oh it's just that, but yeah exactly.

B

So we are at merge requests. Oh, what merger quest is this.

B

We are at merge request.

B

Part of me thinks the safest thing to do would be to fail the pipeline, uh but maybe I don't know, maybe that's not the safest thing to do.

B

Do I want to do the id or the whole.

D

So you can actually I learned the other day. You can do just project parts. So if you do gitlab.org but then uh percent to f for slash and then gitlab there you go that should work yeah, okay,.

B

Is it because is it because of the post? How do I yeah.

D

I might have gotten.

B

That wrong, you need data in your post.

A

Or no it's just a post. I don't.

B

B

B

All right, it's unauthorized as we'd expect I'm gonna stop sharing my screen.

B

Oh um me, oh, do we have we don't have any in one password? Do we don't have like a the bots token? Do we? We don't do that anymore.

C

We did for a while.

B

But I don't know.

C

If we do that anymore, you can also generate a new project token. I suppose.

B

Okay, I was kind of hoping somebody else might have left there.

A

I I will I'll, send you one. No.

B

No, no, don't don't regenerate it. I trust.

A

You paul you're a very trustworthy guy. Oh.

B

Man put me on the spot: something's happened. Do.

D

You trust any of us there.

B

If something happens, chad you're gonna, you're gonna, be like. I.

D

Just had to rotate everything.

B

Remember that token you gave me or that token I gave you well yeah.

B

This is this, is this is how it goes down. You know, a friend of yours is like hey. I've got this suitcase. I trust you can you hold on to it. For me,.

C

Now could you use that token to create another token?

C

That's! Oh! No.

B

uh You're very nice, all right, I got it on slide, I'm still not sharing my screen, but I need to add: what's the um what is the x something yeah.

D

As in to add the header.

B

Yes, yes, yes, yes,.

B

Yeah, how do I add the header is that.

D

So what you want to do so um it's double dash header and then quotes private dash, token colon and then your token.

B

Okay, I can I can. um I could share my screen for a second, because I've I've cleared it out uh boom boom. Although part of me wonders if zoom is always looking at my screen, um double dash header.

D

And then in quotes and then it's basically a header format of private dash, token colon and then your token.

B

Okay, all right, I'm gonna stop sharing just in case.

A

I mean, since this is recorded, I'm totally gonna regenerate my token yeah.

B

And that's safe thing to do too yeah.

A

I would do that as well. I just did it yesterday because it expired.

B

Oh good idea, it.

A

B

B

It's it's hanging, it's really hanging, and maybe that's what's happened. Maybe we're not waiting for it. Oh, it worked.

D

Could do something.

A

Yeah, if it doesn't wait, then there's a possible race condition, because the mr title might not be updated. If that api call that you're doing to update the title doesn't block. Oh.

B

Yeah so that worked so I kind of wonder because the trigger.

D

Is chad, interestingly, so that's good.

B

um Chad, I don't know if I would label you as a trigger uh I'm joking.

A

I'm triggering for some people.

B

So I feel more comfortable with failing in ci if this does not exist. On the mr title, I I want to we'll update it, but I want it to fail like.

D

You know I want people to to know that this is a strong reason to look carefully at the mr and run a pipeline specifically for this.

B

Yeah, otherwise it's gonna break fast and, like that's, the thing is, it is going to break. That's what's been happening, is it'll break the foss, build.

B

uh So I I would like to we do, let's do the update, but we will fail on saying if you are updating startup css. Your mr has to include this.

B

The powers have tried to do it for you the end and we don't create a new pipeline. We let we let the the user figure that out.

C

I'm mostly just a word that the the process to trigger any pipeline won't work and then yes,.

B

And then and then it all still passed and it looks like it's good to go. um That would be the concern because there's there is some race conditions here, but also here's the other thing. If we run as if foss, if I've only changed ee and we run as a foss, it's gonna fail anyways because I haven't updated the ce one.

D

That's a good point.

D

Yeah, I think, failing let's just fail, let's check! That's.

A

Fine, but I just had a thought: maybe you can't run this locally because there's no idea of an mr title locally.

B

Right and so that's what we've done, I agree. So that's what why we're wrapping this and here and we're just doing a warning like if we're changing, startup css, please make sure to update both okay.

B

But what we'll do here is here if the titles oh- but this is so that will run locally. Okay, yes, but here if the titles are different, we're going to throw an error.

B

So the warning is always going to be there. But here if the titles are different, we're going to throw an error right.

A

B

A

B

I would put.

A

The air at the very end, and so it's not printed out and if this thing blows up for any reason, that's a good idea. So kill you don't need 24 anymore, we're not doing that 24! Oh yes, yes, yeah! Just do it here.

B

Do the whole thing again.

B

Or maybe we can just yeah, maybe we could do it here.

A

I mean you could do guard clauses right. You just do a dark clause on 14 and then you don't have to do you mean rather than doing three lines just.

B

Do it in one line.

A

Here you could say return unless new mr title right and then just have the rest of it.

B

Oh you're right because we don't need that yeah unless new mr title does not equal helper dot. Our title like.

A

That nothing to update, I mean, and I would take out the double negative. I would say, if equal, if double equal uh return, yeah mu.

B

A

Equal and then you don't need the check on 17. and.

B

I don't yes, yes, yes, yes or this one right, or even this thing. Oh yes,.

A

B

Or even this thing, I love it. Okay,.

A

I was going to mention that the triple nested conditionals before, but I was messed with your flow.

B

I know I I'm glad you brought it up. This is so much better. uh um How do I, how do I blow things up in danger? I feel like danger would be really good at this.

D

Surely you just write danger right. That would be the way to do it. I'd thought, but no, but it's not it's.

B

Probably error.

D

B

Die and I'm gonna look for the game.

B

uh Nope, not error, die, uh I mean, am I maybe I'm not, including all the danger files here? Oh did nathan have to hop up which one does actually blow.

A

Up, I see fail other places.

D

Fail, of course, the other trigger.

A

Fail is just an alias for race, but it's more semantically like it's, not a real exception. It's a it's. A control flow exception.

B

Right, I was trying to think: where does this fail? It's like. Oh, it feels like commit messages for sure self. That does it have to be self that fail. You think, is that a thing no.

A

Just fail: okay, I don't I see yourself that fail. I have no idea why that would be there. Okay, I don't know.

B

A

We're gonna fail with the message.

B

uh Startup help me out so.

B

When updating startup css files, it is required to check both ce.

B

Mr title must have run as a foss.

B

We've tried to do this.

A

Let's change line six like this, instead of a pronoun, can we say this danger check.

B

This danger check.

A

Yeah the same thing at the bottom, instead of weave.

B

Maybe we should think of a um a name for it, her name for danger. Is it danger bob danger bob tried to do this, for you.

B

Dangerous time to do this, I'm just gonna quite danger.

B

I liked it I like doing this. That's fine all right, um I'm gonna! Try! This again.

B

Are we cool with that.

D

Absolutely have you changed startup css files in this demo.

B

Yes, um which is what caused the original run, I'm canceling all the pipelines and I'm gonna undo my title. We could try the we could try the positive case. um Oh no, I don't want to retry.

A

uh That makes as soon as you do it I have another thought. Oh.

B

My gosh I get so click happy sometimes um do we want to remove the run as a foss here or do you want to try the the happy path or the blow up path.

A

We look at the code real quick. I.

B

A

There's a problem, maybe so really the title check should be. You shouldn't do the warn unless the.

A

Do we want to just do the warrant? You don't want to say the warrant if the title is already changed,.

B

Right yeah, so I'm going to do this just locally, so we'll do it. Oh my gosh, no idea what happened.

B

There we want to just do this.

B

And we could even we could. I mean we could do a return early kind of thing too. But what do you think of just warning locally when I'm running my left hook, things.

A

A

Yeah that makes sense. Okay. I I.

B

Like that, I think that that.

A

That should work, um and I would say, on online 21, make sure to update like instead of to update, I would say, add, run as if to the mr title.

D

Should the fail message and the one message be the same like is there any reason? I think.

B

When updating startup, css files make sure to update and check both ce and e, the mr title must have run as if fox I'm just gonna leave it like that.

D

uh You've got haste instead of have. Thank you.

A

So that the two update is to update what right that's, we can wordsmith it later, but I mean I'm just like.

E

I feel like delete.

A

It for now just say to check yep. I love you guys. I think the brevity is.

B

It is required to update uh that's that sounds like the messenger. The message I can see it's about uh jam stuff um all right. Let me commit this.

B

Okay, great, let me I'm going to go ahead and do the uh I won't I'll rebate.

B

It'll it'll automatically make it a draft. That's one of my least favorite. I would love, I can't wait. I know it's going to be solved and I can't wait for it to be solid gitlab.com. When you push a fix up, commit it won't automatically put it as draft that'll, be pretty sweet right now. It automatically puts it as draft and it gets a little annoying.

D

Would be really sweet is actually if you pushed fix up commits and they in as part of the push. Oh, no, that's that would ruin things actually no, never mind. I was going to say as part of the push it auto squashes it. I think.

B

That, maybe you add, like a mer like a push option to it, to do that. That'd be pretty sweet.

D

Yeah but then you'd need to pull immediately afterwards to.

B

But if that's what you're wanting to do like, maybe it's easier to just do all that uh I don't know so we're going to test the happy path uh we have this on it. um Let me mark as ready.

B

So this this comes at a good time, because uh this- I I woke up this morning to fast breaking because because of this, uh which is unfortunate, so this is going to be really sweet. I'm glad that we're able to get this on while the pie plane is running, I it might be. Do you think it'd be interesting to to share the extractor stuff that that you and I ran into, and then we ran into it again mark.

D

Can you say that again, I didn't quite understand.

B

So since this thing launched uh it's, it's failed a couple of times as kind of expected, um but since it launched there's a couple of things that are hardening it quite significantly, so that it should be safe or or at least a lot stronger and less fragile and one significant change has to do with the uh startup css.

B

The html extractor, I don't know where it went. Oh my gosh.

D

um Yeah, natalia merged it earlier today right.

B

D

That no, that was something.

B

But previously I'll just open it up over here.

B

um Previously we just used- and you left a really good question- do we even need this? Previously? We just used this extractor, which takes a file, and it's just gonna look for words, which are this combination of characters, dashes lowercase, word letters and exclamation marks.

B

um This was a gross oversight on my part, where clearly, more words than are needed are there, which I thought well, that's negligible. Let's be fine, but also it's non-deterministic. What words uh can be there and one of them was like. We have a nonce that that gets generated in our fixtures and then included some characters like sometimes it would just include the the letter p and it meant we're getting the paragraph tag, and that was.

D

B

So that was that was really disappointing, but this is the solution. We probably don't need this. I just left it in here, but I don't know.

D

um Yeah as long as it's not like the supe, the union of those two things.

B

Yes- and it is not okay- and I I left it in there because we could like I didn't- we can't just throw viewfind- we could throw whatever files we want to at this time, and I I wanted to leave that intact if we wanted to, um but I don't know, I really don't know so,.

B

um This has been wildly helpful because I clearly did no idea what I was doing, I'm so glad we were all able to collaborate on it and implementation time. I think the result is a very nice developer experience and is going to help solve issues.

B

I've gotta hop off in one minute.

B

Is it gonna? Is it gonna? Do it in one minute? I doubt it well see. We expect this one to pass, which would be really sweet if it always fails. That would be that.

D

It would pass because the mr title has uh run as if us.

B

B

um The other crazy idea that I had was.

B

And I'd like to know what you think of this.

B

The other crazy idea that I had was.

B

What if so, these these ci jobs have rules, meaning they only run under certain changes um or other kind of conditions? um So what if, when we ran um for this one, the startup css check as its foss we're using this default front-end jobs.

B

But what if we added to the condition- and let me show it to you what what that condition looks like what, if we created a new condition or something and added to it,.

B

Like here, we're saying run these as if foss jobs, if we have the as if in the title, if we have run all if we're just on a regular merge request, only run it on these changes, and so, if, since we're all just concerned about changes, what if we said, only run it on the ci pattern or like the startup changes, you know what I'm saying like what, if we had it changes, ci pattern, plus startup changes or something you know.

D

What you also need to do on css changes.

B

uh um So this is just as a foster just as a foster, so it is a two-step, like you know what I mean.

D

Yeah so yeah, so you probably need to extend this job with that additional change, because you don't want to run all the front-end jobs.

B

D

B

Just this one, but here's here's a challenge: here's one of the reasons why this had to get reverted earlier earlier. We had specific rules for these jobs, but the rule for this one was too lenient was more lenient than its requirement. Its requirement.

B

This one follows the same rule. There's our spec front-end fixtures as a foss thing right. So if we do it, we'd have to keep an eye out for like the parents of what what their rule set is and um but it would be sweet like it'd, be all baked into ci like we wouldn't have to do this whole danger, but um I think danger is a nice solution. Right now. This would definitely complicate what's already pretty complicated.

D

Yeah still, um how did that go? It failed, oh, no, for a wrong way, not the other failure.

B

But I'm going to treat it as that, um so yeah, I've, gotta I've gotta hop off. I'm gonna! Try it both ways: um I'll ping, you all that that hopped on on this mmr and then hopefully we can get it merged and figured out so good stuff. Thank you paul. Thank you mark. Thank you, yannick for for hopping on and everyone else that I had to hop off I'll catch you all later. Bye speed have a good one.