GitLab Pair Programming - Frontend, 17 Jul 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Pair Programming - Testing if a MR revert fixes an issue

Description

Revert MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37131
Feature spec MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37136

A

Okay, um let me close some tabs and let me try to find my issue. Oh, that didn't work out trying to close tabs. Now, I'm sharing my slack screen. Oh okay, uh I'm trying to go to can't nope! That's how you spell it. What is it called? Auto? Complete? Yes, it says yes, so here's the issue can't select comment, auto-complete suggestions with keyboard, so if you're here you start typing something and I'm trying to you see, oh, you should do enter and then yeah yeah really frustrating.

A

um Oh because I like really depend on this without really yeah.

B

So I I don't know if this is related, um but just for context.

B

Something recently went in where, if you like highlight a word and then you surround it with backticks quote like single quote: double quote: parentheses brackets think that was it it'll wrap yeah and I don't know if an enter thing might have got caught in there. I've noticed this.

A

New behavior, do you happen to know, have the mr for that or yeah one second yeah. If you could share the mr to it, uh maybe we can just.

B

This I'm, I am probably like 90 sure, that's not it, but it's something that was touched recently in the uh yeah.

A

That kind of thing, though, is I was trying to look through just lists of mrs to see what could have possibly introduced something like this and I'm kind of thinking. It may have to do with our underlying library that we use for this container stuff, because I just.

B

A

I wasn't able to find anything that really stuck out to me and I tried pinging on slack, see if anybody's seen anything and um so, but I think I'm gonna. I think I'm gonna check out master and work off of that or I'm not in a good repository right now.

C

D

But yeah what I was or the what I was kind of thinking was it had to do with like like missing, like key down event handler or a keydown event handler. That's getting blocked um because it seems like none of the keydown events are working like enter up and down, um I know and then yeah. So then I was looking at like there. There's like the shortcut plug-in that we use- and I was trying to see if like there, are any shortcuts that were recently added, because I thought maybe that'd be an idea.

D

But I didn't really get anywhere.

A

Yeah there was there's one change to that file that had to do with like the way we load emojis that I noticed and I tried like reverting those commits and seeing if it fixed, um and I was still able to recreate the issue with those commits reverted, so um I'm really at a loss, which is why hey scott's like it could be this, mr I'm like yeah yeah. Definitely I hope.

B

It's that more.

A

B

Paul, I just liked it to you. Okay, um the only reason I know about it is because I reviewed it, so this is 100 my fault.

A

It's your fault. If that is the case, yeah.

E

B

But I get these weird, like one-off behaviors, like this and in other parts of that location, that I then I can't reproduce and I'm like ah that. That's definitely like it's breaking my workflow and then I can't seem to get it back and it's like everything has to be. Can.

A

Can you ping it, um can you add.

B

A

The front end pairs thread that we're on sure.

A

um Let me see if I got the gdk doing its thing. um Oh, I got my.

A

Ip addresses showing up.

A

Oh, it's doing some database migrating. While that's going, let's check out this merger class okay, we got big text little text. Okay, all.

B

Right, oh, it's like it's uh add markdown listeners. So here's the listener on key down and then it's evaluating.

F

B

A

A

That'll do it. This is what I was looking for, because that's going to turn it off for all.

B

This wait. Wait, oh my god! Oh no,.

A

Let's, uh let's, let's try to recreate it fix it scott I am so freaking glad you were on this call. Providing value is my middle name.

A

We're going to talk about.

E

That we're going to totally spend this story as well.

A

Maybe we should stop recording.

A

This you, you could really get like a um there's, a psychological term for it. I don't know it, but it's like a superhero complex, where you like, create the issues that everyone.

B

E

Yeah yeah yeah yeah come in and solve.

A

It that's kind of what's happening here.

A

Now you're just.

B

A

B

A

Oh gosh, that really might be it. Oh, okay, let's see my heart is.

E

um Yeah, I didn't even think that that removed mark down yeah.

A

I didn't even think that yeah and that's that's is a really tough thing, and so this is, I think, what's hard, though, is that this isn't all the time? um So when does windows remove markdown listeners happen?

A

That's a great point not entirely sure.

B

Yeah, well, I mean remove it's in geo forms when clear event. Listeners is called. So when you oh, what is this called on? Destroy yeah.

A

I'm gonna check it out over here, so remove markdown centers gl form yeah, clearer than listeners.

B

It's on destroy but when's destroyed, being called.

A

Oh here it is oh there it is wait before we start, that's never mind, that's not it. um I guess this is something that's called by people that import it. um So we can check out. When do we import geoform.

A

A

I'm going to do um gl form, destroy here's one on notes. Remove discussion, note form called the response to.

B

Cancel on a different note: oh.

B

So if you toggle between like a discussion and a note, would that do it and that's probably why it's not reproducible.

A

Like like it's a little flaky that that might that might have to do it, um it could also be here's another interesting thing. That's happening with these listeners. You notice this is using jquery to select everything and it's selecting every markdown area. That's currently there, which means, if I haven't like expanded the discussion or if I haven't, opened up the diffs or something yet like that's not.

B

Going to be there yet.

A

um And then we also, I notice. We also then call it on like destroy here and that's going to happen like if I do a collapse of yeah.

B

A

All right, I'm you said you're 90 certain. This isn't I think I'm 90 certain this isn't. But, let's find out, um I shouldn't have said that.

A

Oh gosh, I'm so um I cannot express this like. I was really worried about this and I was going to add console logs everywhere and it was gonna be really ugly. Oh plus one for transparency.

A

uh This is good and here's the cool thing, though we dog food, our product, so we caught it first like don't feel, don't don't feel really bad.

B

A

Yeah, hopefully we catch it and we can get emerged before the.

A

A

Cool, when was this merged.

C

Say you one to one and a half weeks ago, oh yeah this'll do it this. Is it.

A

Yeah that those um listeners we should have like an a we need to probably have a linter, and that may be, if you know, if we have some time well, we can spend the rest of our time being doing something productive. um Besides fixing this issue, obviously uh we should probably lent any time you do. A global off.

B

Yeah, that's really that's really scary.

A

um Because of these kind of things, let's check it out- let's, let's not that might this might not be it.

B

After all, the hype better, be it.

A

I know after I know all of this we're like oh and then it's not yeah yeah yeah, just how funny.

B

A

Back to the console logs, um so I'm going to do something crazy too. I want to add some console logs to that slice. um This is here right.

A

Yes, so I'm going to add some console logs to here, um just to double check. What's happening and whatnot.

A

So and add markdown listeners.

G

A

Okay, I'm gonna open up: oh gosh, oh no, okay, I'm gonna pretend I didn't see anything.

A

There I think that was because we were reloading something I don't know.

A

What happened here? Why am I here? Okay, let's go to this random merge request. It has a coffin on it.

A

Oh, is that an avocado? No, I think it is a coffin. Okay, all right! So here we go yeah here I am trying to test what is going on here. Oh no, all right! That's a different issue.

A

Well, I I think I know what I'm going to do next.

A

So here we've done some yeah. This is really annoying. uh We've done.

B

A

Hello world great, I'm adding this comment.

A

We have now removed markdown and then now you can't do it. Oh, no! It's working, but.

B

Why wait wait? Wait? Do the do the name search just so we're like consistent, because the emoji search could be different right. Your example in the issue is name.

D

B

I just don't want to. I want to make sure we're on the same page.

A

No that's working for me gosh! I don't know what these errors are. That's, okay, all right! Let's try to figure that out um yeah! These are all working for me. uh Gosh with those errors. That's.

B

D

Past that I know it's really distracting. Let me uh let me go. You haven't removed that you didn't remove that off statement. Yet, though, did you.

A

No, I don't no. No, I have not I'm now trying to see is this: even this is a markdown area. Okay, and we are setting off.

E

Yeah, I guess that's like you, said: let's try and reproduce that, because.

A

I come back here: it's not working now: okay, okay, that's interesting!

A

B

Maybe maybe all of the to remove listeners.

E

Okay filter something here: okay, just.

A

So we're not yeah, so here's here's one way. I was able to do it and I think it has to do like when we do the destroy callback. For some of these, um I want to be able to reproduce it consistently uh so that we're guaranteed, we know what's happening so we've called remove. Markdown listeners add map markdown listeners. It would probably be nice to also include like how many markdown areas it's finding there, um but here I am about to do this thing, hello, all right. All that works. Oh, I don't.

A

What are you doing? Why is it just jump into pages?

A

Sorry, I don't mean to be so frustrated.

A

All right here I am I'm jumping back to here.

A

This should work yeah. This works great if I come back, nothing's destroyed, yet I come back. This is all working. Okay, so that's not happening. I haven't run remove markdown listeners yet, but what if I start doing? Okay, now we just re-added markdown listeners for everybody again, if I start and cancel.

A

E

A

So that's also weird right like why so here's what I think is happening. It is weird at first and the reason it when it works it's because this pop-up hasn't been created. Yet so those listeners haven't been created. Yet, oh after the pop-up's been created, then we remove listeners now.

B

A

Pop-Up listener is gone, that's what I think is happening. uh So, let's try to create a test script that actually 100 reproduces it and I think.

E

So that that listener.

B

I had markdown listeners, so that's doing them on all markdown boxes right so it'll. Do it twice yeah exactly so. That's that's not ideal. Either. Probably.

A

Gonna, I'm probably gonna suggest we revert the uml okay um yeah uh all right, so this works. I've got and I've got. The suggestion. Thing is now created, but I come back to here and I say: whoops cancel.

A

Nothing's working, that's it the the suggestion thing has to be created and then an event that triggers remove without adding them again um and that's gonna happen. If I do cancel or something um or.

E

On certain kind of destroy events or something it looks like, but are we sure are we sure that that mr is the cause of this? Like you mean.

A

This is a really yes you're asking a really good question. Now, let's I was going to let's just revert the mr locally and see if that actually fixes it. Okay, okay, but does this test script sound like it's reliable.

B

um I am yeah, so if this doesn't, if this doesn't work, then we need to write the test, get bisect and then magic.

A

Yeah yeah: um let's, let's hope it doesn't come to that.

A

B

A

I have changes, it's not gonna, like um so I'll stash those I'm gonna revert. This commit great.

A

Okay, maybe I can also then re-add my my stuff by going up.

A

Oh well, okay, it doesn't like that.

E

A

Does that look right to you all.

G

C

A

All right, so we got, we got the listeners back. I've just reverted commit, I shouldn't have to refresh the gdk or anything you don't okay, so this ends up fixing it you're, not gonna, call foul or I'm I'm joking scott. I'm sorry! I'm.

C

Picking on you now I'll, just tell you it's a red herring. We should go back to the running board. Oh.

B

Yeah was this happening to you in issues and merge requests yeah, probably.

A

I only observed it on merger quests and I think it's because we do more of this comment, destroying.

B

A

On issues, um but I think it's possible, it can happen in issues as well uh yeah. It's the same notes, component yeah.

A

Vanilla javascript man.

C

That's tough. This.

B

Is such a such a like a weird test case too, but now we know.

A

Yeah, so it would be, it would be really smart to probably write a um a feature spec for this. We could. We could spend some time doing that. If you all are it's probably a good idea.

B

Yeah, just I mean like eventually we'll probably remove these javascript or like the jquery listeners, so it'll be good to have that, for when we um remove them.

A

A

Oh gosh, it's taking so long. Is it because.

C

It's I think, it's because you're sharing your stream.

A

Oh, is that why.

B

Yeah, I think so.

A

That's slow! Oh now, I'm getting some errors terminated with exception.

D

You might have to like reinstall your dependencies and do gdk restart because you well, I guess actually, maybe not. That would make sense yeah. I didn't think it was.

A

A whole, I didn't think I reverted a whole lot, but I might need to just reverted one commit so it's taken a while. So I'll go ahead and do all of this um which does bring while this is going. Maybe we can also investigate. What's going on that position thing.

B

Oh, but it's oh uh hold on.

D

One second: it was like this yeah, I'm interested to see after you refresh your gdk. If that still is there yeah.

B

I just did the same things.

D

B

Did the same thing and wait for pictures, I'm not getting these errors anymore, you're, not getting here. No! Okay, that's not an issue, that's not an mr! It could be wrong hold on. Let me do it anymore.

A

Scott, I'm I'm I'm so glad that you were here and saw this. I would not me too yeah. This is this was really helpful and this is a win like. I think I think we caught this before it hits customers machines, that's the gold, so yeah. I can't reproduce those errors on an mri issue. So I'm not too sure. What's going on the discussion position, oh.

B

Oh never mind: oh man, especially.

A

All over the place.

B

I suppose you should yeah it's. um You have to open a discussion, it's not a comment.

B

E

A

B

Here we go this.

A

E

B

I'll take care of it. Oh you rock scott, like yeah. Oh, don't worry about it. I'll! Take care of this yeah we're already we're already fixing this. The issue on an issue, which is what plan is also so I'll go. Do the errors.

A

So I'm going to add some.

A

I'm adding some comments here, just emphasizing that this is the new scrubs.

B

If we do regret that, mr like, I would like to reopen it, though, because they think it's super useful and it will only take a few weeks. um Yeah.

C

I think that's a good.

A

A

The reason I would want to revert it is because it is doing this global, selecting thing sure.

B

Sure yeah, I don't disagree.

A

Yeah, no, okay, that's and I'm just like that's a.

A

Between the lines of trivial and non-trivial problems, I'm like I, no, I completely.

B

Understand yeah yeah um I've just like I've, I've made mrs broke something and then reverted it and I just like never got back to it. You know.

D

um I know so I just want to make sure.

B

That, like we at least reopen it and identify what we can do.

A

So I have this thing: this utility I use, I call curl weight, get lab. um It just keeps peeing in gitlab until it's ready.

B

You should give like, in.

A

Yeah, oh, oh! No! Something weird is something weird happening. Oh wait! Oh, what the moses!

A

D

Think it's yeah, it's just. I think you might have to do yarn install to update your dependencies.

A

Yeah so part of my script does that too? um I have this.

D

A

Gdk refresh script: oh okay, huh okay, then I think it's working.

A

Now it's so helpful for me to um to think out loud with others. I really appreciate you all hopping on this pairing session. Oh yeah,.

B

I'll get you a a rubber duck that you can put on your desk with her faces on it, I'm so glad you brought this up.

A

C

Did you get one.

A

With my daughters, uh I'm working on this, um this robot- oh cool- um maybe I should have it boot up, uh show it off while we're doing this, um it is basically going to be a rubber duck for me. uh You hit it and it says something random. That's all it does.

B

Just just like program it to like, say like inquisitive or like thoughtful questions, right yeah. I, like that. Did you check your gdk.

A

Are you sure about that? That's a really good call! Okay, so we're here now all right ready to go um and our script was hello. We create this keys are working okay. I come here to do something: whoops cancel we removed it.

A

Key is still working.

A

This is I'm happy, I'm happy and not happy.

A

That makes sense, though I think this is it okay, all right. So, let's, let's do the reversion. um Oh here we go. I'm.

G

A

Yeah she's she's, oh.

E

A

That scared me yeah, so do you think we should revert the mr.

B

I don't like that.

A

G

A

Yeah all right cool, oh this is helpful. um Yeah, I'm gonna create that mr revert. Do you guys have any other things you think might be cool to tackle or you feel like this is a productive use of time. Yeah.

B

A

Very productive, you're.

E

A

That discussion position stuff and do you have a good idea of what that might be.

B

It was also on merge.

A

Requests so it's a create thing too well, let me see hold on hold on.

B

No it's on issues as well um I'll handle it talk about it. Sweet.

D

B

Feel free to ping me as the maintainer is that.

D

B

Blocking you know it's not blocking um making this. No, no, okay, yeah, it's just an error, but it's not blocking naming the or making a discussion or anything so I'll. Go. Take care of that. But um thank you for hopping on.

A

Yeah, um if you guys have a little bit of time, we couldn't pair on um writing a feature spec for this, um like I don't really know what that would look like and because we'd have to send like keyboard events and stuff. If you think that's interesting or I don't know what your guys time availability is, I have to run okay.

B

um Cool but I will watch the recording.

A

All right, no, um are you um are you? Do you have some time peter? Are you um yeah all right all right, I'll uh work on writing a future spec for this or cool? Do you want to do you want to drive or I could drive it or uh we.

D

Can try to uh you can drive all right see you later.

A

Scott thanks.

F

D

Oh yeah, you can drive you're already driving okay.

A

Let me go ahead and create this revert um and let the pipeline run. In that thing, uh I'm.

D

Still like uh pretty new to our spec and stuff, so me too be cool to write some feature specs for this.

A

Yeah uh yeah it's! It can be um a bit of a challenge, but um it's actually like super helpful uh yeah. Definitely so I think one of the things that'll be difficult would be sending like keyboard events and getting it getting that information like I'm, not entirely sure how to do that. But maybe we can spend just a little bit of time figuring out. I don't think we'll end up solving all of it, but it'll definitely be learning together.

D

um Yeah, I know you can do um page dot, send keys or something like that in our spec, I think, or in capybara or whatever. Yes, um that is super helpful. So, let's the only reason I know that is because I was just messing around with like a qa spec end-to-end test earlier, oh nice.

D

Oh look at this.

A

All right, I'm going to close my door real fast. Look at this. We've got some feature specs for this. Already it's not rocks um see. These are like just ee stuff. I don't know. Oh wait. Here's one.

D

A

There's probably a.

D

I think there's like ee specific okay, auto completes. Oh, this is like testing some xss stuff.

A

Hopefully, I'm not reviewing.

A

Sorry! Sorry about that.

A

A

So I kind of really want to see one for oh yeah see, there's a send keys right there. Oh, where do you see it.

D

uh Where your cursor is right now.

A

Oh awesome, that's super helpful cool uh yeah, so I wonder if we could do one for merging quests, because that's the one like I've really seen this yeah definitely.

A

I don't think I see it so much by now, um or I don't see one for merger quest. Maybe we could do it for issues um what's consistently caused. It was starting to type getting it to create um locally on the main comment box, but then commenting on a discussion um do you? Do you think that there's any are there any areas that we create discussions.

A

All right, let me just create something like over here at the bottom, for.

A

um Oh gosh, there's so much here: okay, here's like testing assignees. All right, I'm going to create one for contacts. um We want to test.

A

D

Maybe sure what so, what file are we in right now? Oh okay, we're in the auto complete gfm, auto, complete spec.

A

For issues yeah.

D

A

That makes sense we should be able to test the same thing as long as.

A

We have a discussion to comment.

A

So, but what I'm not sure about is how do I create a discussion in our spec land.

D

D

If you maybe look at like through the factories for like uh factories, slash discussion or something oh yeah, factories.

D

A

Discussion, note: oh nice cool, that's I think that's it. So I think I didn't. Let me see if I can find a um example. That's doing that uh discussion. Note on issue cool nice.

F

Yes, but I guess it uses the same thing so, oh yeah, it's probably, I think it's all the same.

A

Do you think it's actually going to create a whole discussion.

D

Can you go back to that factory, see what it does.

A

I should have left that.

F

Open discussion note class discussion note so.

D

I don't know, I really know what that means. Honestly yeah, I don't really know what it means either. um I guess I mean I guess we can just we can always like. Have it open up the browser and see if it's.

F

D

A

Yeah, so I'm gonna do that it works.

A

And then you do live debug. I guess.

D

Yeah you can do that yeah also.

A

We got to make sure those variables.

D

Exist like issue and issue.project in the in here.

F

Issue in projects.

A

I guess gosh, this is huge. Oh, I lost my place.

A

Okay, I'm looking for works all right. I.

F

Mean it's like.

A

That'll kind of work, but I want to visit instead of ischio signee, which seems like a special kind of issue. I guess.

E

I just want to visit the regular issue.

A

D

Yeah, let's see.

A

Okay, cool um and they're doing they're finding stuff by their ids, and I guess we could kind of do the same thing. That'd be cool, um but let's just run this uh yeah, let's just see if it like does anything first have we already talked about spring before?

A

No, I don't know what that is. um It makes r expect a lot faster, um so I guess normally r spec has to read all the ruby files from disc. Like I I get. I might not be right here. um I think that's what it says, but spring creates some sort of spring loader server. That like makes that whole process of loading some of these files a lot faster. um Yes, that's mine, but because it does like some caching stuff.

A

uh Sometimes its behavior can be weird. So you may want to just be careful about that, um but it does make things faster.

D

Nice yeah, that's right, rerunning the test when you're trying to write r, spec and you're kind of a noob is takes so long. Oh yeah.

A

And yeah it takes a long time, especially like having this startup the life. Oh wait. Instead of running the whole thing, I really should just run just that one bit: oh no gosh yeah! This is a huge file. Okay, all right!

A

um I think you can do 648 like that. Oh nice, I say see it's last one. It was like booting up the spring loader and now it's like using the same spring process for doing something. I'm not entirely.

A

A

uh While that's loading, I was gonna type, this out.

A

G

A

Smr has some issues: uh smr reverts.

A

um I lost that.

E

Mri that it.

A

Referred uh all right, this is still starting up um this, mr reverts. Here it is.

A

Inadvertently introduced.

A

Disables the um reward handling I will complete.

A

Suggestions um I'll include some screenshots later and I don't think we need to change log or anything like that. So I'm just going to delete this.

A

Oh, this one is.

A

That's still running.

A

A

A

A

Just found the cause and for this and created.

G

E

We're ready to go now.

A

Finally, jeez all right, someone special I'm someone special now I guess and that's.

D

Different than the last time I used live development.

A

Okay, here we are, and it created a discussion all right- we're ready to go.

E

To us, so what was our.

A

What was our script again? Our script was start writing into here, yeah colon I want to send. I think I want to send the keys right.

D

Yeah, you might be able to do like type, there might be like a capybara typing command or something.

A

Okay, let's check that out, um but it looks like this is note body. So that's how it's doing this thing.

D

Yeah, nice, oh yeah. I guess actually that's a pretty good example right there. That's what it's doing! Yeah.

A

Find notebody within what is it saying here? What is this timeline content form? What is timeline content form?

A

Why does it have to do that instead of nobody? Oh that's. This whole thing within timeline, content form that was really weird for it. To put that, I don't understand why I would wrap that I'm sure there's a good reason to it. I don't know, but I guess.

F

A

F

A

Oh, but this makes sense I can now I can just send these keys okay cool, so I'm going to find no body, let's see if this works, fine, nobody.

A

I guess I'm, I guess, I'm looking for.

C

Hello yeah, like.

A

That sure yeah makes sense. What is what is going on here? Oh, it's wait. This is waiting for that to show up okay, okay, okay, because it'll do some loading stuff. um So I'm.

E

A

A

Is there text here? Oh.

A

A

I guess I can just wait for the 100 to show up.

A

um Does that make sense? Why are we doing a find without like um yeah, okay and then oh, so I can actually just copy one of these like this is doing the whole.

D

Yeah, so I was just thinking it's like that's pretty much exactly what we wanted to do.

A

Okay, so that's interesting, so why am I recreating one?

A

I guess I want to rerun this right after.

D

I want to re-run, so we can always like refactor it into once. We get it working. Okay, that's that's a combined test. That's that's! A really good call.

D

I don't know that's how I usually do is just copy paste first and then refactor yeah. That's a really good.

A

When I'm a little bit.

D

Shaky I'm like what I need to do.

A

Yeah, that makes sense so, but here we first the first step to this is uh load the add who, but then we want to um cancel a different note right.

D

Yeah or even just leave a comment I think was working for me, but yeah.

A

Okay, so I guess.

D

A

This add a reply. Button click button. Add a reply.

A

Do you think that'll work.

D

I can't remember how quick button works, but it sounds good to.

A

Me or maybe I have to do reply, dot, dot, dot, I'll, do reply, dot dot. uh Is that an actual ellipsis or dots? It's a dots? Okay. I clicked the button.

A

And then I want to.

A

Oh, this is note note: do we get multiple ids when we do this.

A

Maybe so I guess I want to go to uh note one. Oh no. I guess I want to go to I'm trying to figure out. How do I select this thing.

D

Yeah, maybe no no, that works.

G

For me, no nope.

G

G

Then, with the note note.

A

I want to yeah it's probably we'll have to do some refactoring after this.

A

I guess I want to do native, send keys.

A

Oh yeah, I was saying whoops and then I hit cancel click button.

A

Cancel and then.

A

I want to go back to the note and I want to clear it out. um I don't know how to do that.

D

um I've actually seen- I actually saw this done in a test that I was looking at recently.

A

You think I could do like that value equals empty or something that's worth. The show.

D

You might be able to do that, but you can also do it with like send keys and do like command a and then hit backspace.

A

Okay, but that seems like a little crazy yeah that it yeah that'd be interesting.

D

But I was like this is what I saw in like an end-to-end test yeah, um but yeah you might feel well is yeah. I guess note is like a dom node as a variable. Now you can try value equals. Let's try it so.

A

Then I want to wait for the 100 to show up again.

A

But then I should do this thing.

A

Right or send keys enter.

A

And then I would expect note dot.

A

To have, I don't know value, I guess that's the thing to have. Maybe maybe I can just do text to have text hello.

A

D

That should be it right. uh It'll probably work on the first try.

A

That's that's been my experience with capybara so far. I think he might have forgot the live. Debug, though, did I I.

D

Mean I guess we can just see if it works, but I yeah it's.

A

Kind of nice to see it in the browser yeah, it's kind of, let's just see if it works and then undo my revert and then see if it fails um but yeah. I have to see that's the thing. I know that there's a way to like open in the browser without and run the script on it I haven't. I don't know how to do that. um Do you know what I'm.

D

Saying I do like uh chrome headless, you can set like a chrome headless variable, yeah that'd be really cool. I don't know how to do that. um Let me see like it's somewhere in the docks. I always have to find it.

D

F

D

A

Wow got some stuff.

A

Undefined method value: okay, all right: I need to figure out copybara clear.

E

D

Yeah, so you can just add: a variable chrome headless equals zero. If you want to like run it. Oh cool in the browser, that's really helpful.

A

Oh, I can see the errors. Okay, yeah value is not going to work and it's because it's filling, I guess, fill and note, and I guess you don't need parentheses and ruby.

D

Yeah, those always confused me.

A

D

A

Confusing um it's that's almost as confusing as not needing semicolons uh are you? Are you a pro or anti-semicolon kind of guy in ruby.

D

And john's creditor, oh semicolon um I, as long as I have prettier, it doesn't matter to me. That is, um that is a very wise response, but in uh ruby there's or at least I don't have any auto format or things. So I always forget stuff.

A

Yeah, ruby doesn't have semicolons, I don't believe. um Okay, yeah, that's one of the things. This also really throws me off with like python, like.

A

D

But the uh no parentheses thing throws me off in ruby all the time, because we're not super consistent about it. In our good days.

E

A

I think the time like when you when you don't do it, because I guess everything is like a method like all your fields are methods or something and so something's like I can on a class. I guess I can like def a getter or something, um and so I I I guess you kind of just have this gut feel if it's this is like a property or is it like a method and um anyways.

A

D

All right, oh there's an alert, no well! So if we don't want to deal with that, I was able to reproduce it by just adding a comment. It might be easier than having to deal with an alert which I don't might be kind of hard in capybara, but I'm not sure I.

A

Think we might be able to find I'm I'm I'm fine. With going that route. um My my only hesitancy is. I was trying to recreate the one that I was doing. Yeah yeah, that's a good point, but if you're able to recreate it with creating a comment, um we can just confirm that this fails on master like so, let's just and that'll be pretty probably the fastest way to do it. So how? How could I create the comment?

A

I guess I can hit a button like.

D

I mean we can we already have this, we can just try and close the alert. You want to try that out. If I don't know we're already down this road, we might if it's easy, we might as well do that. If it's kind of hard, then maybe we should try the other thing.

A

Okay, I'm going to see if I can find um find this nope, not r.

A

Let's see if I can find a spec for this here.

A

No oh gosh, okay right here, you.

G

Can just do page.

D

Dot accept alert, I think it's like or like accept, confirm or something page I don't know I just googled it, but that rocks. Oh.

A

Here we go except yeah there we go.

A

Oh, what's going on there, that's interesting so this. How does how do you use this? You, oh it's like a callback kind of after uh it says. I'm gonna accept this alert, but then here's what you're gonna do to trigger it.

A

So I guess what I would do is.

D

Oh, that's weird: it's like backwards. Yeah.

A

D

Like that, oh wow yeah, I would would not have figured that out.

A

A

What do you think of that? Oh man, that's a tough one. I know.

A

So I was creating these voices um through google's, um so you can like connect it to the api, like their google cloud like and you can configure their text to speech stuff, but it's technically cost money to do.

A

All of that um I was creating samples using their like demo tool and then like just using that api, converting it to little an mp or converting it to a wave and like, uh but it's pretty fun like you can create some I'm impressed with how text-to-speech was gone these days, it's a lot more advanced than when I was a kid yeah. It's pretty cool.

D

There's like a browser api too, I think you can use it's built into just into chrome. I think right now.

A

Yeah now that you mentioned it too, I know like mac, has like accessibility features baked into it as well. It'd be interesting to be able to hook into that to generate your own stuff.

A

Oh, this is this is problematic, because I think I guess you need to do note. Dot fill in um oh.

A

A

A

Unable to find field, it's not disabled.

A

A

Oh, because I forgot to wait for requests, okay, because I guess I'm canceling it and then it's like disables everything while I'm not well, I'm canceling it like I'm kind of thinking that might be it. Let's see, is.

B

It send a request when you cancel.

A

A

Well, yeah, I kind of wouldn't think it would yeah. That's a good point.

D

It might be because the note- maybe it's like recreating that node the node, the note node, and so you need to refine it or something I don't know, maybe like. If you want it because it's like yeah, I don't know if that's it, but like that's a reference to like a dom node and then, if it's recreated, then you have to refine it.

D

A

If that's it yeah I'm gonna cut down for checking that out. That's interesting that could that could be it. um I don't know if it's gonna like fill in with we'll.

D

See yeah also, we might be using filling in correctly.

A

Yeah, there's a there's a helpful and there's like this for everything. There's a helpful capybara cheat sheet. That's how yeah.

D

Yeah, I would struggle with like r spec docs like finding what I want.

D

A

In yeah it looks like you can find something and then fill it in oh, but that's like finding in the form and filling in. I guess a certain valuable or something too that's interesting.

A

The flexibility of ruby is like and and of cathy bros. It's it's a little daunting, but at some point I guess you just gotta lean into it and it's like it knows what I.

A

A

A

A

Yeah, I don't really know how to like.

A

So what would you do to clean up this spec then.

D

Well, I mean, I guess, if, like we, it looks like the above one is doing similar stuff, so we could combine them and do like a before each or something. So they were not repeating the same commands, but.

D

I don't know I was trying to get it working before I start combining stuff, because then it just gets more confusing yeah. That's a good point.

G

F

D

F

We got past that.

A

All right, I think, half text is wrong.

A

Expect note.value.

A

That might be more accurate.

A

I might need to denote that value to.

A

Equal, I guess that's how you do it. um Let me double check what we're actually we're putting here and expect to wrap yeah they're, putting the no body into there yeah. I think it's note that value. I think the text bit was wrong, which makes sense, because it's an input, I guess.

D

So when you're getting like, uh when you do find in our spec caviar like find an element, are you getting back the dom node like or is it a wrapper? I think it's like a wrapper around it kind of that's.

A

A really good question, though I I don't think it's a wrap, because I know I'm pretty sure if, if you visited another page like it's, not gonna be a rapper for it. I think it is the actual domino um which is which is interesting and which is why you probably shouldn't: do they kind of suggest not doing selectors as and doing more, like?

A

um That's probably why you don't see a whole lot of you know: hey with this field, fill it in because who knows uh it could be, you know, regenerated or somehow we visited another page or something, and um that's probably why they want you to, and this is a good thing, with these kind of tests to prompt you to have more accessibility so that you know things that you can look things up by aria labels and just a number of other things like that, besides keeping a reference to something.

E

D

Okay, why did it fail when it says expected and got is the same thing? Oh there's a space yeah and that's sounds like.

A

D

Because, when you hit enter, it adds one extra space after it and.

A

That makes sense because then I can just get type typing: emojis, oh sweet nice. So that should be good. So we got our spec. So now what I'm gonna do? um I'm gonna just gonna commit this: uh let's all right! Just for fun and giggles: let's go ahead and run it again. So we see the green. But then, if I yeah but then, if I revert, um revert the reverted yes yeah.

A

All right sounds good cool now. This is super helpful thanks for um thanks so much for pairing with me on on this, because I I probably would not have done it on my own for sure.

D

This isn't a problem, it's helpful for me, too, the more our spec. I write, the better.

A

Yeah we learned um how to accept an alert that was cool, um how to send keys. I send keys.

D

So yeah there might be a better way to do that. Maybe not.

A

D

Can you not do, can you not do fill in instead of send keys and that's a really good question? Well, because then we're using fill in for.

A

Oh wait: what does but send yes fill in, I think, is going to actually just programmatically set. The value send keys, I think, is actually.

D

A

The key events, which is.

D

Right so we do need to do that.

A

But it's interesting, you kind of wonder how come fill in, isn't filling it in like a human. Maybe fill in should be sending the keys like that would be really that would make sounds like that'd be really helpful. um I wonder if that's a configuration that you can set for capybara.

A

um You said you were messing with some qa specs. uh Were you? Were you actually running them too?.

D

Yeah uh it was, it took me a while to figure it out, but you can run it against gdk wow.

A

All right looks like we're good nice, and it's back, oh, and I want to get rid of this thing.

D

Yeah because I was I changed um like this simple text field to a gitlab ui component and then there was a qa test uh to like improve ux, um and then there was a qa test that was failing because of that change. Yeah update it, which took a while.

A

Was there a qa selector in the in the element.

D

um No we're actually like a follow-up issue to add some selectors to the gitlab ui component, so that we can select it better. That's interesting, that'll be that'll.

A

Be interesting, um ad spec for.

A

Testing resilient key events- or I don't know.

A

Yeah, that's um I know danger would be upset about me. Not me not having a fight. I.

D

Always struggle with the 50 limit thing it's hard to be descriptive in 50 characters.

A

Yeah because it is all right, so I'm going to revert the revert and let's double check that um or I could just rebase on top of master. That's probably makes a lot of sense. Let's see that.

E

A

A

A

So yeah, I don't. I don't think I would have found um this issue if it wasn't for scott's inside knowledge, which is a little concerning because I'm like you know what, if scott well, if he was on vacation.

D

Yeah seriously got lucky he's on the team same time, zone or similar time zone.

A

Yeah, so it seems to me to be the the crux of the problem is um doing something globally for all was like like uh doing off for all listeners um and that's something I think we can probably add to eos lent rule for yeah. Definitely.

D

That makes sense yeah or I guess I was kind of on the right track when I was messing around with the event listeners but in the dev tools, but I guess I maybe I just wasn't using it correctly, but it didn't look like anywhere being removed, which was what was confusing me. So you can actually see listeners here like. Can you show um yeah so like if you right, click on like a link or something or.

B

D

A link, sorry like inspect a link element or something is clickable and then go over to event listeners next to computed.

D

um So I was looking at like key down events to like see if any were removed or like.

B

Added and stuff.

D

But I couldn't I couldn't like narrow it down at all wow.

D

This is so helpful, but maybe it wasn't, maybe it doesn't showed. Maybe it doesn't show jquery events I don't know, but yeah.

A

But yeah it's super helpful when you're trying.

D

To debug stuff, like this.

A

That's interesting because it might not, um because jquery may do its own event thing yeah. I think it has like its own event thing or something.

D

I don't know that's scary, yeah anyways.

A

All right, so we would we expect this one to fail and then we then we should be good to go.

D

So how did you revert that you just re-based with.

A

D

A

Yep just to get rid of the revert commit because I was already on master, and um so I was just re-basing.

G

With whatever my.

A

Marriage base was, and that happened to me, master.

G

Yep here we go.

A

It reveals the real issue before we were just entering a new line, rather than actually handling it. So cool uh nice.

B

A

Respect yeah, I'm gonna push this up too. um Awesome, hey peter thanks so much. This is so yeah helpful.

D

You might wanna, maybe it might be, makes sense to do the feature spec in like its own merge request so that that other fix can get in, because I feel like getting feature. Spec reviews takes a while.

A

Yes, no and it's messy too you're right. This is a really good call, but it's really helpful because that we wrote this spec, because this is my screenshot. You know uh oh yeah. This is my screenshot of it not working, but I could show hey when you rebase this off master your screenshot. It works. So that's really sweet um cool, hey thanks! This is.

B

D

A

um This is probably one of the most productive days that I've had.

A

Thanks, I appreciate it I'll talk to.

G

A