GitLab Pair Programming - Frontend, 9 Apr 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: FE Pairing - 20210409 - Fix "Sign out" in 404 pages

Description

In this session we fix a bug where the "Sign out" button does not work on our 404 and 403 pages.

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/322980
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/59030

A

And it's in progress and now I'm going to share my screen and uh I was going to suggest- let's try to fix this issue because um it's been around for a little while and it's not a great issue. So if I am logged in, um let me log in to let me demonstrate.

B

This account is right, just enter something like that that don't exist like gitlab or foobar right, oh great idea, yep. I could do that. I I was.

A

Yep goodlab.org.

A

Yep so there's a cool, this button doesn't work, this button doesn't work and the reason this button exists is because this could actually be a valid thing. Oh I clicked it and it just navigated me to here. The reason exists because it could be a valid thing and I just don't have the privilege to it. um That's why this button exists. It'll.

B

A

Simple fix cool all right, yeah, so yeah. What we talked about just a second ago was these these buttons, the way that they work to sign out, because it has to be a a post.

A

It's doing what we do elsewhere in our gitlab application by adding a data method for post, and I expect that there's some javascript picking this up and knew oh we're just going to create a form submission for this, uh and that works on lots of other places in gitlab.com kind of just out of the box. But- and I guess it previously used to work for the four or four pages. But it's not doing that anymore and I'd, be you have some contacts? Maybe yes,.

B

Exactly sorry, I I was wondering why you were telling me the same thing twice, but you just did it for the recording.

C

B

The the thing is, um there is a rails, javascript thing that picks up automatically uh based on data attributes and then converts certain links to be post requests. So the thing is we had jquery rails and because we want to move away from jquery, we migrated to. um I think it's now just called rails.

C

B

Yes, and so the thing is, we also removed it from the main js. So it's not loaded on every page anymore, but just on those pages, you need it. So what this means is that there was no copy borrower test for this uh functionality sounds.

A

Like something, we should right too, yes,.

B

Otherwise we would have caught this funk this this problem right um yeah, because when we migrated we just checked the most important paces uh places and thought hey. You know if the tests don't catch it, it's actually, okay right, because then someone will report the bug and we will have exactly this going on yeah. So.

C

It's okay to still use rails, ujs.

B

Yeah, like I.

C

Would say, but it's not preferred.

B

But I mean in some cases like this one, it's probably super. It's it's. Okay, right.

A

So um I'm a little concerned if it's not in our main bundle, and the reason is what, if we have a um some sort, it's.

B

Like this for eight months now, so the train is yes and I agree.

A

I hear that, but I think I think it still is cannot not be obvious that it's not in the main bundle and developer could add something to a component that works in one page. But now it doesn't work in another page um or even something to a shared uh and.

B

Hammer template yeah, I think you're right so you're, basically saying if someone creates a form uh data method, delete or whatever or even uses in a view component, but it then works on one page, but it doesn't work on the other yeah.

A

So where does it get? Where does it get imported? Just from the can you share.

C

A

Yeah, let's dive into it, I'm I'm here in the code, um um just search for rails.

B

uh Yes, yes, and wherever this is exported, uh it's basically initialized right. So, like just look at the unit rails, yeah.

A

You can see it.

B

Is in maine, oh, it is so. Is it executed yeah? Yes, it is so maybe then the other I'm actually wrong and the problem is, can you go back to the page to the 404 page.

A

Oh yes, the 404 page doesn't load any anything so.

B

If the, if the 404 page doesn't load any javascript, then that's the problem. That is the problem. So what we? What I would suggest we do here and can you go up in the 404 page again scroll down.

C

It's actually rendered via rails, or is it a static page, it's a static page. Is it I well okay, it usually is in rails.

A

C

If the app is broken, they'll there's just.

A

We have a suite of static pages and this is not the same one. So there is all right. There is one that is rendered by rails, yep, yep, okay, yes,.

C

Which one are we getting.

A

um We are, we must be getting this one because we're getting the errors footer and we get the nice illustration and stuff. um This is one of the first things I did at gitlab. uh Was this these four or four pages, um and I learned that there's interesting relationship to these error pages and also workhorse or whatever proxy we actually hit as well and- and so I think, that's why there's also these static ones is there's some sort of weird fallback that happens well.

C

You if, if the whole app is broken, you don't want to just not serve anything. You want to have it be able.

A

To have a static page, even.

C

If the rails is not working at all and.

A

I think that's what happens with this like 500. I think that's why the 500 page looks a lot different than our 404 page too. That's a good point. Okay, but the 4-4 page rails is working. We know that something's wrong and we are uh actually rendering this. We.

C

Don't have any of these links on the 500 page, so we're good. There too.

B

A

B

So then the fix is still the same. uh We basically need to create a javascript bundle where we just include the rail stuff and uh we just need to say hey, and I think we can even do it here in the footer. You know include this, because the good thing is the: if we, if the error footer would be used on another page that does the inner rails anyhow, it will not be a problem because uh the inner rails is just happening once.

A

Oh, I see okay, so we want to I'm trying to see where we oh yeah. It looks like we also get this on access, not denied. We get the errors footer as well, so you're suggesting, let's just because I.

B

Mean this is basically using the sign out method, post thing right, um so I would suggest it makes sense here because it's using the method post thing to say hey on this page, we want to have rail, uh the rails, ugs yeah,.

A

That that that sounds good to me, um yeah yeah, so I mentioned creating a bundle and that's where I I get a little lost because I'm like yeah. This isn't a page bundle that we usually do so.

B

So could you go, is the not found html hammer actually the the whole page with the layout and everything? No, it isn't right. um So I wonder.

A

Which layout is.

B

Used for this, I wonder if there's a errors.

A

A

Yeah arrows, oh.

B

It doesn't have.

A

An underscore there you go yeah.

B

So so you can see it's actually funny here, um because it's yielding a title and it's yielding like uh so there's like no actual way to use. One of our helpers, like you know the add page specific styles or edge, add something here, because there's like no place where you uh can inject something from the template, um given that this arrows footer, so I think we have two choices either we extend this to be like hey.

B

Yeah I mean we could do the same thing.

C

Here in the header here, like.

B

I would just put it in the header here, probably yeah, to be like hey and I would create a page specific bundle and call it the arrow bundle, and then uh I would I would load this uh okay here.

A

What do you all think of doing something, crazy and writing the failing test for it? First, can you can do that? What do you? What do you want? What do you want to do ibm? Do you want to fix it and then do that or.

B

Nah we can write the test first, if you wanna okay, do we have any tests for those? I don't know. I.

A

Don't know, maybe not any feature test for it. um Let me let me do a search for that text, because I think um that would be how it would.

A

Oh yeah, we do some where we see. Oh, we expected a four or four page, but I don't think we have actually tested that four or four page itself, maybe not.

B

For not found, but maybe search for that specific sign out. No, that sent out thing okay, good idea, uh well yeah! Maybe I can search for.

A

uh Sign in register- oh that's like show spec.

A

Oh that's! This is different. Oh yeah yeah this is gonna be different. Is it gonna be different.

A

Yeah, I think that's different.

A

um Yeah, I don't, I don't think so.

A

I'm gonna look at file names now of four or four yeah. No, I'm not gonna get anything or not found.

A

uh Nope nope, I don't think so. I think I think I think we get to do it. That sounds like fun, um so I'm going to.

C

Unmute so there's error pages spec, that's not it.

A

Oh, oh error pages. Oh that does look like it. ah ah Chad, you rock. How did you find this.

C

You're not gonna want to hear this, but in my ide I typed feet slash error and nope.

A

I don't want to hear that yep how? How did your id, how was your ide smarter than my regex searches.

C

It's not a reject. That's a good point. Okay,.

B

Before do sign in users, so we're actually signing in visit, not a real page, and now we would write. You know we wait. Do we actually allow someone to search.

A

Wow, I didn't even notice that search bar there.

B

Can you search for gitlab.

A

It's not going to fill anything, uh but it takes me to the search, that's cool cool that works, yeah, that's pretty fun, um okay, but then here we're just saying it shows nav links. You.

B

You want to do a really stupid thing, though, without rails, ujs and whatnot. Why don't we wrap that little thing in a form, then right that does it it's much easier than you know, yeah, including the javascript and so on, but the test here should be pretty simple. You know we say: hey click, the button that says whatever.

A

I'm so I'm going to add it to the shared example. One uh do.

B

We have that on the four or three as well yeah we're rendering on four three.

A

Yeah yeah user can sign out um then click click link. This is my action. Is I'm gonna.

C

Click the button.

A

For this lovely title.

A

And I would expect, how can I expect that the user is signed out.

B

I mean you're probably going to be redirected to the login page.

A

Okay, uh oh, I can maybe look for the current path. I would expect.

C

Expect page location, page.

A

To have oh look at this right, jax uh isn't it? I don't think you.

B

Need a sign in yeah, it's something.

A

Like that, oh it's checking my browser. Yeah! That's super annoying! Oh I'm already signed in well. I think that was it come on git lab. You know.

A

um Yeah that that should be sufficient. um Do we want to.

C

Work is there going to be a redirect in the middle that's going to mess that up.

A

Well, the post to sign out, I think, is going to redirect to sign in. I would like to add the assertion that we did sign out. I don't really know how to do that here.

A

I I don't know, I don't know how to how to see if I've actually signed out or not.

A

Oh, maybe we can see. Maybe we could see what expectations we use for the sign out uh feet.

A

B

Sign out maybe log out oh yeah,.

A

Feet log out: spec! Oh, yes! Yes, yes! Yes, yes,.

A

Current path to equal, oh well, that sounds like a nice way to do it um I'll, probably copy that one. uh It looks like that's the only way we do it.

C

Yep: okay, yeah! You can't check your cookies or anything like that, and it's unlikely that anyone would ever change the implementation to redirect them to the login page without signing them out.

A

Yep uh yeah, that's the bit, I'm not super super excited about, but I think it'll be okay. So, let's, let's run our failing test.

A

And let me yep we've we've loaded, the gdk uh but you're saying maybe let's just let's just wrap this in a actual form.

B

That's what you're thinking? Yes, yes, I'm I'm saying you know changed is the gdk running yeah, I'm just say saying, because that's actually what rails, ugs kind of does right.

A

B

A

B

Make this thing a real button: that's inside a form and when you click it, you submit the form and.

A

B

A

I I did remember now that you bring it up. I remember seeing if that was possible um and because we also don't have access to all of our css here, um a button is gonna. Look like a button.

B

And so in the worst case, we can make it an a with that triggers the javascript on the, because we had some inline javascript on that page right in the worst case. We can make it in a if you click it. It submits the form.

A

Right, yeah, I'm even I'm even down with we can even drop here in this javascript that one bit of code that does form submissions. We don't even have to create a whole page bundle if we don't want to I'm I'm down with yeah.

B

Exactly I mean because it's really a test for it, so it's yeah exactly.

A

B

Why over complicate it right, like maybe we add a little empty form here and then you just submit it with the thing, and I mean we can call the form sign out form or whatever um well but but could you could you try to maybe hardwire the form I mean you can worry about the styling and moving into javascript later on yeah. But could you could you try out here with the form if it actually works? Oh.

A

You let me do it. uh Oh gosh, sorry, you let me do it here.

B

Yeah, it's also fine. I mean.

A

Oh, if I do this and I make the I gotta edit- some html uh form action yeah. This is this: is this right.

B

A

B

Delete is it delete really yeah, it is ah post yeah.

B

A

Actually removes the user.

A

That would be really sad, uh yep yep yep, don't, but this is going to be a type submit. Yep.

A

Here we go, let's see.

B

A

B

An hecker such a hacker, so it.

A

Sounds like we just need to create a browser extension.

B

No, we just need paul right every time someone wants to sign or they they get a zoom session with paul and they and oh there you go. He manually changes the that's.

A

B

A

I'm I'm reset typing. The password yes makes sense, just trying to be uh completely safe. Okay, I'm re-sharing my screen, so yes doing the and that's technically what uh that is technically what um the rails ujs is doing.

C

Yep and then so.

A

C

Just like what you said uh submits the form.

A

Yep yep 100 uh mandy's tests are give me you.

B

Would have started with spring, or just I.

A

B

I haven't started spring yet so: oh yeah, okay, yeah, it's like I recently contributed to some other ruby project, and I was amazed how fast aspect can be like some triage ops or whatever right. That's like! Oh, what the the tests ran, because I'm so used from the gitlab project to start the tests and walk away and make a copy.

C

Of the rail stack like uh in modern rails, there's like the the r-spec helper helper that loads the whole rail stack. But there's like the plain one that doesn't load the rail stack and if you can write a pure library class that doesn't need rails, which is rare. But if it's just pure ruby logic that will run instantaneously.

C

B

Mean additionally, here is like with the setting up giterly stuff right and we don't have any logic around hey for these tests. You don't need giddally, but I had that exam problem earlier and I don't know you know if.

C

It's a database problem.

B

Yeah I had it earlier and I'm now stuck running, gdk update.

A

Oh no, oh yeah! I was trying to see if masters was broken, but it might. I might need to update my gdk man.

B

All right do you need to maybe we can just implement it and push it. Let's.

A

Just do it, I know.

B

A

Pretty sure this test.

B

Because we just have 22 minutes, left right, yep.

A

Yep yep, I agree so let me sign in let's just fix this.

A

Here we go we're signing in and I'm gonna go to garbage foo. Okay. This is the button that doesn't work. So I'm what I was saying I would be fine with is uh just adding you know the one or two lines to make a data method work, just whatever rails ujs does. We could just you know, kind of copy that over here.

B

The problem is that it will basically create a form, do the form wrapping. It is.

A

B

A

B

Yeah, but that's that's like a lot of code that we could also solve by just adding an empty form that we submit after the click right. So I would I mean you're the driver right, so you have no say what to do. I.

A

Think I think, as a navigator you have say I think the driver.

C

A

Like just just tell me what to do um so,.

C

I agree with ip. We should just like make it a simple form and then yeah.

B

C

Anchor link with the submits the form yeah.

A

Cool- let's do it so here so.

C

Is it two places we're gonna have to duplicate this on the two pages, but that's okay,.

B

No, it's actually, I think it's uh in the.

C

Footer yeah, okay, yeah.

A

So I'm here I'm gonna go action.

A

Goes to destroy user session path, yeah.

B

A

Post host, maybe like id.

B

Yeah sign out form.

B

Is that you feel good about it, yeah and I would add the javascript even here in the footer, because why not like.

A

I would almost I'm about to I'm not about to propose something really yeah you're gonna you're gonna, take away my inline.

C

Javascript, that's what I'm gonna say just put it in that.

A

Yeah, if he's gonna take away my maintainer badge no.

B

No, no, I have no power to do that. I'm not a maintainer myself, but it's like hey.

A

um These pairing sessions- and this is a good thing and I'm not going to stop doing it, but sometimes I'll brainstorm ideas just like. I know this is a bad idea, but why not like? Let's, yes, but some people are like man. I can't believe you suggested that I was like dude we're brainstorming.

B

uh You know it's so bad that I'm actually not. I don't know how you write. Inline.

A

Oh, you know it's on click man on click.

B

No, not href javascript colon.

A

Oh, no, not that that would be that okay, but speaking of ahrefs the href, I guess would be.

B

A

That um and then the on click uh would um be a function, arrow function. Well, we just we just call it. It's document get element by id. Oh gosh sign out form, submit.

B

Do you need to prevent the normal event.

A

B

A

Why I have the little thing.

B

Okay, good, uh but that's a good. That's a good question, um get element by id yeah, it's cool! That's even you know ie9 compatible. I love it. Should that.

C

Technically be inside the form element, I mean, I know it doesn't matter, but.

A

Oh, I did something wrong. I've done something wrong. Look look at. What's happened here, no, what's wrong with you. Why is my.

A

B

uh Can you go back to the code yeah? How does link two work? I think you don't.

C

Need to write href.

A

Oh you're right, you're, right, you're right. You just need to write like oh thank you. Thank you you're. So right, that's what I want to link to, but then I must have to do something else to be able to just probably with the uh link to you. Just have to put it in the curly braces.

B

Oh, you think, oh, you think, like I'm just passing an object.

A

B

A

uh I'll tell you what I do really like all the documentation there is for the rails. Oh.

B

No, you need. The on click is just a colon. uh You just do colon on click uh and then also an arrow. You mean this one, yes are those equivalent. I don't know.

A

C

Yeah, I don't know.

A

Let me try this one out and because I did get rid of my little href thing, yeah looks good, oh yes, it sure does boom.

C

Yeah, I don't think you have to switch over to the uh rocket forum.

B

A

Perfect it works. uh Do we like the inline javascript.

B

Yes, I love it. It's I mean it's a it's. A two-line fix for a bug that probably not a lot of people meet but like hey, maybe you know if I would suggest I could suggest I would leave a comment above like we. Don't have rails ujs here. That's the reason why we do it in line and yeah. Okay.

A

I we could also add a one-line javascript thing here. Yes, that's also. What would be nice like we want to just do that like we can just add.

B

It's a little bit nicer and I mean it will be loaded anyhow, and I mean it's like hey document, query selector for the link and then we can say you know yeah.

A

B

Yeah, that sounds. It will then be four lines.

A

But it will look a little nicer right. Let me go ahead. Let me just try that out doing it from here, because I can even understand if down the line we want to lent against online javascript or whatever this would come up like. Let me just see if I could do.

B

It this way and to be honest, like if we do that and want to get rid of the plain javascript text, for example, this will also be easier to find and to migrate than having it as an on click on the link right. That is a brilliant.

A

Point as well, so I actually think because the click is going to bubble up. I think I can actually just add this click to the body.

B

Yeah but event listener, then you still need to filter for the id right like or something so why don't add it to the id to the to the link directly?

B

A

Okay, I see what you're saying I was about to do something just way more generic, but I I see it's it's easier. If I can just query select yep: let's do it yeah.

B

uh You have a typo in document. Do you not have to type document out? No, you have a typo in document.

A

Thank you, um so I'm gonna query for um I'm going to corey for.

A

I'm going to call this instead of all that sign.

B

Out form trigger.

B

B

Why are you generalizing so much like? Am.

A

I am I too generalizing. Am I generalizing too much.

B

I don't know feels a little bit like it, but no it I mean. Maybe it's okay, like data data form yeah yeah, yeah, yeah yeah. You know what I mean.

B

Okay, I mean there's a for each for one link, so maybe you're generalizing too much.

B

C

I agree with ip.

A

All right all right, all right, I hear you, I hear you, I hear you all right, let's do it, how do you want to do it? I mean you want to add a class like a class selector here.

B

Yeah, it's okay! No! Let's do it your way: okay, yeah, whatever okay.

C

Why can't you just give it an id like sign out link? Oh.

B

A

We could do that too yeah, I'm I'm game, I'm game. Let's do it all right. One page.

A

I'm I dig it. This is gonna, be so easy, uh but I am gonna add a comment of. uh We do not have rails ujs here, so we're manually uh triggering what data method used to naturally do.

B

I don't know if it does it naturally like if, in nature, we have a data method, but.

A

Okay, get element by id, it is sign out, link, uh add event listener on click, um oh and I don't even know if yeah I was about to start doing some some fat air, I'm going to do some arrow functions, but that's that would be fine.

B

Because we don't support ie 11 anymore, so.

A

um uh We do want to prevent default. I imagine.

B

A

And we want to get element by id sign out form.

A

Okey-Dokey, let me go, I.

B

Mean there is no god in case the form doesn't exist, but I would say: that's: okay, because.

A

Yeah yeah yeah. We have a test for all of it too, so I think we're yeah garbage nut garbage nuts.

A

C

Suggest a different comment.

A

Yes, please do.

C

Like, rather than referring to what it used to be just say, we now have lsu.js here so we're manually, making a link.

B

Trigger phone yeah, okay, yeah.

A

So we are manually making a link trigger a form um cool.

A

Awesome uh yeah that fixes it great I get to commit and create an mr. uh This.

C

Was gonna pass.

A

I think it's gonna pass too, so I feel good about all of this. You think.

B

It's gonna pass like because I don't know with the click button to be honest like because it's a link.

C

Yeah I was wondering about that. Oh it would have failed. You're.

A

C

I thought about that when you wrote it and then I didn't say anything navigator too, you should.

A

Have said something.

C

A

Has to be click, link right.

B

A

B

Click link is like a one page- oh I'm pretty sure, but.

C

What I second guess myself, because I think no actually, I think click button is smart enough to click the link and then.

A

I don't think so. Actually you think so yeah, yes, click link. If you click on I'm gonna be I'm gonna do click on. I don't think we actually use click on a lot. Oh, we do quite a bit, um but you know.

B

What's the boost you know, what's the worst thing that I just realized about those pages, what is.

A

Internationalization well, do you think we can fix that while we're here.

B

No, no, no! It's fine like because we we don't load the javascript. That does the thing for internationalization right and, to be honest, oh we have oh, no. We, I have internationalization here sorry but you're right.

A

It's called rails rails is doing it. Yeah reyes is doing that yeah sorry, but yeah. We have it yeah cool. So I I would like to spend the rest of our pairing time talking about something that comes up in my head almost every day, um but I want to open up gitlab.com and side of my a little browser environment. I don't know why you keep asking for that.

B

Have you created yamaha already, I.

A

Have not uh let me let me go ahead and make a commit and push this up, and while that stuff is loading, then then you'll be good to go. uh No, no, no you're great! um So uh my commit message is we fixed? Let me go to my um yes: fixed sign out button and 404.

A

Slash three pages.

A

uh And error pages um added some vanilla js, since we don't have rails ujs here.

A

Jail's uds was here: we could simply use data method, cool committed that I'm gonna check out a new branch from this issue.

A

Number fix uh sign out on error.

A

Pages cool, so that's loading, but here I am at gitlab.com in an environment um that does not have javascript and I don't get anything uh yes, you mean you want to have a noscript somewhere. I want to have a no script somewhere telling you hey. Gitlab works best with javascript enabled no.

B

Actually, you can say: gitlab doesn't work without labels, because it's actually now docs that you need.

A

Javascript enabled right right, but it would be nice to get that message from here, because some pages look like there might be some stuff. um I think, uh but or it may even look like some of these work, but sometimes they don't or whatever, and it would be nice to just not show any of this and just show similar to our error. Page layout, uh if you don't have javascript enabled you gotta enable like, let's not show any interaction to the user, because none of it's really gonna work.

B

You want to, I would, I mean, to be honest, like first iteration, to add a no script here. That is an alert or whatever that just says that and links to the docs uh would probably be good enough right. Okay, yeah.

A

Would that just be like the top of our layout? You think.

B

I would just edit like here like whatever, like top of our layout yeah under the navbar. Like I mean you can theoretically do things right, you can navigate to help, for example, right right now, right well without javascript, pretty.

A

Soon, you won't be able to.

B

Because help will be deleted.

A

Or you won't be getting any help, no, that this is going to become a bit more javascript uh and like the projects, is actually a drop down, but you know this is not drop down right now and yes, this is gonna, be all be combined pretty soon um to one drop down thing: uh yeah, it's gonna, look really sweet. It actually looks really sweet um yeah. But that's got me thinking about noscript.

B

I would, I would, you know, add a no script in the template here, wherever it is right now and then, if you refactor it, and you know, the navbar won't show because it's all going to be javascript so right.

A

Yeah um but like you know, oh you still got. Oh you have. I don't know what that was. Please turn whoa that that's what I'm talking about.

B

Yeah, that's that looks sweet. uh Why don't we have it everywhere like? Can you just copy that and into our normal layout I mean yeah, that's what I'm talking about.

A

Let me let me see, let me also open this thing up to create an mr. While we're doing it.

B

To be honest, like, if you don't find it, it feels like this is a cloud cloud. Oh.

A

You think so you notice, I I'm getting something about a page being missing.

B

A

B

Can you can you check the? uh Can you check the html, that's coming back here because.

B

Yep cloud yep, cf, browser verification.

A

Cloudflare is is, but this that's not going to solve the situation for self-hosted users.

C

B

A

B

um Oh it doesn't it doesn't. He also doesn't solve the situation if you're already logged in isu.

A

Yeah, I don't know, what's going on there: uh okay.

B

But yeah go go back to the gitlab.com normal page. I would just add a noscript tag. To be honest, like okay, I think there's an issue for this javascript gitlab. That's a really bad search.

A

Script, gitlab! No, I can't find it.

B

Nowadays, like there's a no script, uh definitely I know because I think I've created if there wasn't an issue. I think I've created it like three years ago, script.

B

No script is hopefully distinct enough.

A

No script head: oh yeah! What's what's what's this expect adam matamo? I don't know what that is. It's different. This is something different.

A

Oh php! Oh no! I'm leaving!

A

I don't know what matamo is. um Oh, it must be some sort of. I don't know uh anyways. Let me finish creating this, mr and then and then we'll we'll. Then we should be good to go. This, mr fixes, this issue by adding the missing javascript.

A

We are guessing. This was broken when we refactored.

B

The rails.js into I don't I to be honest, like I don't know if it's actually related to that at all, because it would work if we were loading main.js, it could be that someone kicked out loading javascript from that file. Right, like okay,.

A

I'm gonna I emphasis on the gas uh cool.

A

Just take a screenshot of this that it.

A

A

A

Let me go ahead and sign in and take the before screenshot.

A

A

B

But why? Why is this like that? I hate this.

B

I'm trying my best. No, it's it's fine, so it seems like I've.

B

I've completely wrecked my ruby, install oh.

A

Man are you using asdf.

B

Yeah but I update yes, the problem is I updated openssl.

C

Oh man, did you upgrade your mac os version.

B

No, I I just homebrew forced me to use a new open. Ssl version go away.

A

Sweet all right, I've got to add one of those sweet change logs, um but this is this is time uh thanks for hopping on and helping out- and this was fun.

B

Yeah, likewise, it's good seeing you likewise all right. Well,.