►
Description
In this session we discuss at a high level the tradeoffs of different approaches to showing code quality warnings in MR diffs. We also show some helpful CSS classes at center aligning icons.
A
B
It's
so
funny,
interesting,
just
because
I
am
looking
for
so
long
on
this
feature
that
I'll
be
speaking
to
you
about
that.
I
completely
am
oh!
Looking
like
I,
don't
even
see
this
thing
anymore,
and
that
is
why,
like
what
is
Paul
speaking
about
what
kind
of
debugger
I
don't
get
anything
here,
but
okay,
so
what
I
want
to
speak
to
you
about
or
yeah
a
question
that
arised
for
me
is
yeah.
B
We
are
speaking
about
the
the
code
quality
inline
indicator,
where
I
had
to
write
some
horrible
codes
to
actually
trigger,
and
it
should
not
be
too
much
about
this
because
it
is
more
kind
of
a
gitlab
UI
kind
of
question.
So
I'll
be
hovering
this.
That's
all
you
need
for
now.
As
you
know,
for
a
moment
and
once
I
click
it
I'll
be
expanding.
B
This
change
the
icon
and
have
a
different
tool
tip
so
far,
so
good
now
I've
been
dealing
with
some
kind
of
UI
UI
ux
feedback,
which
kind
of
said
unreasonably
the
icon.
Don't
really
look
great
with
changing
that
we
don't
wanna,
we
don't
want
to
modify
any
existing
icon,
but
kind
of
did
you
wish
from
ux,
which
is
fair,
that
came
off.
Where
could
we
try
to
Center
the
collapse
icons
so
that
we're
just
basically
growing
from
the
middle,
which
would
be
a
little
more
pleasant
for
pleasing
for
the
eye
yeah?
B
B
A
A
I,
don't
want
to
comment
here.
This
I
feel
like
some
of
the
UI
complexity
that
you're
running
into
we
should
we
should
go
back
up
a
step
and
talk
about
the
ux,
because
the
the
ux
of
this
doesn't
feel
great
yeah.
It
doesn't
seem
like
it's
great
to
implement.
So
is
there
something
simpler?
We
could
do
that's
even
maybe
potentially
better
for
the
end
user.
Here's
my
crazy
idea,
go
for
it.
A
How
do
we
communicate
quality?
Well,
I
said:
load
quality.
How
do
we
communicate
quote
quality
issues
and
the
IDE
squiggles
we
use
squiggly
lines
and
what,
if
What
If
instead
of
an
icon,
there
was
a
yellow
squiggle
on
debugger
the
word
and
then
what,
if
below
this
file
blob?
If
there
was
any
code
quality
issues,
I
could
see
a
collapsible
list
of
all
the
like
an
eslint
printout
of
rather
than
having
it
in.
B
C
B
A
Definitely
yeah
the
difficulty
of
implementing
this
I
feel
like
is
a
symptom
of
no.
This
is
a
really
weird
invading
into
the
current
UI
space
and
it
looks
cluttered
and
if
you
have
opened
threads
and
discussions
and
collapsible
stuff,
it's
going
to
look
really
cluttered
and
I
will
not
miss
it.
If
I
see
squiggly
lines
because
I'm
trained
to
see
squiggling
lines
and
I.
A
It
if
this
file
has
at
the
bottom
I'm
kind
of
anticipating-
let's
just
maybe
the
squiggly
lines,
I,
can
hover
and
there's
a
call
out
that
comes
up
on
top
of
it.
That
would
be
great,
but
maybe
that's
another
iteration
I
would
just
for
the
first
iteration,
let's
collect
all
of
the
ones
for
a
single
file
as
like
a
little
box
at
the
bottom
of
the
blob
that
I
could
collapse
and
expand.
That.
B
I'm
happy
to
take
us
because
funny
enough
actually
this
and
this
discussion
is
not
too
far
away
from
me
at
the
very
first
that
years,
and
this
would
actually
have
these
indicators
within
this
element
here
like
driven
here
and
that's
where
I
hardly
protested,
because
there's
just
so
much
going
on
with
States
and
hovers
and
comments
and
what
not
Within
These
within
this
little
bit
of
screen
state.
So
that's
where
I
was
okay,
let's
at
least
move
it
out
here,
but
it
brings
some
problems
like
this
is
a
highly
popular
area.
B
Let
me
let
me
call
it
like
that.
Still
maybe
we
can
before
we
completely
reflected
this
thing,
and
maybe
we
can
see
if
we
can.
We
can
Center
this
thing.
So
what
I
did
was
to
what
I
did
was
to
apply
a
negative
margin
on
3D
icon,
which
it
obviously
well
surprise
it's
a
hack,
but
it
kind
of
does
what
it
does
and
it
does
what
it
should.
The
problem
I'm
now
thinking
of
and
I.
C
Of
it,
so
my
my
immediate
thinking
was
is
before
like
why
clearly
the
way
that
we're
centering
the
gold
icon
is
is
not
correct.
If
you
know
what
I
mean
because
you've
said
for
yourself
we're
not
centering
it.
We're
left
the
line
in
it,
but
we
left
the
line
in
it,
and
yet
it
appears
in
the
center.
So
my
gut
feeling
is
what
whatever
it
sits
inside
so
at
the
moment,
I'm
guessing
we're
using
a
margin
to
to
get
it
away
from
the
the
what's
it
from
the
the
border
from
the
line
next
to
it.
C
A
A
A
B
C
B
A
A
A
C
A
C
B
That's
a
fair
point
like
the
plus
is
such
an
anti-pattern
like
what
we're
seeing
here
is
there's.
Actually
there
is
a
trigger
to
expand
something
and
to
me
it
feels
like
it
is
internationally
accepted
for
a
plus
to
represent
something
to
be
clicked
and
then
expand
it,
but
it's
actually
the
indicator
just
next
to
it
yeah
and
it
also
it
could.
The
lion
is
as
well
not,
and
you
probably
would
have
solved
your
code
quality
issue
so
yeah.
B
A
B
A
C
B
B
B
C
A
B
B
B
A
No
because
I
don't
lose
my
place
like
I,
like
if
I'm
scroll,
if
I'm,
scrolling
and
I
know
oh
I'm
I'm
like
two
inches
down
but
I'm,
going
back
and
forth
between
like
scroll
down
scroll
up
well,
if
I've
collapsible
stuff
my
place
is
now
a
little
lost
like
gotcha
and
I.
Think
it's
like
you
usually
see
things.
That's
why
we'd
usually
see
in
the
editor.
You
know
hovering
information
for
discussions.
It
makes
sense,
because
discussions
are
a
little
bit
more
long-lasting
for
this.
B
Yeah
kinda
I
still
think
it
is.
It
is
super
valuable
feedback
and
the
I'll
I'll
bring
it
over.
That's
that's
for
sure,
and
I'll
I'll
make
a
proposal
about
a
squiggly
line.
Maybe
that
is
actually
exactly
what
we
need
pick
is
I.
Do
really
think
it's
a
it's
a
tricky
question,
because
there's
just
so
much
going
on.
B
A
A
A
A
A
For
any
time
we're
doing
this
has
helped
us
create
a
box
within
another
box
that
had
like
Center.
That
little
box
would
then
be
16,
and
then
the
outer
box
would
be
like
32
or
something
like
so
like
yeah
yeah,
that
that
was
always
really
helpful.
If
you
go
to
I
would
do
a
project-wide
search
for
like
SQ
Dash
16.
A
C
B
C
C
A
B
A
B
A
A
B
B
A
A
B
A
A
A
A
A
C
I
looked
for
wavy
lines,
we
could
we
could
use
a
bull
for
the
bottom
and
we
could
use
dotted
there's.
We
could
use
a
tiny,
tiny
little
image
and
set
it
to
repeat,
or
there
is
text
decoration
underline
wavy
that
I
don't
I,
don't
know
what
the
browser
support
is
for
that.
So
we
might
just
want
to
check.
A
A
A
C
B
Like
no,
no
that's
like
partial
support,
no
support
unknown
yeah.
No,
no!
So
to
quickly
quickly
explain
this
is
it
is
not
related
to
any
kind
of
GitHub,
metrics
and
I,
don't
even
know
from
the
top
of
my
head.
I
think
it
is
latest
release,
plus
the
two
versions
prior
before
that
something
along
those
lines.
So
from
what
I
can
see
in
first
row,
this
should
probably
be
okay,
and
these
are
that's-
maybe
me
leaning
a
bit,
but
you
see
browser
for
Android
and
the
Bible
browser,
probably
not
our
biggest.
B
A
A
C
C
Put
about
completion,
but
that
would
be
just
it's
just
going
to
be
awesome,
that'd,
be
so
good.
If
so
we
use
markdown,
Lin
and
I,
don't
don't
think
you?
Oh,
you
might
be
doing
some
links
in
yourself,
but
I,
certainly
in
the
office
use
markdown
in
the
sort
of
says
this
line
song.
There
should
be
a
blank
line
here.
If
that
had
the
wavy
lines
and
visualizations
in
the
diff
that'd
be
awesome,
so.
A
I
think
I
think
though
I
was
starting
to
get
a
little
worried
of
like
oh
man.
Maybe
we
shouldn't
be
waiting
using
wavy
lines
for
this,
but
now
I'm
thinking
the
way
Ides
resolved.
This
is
like
yeah
any
kind
of
outside
tool
that
wants
to
comment
on
a
line.
You
add
a
wavy
thing
and
then
those
comments
stack
like
if
you're.
B
B
A
C
B
A
B
B
B
C
B
B
A
B
C
A
C
A
A
A
It
seems
a
lot.
It
seems
a
lot
more
maintainable
and
easier
to
do
as
well,
so
nice
I
would
say
per
file
if
a
file
doesn't
have
any
issues,
we
don't
show
the
box,
but
if
a
file
does
we
would
have
per
file
a
box
at
the
bottom
which
just
collects
these
things.
Maybe
we
can
add
a
click
listener
if
I
click
on
that
it
brings
me
down
to
the
box
or
something,
but
that's
just
the
first
iteration
yeah.
It's
not
great.
A
B
Yeah
yeah,
just
to
haven't
mentioned,
like
for
first
iteration
kind
of
things
we
still
like.
We
are
currently
looking
at
an
active
feature
for
like
200
Austin.
We
would
have
these
these
findings
in
there
in
line
in
this
tooltip,
so
that
would
be
kind
of
it.
We
can
probably
get
away
with
that,
but
I'm
definitely
taking
away
the
baby
life
I.
C
Think
I
think
I've
kind
of
know
how
it
looks:
Stephanie
Paul
because
you've
been
suggesting
it
but
I
just
pinged
you
on
slack
with
a
screenshot
that
I
took
because
I've
got
a
visual
studio.
Oh
nice
thanks
I've
been
here
and
it
just.
It
helps
to
kind
of
reiterate
what
you
were
saying:
Paul
about
at
the
bottom
of
the
screen.
You've
got
your
list
of
of
errors
in
that
that
window
and.
C
B
A
A
B
Oh
I
feel
like
this
is
such
a
good
argument,
because
some
of
those
some
of
those
findings,
they
would
actually
make
a
very
limited
amount
of
sense
without
having
the
context
of
the
other
ones,
if
you
would
say
like
if
it
might
just
say,
duplicated
method
and
it'll
be
a
thing
in
one
place
and
then
you'll.
It's
your
task
to
Now
search
for
you,
100
000
lines
of
code
in
this
file
to
actually
find
the
yellow
duplicate
which
just
feels
stupid.
So
that
is
here.
A
Can
have
like
I
think
it
would
be
really
nice
to
have
the
traceability
links
to
it.
So
it's
like
I'm
looking
at
the
summary
I
can
click
on
it.
It'll
jump
me
to
the
line
of
code
where
that
was
ideally
I.
Could
click
on
the
the
line
here
and
that
could
drop
me
to
the
summary
or
something
maybe
the
traceability
links
will
be
important.
I
think
that
IDE
experience
for
how
the
IDE
communicates
these
messages.
A
C
I
do
agree.
The
only
thing
that
I
think's
wife
is
having
in
the
back
of
our
minds
is
yes,
probably
a
large
percentage
of
people
that
are
using
this
tool
are
developers,
but
then
you
also
got
people
that
may
be
doing
markdown
or
or
some
other
kind
of
maybe
people
so
I
would
definitely
be
drawn
towards
well
I'm,
so
used
to
using
my
IDE.
If
I
can
make
this
work,
like
my
idea
awesome
but
then
maybe
I'll.
C
B
B
A
We
would
need
to
do
the
we
would
need
to
have
it's
not
bad
to
do
this.
We
just
have
to
be
extra
careful
and
have
you
know,
control
of
what
we're
doing
from
The
View
component.
That
calculates
where
we
need
to
do
this,
we're
going
to
have
to
query
selector
the
right
HTML
that
has
been
inserted,
yeah
and
apply.
You
know
whatever
classes,
we
need
to.
B
B
C
A
C
B
C
B
A
B
A
A
C
C
B
A
A
A
The
other
thing,
though,
is
if
the
Mr
is
like
not
approved,
then
we
haven't
run
the
full
pipeline,
so
that
could
be
related
to
it
as
well.
Yeah
the
MRI
I
sent
you
does
seem
to
have
it
working
I,
don't
think
it
has
any
front-end
files
in
that
Mr.
So
we
can't
check
it
from
that
perspective,
but
the
back
ends
seem
to
have
the
coverage
stop
working.
Okay,.
B
B
What
I'm
thinking
about
is,
if
I
imagine
that
there
would
be
a
code
quality
problem
over
there,
I
feel
like
we
do
have
a
bunch
of
scanners
and
we're
having
more
and
more
of
them
working
on
on
those
lines
which
is
fantastic,
but
maybe
we
should
have
like
something
like
a
shared
control
center
on
interface,
which
will
just
show
you
what's
going
on
no
matter
if
we
test
covered
with
security
code
quality,
any
of
those
kind
of
things
like
that
is
where
you
would
go.
Oh
yeah.
B
Be
a
bar
might
be
a
wavy
line,
might
be
a
circuit,
but
just
get
those
kind
of
yeah.
Let's
start
read
all
those
scanners
differently,
because
yeah
as
a
reviewer
or
developer
I
just
want
to
see.
If
there's
something
going
on
like
there
was,
there
was
a
problem
that
requires
your
attention.
Yeah
I
feel
like
that
is
where
we
can
can
can
find
some
some
things.
B
A
A
A
Maybe
if
maybe
you
know,
if
one
of
the
extensions
has
detected
some
sort
of
issue,
then
yeah
it
gets
promoted
to
some
sort
of
some
sort
of
yellowish
or
red
like
if
some,
if
one
of
the
extensions
has
to
really
flag
this
line
as
red
that
wins,
and
so
this
is
now
a
red
line
and
I'm,
but
I
am
what's
challenging.
There
is,
if
I'm
wanting
to
just
get
a
cursory
glance
of
test
coverage
I've.
Now
you
know
that
information
at
a
cursory
glance
is
now
lost,
because
it's
it's
yeah.