GitLab Plan Stage, 3 Aug 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Plan | Weekly Sync 2022-08-03 (Part 1)

Description

Part 2 https://www.youtube.com/watch?v=WYMgl3JLJ4E

A

uh Okay, third of august, planned team meeting kashal's up first off, you go.

B

um Sure so I'll share my screen and uh demonstrate uh a recent change that I've made. So let me zoom in so we are basically adding the ability to mark a task list item as confidential.

B

The way it works is that any task list item when you click on it. It reveals the model and, as for the proposed ux, we need to show an action in the context. Menu clicking on turn on confidentiality will show the badge here and you can simply toggle it off.

B

I I do have a couple of questions around it uh which I'll ask later so once you turn on the confidentiality and uh close the model, uh we should also be updating this list uh to reflect it, which would possibly involve updating our banzai filters so that we can add a relevant markup to show the icon within this list. That a taskless item is confidential.

B

Now the question I have, which is directed more towards ux, is uh there in in the designs. I didn't see anything around. How do we show the action in progress like if I click on turn off confidential?

B

For now, I've added the loading animation um and I've placed it right next to this drop down, but I'm not sure whether that's the correct way to go or do we need to show the loading animation or some progress that the confidentiality toggle action is in progress uh anywhere in ui. So right now it shows right. Next to this drop down, I feel it works, but obviously you will need uh confirmation from ux so yeah that is it for the demo. Any questions.

C

Yep I had a question that we are calling it right now on the model level.

B

C

We could call it on the actions, but then I assume that we should update the issue description, so I think we will be doing the same, that we do for delete item right. We will be splitting it on two parts. One is called from the model and one will be called from the work item root, app.

B

Yes, so uh I I did uh respond to your concern. I think your your question is valid, that we shouldn't be calling it from model, in fact, because if user ends up opening this work item in its own page, then clicking on this item doesn't do anything.

B

C

Mean we can call update work item from the root level as well like we do with delete item. But it's a valid point on, like maybe also for delete mutations, because currently we're calling to different ones, and it's less than ideal.

B

Yeah, so, even if we, uh even if we uh call the mutation from the work item, detail component, which is the root component here- that should still allow us to identify that something was changed with regards to work item and we should be able to update the description, yep and yeah I'll stop the screenshare and uh next is uh natalya. Sign is widget.

A

uh Just before you do like, we don't.

B

A

Need to update the description yet right, because we don't need uh the marketing.

B

Element for gi yeah, so there's uh so there are two issues uh regarding the confidentiality one issue is showing the confidential status on ui and the other one is obviously adding support for changing the confidentiality status. Now, as far as showing the status is concerned, it currently just covers model dialogue, but there's an ongoing conversation like how we are going to show the same for the listing part, and if we were to do it within the same milestone, then we would need to update the issue description to reflect the confidentiality of the item.

D

We don't need to do it during the same milestone because we're removing the listing of uh tasks from the issue description anyway, so uh yeah, so there's not gonna, be a need to update the description, at least for fifteen three. um Okay, then.

B

Yeah then this dmr, I have basically has both the changes like showing the confidential badge on ui, as proposed and uh the action to do it.

E

I think we do need to update the child items section, though, um ideally in real time after you switch it. So it's not confusing.

E

Because we're removing the list from the markdown thing like the convert to test thing, but where you know we do the child items thing. That's the list of tasks of an issue.

D

Yeah, I don't remember that, are we showing confidentiality in the child in the hierarchy, widget.

A

E

Noticed it didn't change, I think in the.

A

E

But maybe it needs a reference.

B

uh Yep, let me show it again so you're, referring to these items right.

E

B

Yeah, so the thing is that I I don't know whether this site these items, I think yeah. These items are tied to this one, but there's no way to update the confidentiality from this list. It only happens from this model so yeah. We. We can in fact update this list to show the icon reflecting confidentiality, and that should be possible because uh this list is uh I'm not sure whether it is using subscription or not but yeah when the model is dismissed after uh confidentiality is updated. We can certainly refresh the system and do it.

E

I think the child items thing is supposed to open the model right. I don't know if it's like.

B

Yeah right now, but which is not the case right now: yes, yeah.

E

Because we're removing the test list from the checkbox items, so there's no other way to open the model unless you do it through the child data.

B

Yeah- and uh so I I haven't- had much chance working on the child items, but when I looked at all the feature flags, I got confused in getting this model dialogue to show up, because I had to first enable work items. Then I had to enable work items mvc2.

B

Then I realized, by going through the code base, that we also have work items from task list or create task list from work items or something similar work.

D

Items great from markdown.

B

Yeah yeah and that's probably.

D

You probably just got that.

B

Yeah- and I was I was looking at our documentation around the task list, which did reflect like what to expect when you hover this and uh turning a task list item into a work item. But then the feature flag mentioned in the documentation says just enable work items and it should work. But that wasn't the case so within this, mr I'll, be sure to update the documentation so that I basically in in future, I don't forget like which, uh which uh which flags are responsible for what.

A

Yeah I copied in the issue there which floor is working on to open the model when you click on one of the items in the widget she mentioned. So it's related to my next point is that she mentioned this morning that she has to re-implement the modal for this, I'm not sure like of the ins and outs of it, but it may be neither like, since you've merged this there's. She also has to include your newest work.

B

No, so I I haven't merged anything. The mr is in draft status, so nothing has merged. I just wanted to have the visibility around the experience of getting the confidentiality updated, like the loading animation that we show is that correct or not, and.

A

B

Have a broader visibility, no.

A

That's great thanks, yeah, like it's just that, if I understand it correctly, she has to implement re-implement the modal entirely for the widget. um Is that does that sound right, or does that sound like I've got this horribly wrong.

B

I I'm not sure, what's the background right.

A

Okay I'll check that right, async, I'm not sure if I've got that wrong.

D

I I think it's about when the modal is or which modal we're using, because I think we attached the like modal container, essentially within the issue description originally, but when we move that behind the feature flag, um we no longer have access to that modal from outside of the issue. Description- maybe way off here. So I I I.

B

Think this may be around uh what heinrich mentioned earlier, like in the in the child uh items task list clicking on individual items doesn't open the model, so I think maybe flori was referring to that behavior, where clicking the child items from the task list should be able to launch the model and show the relevant information, because right now.

D

B

Do anything if you click on child items.

D

Kong you're here too, I know you know exactly what we're talking about, because I thought you commented in her mr or review her. Mr.

E

Yeah, so I looked at her mr this morning and it looks like she's be using the model, that's um that we used for when you click on the task item in the description, and so I'm just thinking of yeah. What john might have been by harvey doing the model. It doesn't seem to be the case so far, but yeah, I'm not sure. I don't have other context around in her struggles because she mentioned that she had to spend time redoing some stuff and but yeah. I guess we could get clarification from flori.

B

Yes, I'll get in touch with her tomorrow uh and basically sync on how we should move forward with regards to, because my changes are also touching model and I may end up causing more conflicts for her when she ends up refactoring. The models.

D

uh One last question on that: so for linked items or linked issues. What uh what model were we using there? Were we creating a new modal from within that widget or where we were using the description.

B

So we we, we have a common uh gl model component, uh which we just show depending on when user clicks. So, given that it's a description body which is not a view application, then we are basically binding event listeners to those items from the description and that basically propagates into the work items have that we have, and that ends up launching the model and shows the information by fetching graphql first so right now, obviously we are having a communication between a non-view part of the page and the view part of the page.

E

D

So john, we probably need to and cushion uh sink back with, flory to get a bit more details on.

A

Sounds like horribly, misunderstood anyways like so. It's probably not a big deal, but I do think it's a good idea, probably to sink since, as kashal mentions, probably merge conflicts.

A

C

Yep, let me share my screen and bear with me, because this is a new laptop, so if it's not shared from the first attempt yeah, it's like open system preferences and everything so give me a moment.

C

Setting up m1 is a challenge.

D

We're all smiling, because we completely understand.

C

Okay, I will reconnect with the call, because it just asks me to quit and reopen one second.

A

And I we should also ask natalia how she got a new laptop.

D

It's happening all the I think they mass sent out laptops to all of europe. Yeah.

B

I I wonder what happens first apple releases, next-gen macbook pros or the last team member in gitlab gets the m1 microphone.

C

Okay, chinese, so uh this branch actually uses the latest changes on both backhand and front end. It's based on heinrich's branch, where he adds the input permutation and I've added front-end changes here as well. There are a few things that probably are not perfect, but let's look at the ui right now, so assignments have no login state. Whenever you just change the assignments list, mutation is happening on the background right now and we don't show any kind of disabling the input or anything.

C

uh You may ask like what happens if I do a few mutations very fast. So, for example, if I remove this one and then remove this one, there will be probably okay. My mutations are super fast, but normally you would see the old result for a second and then a new result, but there is no colliding in terms of problems. Issues with back end anything. You just see the result of the first mutation and then a result of the second mutation.

C

It has a quite nice, I would say interface when you work with keyboard, so you just type anything and then you can remove anything from the keyboard too. That's a good difference with our current drop down and the only problem that I see from the ui point of view is that we have this clear, all button and it's visible on all the states, because this is gl token selector.

C

So maybe I will just remove it and show it only when we are editing so in this state whenever the input is focused but rest should be pretty much the same. Yeah sign myself works too just works, and I really like their ux here. We've been working with all assignees a lot, and this one is feels much better faster with a few visual glitches. Maybe but we're working on that.

C

So this is all for sinus and let's see if there are any questions, yeah.

E

Now I have a question on the okay, so you're saying the front end like um you're doing the mutation on the back and right so question is: uh do you try to reconcile the result of the mutation to the ones that are currently shown, or do you just ignore the result of the mutation.

C

The the result is not ignored uh whenever we have their response. Actually, we update the assignees again. So first we assign they have the specials.

C

It is a copy called local assignees, but whenever we have the response, the result is updated all the time and when, if mutation errors, for example, we just uh remove all the changes we made locally and we roll back to the previous assignments that we have so, for example, I have non-assignees and I assign myself, we see ourselves in the sinus build, but if mutation fails it's removed and we have no assignments again, so we synchronize the state with a back end. All the time.

E

Yeah, I ask because sometimes when you, for example, send a mutation to assign user one and user two, the back end could reply that only user one was assigned because we checked for permissions and other stuff, like only users that can read the issue, can read, can be assigned or something so it might like partially fail and only some users are assigned or something but yeah. I think the other thing with this reconciling, I think, is like do you?

E

How do you handle out of order requests, like you said when you like change the size quickly and the second requests or the second change you made returned first, and you know compared to the first one and like yeah things like that, but yeah. I guess you thought about that.

C

For now it's not handled it. There is a visual jump because, for example, you have one assign you assign two more mutation is sent and before it's resolved, you remove one of them, so you will have three assignees and it will jump to two.

C

But what I think about is probably we will not rely on mutation response in the future at all, because we plan to have real time. So I will remove all the dependency on mutation and I'll put just listening with a subscription to update the state and reconcile.

C

Probably it will be more reliable than just listening to mutation responses.

C

D

uh Yeah, so my question was um was exactly what heinrich was wondering around the order um like what happens if we send uh four delete mutations quickly and the first one errors out, um do we like? How do we yeah? How do we handle that first, one failing and then the following three succeeding?

D

Are we sending all of the assignees so.

C

We send them to science but assigning ideas. First of all, uh if mutation fails uh that there will be a roll back to the previous state like before the mutation, but the following mutations will be resolved and we will update the sinus list according to the mutation response.

C

So whatever mutation brings us at the response will be reflected in the sinus field.

F

um I'll write this in the doc in a second um one of the things I've I've been thinking about. As I was looking at the new widgets is we probably need to define like a standard sort of pre-interactive state that for for any widget right and then, um which could be basically that everything starts as like a like a button or something that, like immediately on interaction like switches to that active state like? Would that uh would that help resolve? Some of the like, you know like.

F

I know right now, you're hiding a lot of stuff and then showing a lot of stuff. Would it be? Does that seem like a reasonable approach to instead of hiding and showing we have like a default state? That's maybe more of like a structured component and then on, like focus or on enter like switch to the to the input.

C

It will bring a trade-offs. uh Usually when you replace components you will need to synchronize the state between the component and the input both and uh focusing the state and especially keyboard interaction, can be a pain if we have different components. So, for example, like blur and focus uh handling this with replace an input with some default component is complicated. So for now I would probably stick with just hiding the clear role on the input, but we can revisit it later if it becomes too complicated.

F

Okay, in the other consideration, there's going to be consistency with, like I think I I initially noticed this with like due dates, because due dates are not because it has to have like this other panel. It's not strictly like an input that we can utilize, um so we might want to look at like how can we make everything sort of feel the same, but we can probably take different approaches to getting to that feeling um depending on the type of widget, if needed.

F

um That's something I'm gonna look at so we can collaborate on that further, as as that evolves.

C

Okay, uh no more questions on the assignments.

C

Okay, I think we can move to the next point. uh I'm not sure it would be cohen or donald to demo. So.

D

I'll I'll demo, because I didn't uh I didn't warn or anyone uh or asked to demo uh so I'll- walk through kind of the rest of the recent work items or test progress.

D

Which window this one.

D

Okay cool, um so I am going to demo from uh production within our plan stage group on the test project. Within that plan stage group. The first thing to show is the listview now filters by uh tests or has now shows tests and has the ability to filter either by tests or by not tests, so it works shows all of our tasks. There.

D

uh I'm often trying to find out just issues, because I've created a lot of tests within that project and you can filter, filter out tap them. You can still do the oops. Oh no hotkeys.

D

Should show everything that we showed uh before this change all right, so not a demo, an actual work item I'll create another.

E

D

It says issue I am going to.

D

I'm going to add a test list here, um just because of where we're kind of at with feature flags. um So we have the uh the test issue here.

D

We currently still have the ability, uh within gitlab, org and gitlab.com, to create a task from the issue, description that is behind a separate feature flag now, which we're going to turn off once the um once the ability to create a child from within the hierarchy. Widget is done and tested, and we add one more feature to that. So within the next couple days, I'm going to turn off this feature flag, so we can't create it from from the issue. Description that feature flag is now called work.

D

Items create from markdown um just to kind of level set where all of our um are relying on. Where all of our feature flags are currently have the work items feature flag, which is um primarily the core of tas.

D

We have the work items hierarchy feature flag, which is child items. Here we now have the work items create from markdown future flag, which is the issue uh crate from markdown that I was talking about, and then we have the work items nbc2 feature flag which includes all of the widgets outside of the core task experience.

D

Okay, so I'm going to first well here let me move on to the hierarchy. Widget and what's been done recently here. We can now add a task and we can create a a.

E

Child item here so test.

D

D

Create it and it creates it here- uh the feature that I was talking about that we wanna make sure is in before we switch to feature flags. Is the ability to to click into this task, which we currently can't do, but the mr, I think, is in review so that should be in the next couple days.

D

Okay and then I'm going to create one here just so, I can pop up the modal for a task and demo the rest of everything on the list. uh What do I have next?

D

Okay, uh wait: widget is in um it's integrated, uh the front-end back-end is integrated, so this works and changes saves it there close it, reopen it still there, if I refresh still there, uh so the weight persists there.

D

Labels is. I don't think this is fully integrated with the uh with the back end yet uh so this will not persist, but this reuses.

D

It looks like it is, but this reuses a lot of the at least token display logic that that natalia demoed on assignees, so it should be pretty similar to what we have there and just search doesn't look like it's working yet, um but again that does not persist yet and I think tapping out of it. I think unfocusing saves it.

D

That's nice um or it may just save once we uh once we click or auto complete.

D

Let me refresh just to confirm that it doesn't purchase yeah, it doesn't persist yet all right labels and then the last one is this. um This call out here with the information about tasks that the pika created.

D

I think it persists in local storage. So if I close that out and refresh yeah, I don't get it anymore.

D

I think that's all to demo um within work items. We have some questions. Yeah john.

A

All right can I do them out of order, since we're already on this view, like uh what happens, if you try to make the issue confidential in life that you've created some public tasks.

D

um So if we, if we turn this to confidential and the parent issue, is public, then we will get in. Oh that's a lot. That'll work once right.

D

The other way around, if we have a confidential parent and we try to by default, the task will be confidential. But if we go in there and change it to public, we will get a an error. A graphql validation error, saying.

A

D

A

So that's what I'm wondering like. What's the experience like now, I know we have the back end validation, but I don't think we have the front end um like the front end needs to send automatically the confidential state when it creates the task, um and I don't think that's right, so I'm kind of wondering like what's the user experience like at the minute like. Does it just fail with no indication of why or is there like a flash message with, like you know what I mean.

D

Like just like, if we had.

A

To release this tomorrow, what would the experience be like you know,.

D

All right, so, if we turn this confidential confidential.

A

D

Already got the error there um yeah. So let me uh let me.

A

Create another issue: if there are non-confidential children, okay,.

F

Well, it gets the.

A

Message across it does say confidential twice, but.

F

From at least from a pattern perspective, that's the same thing that happens with epics. Today I mean I think we can improve that in the future, but it's the same at least.

D

A

So now it's confidential.

D

And if we, let's see what happens if.

E

We have it here.

D

Okay, so we get an error there.

A

That's not bad, like I mean it doesn't fail, silently or anything I mean that's actually pretty it's actually pretty accurate.

A

I mean it would be nicer if it automatically created a confidential task, but I mean I could live with this. I don't know.

E

I think that actually, because there's an id there that shows up 265, I think it created the test and it became an orphan because it wasn't able to link anything so yeah you're, probably right.

D

D

uh That's not right, 265 is the id. I guess.

E

Yeah, I guess it should show up in the listing if you just open the listing.

D

Just titled confidential, or is that what I do.

E

Wait, no, that is the.

D

E

Yeah, it's 264., so maybe it didn't. I don't know. Oh yeah probably failed. It just generated an id but failed or oh.

A

Weird yeah change the url.

E

To 265 and see did.

A

E

Reserve an id then.

A

Like so, is the next test gonna be 266.

E

A

A

Like if you're trying to add it again,.

E

Is the error gonna be the same.

E

Yes, okay, it's nice.

D

Yeah, so it doesn't look like it was created, we're just guessing what the ideas might be. A rollback on the transaction.

E

D

It's still weird.

E

Because the the action there is like make the work, item confidential and try again, but you know you cannot make the child work item here confidential and it's also confusing which work item you need to make confidential is the parent or the child.

E

There was a discussion around that I mean and we actually changed that for making creating a task from the description on a task list. That mutation actually uses the parent's confidentiality to to create the task. uh So the discussion was around if we should do the same for the child items, mutation is still missing.

A

Yeah we have an issue for that and yeah.

E

Yeah but anyway, I don't think this will be a problem once we implement a feature where child items automatically inherit the you know, confidentiality of the parents so shouldn't be much more problem for the normal workflow.

D

I was going to also test.

D

Because I can't create one like what happens if we oh, no, we can't test changing the confidentiality, but we should get a similar error within.

D