GitLab Protect Stage, 31 Mar 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Standalone Vulnerabilities Demo - Makes a new resolution alert component

Description

Frontend Engineer Sam Beckham recorded this demo of the new resolution alert component created to notify a user when a vulnerability is resolved on new standalone vulnerability page
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/27696

A

Video yet so, this shows what happens when a vulnerability is resolved in the default branch. So this shows up unless you change it to resolve, which case it is be us because it's resolved, so we don't need to tell you to change it. If it's any other stairs, it does show up.

A

That is dependent on the is resolved in default branch flag on the back end, and you can see it just says, burner ability resolved in the default branch, which is not quite what the design said, but that's because we don't actually have a default branch name. Being pasta was just yet so if I had called this for now just to show you.

A

With master, why not when this reloads, it should say vulnerability, resolved in master recompiling and come on there? We go really resolved in master. So if we know the name of the branch, we say the name of the branch, if we don't, we just said the default branch is a nice little fallback.

A

The only other thing you can do. This really is just dismiss it. I have set it so that it it just it hides the actual element from the page, so it it.

A

It comes back when you refresh the page. This isn't exactly what we wanted, but it's a hell of a lot quicker to do. We can area on this layer if we decide that you know we want different functionality for this. This doing it. This way just saves us messing on with getting endpoints and plenty of local storage, and things like that. So yeah born solutions. Let's try and remember that.