GitLab Runner UX, 25 Sep 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Disabled shared runners - FE/UX sync

Description

Sync between Payton and Juan on the UI and UX around disabling shared runners at a group level.

A

All right so, let's see here.

A

Share my screen, um my gdk is being a little slow today. So we'll see, oh.

B

It's always being slow.

A

Yeah, that's um okay! So what I've got here um is um a top level group um name, runner settings test, group, okay and then within that I have runner testing a runner settings test subgroup, and then I have a project within the main group. So we could perfect. We.

B

A

Just look at the structure right here, um so there's the project, that's within this group and then we have a subgroup, I'm not sure how much manual testing I should do per level. Do you you know um like how deep I mean. I guess it could go on forever.

B

Yeah, it probably can go forever. That's that's correct, but I think that you generally like the p95 of these is that you're, just gonna find one subgroup. You know it's. I think it would be. Very I mean I I don't have the data, but I think it will. It will be very rare for someone to have us as a group within a subgroup. You know I mean it can happen and like we allow that but uh yeah I like, whoever is doing that they shouldn't do that.

B

I think that that's basically even that you have like a high level group, so you can use to organize things a little bit more. uh You know smarter and clever. I don't think anyone is using that. But if someone is using that and they find an issue, they will tell us so I'm not concerned about that. Okay.

A

Okay, um so pretty much when you create a brand new group, this is what you will be um presented with within setting ci cd, okay it'll um any- and I remember we got a comment on some of the text uh like being updated and stuff like I'll. Go back and look at that, like uh I just kind of like want us to like look at the ux here and how everything's um behaving and get your opinion sure. So um we can look at the network console too just for um so right now.

A

You know by default. We want uh shared runners to be enabled correct for the group right, correct. Okay. So when we click this toggle um it we send a payload up, uh shared runners, settings disabled. So now we are presented with the new toggle, which will allow projects and subgroups to override this group setting if I click that we then send up another um payload shared runner, setting disabled with override okay and then what we're kind of discussing offline.

A

If you click this, what I'm doing now is go ahead and setting this defaults for now. um So we have that only you know the different settings we can send right. Does that look okay,.

B

Yeah, it looks fine and I just want to clarify why that's fine, I mean like my ideal ux, for this would be that we respect the uh allow project subgroups because, like someone can just come in and like you know like say like, oh, I want to disallow them for for just me. I I want to enable them just for a minute right, so they do that and then they turn them off again right and that probably is going to force them to like re, allow or disallow the project subgroups uh setting.

B

So I think my initial uh yeah, my initial rationale, was like we want to respect that in case people are dealing with that just momentarily, but it's not a big deal. You know like people like the way that we set it up right now, which is like progressive disclosure, is gonna force people to review that second setting always and if it's not what it is. They're just gonna really love it. So yeah. It's fine.

A

Okay, all right cool, so if we have both of these um disabled, so we have shared runners, disabled and we're not allowing the subgroup or project to overwrite. So this is the subgroup within here we'll go ahead and refresh the page. So those settings update both of these toggles are disabled.

B

A

B

Yeah, uh I was wondering we had a tooltip too there's already kind of like affordances telling you that they are disabled and you cannot touch them.

B

But if we could add like a tooltip when they hover saying that uh your the parent group doesn't allow this, you know just so. It's not like completely disabled in a vacuum and like people are like why why it's not working? You know, okay, so add tool.

A

Tip to toggles on subgroup.

B

And I can send you text for that. Okay,.

A

When parent group has disabled settings.

A

All right so cool so um and then we'll go back here and let's say that: okay, we're disabling for the group, but we're gonna allow to override correct them back here and refresh. Let's see how that behaves. So then we have both toggles enabled.

A

A

They have full functionality to um test this now, should we should, I probably, should I probably check with them, just just probably for maybe another sub group within this subgroup. Maybe um I can do some manual focusing on that yeah.

B

I mean, maybe, for the sake of completeness, create another subgroup.

B

But I think it wouldn't go farther than that. To be honest,.

A

Just like okay, okay, that sounds good um okay, so let's say we have this disabled um and now we're gonna check the project within that top level group, not the uh the subgroup. Oops not pipeline triggers uh runners getting mixed up here. um So this is from.

A

This is what the contractor had here. I don't know if this came from you for the ux, but it's just a button that says enable shared runners for this project and it's kind of like nested within this call out.

A

So then, once you click enable shared runners for this project. um It does such and then it gives you the ability to uh disable right.

B

Is that okay, uh the contractor? Did it like that because that's how that's? How groups, if you just go a little bit down scroll down a little bit, that's how it works? Okay, so uh I'll say yes I'll, say yes, just because that's how it works right. It's not my preferred uh ux.

A

B

uh But also like from because of how long has this been he's been taking and like.

A

B

A very mvc perspective. Yes, I think.

A

B

Fight to keep the buttons and then like down the line, we just changed that to a toggle in another issue, separated issue.

A

B

A

Okay, um okay, so now let's say we do this and let's come back and check the group. I think I didn't do this part, okay yeah. So this is what we get just a little call out that shared runners are disabled on the group level. That's.

B

A

Disable them, but now, if we enable them we're going to show the state uh again like this, so.

B

Actually, that's the text that we should use for the toolkit, but that exact same text. Oh.

A

Okay, okay yeah the tooltip for the subgroup when they're disabled.

B

Yeah, when they are not, uh you can now operate the toggle okay.

A

I think I just came across okay, so that's good that says back default, yeah, okay, yeah good! All right! So just show that on these um okay and you okay, you would prefer the tooltip, rather than maybe a call out like under setup, shared runner available. Okay,.

B

You know what like it could be totally that same call out at the top, and I think that's cheaper than us doing tooltips so yeah go for it. Do that do that instead, I'm fine with that. Okay.

A

Yeah, I think that'd be quicker.

B

Yeah yeah yeah. Let's do that then. Okay sounds good. uh uh The only thing that you mentioned at the beginning about the text is that yeah, it's just. uh We are stopped we're stopping like the use of share runners uh title case so like it's just like. If this will help us.

A

Just be lowercase here, lowercase here.

B

Correct everywhere,.

B

Well, yeah, even there like the just like the yeah, just so like for for single uh phrases. Of course, the first one capitalized but runners aren't uncapitalized gotcha gotcha and then for like non-single ones. Then everything in uh low cups.

A

Okay, on the same runner like right here,.

B

Yeah I want to yeah I mean basically, runner is not gonna, be capitalized major concept anymore. It's gonna be just like a loose uh okay.

A

Okay, okay cool so.

B

Yeah and you don't need to worry, you don't need to worry about anything else. On that page I mean just like the things that are within the scope of your work. We will be doing the other things our own, just because you're already touching those I mean, there's there's no point in like delaying that.

A

Absolutely yeah, I don't mind doing that at all. um Okay is there any okay? So I need to do the call out the text and then we just maybe need to uh test a little further with another set group and make sure that's fine, um but as far as the ux it looks good. It.

B

Looks amazing this is this is great thanks for taking the time to do this, and also for uh you know like dealing with the pain.

A

Yeah, it's definitely a weird pass off, but I'm glad we could refactor it and at least get a decent mvc out for the customer.

B

Yeah yeah, no, I I feel that it's uh it's perfect and I think the the discussions like helped a lot and yeah. It's great I mean like this is probably the ideal state if it ships like this, even with any of the things that we talked today like it will be completely fine, so uh yeah. Thank you.

A

Okay, awesome um anything else you need, or does that sound good.

B

No I'm good thanks peter, like that. That's great awesome.