GitLab Secure Stage, 1 Jul 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Walkthrough for MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/35624

Description

No description was provided for this meeting.
If this is YOUR meeting, an easy way to fix this is to add a description to your video, wherever mtngs.io found it (probably YouTube).

A

1 this video is a short walk through this admire, which aims to improve message when filtering on security. Dashboard lists no vulnerable, these results, so the current state. We always display these kind of messages. So no wonder what is found for this group or security, dashboard or project dashboard kind of messages, even though the the dash boots are configured so instead we're proposing to display this message when there are filters selected and it produces no results.

A

So here what we see is a security dashboard that is not configured. Ok, so the this is the initial message: it's not aligned central centrally, but it's there is already an issue for that. So I'm gonna go ahead and then pick a test project here at projects and then go back to the dashboard. I already have some filters selected, so you, as you can see here, the error messages or your filter produced no results, since this is handle so I also changed the way the code works.

A

Previously, it was handled individually by every dashboard, so the the empty State message was provided by the dashboard to the vulnerability in this component, which is this one, and instead I moved the the whole logic into the vulnerability in this component.

A

Here we have an empty state.

A

An empty State which basically it says if there are any filters selected, then display the filter produced no results component, otherwise display the dashboard has no vulnerabilities, so it may occur that some dashboards have projects associated, but the vulnerabilities they don't have sorry the projects they don't have any vulnerability.

A

Maybe I can find one here free. Let me reset the field.

A

If I go here, we move this one and then pick this project and return to the dashboard yeah exactly so this one. It says no vulnerabilities found, while it's ready to have on their booties. No, no is it can it can happen. In any event, we ask you double check your settings to make sure you've set up your dashboard correctly and then there is this call to action which leads the user to our documentation page now.

A

Previously this one was handled individually by every security, dashboard, so disappeared, that's what we had no vulnerabilities found for c4 security, dashboard and then for the Group one. We were saying Noble liberties found for a group and then for the project. We were saying noble liberties found for project so instead of managing three similar components in three different places, I moved the whole logic set here in the vulnerable to this component.

A

For that reason, I had to change the title a bit so instead of saying normally what is found for project or group I'm, just saying normal nobody's found- and here we were I- think we were saying while its way to have no vulnerabilities for group, or instance, level or project I, just straight that part out- and we just say, while it's rare to have no vulnerabilities.

A

So yeah yeah I think that's it. Let me okay. So if I pick exactly, if I pick the filters now, it says this one. If no filters are selected, it displays this one and if the dashboard is not solid coffee yet then it displays the default, but not configured, error message: I guess! That's it! Thank you for watching and have a great day.