GitLab Secure Stage, 9 Sep 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: secure UX: front-end updates to auto-create merge request MVC

Description

UI/FE revisions/updates to upcoming MVC to auto-create merge request w/fixes

https://gitlab.com/gitlab-org/gitlab/-/issues/234082/
and
https://gitlab.com/gitlab-org/gitlab/-/issues/235126

A

Hey this is just a quick update for some subtle changes to the upcoming mvc for uh suggested solutions, the auto creation of merge requests and that so for the first change in the initial design.

A

There's an alert here that actually displays when those auto-created merge requests have been created, and then the user clicks view security, fixes and then lands on a pre-filtered, mr list.

A

um But the change here is actually a little bit different and it's leveraging an upcoming edition uh for being worked on in thirteen five as well, and it's a design that warns when failed jobs are in the project dashboard.

A

So just taking a look at that that changes this view a little bit um and it leverages that upcoming ui. So here this is what's scheduled. Is this uh this sort of element here and it says last updated 10 minutes ago? That's showing the latest update to pipeline. That's the new issue, and then this issue is merging into it by displaying autofix solutions, three are ready to view, and then the user clicks that and it goes to the pre-filtered list.

A

So it's a little bit different than the other one and the the this is improved, though, because the alert display um takes up space unnecessarily, and this is a more uh long-term solution that matches well with the most recent updates on the vulnerability list. um The other changes instead of that alert. This is just a banner, that's introducing um the feature so similar to what we did for. First class objects: it's just introducing gitlab autofix.

A

What is autofix, and it's just letting the user know that if you're using dependency or container scanning this feature exists and then learn more goes to documentation. So again, these are just uh those subtle changes, um leveraging the most up-to-date changes on the vulnerability list for awareness. The next change is in the original design.

A

Let's see if this one is, the original design was showing a. I think, I'll just go here to this main issue. um It was showing a light bulb if a solution was available and a prefix of uh the merch request link.

A

But again these are slightly out of date because of the recent updates on um on the vulnerability list, and that update is there's a new activity column. That is being worked on in 13 4, so to align with that. So once that's completed in 13 4, and then um this is scheduled for 13 5.

A

We can, instead of showing it next to the title. Let me just move here to your designs from team to align these other designs.

A

Okay, so the activity column here and eventually it'll show issues and so on, but for the first mvc for auto, created, merch requests could show whether there's a suggested solution or an auto-created merge request here, um show the light bulb in that activities column. So just I'll go back here.

A

There's this new activities, column that's being implemented now, so the addition for the auto created, merge request would be to show that light bulb. This is to help because there's no visibility today on the vulnerability list to know if there's suggested solutions that exist um and- and this helps to display that as a follow-up um could show, merge, requests on that list as well. I think a note here from andy was that this would be a good post mvc.

A

So this design file also has that post nbc of showing the auto created ones, but as it is for this first mvc, it is just adding this to that new activities, column and then the other thing is uh filtering here: uh all no activity with issues with autofix solution.

A

um Some of these I'm just confirming with andy and the threats insights team here, just to confirm what those filters mean, but that for this auto create merge request in pc.