GitLab Source Code Group, 19 May 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Merge request reviewers - 13.1 Create UX team updates

Description

Pedro Moreira da Silva, the Sr. Product Designer for Create:Source Code, shares one issue that he will be working on for the 13.1 version of GitLab.

Create:Source Code is the area of the product that deals with merge requests. More specifically, merge requests fall into the Code Review product category. More info: https://about.gitlab.com/direction/dev/#create-1

References in the video:
1. Work issue: https://gitlab.com/gitlab-org/gitlab/-/issues/10294
2. High-fidelity mockups (Figma): https://www.figma.com/file/KAz1DEdS3kx01dPp9H5cDH/Merge-request-reviewers-10294?node-id=31%3A31
3. Low-fidelity mockups (Balsamiq): https://balsamiq.cloud/saotw6e/px75pbt
4. Epic that groups work around improving merge request reviewers: https://gitlab.com/groups/gitlab-org/-/epics/1823

A

Hey so issue I want to share with you today that I'll be working on we're closely in 13:1.

A

I actually started working on this a few months ago on and off and last I'll soon, 13, no I made some progress on it and in 13, 1 I hope that we get it in a good States so that it can be shipped. So what I'm working on is showing the list of reviewers and initially we thought about showing in the merge request widget, and you can see some mock-ups here- that some early mock-ups that show you in the merge request, widget, who has approved, which we already show today.

A

But then we would add this new column here be reviewed by and we would see exactly who has left any comments prior to approval. So this would allow us to track the status of the reviews and I actually to work on this.

A

I I did some initial wireframes of not only how this could look in the view, mr page and in the sidebar with the assignees, and how would you assign reviewers, but also how it would look if you wanted to edit the merge request and assign people as reviewers and and this would basically mix the concept that we have today of approval rules with reviewers, and but this is very, very big and you can see as I started working more.

A

This I started to trim it down into the bare-bones, and this is basically what we're aiming for in this. First iteration is just having a reviewers field, which I aired earlier last week and, as you can see here, this is what we're aiming for. So it would basically be a new field called reviewers work, exactly white, like the assignee field, you can add people, multiple people, remove them once you add or remove people.

A

We would have the system notes, saying that someone requested review from someone else or remove the request or just remove the review request and it would be displayed below the assignee.

A

As you can see here, one assignee in this case we're selecting reviewers, and so once you select them, they appear here and they, as you contains exactly the same as the assignee, and this would be the first iteration and based on the white frames that I did here, which I didn't want to throw away, because I think they have a lot of good ideas, especially for the merge request, widget kind of simplify it and also merging the concept of reviewers and approvals, which I believe is the direction that we should HR the aim for, because someone that is a reviewer, the goal is for them to approve.

A

So you wouldn't have those two separate concepts of someone that is an approver as someone that is a reviewer, the reviewer approves that's their goal, and, and so I I did another round of mock-ups of what could be the vision for the future and I shared these in in the epoch that we're talking about improving, merge, request, review where assignment and I think the epic might be the right place to talk about this yeah. We think big and build small.

A

So here we're thinking, big and then in issues we start building steadily what we think the vision could be yeah, and these are some mock-ups I will share the link in the description of the video and you can review them asynchronously and see them on your own. But I think there are a lot of good ideas here and now we're discussing yesterday in Marcel the product design manager for create.

A

He left a really good note here that says that he's a bit concerned about adding yet another term, another term and concept of responsibility with the reviewers field, and what he's asking is, if, instead of just shipping, this small iteration, where we had this new field, what if we look at this the other way and instead of having this new fuel reviewers and also the approvers, we started working on approvers, first and tourists, this vision and then add reviewers in the end- and this is something I'll try to discuss with him in the following days.

A

Yeah. So if you have any comments, if you think this would help you working through gate lab or you struggled with asking people to review, your emergency quests feel free to comment on the issues which are linked in description. Thanks.