GitLab Speed Runs, 18 May 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Speed Run: Code Quality notices in MR Diffs

Description

Quick run through of the new feature to display Code Quality violation data in the Merge Request Changes Tab. For information about how to setup Code Quality please reference this video (https://www.youtube.com/watch?v=4pJcrvZfGQU) or the documentation link below.

Documentation: https://docs.gitlab.com/ee/user/project/merge_requests/code_quality.html
Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/267612

A

Hi, I'm james eibach, the product manager for the testing group in the verified stage of git lab, and today I wanted to do just a quick speed run talking through a new feature that we just introduced. It's a minimum, viable change, showing a file, has code quality data in that mrdiff view.

A

So here is a merge request. This is out of just a sample project of mine and so code quality.

A

Today, you should be used to seeing here in the merge request, widget that there's been a degradation in my case, there's only a little bit of code or just a couple of files in this demo project, so not too easy to find or not too hard, rather to find any sort of problems here in the code, and then you always have in the pipeline page the full report as well, where you can see everything that has happened in your branch. So if you weren't just looking for changes, you wanted to clean everything up.

A

That would be a good place to go. This tab is part of our premium tier and the merge request. Widget is part of our core tier.

A

A new feature, though, uh and this that's being introduced in 1312- is this little feature here, showing code quality so as part of our merge request, something in this file has triggered a new problem, so we can see here by clicking on it here within app.pi that we have a couple of issues, so this is a faster way for you, as a developer or a code reviewer to find problems that are in just the files that were modified as part of that merge request and really just new things that were introduced, not everything in app.pi, so you should be able to then review that code quicker, add more contextual, hints or to do's asks as part of that code review to get things cleaned up and reduce your tech debt, and so this is, like, I said, a minimum viable change for us.

A

This is kind of what we're first introducing is just this little badge next to the file name itself. This is what we're getting towards in our next milestone. 14-0, I'm actually introducing this on the left gutter here, so you'll see the exact line where the problem might lie with an icon and that hover telling you what the problem is to give you a better hint as to where exactly in the file. You need to be paying attention, not just that it's in that file somewhere.

A

So that is how you use or the the new feature that we've introduced and you'll just get it for free as long as you're, using our code quality template already. Today. We look forward to your feedback on this and on our next iteration of getting this in line thanks.