GitLab Working Group: Merge Request Report Widgets, 23 Sep 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2021-09-23 Working Group: Merge Request Report Widgets

Description

Fifth weekly meeting.

Agenda:
https://docs.google.com/document/d/1bcch8UUkwmgEHFolTWDrQFJtUiiXlv_yQFAGwSSDSUE/edit#

A

All right and we're live welcome to the fifth uh edition of our weekly uh call for the working group for the mergy quest report widgets. I hope I got that right and going straight into the agenda.

A

We have some announcements so, as we talked last week, we were going to start off with the implementation on the engineering side and there's two efforts and both of them have kicked off. So we have the effort of adding support for the ux framework to the core components that has been started. Phil has already started picking those up.

A

You can see that on the list on the issues list on the link at the agenda, that's ongoing and you can expect more more news coming in the upcoming weeks, so that we can keep up the speed with what's happening there. Phil do you want to add anything that I might have not included nope?

A

How does it feel to actually get your hands on it? I.

B

A

B

A

B

A

um The other part that is uh that has started. um I can't see everyone on my zoom, but so peyton is not on the call.

A

No, but payton has already started to find bugs, which is great and we'll go to that in just a second. But that's the other effort is to adapt the existing widgets to using this card component. I see a couple at least two issues already set to 14.4. uh One has been picked up by daniel daniel kyan.

A

He hasn't been able to attend this call because time zone is hard and hawaii is really early at this point um hi daniel, if you're watching the recording, so he has assigned it himself to the security one I'll check in with him to see if he's already started on that, if he needs any support, but it feels like we're, starting with load performance and browser performance, which is good news.

A

Those are the simpler ones that we're hoping to find the um the most immediate bugs and then we'll go from there right. That's you know. Anyone else has any announcements to make to the group.

A

No all right, uh then we move on over to the discussion items, although I don't see tim noah on the call so kai.

C

A

Office, oh, you are yeah, I'm here. Oh man, hi. Oh there you go. I had another page on my on my face list. Sorry tim. uh So I just.

B

Wanted to check if.

A

You had the opportunity to catch up with kai about the process for contributing to this in the future. Have you had a chance to talk? Do you have any questions any things to to share with the group.

C

um So uh nothing concrete, but um just to give you a kind of a high level overview. um My my thoughts now have slightly changed from the first time we were started talking about this. I actually think that the initial documentation is actually good enough, especially when it goes especially when it uh talks about the the getting started, section, validation, backlog and problem validation.

C

I I think when it comes to specifically the merge request um widgets, I I don't think that we need a completely separated flow of contribution. I think the already established merge request page kind of documents quite um quite thoroughly. um There are some things I wanted to run by kai, um but since he's out of office um it may be a little bit difficult, but um at high level um my position has changed.

C

I was quite gung-ho in coming up with a completely parallel workflow, but I think that may just add noise and maybe even cause confusion going forward. So if anyone else has any anything to add to that, I would love to hear it.

A

Thanks tim, I would add that I think that speaks to the to that process already in place. It hasn't been very used as far as I know so far, but I think I think eventually what we'll do is just interlink the documentation on documentation of the code or anything like that about the merge request report widgets. We just make sure to include a link for that process so that they cross-reference a little bit and that's actually good to hear so so thanks for for that, anyone else has thoughts on that.

D

Not a thought, but mostly like question. What, specifically, are you folks talking about? I I got lost for a moment.

A

It's the process for contributing uh new things that are not uh so, for example, if you want to have a new widget or a new new feature that is not supported by the ux framework, anything that is that falls outside of the guidelines.

A

We would like to have a process for the future to accommodate those needs, so to speak.

D

A

Is that right, tim noah, please.

C

That's great, no, no.

A

You you were right.

C

A

Did you notice tim that I called you by the two names yeah? Thank you.

C

Has requested before all right appreciate it.

A

Anyone else has more thoughts on that.

A

All right thanks for taking notes, um so we move on to technical discussions. I guess if nobody has any uh pressing discussion items any does anybody have any concerns, something that we might not have discussed? Yet we have time so um might as well use it.

A

All right, then, we move on to technical discussions. Phil you got the floor.

E

So the patent notices an issue that the extension wasn't rendering within the widget itself.

E

I had to remove the code because it wasn't needed anymore whilst after I did the initial extensions, so there's merge quests there that adds it back in. But as I added that back in, I just think this.

E

That one and I'll probably do that next week and then of course, push the image quest as well as the top level state icons and sign up to jeremy for review.

A

Nice good news um yeah our just so that I understand- and I don't know if peyton is still on the call, but the question I have right now are: we: have we decided any sort of system for feature flags? How are we going to coordinate that.

E

Well, scott.

B

uh He's not on call right now, um that is that that's a good question we haven't talked about it, yet um he has a point at the bottom about his.

A

B

In progress, so we can probably start the discussion there.

A

Oh yeah yeah, absolutely it's something that will only be relevant once we start merging the code and we had discussed before that. The expectation is for this effort from peyton to start kicking the tires. It might not be ready for merging right away in fortune 4, but the value is definitely great in finding this hole. So thanks phil for plugging patching the bugs and thanks peyton for pushing this forward and everyone else. Looking into this, this is very much appreciated.

A

So I feel I guess that's takes care of your two announcements. Scott, do you want to read peyton's point, or is it that that just did.

B

No I'm happy to uh yeah. He just basically he has a work in progress, mr uh for refactoring, over to the new widget uh link there. So um still in progress yeah, we can start the discussion on the feature flag. There.

A

Oh, I like that. I, like the um give me just a second I'm, going to try to put this on the video.

A

Please don't fail me windows come on all right. Can you see my screen?

A

Yes all right, so it's already shown the progress that is that is made so far and in here we can see the two, the two widgets side to side. I'm guessing one of these are the old one is the old one. The other is the new one um and, as the icons are get added, they'll probably be updated in in looks and start to be um more in line with what the ux framework dictates.

A

So this is exciting. It's actually starting to see some things fall into place, which is, I don't know about you but exciting for me. So I'll stop sharing. Now, um thanks scott for reading that and thanks peyton for pushing vmware uh right, then we have nothing else on the agenda.

A

um Anyone wants to share anything else, or are we gonna get some free time back.

A

All right don't feel shy.

A

All right, this is good thanks, everyone for another productive call and thanks everyone for pushing this forward. I feel like it it it jolts everyone into action by seeing other people getting their hands dirty. So, let's get it done thanks. Everyone have a wonderful weekend and I'll see you.