GitLab Working Group: Merge Request Report Widgets, 10 Feb 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-02-10 Working Group: Merge Request Report Widgets

Description

Eighteenth weekly meeting of the WG.

Agenda: https://docs.google.com/document/d/1bcch8UUkwmgEHFolTWDrQFJtUiiXlv_yQFAGwSSDSUE/edit

A

And we're live all right. Welcome everyone. Yet another weekly uh meeting for the working group of merge, request, report widgets and going straight into it. We have one announcement phil.

B

Yep we have the dev docs new dev docs has been made. It should include as much as needed to get running it includes stuff by the textile and the action buttons icons to their polling.

B

um I hope I've not missed anything from it. If there's anything missing, please just bug me, and I shall add it in put me in janet way, to get running so.

A

Should be good thanks thanks phil and thanks yannick for helping um what I would ask uh engineers and like peyton and everyone to just take a look at it, see if there's anything that you would like to to know or or something like that, so we'll just double share it on the slack channel as well, so that people can see uh might be worth adding a note to the front and weekly agenda for the next set for the next week. Tuesday.

A

So can you please add that they're filled so that even if you're, not there, just make a read-only point to just hey? We just published the docs for the much request report. Widgets. If you have any questions, do join us in the slack channel or something cool good to see. um Do we have anything else.

A

It's fine, if you don't, you can get some minutes back. uh We still have an ongoing issue to add support for level three, something right.

B

Yeah, I'm still.

A

B

um I think it's pretty simple for me to do I've just not got to it.

A

Yeah yeah, I don't know where is but.

B

Three is identical to level two: it just indented a little bit. Do I need to double check the freeway. I think that's what it is yeah, so I can reuse the components and add nice. Little margin left.

A

So we'll see if we can still make it into 14-8, uh but if not, it should be coming soon after yeah right uh anything. You want to bring up scott, fernando anything.

C

um Just that uh I'll start transitioning more from my prior commitments to a new team which will involve more mr widget work uh around for compositional analysis on the secure team. I just haven't had a chance to dive deep into the mr widget work, but uh I'll provide more feedback as time comes along so I'll, be.

A

C

Consuming mr widget.

A

Extensions yeah there's a lot of uh so there's a couple of example, mrs already, that you can take a look at peyton, the work that peyton shipped and the some of the some of the widgets that have been rewritten um so start by looking at that and see how that applies to yours and anything that you need from us. Any shortcoming on the implementation or something just bring it up here or slack, we'll happy to oblige um just help out sure. Thank you, cool scott. Anything from your side.

D

Nope we're good. We, we have um the the last two widgets for our group uh scheduled for next and the following milestone. So um the level three um issue is scheduled for 1410, so we're fine if it doesn't make it to 14.

B

Okay, cool good to know which, which would you have level three in it just saying.

D

The the test summary widget- we've split it out because it was like a five point issue anyway, so we we just did the first two levels and and one issue: yeah: okay,.

A

That's cool, uh so all in all, we should be looking at 1410 being one of the well, not the final target. Of course, there's always ongoing stuff, we'll be probably in a good shape to start talking about turning it on.

B

Yeah did we come to a conclusion that to start enabling it now, let's definitely add that discussion at some point.

A

We had it, we did.

B

There might be weeks ago.

B

I remember at 13 mark sound.

A

A

I think, as long as we have the majority of the widgets, I think we can start turning that on we'll just have to to move the feature flag from a global feature: flag to individualize feature flag on widgets, and then tim suggested, starting like onion like enabling them for a certain project um and with that that will give us a lot of feedback, whether the mix would be confusing or not, because if like, if people start what's happening, what's this, this has colors. This doesn't have, which is right.

A

We don't want to revolt, so let's um hold off on the rollout, but if 90 of people like seeing that makes accepted as acceptable, we just move on to production, while other things are being rewritten, because right now the current problem is that there's so many things changing that if we enable it now, there's a high chance that things will break for users, whereas if you're, just rewriting one widget under under a feature flag, then that's a lot less prone to breaking, because we won't be touching the car component as much.

A

I feel like that's a solid strategy.

B

The core comparison should be pretty stable now going.

A

Yeah after this one, it should.

B

We just need to check out the car remember if we had the future flight check to hide the old widgets, because there was a point where it was like. We were showing the new and the old widgets together. So we could easily see. I.

A

Know what you mean it's like a toggle between the other. I don't.

B

Want that got fixed or not.

A

We look at the example, mrs, that we have at the top and the way that I think we're showing we're showing both yeah we're.

B

Showing both damage to the change thing to hide the old ones, but.

A

Isn't that part of the rollout, though,.

B

No, the old widgets just don't have the feature fight check on it at all.

A

No, I know, but if we do that now we'll stop people from oh, I see what you mean, so you do.

B

A

Add that check to the ones that have been rewritten.

B

If I enable this fujifilm to be doing it up now, let's see duplicate it. We're going to see widgets.

A

Yeah, well I'm thinking that now it's useful to compare the old and the new while we're developing right. So I wouldn't rush with that until we're ready to turn that on so, for example, maybe 14 9 on 10, we can add that check so that the old ones don't render at the same time as the new ones, so maybe create an issue for it and that'll. Be that and then we'll just pick it up in 1410 to.

B

A

B

A

Fix the feature flag check. Yes, does that sound good yeah? So I'm going to put a note here, uh robot plan discussion on the agenda. I don't know how to write roll out.

A

So, let's open an issue to add the feature flag check properly, to not show the old ones. If the.

B

There was also an issue by pedro, it's kind of not related to the widget directly and as soon as you can just make the most sense. So these ones have the nice icons where's. The actual widget itself would still have the old icons.

B

Now pedro made an issue to change this icon to match the widget icon, the extension icons as well, which one so.

A

That's the merge one.

B

Yeah, just for any of the didn't base, widget like the raised major stuff that way.

A

So that's not a report widget right.

B

No, no thank you just just for you to know, so. You can schedule that work.

A

That's good review stuff, but like.

B

That we're going to get our have that mix anyway, with the new icons and the old icons in it.

A

Yeah, we could add a feature flag check but seems like overkill yeah, I'm with you yeah yeah. Let's go ahead with that. uh That makes sense. uh Can you send me that link to me so I can put it in my radar, um but this sounds good uh and then we'll just pick that issue phil, I'm counting on you to open that issue. Okay, thank you, smart and that's it uh anything else. You want to talk about.

A

Cool then have a great weekend and I'll see you next week right. Take care, mate, bye,.