Jakarta EE TCK, 5 Apr 2023

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: TCK call #30 to discuss Servlet TCK refactoring https://github.com/jakartaee/platform-tck/pull/912

Description

April 5, 2023 TCK call #30 to discuss Servlet TCK refactoring https://github.com/jakartaee/platform-tck/pull/912

Minutes can be viewed via https://docs.google.com/document/d/1V1dDLJkd14EDRMPeuI0VzPtU4Lbli8FFBd1pLDLlOrY/edit#bookmark=kix.494i49txwknm

A

B

Great, um what does so um welcome everyone? um Does anyone have a preference for whether we look at the pull request on in the browser or from command line? Is it and oh I was just looking from the command line? Actually, I was actually just taking a quick view of like the root Palm in the servlet and I built it and, and just was looking at some of the common elements and looking at things like.

B

Oh, we, you know we're we're and how is shrink, wrap used and so kind of like drilling into those kinds of things. um um I see Scott, yeah you're here. Do you have a preference for how we go through this because you.

C

Yeah well like the one starting point uh I wanted to see, is how you switch from the Legacy Java test server vehicle to uh uh the archealian framework. I mean how was that switched on.

D

E

Can make like we can take.

D

E

In the brother, we can watch that because we yeah so I usually get all the classes all the tests. You know they are all named, like URL, client or something yeah, and uh for each classes. uh I. Just look at the build.xml and um uh created like um by code, the uh the equivalent in a Killian.

E

It's a very manual work, so it took time but and so each and then oh yeah yeah there is something else was a bit tricky is um um the Legacy framework or Legacy. It still work, but um he's using like some javadoc annotation and some uh inheritance as well. So it means there is like a very top class with all the tests and uh some URL client chai classes um they do not inherit, um they shouldn't run all the tests from the parent classes and they should run only the tests with The annotation.

E

uh So I had what I, because I changed my mind few times on that so yeah, it's very manual work. Honestly. It was not very um something easy to have automation.

B

um Should I open up my shell and just show you what I was just looking at yeah.

E

Or maybe maybe an IDE or something where's.

C

The board box: do we have the link in there in the notes.

D

E

Right here so yeah yeah, there is.

E

I think it's probably easier to to to have a look in ideas.

B

Do you want I mean if you want to share your screen and do it and then yeah.

D

I can do that. um um Let me see.

B

I was just using VI and that's why not, as.

E

B

I, just grip, I grip for shrink, wrap I opened up all the different test clients, while you're getting things going, I'll just I'll, just I'll just talk for um there's all the test: clients classes we used to in the old tcks our current tck scene, various test, clients and I just saw that you know they all have like shrink wrap in them directly and then they have the what looks like the coloring code um in the test, client class. So just an observation. But okay here we go.

E

Yeah, so if you look at that, one I will take this one. So um I didn't change any name. You know I I would like, but maybe we can do it later, because the the all the tests I still have the name, this name URL client. Well, we can still use them. The package package name so I just like for each I, had a look at the build.xml and say: okay, it does this class, this class, this class and um just manually um change that and.

D

E

One it's pretty simple, and um there is this um yeah. The problem is uh I need to find a better one, so I just add, The annotation for a robust test for all the tests to be run.

D

um What I did there is something else? um Oh my God. Sometimes it's so I I did long time ago now, um yeah.

D

E

uh Yeah, that's that's pretty! That's uh yeah yeah I I use the same um archive name as it used as it was previously. So I don't have to change the context route.

D

um What I did is um yeah, abstract.

E

Yeah I didn't touch everything, I mean it's um yeah, so it's um now it is um here as it's uh still um um Maven module. So it depends on the parent project.

E

um Something we can discuss is to get rid of um command HTTP client, maybe in a later time, so it just generates a jar and I can show you how we run it with the the JD project. Here, I have a I. I can put you the link, it's um yeah. It is uh this project.

E

um I, don't know where to put the link. uh We can reorganize then, but yeah.

B

Anywhere is good right, you know, you know you can start. You know you know. Do it as part of the pull request review underneath there.

D

A

D

E

Doesn't want to pass okay, oh.

B

It won't it won't. Let you.

E

Well, I can edit.

B

C

Chat, okay and keyboard, shortcuts or yeah put it in chat and then yeah.

E

I will even copy.

C

D

E

It so here uh that's the project we use at JD, so it's um we usually uh because we are writing a new version of JD jt12, so it runs with. um We have like E9 E8, E9 E10. So with this tck is more the E uh ee10 version um that is uh running um almost every day here.

E

D

Jenkins jobs.

D

E

Okay running I mean the new right new servlet Eck.

E

So just to give you an idea, it takes um 13 minutes to run uh and we use The Arcadian embedded jetty and we have the uh the current tck I mean the I would say the Legacy one which take like an hour more than an hour. So it makes a big difference for us.

E

So you can have a look at the.

D

E

E

And a good point with this is here: uh I have this project um the tck, um the new one running with um arcanion I, can't even know uh running uh run it in my IDE and debug uh the servlet contner. If it's an embedded one yeah.

C

A

C

Is really just focused on replacing the client side uh uh creation of the artifacts, so you didn't even have to mess around with the the Java test uh vehicles at all right.

E

I I I, don't think what is the vehicle? What do you mean with that? That's something I didn't understand. Already yeah.

C

E

Actual running.

C

Of the test is just has nothing to do with the Legacy vehicle architecture.

C

ah It looks like so that that's great that's one part I was worried about now, you're, showing it doesn't matter at all. Okay, you basically just created the art. The test artifacts, yes from the existing Java test classes, just getting rid of the job to have stuff and replacement with.

E

Yeah yeah it is, it is just a a not effect with all the junits yeah.

C

E

um And to run it in the um I have like this separate um Maven project and in um in the Surefire configuration uh you can just um add. Where is that here? So I I have my tck um the new tck uh artifact, which is declared like here.

E

And um in the show fire configuration I, I tell Surefire to um here to scan the dependency, so it just goes. It doesn't scan only the class pass like the target test classes, but it will scan The annotation from the artifact so that that's it if I want. If we move uh websocket, uh JSP or whatever as well. It's just a matter of adding a new line.

C

Right, okay, all.

E

Right this is great and um in my pull request um there is already like this glass finish: Runner in the The Source three at the moment, so I added um the servlet tck as well to run with glassfish.

E

At the moment it's running a glass fish, uh six, two five, which is uh I'm not sure if it's the correct version, um I I just wanted to have something like nothing depending on any uh implementation like something very neutral in the matter of the tck, so I I have. There is no like um code uh proprietary code in the tck now, um but I have no idea. What is the class switch version to try now.

E

Yeah so uh yeah, okay I, try something like seven, but the The Arcadian uh doesn't doesn't like it. The.

D

E

I couldn't find very like new arcillian, with the glassfish 7.

A

B

Can get you yeah so so there's a glass fish, I Killian integration in the platform dck um as well. So we can see what the version is there, but.

D

B

um I also I posted into chat just what the servlet vehicle um looks like currently as well.

A

B

A

E

C

E

Yeah sorry, this.

C

Is the entire uh test me.

B

Yeah, so so so the servlet tck is is a standalone, Surplus tck, um but um I mean you did the you did the whole. It's the in.

C

E

B

Servlet it, it would be, um um you know, I, think I, don't think you left anything out from the platform. Tck servlet, folder, right, yeah um or or maybe you did maybe left out some ejb and yeah.

E

Yeah I I transform like.

D

What I did exactly is uh maybe my Branch video.

E

E

Here, in common.

D

E

Yeah yeah I I remove a bit of the AGB thing and.

D

There is something else.

E

Yeah, the glass fish tck, um it's I, removed the classes and put it in um in a command in a new folder. But it's commented: it's not active.

B

uh Except the glassfish um deployment descriptors and integration yeah.

E

There was something like very, very um glass fish specific, so I couldn't really uh migrate. That.

E

And I I still have the the yeah I wanted to show you something here. So if I run the the current um document code on my Branch with um glassfish 6.2 um I have it running here. It's there is like 62 failures, but it's it's like E10, not e uh glass 36.2 is probably E8 or a E7 to be A9.

E

Oh okay. So there are filler uh on the test. I I, don't really know.

E

But if I compare um yeah in term of JD, if I comp.

D

um Oh not this one.

E

uh Tck tck: this is the um the current tck, so he got we in our new code gd12. We have 30 failure and with um the refactoring I did um we have this almost the same number of failures, so I still have like yeah.

E

We got five filler I need to investigate because there is a gap between the that's it. That's something I need to investigate those five thinner, I think there is something regarding cookie yeah.

C

um I would expect there's you know a lot of you have to roll in a lot of the the JTV TSE. Whatever that's that's called the the Java test environment settings. It seems like.

A

C

A

C

Properties and stuff that end up affecting the test or getting bundled in art of the deployment artifacts. It could affect that this as well, but yeah. This is great so now that now that I I I just glanced that up before, but now I understand what you're doing I'll take a deeper look and yeah. This is great because it shouldn't have much of anything to do with the whole vehicle stuff.

B

I think the vehicle stuff look: let's, let's assume that the current structure.

C

Is I'm not understanding the vehicle stuff possibility.

B

The um but I was just going to say you know, for the platform for the platform, tck aspects of running other Technologies um with servlet um I I. You know that can you know, can be a platform.

B

You know uh you know, like you know like this is kind of like equivalent to the Standalone servlet tck, maybe plus um some more or not I'm, not sure, um but for the other vehicles where, where the servlet tests are running against ejb and you know app client and what have you that's kind of like a a like like a separate like you know, Builds, on top of this integration, but like the way those vehicles are replaced, you know you know could be yeah, it could be similar, um but you know it just you know just the ejb um shrink wrap and all that it isn't in here.

B

That's what I was trying to say. Yep.

C

Yeah well yeah. The vehicle stuff is still in.

E

C

So then, I need to read. We need to figure out how this I mean Scott. Do you know and test in the current uh Java test based framework when it calls into the client are? Is the vehicle the receiving end of the test invocation on the embedded on the uh on the container side?

C

Because, because that's that's, how a care uh works with our Killian and so is, is that is that actually how this vehicles are used.

B

um So for yeah, so for each each test has like the like the vehicle, the vehicle uh reference and the vehicle kind of just is like those you know. You know, like you know, kind of looks like has like fine finders and um looks for the um um the tests to run so there's like fun, you know fun, you know fun, you know kind of like the enumerates, true finding all the tests for the you know what it's doing and like kind of like so initializes the vehicle and the vehicle kind of likes.

B

You know um deals with um just doing you know you know like initialization. You know boilerplate stuff, that just so that it doesn't get. You know you know. So it's not redundantly. You know you know duplicated it everywhere, um um but but um yeah um so yeah, and then there's like a really there's like a really deep layer of yeah of elegant um code. That just does a lot of inter yeah a lot of things, discovery of what to do and what to run. But um the vehicles are all pretty small, but.

C

That one, that one so I just so I'm just looking at the connector vehicle Runner code in in the pr which is all been converted to you, know just use. um Basically it's just using logging and.

C

Then standard Java URLs to make connections to the endpoints and it's pulling in the properties for the web. Server host works, Etc.

C

The runtime environment so I mean here this vehicle just looks like a client.

B

Oh and under common I see it now: okay, yeah.

B

So, that's probably unchanged: that's just yeah we so common has a lot of the of the current tck um code and it contains anything that needed to change so far, for you know, but yeah so part of it is unchanged.

B

um I would I mean. Let me just take see if anything is referencing, um that um I doubt it's being referenced from the server tck now, but.

A

B

So it's just common, so there's just um yeah one common other common class, connector servlet, um um there's the connect to servlet vehicle Runner. um That runs that and they just see what touches that. But it's that's just yeah I think that's just Legacy code I, don't think we're using any of that now.

B

uh Yeah, just more common, um just um wanted to get rid of common, but um yeah, at least from you know, from the point of you know, of um not sharing common codes throughout all the different pcks, but yeah I mean we'll see you know what we can do.

B

It's fine that we're using it. You know now and I. Just don't know if you know, if we'll you know be able to not.

A

C

But have to trace through how this is getting called.

B

Yeah I: don't think that I don't think it well. We can look at the old code, but yeah, but yeah I mean the old tck, but I, don't think anything's calling it from the new tck.

B

Sorry from the refactor branching I mean.

A

B

A

I went too deep.

C

Okay, so we just yeah sorry does this: how much of the refactor brands, so it's just a little a little common just be.

A

So there's a little bit of a Kind. Oh.

E

Yeah they're still there yeah.

C

But the majority is under the circular.

A

B

So I posted a link in the chat um there's like a main. uh The vehicle, Runner Factory kind of has a get vehicle, Runner method that you know, checks to see what the vehicle type is, and you know it has a case like ejb, servlet, JSP, stateless stateful, app manage app, manage no transaction um and yeah other other. All you know ejb light and all you know other other things as well. So it's kind of like a I think like a root.

C

C

So what what's stopping us from merging this.

B

So I was what what I didn't really say before, but I was going to say anything emerge into the cckb factor. Branch is like you know, is it's work in progress, and you know we're collectively working on on completing tcks, but yeah. We have a lot of work to do so. It's not like you were near an end of a release and we expect that hey. If we merge this we're gonna, you know we can't make further changes. So um I I, don't see any reason not to merge it.

B

um I was just trying to be respectful of the um um servlet leads to give them a.

A

You know to give them a.

B

Chance to give feedback- and they may not been clear to everyone, but which is something I've always have done in the past and and yeah.

E

The thing is: uh yeah um I make a try to um to run Tomcat as well. uh I started like a project.

E

D

Let me figure out.

D

E

I created a project like uh how can you run this? How can you run um this new wisdom, cat but I have a some issue with the current arcillion um integration, uh Arcadian implementation of uh Tomcat, so yeah, uh yeah and I I. Don't have a really big time to go deep to it. So I uh yeah I'm supposed it should be right. Yeah, yeah, I,.

C

Can I can take a look at um trying to run this against wildfly so.

E

I can put them so.

D

B

You would you run against Wildfire or undertow I mean either one well far.

C

We usually, what do we usually use undertow.

B

Well, I I think usually just certainly implementations run against it, but I mean what wildfly a wildfly runner to run. These tests would be great I mean that sounds great.

C

I just wanted to that's the thing we tested most in the E10 is that you know our because we we did it for we updated the wildfly runner yeah.

B

Yep um yeah, we just don't yeah I- think the undertow project may have run against the Surplus tck directly before I. Just you know, I, don't I, don't know. um Okay,.

C

B

I mean that would be I. Think running against wildfly would be great yeah.

C

The only thing I want to I guess I would double check the um the changes to the common modules and see how that would impact the other actually just over so have you built? Does this Branch at least build the you know everything is outside.

E

Yeah it build uh I use a command like um let.

D

Me show you this.

E

uh It is running.

D

It's like a where is that here, okay, it came in so.

D

12. yeah, uh if you look at this yeah.

E

What I'm doing is um I will pass here.

E

I passed in the in the meeting chat, oh okay, I can pass Link in the Google Doc I. Don't know why.

E

But a full bill I think it's a full build works, okay!

E

Well, there are a few modules which need to be activated by a profile.

C

E

Yeah, but if you want to build only the servlet, it's like uh you can use the command I I post in the in the meeting chat.

A

All right so I'll paste those in let's see.

E

There is still something to uh install manually because there are like um an artifact.

D

What's the name, uh it's called.

E

um Java test, something which is a bit yeah.

C

That there's still a dependency on that somehow.

E

Yeah yeah a very old dependency uh like the old Legacy framework, so before before, building the um the servlets uh you need to run I can maybe pass it.

D

Now I can't pass. Oh that's strange.

A

D

um I will pass this in the meeting chat, so here.

E

You know it's like the old Java test jar so because I I didn't remove for um the Legacy framework for everything you.

C

D

E

Is not available in Maven Central, so you need to install manually.

C

C

Well, yeah, oh.

E

Well, I still have to figure out um uh four tests why they are failing in the um in this branch and not in the the main branch. So.

C

Yeah, there's no no problem, leaving it the pr open for now, because we look at it, but um yeah I definitely want to take and build in uh trying to get get it running on a wildfire undertow. Oh yeah,.

B

If it it the whole the whole um Branch I mean if you go to the root, it builds fine as well. Okay,.

C

Well, that that all right this, this is good um I, guess I'm, not so I, I, guess I'm uh I, don't understand what the how the vehicles are still being used. They're.

A

C

I I'm, not it's not clear, because you're still a people.

C

I mean in in the main, in the main, the Legacy tck version is: is there another vehicle class that would be in there? That would be getting invoked.

B

um I mean I mean there would be this I I haven't really gone, you know stepped through it, but the servlet vehicle um link that we posted before.

B

um Let me see um so yeah, the the let me just post the link and I think. Let's.

A

See so oops sorry so Legacy.

B

Serve with um tck um I'll, say under I think under the platform tck at least maybe actually I, guess it would be yeah I guess it would be in I think in both, in both cases, actually yeah um I, think that would be used in the server in the servlet TC Standalone tck as well.

B

C

And this class isn't in uh your branch right.

B

It is in the it is in the branch and we've, basically, the.

C

B

Yeah, it's well, it's in the uh it's in the PR, but I think it's it may already be in the um I think it was. It may have been already in what we already had emerged to the tck refactor branch, which always helps um um yeah and yeah and others you know as well, but um that was like the big effort just to get. You know to get a base going and multi-module.

C

This is the server but okay, so this has to be what the tests are. The client side is invoking on against. That's just the serverless.

A

B

What to you know mostly what I've been doing would be I would like look at the uh I would download the um um the Legacy tck just to really see what is in there and I'll just post a link for that.

B

um So, if so, if we download um Legacy tck, um which I'll I'll do- and we can just take a quick peek at what the vehicles in there um and that's kind of like you can kind of yeah, you can look at this platform tck and see what it seems to be doing. But um um if you unzip um an actual tck, and let me um let me share my um oops.

A

She in my window and let's see, share, screen I, think that would be it right there share um if.

B

A

A find for a star oops vehicle oops vehicle star.java.

A

B

That's not too much um so maybe maybe we don't have that yeah, that vehicle class in here yeah.

C

Because it wouldn't make sense, because it's just a servlet which would mean it would be what the clients are evoking against, but if you're using our Killian, you should be relying on the you know: it's it's protocol, invoker to call its entry point to the server side.

C

So if it wouldn't make sense that way, this one still exists that servlet Runner, that servile vehicle.

C

You didn't have to drill into this when I look at the wildfly integration.

C

But uh Maybe maybe play with it a little bit play with uh your PR yeah.

B

You can see this not very much, you know really there in the um in in terms of um what like.

A

What's? That's, that's odd.

B

Standalone tck that's generally generated from the platform. Oh sorry, I missed I I left out the com. Folder okay, I just want to make sure I didn't miss that when I was searching for.

A

Nope but um yes,.

B

Okay, so that so yeah signature tests, of course, as well so and some some JSP and and common and servlet okay. But no no vehicles.

B

I bet there's some stand-alone tcks that do use used vehicles, I, couldn't say for sure. um I really haven't looked at the vehicles. Much.

B

They just work and do their job for the Legacy.

A

C

This is, this is good, so I I certainly understand what you've done, because I think there's just some questions as to exactly what.

C

If, then, those vehicles are used in any way like so, for example, if we went to.

C

Yes, well our so, do we have any tests that, like that embed, bjbs and surveillance? Oh sure,.

A

C

Let's see those are in the egb module. Okay, let.

B

Me, let me just let me just share again and.

A

D

And it might be yeah I, don't know.

A

A

Either either direction um some egb s correct.

A

B

Looks like ejb under servlet being used.

B

um So if, if we look at the act at the um um when we're looking at the install directory before under other the vehicles um properties, um most of the um at the in the platform, tck, um um the um um you know, all the for for each technology, pretty much all of the other Technologies are are used and.

A

um Let's see oops just get back into that install it.

C

Looks like just from the packaging. It's probably just that you have EJ bees in a war, not so much that you're trying to link them into our embed them and sort of like or inject them into a server. So.

B

It it and- and so this is the platform tck um vehicles um uh listing and we can kind of it. It just kind of gives a like a almost better overview of the technology is used in the different.

A

um Different areas and like even.

B

Like for ejb um light yeah, you could just you know, as you can see, the JSP, the servlet technology um being used and, of course, ejb embedded um yeah.

A

Oops, let's see.

C

um All right so Vehicles there's still a two to be determined issue, but.

B

Yeah I mean is: is it isn't it like yeah? So we have the shrink wrap code um to bring in like if you package it up um different I guess different aspects into like you know in in you know in in into like the say like if you know into it into a jar or War, you kind of kind of you know, have one common shrink wrap code bit, that's kind of like crossing over the different kinds of you know servlet and ejb, and what have you so you so yeah?

B

There's an integration question there, um but it's probably something new that we would do in. You know more than trying to keep the whatever you know the current Legacy stuff, because I just find the like Yeah The Legacy, you know tck does so much um and yeah. We don't need everything that it does. So we can either report it and bring it over and migrate it and remove what we don't need or do something new I, don't know which it will be easier, but I guess we we'll figure that out a.

C

Lot of what it does is obviated by being able to run the unit test within an IDE these days, because I mean effectively that's a lot of what it's features were designed around is to build a you know, create a new set of tests to run and they're they're tidy their their interface, which nobody uses anymore. So I mean as long as we can get a genuine, an artifact that you embed into an ID that that's all problems, but anyway, yeah.

B

Yeah, that's yeah that that yeah, that's yeah that'll be interesting.

A

C

Thanks for going over this, do you pronounce your name, your name Olivier or yeah,.

E

Yeah yeah, oh yeah, I'm a French native base in Australia, so okay, but.

C

E

I'm used to yeah.

C

E

Not my real name anymore, okay, so it turns to Oliver or Austrian and usually say Oli, because you know that they, like short.

C

E

Everything here.

C

I appreciate it appreciate the effort appreciate this uh PR. That's great.

D

E

Oh it yeah. It helps us a lot on the JD project, so I think I still have a bit of work to do, and maybe I will like to fix those three four uh different stairs and uh maybe when it's ready put a comment uh and I like to do more on that more cleaning. But we can do it after a while. You know yeah yeah yeah that are more work, a lot of work to do on that and I'm not sure.

E

What's the next step, uh because we have so many personally I will more focus on on serverless like um uh web sockets or um JSP or El, uh because it's what we use in jetty, I'm, not sure I want to do the AGB things or whatever yeah.

B

No, but anything that you don't want to do like ejb and now, and this isn't being recorded by the way.

A

B

Someone will do that I was trying to say before we're kind. We kind of have you know, so this is kind of like the Standalone servlet tck. Equivalent of covering that need um they'll be. There should be work that follows on to cover what we needed as the last bit of the release, which is validating that at least one implementation platform, implementation works and um we hope to get to yeah to that early. But yeah there's just there's a ton of work. You know to get there and um um but yeah you don't like.

B

If that's something you don't want to do, do you know do what you want to do and we want to find people who also want to do the things that you don't want to do, but um Scott was saying it earlier in the call we need to understand. You know the roadmap better of the recipe of how to do this, and you know this is really you know useful. So.

C

B

Can find those other people like.

C

One thing I'd like to uh uh I guess: keep this branch open until you find like one of those one, one of the reasons for those that discrepancy of four tests, because I yeah I bet there's some missing uh configuration type element that that was that's sitting in an ant file or one of those ts.js files that didn't get rolled in first. You know because it's it's easy to miss. It's.

E

Like if you could identify.

C

One of those, and then we know what that is, then it would be more straightforward to just emerge this, and you know we'll clean up clean it up as we go along.

E

Yeah I agree uh anyway. If we merge this one, we will merge it to the.

C

E

Refactor Branch, so it's not very master or what it's just another refactoring Branch, so yeah.

D

E

Yeah, the tests are probably like a missing slash at the context or something somewhere. It's probably something very trivial.

B

Sorry I didn't hear what you said Sky about what you want to wait for before we merge, but.

C

So he uh he said, there's four: there's a discrepancy between Getty running against um the ee-10 tck. Oh.

A

E

I'd like to get this uh clean before uh to have at least the same number of feathers, yeah.

C

Exactly you know at least know what the cause is.

E

um Yeah I think I have identified I know for two and I need to do the rest here.

B

So once we get that, then we're ready, you know we're ready to merge. Some I think we're yeah and the pull request is ready to merge to the tck refactoring, but yeah. Tidying that up I think would be, would be good and helpful, for you know, for others who, um um but I was I was going to also plug yeah. Once this is merged, then the following: the follow-on pull requests will be a lot smaller and easier to um review.

C

So the only other thing that could potentially be done is I mean. Is there any way to script? Any of that manual work that you had to do to go through and you know extract what the the test, the the test, artifact included in it, because that's I was actually talking about this problem that he's unrolled in the morning call because that was the concern is that you have layers that are adding to the definition of the the current test.

C

Artifact, you know that you know doesn't match how artillion wants to see it so ah yeah. You know that's what he that that's the the manual step that he had to do, which is you know, not trivial, so that could be uh I, don't know if there's any way that we can transcript it. You know python.

D

C

You know something like that, so I mean now, but what I've seen now that I've seen what you've done, that you know um I was going to take a look and I mean. Is there any way that we can at least identify a pattern because I'm going to start on a Wiki for this migration.

E

um uh Maybe we can the the program is to translate the uh build dot, XML.

C

E

Exactly that's the problem, a few lines of java code so.

D

E

Yeah I need to to look more at this. Maybe there is a way, but.

D

C

I'm not sure, really yeah. Let someone take one to do with that, but yeah, it's a great start all right we're out of time.

C

Thanks appreciate.

A

C

Lot appreciate the effort thank.

A

You thanks everyone all.

D

Right right, yeah, right.