Kubernetes SIG Instrumentation, 12 May 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: SIG Instrumentation 20220512

Description

SIG Instrumentation Bi-Weekly Meeting May 12th 2022

A

Did Sir okay, uh welcome. Everyone today is May 12 2022.. This is the bi-weekly instrumentation meeting. We only have a couple things on the agenda. The first thing is kept planning, so let me share my screen.

A

I think it's this one gotta be careful not to share the wrong screen and show all my work stuff, foreign, a little bit a.

B

Little bit worried.

A

About that all right.

A

Okay cool, so let's see open caps.

A

All right, so we have a few open caps. I think this one is done. I don't know.

B

A

You have the dock, do you.

B

A

B

um Let me try to find it.

A

We should put it in the middle notes.

B

I, don't have it I'll try to find it in the meantime, okay.

A

A

So we have a couple open caps and we have like. uh We also wanted to discuss I, think um metric stability to Beta I, think that was also yeah. We mentioned yeah in the Bible with latriage. um So should we go through all of these uh API server tracing? Is this one yeah? Okay? Let me just let's go through all of these.

A

uh Damien, what's going on with the graduating metrics.

B

um For this one I don't have anyone working on this, but I think like we won't be able to make it GA right away because, like there is a field that needs to change in the API.

A

So, do you want to change this description to be like 126. we're going.

B

To skip this yeah yeah I have nobody walking on it and I don't have time before. Okay.

A

What about the custom one same thing.

B

um There is um uh that he's working on it Okay and like as of now I, don't think there is any change in the API that needs to be made to this one. As far as I remember, um the only thing that we wanted to tackle is like trying to figure out if we could um extend cubic at all to also show custom metrics.

A

That's that's considerably more involved right. You have to. You, have to talk to CLI.

B

Yeah yeah, but we first wanted to check like if we need to extend the API or not and I think like I started some work around that at some point as well, um because you.

A

Can also use a cube, cuddle, plugin.

B

Yeah yeah definitely.

B

Like since we need to go to GA like it's either like we go to GA or we get a new Alpha version of the JPI, so we need to figure out like if this use case would require a change in the API or not. First I would say I.

A

See so all right, that's my 125 126.

B

uh Yeah I need to rename to rename it, but I think uh young uh opened a new cap just for that. So maybe we can use this one.

A

Okay, I'm going to leave should I just close. It then.

B

Yeah yeah there is one that was open, yeah yeah. You can close this one I guess: okay,.

A

B

A

B

Okay and this one tracks, like G, actual improvements.

A

Hold on, let's open that one to take a look at it.

A

Okay! Is that anyone reviewing this? Do we have a track? I, don't think we do.

B

I, don't think so. I need.

A

B

A

B

List but I haven't had the chance to look at it yet.

A

All right awesome, look at this. Oh.

A

A

Contextual logging- this is done right, like everything is, these are all merged yeah. This should be done. Yeah and.

B

Even the chip placement original.

C

But Cloud, what do you mean by close? This is Alpha scope.

A

Oh, is this just Alpha like why is like this should be check marked though right. Well, this is for Alpha, so we can. We should be able to close this.

A

C

You want to have.

A

The same tracking issue for beta and.

C

Usually it's good to read before closing cup like I think we should be in Alpine 124. It's just like the, but I would double check with the the graduation criteria on the credit cap, I.

A

Mean it so, it looks like everything that was here for Alpha is merged. Yeah.

C

But this is just to track peers that I'm in Flight, not the scope of work. Okay, it doesn't find this like that yeah it's. Unfortunately, we have multiple places to to track the scope.

A

That was that was you, volunteering Merrick.

A

By the way, uh okay, this one we just went through right, same thing: yeah.

B

This one is a bit different again, yeah, it's it's a another difference like OU is not working on it because, like shway, uh I didn't have any time to work on it anymore. Okay,.

A

So can you do you want to change this to 126.

B

um Maybe 125 and I was trying to figure out like how much well.

A

B

A

C

A

C

A

Like given that we have, we have one month, one month, we need to update these dates. uh Okay, yeah. Let me.

B

um Because yeah this one I guess we can close this one and reopen one because like it seems that we won't go ga with disappear yet, and we would rather like create a new Alpha version of it.

B

So I guess like we can close that one and I can realize this.

A

Is for the resource, metrics API right.

B

A

B

Yeah, we don't.

A

Want to graduate that API.

B

um Like we could but like the API can still be extended. There was a discussion recently uh well Maverick put me in which you add, maybe storage, metric, no.

A

B

A

You should just graduate it because.

B

Then, if it's a new.

A

One, no, no, no, no, no, no and just add metrics to it, because metrics are individually versioned, so the metrics endpoint being versioned actually doesn't have that much semantic meaning anymore, and it doesn't make sense to just create a new endpoint. Then everyone has to migrate metric endpoints. It just doesn't make sense. We should just promote it to stable. This is a this. Is your API for resource metrics? Oh.

B

Things will be added, and print is the actual API. Yes,.

A

That's the API. We.

B

Are going to honor.

A

This endpoint right I mean do you are.

C

You talking about cubelets just.

A

Yeah resource resource metrics right- these are the I mean no.

C

This is the resources in metrics API, not resource metrics in cubelet, I mean I, agree: okay am I getting confused.

A

B

Little bit, it's.

A

C

B

C

B

C

B

C

Which we're not talking.

B

C

Yeah so you're right I mean about.

A

C

Other one, even if we would it's same for metrics API until you don't break you, don't like we plan to make a breaking change, we can still graduate it.

A

We can also just add to it right, like like each individual metrics has uh yeah.

C

Yeah until you totally not break the API, I mean like change the semantic meaning of some value of them. They're like compatible apis yeah.

A

Let's say we use Prometheus version 2, which has a different serialization format. Then we should have a different API. You know like like.

B

Even if it's stable, you can still add new fields to the API. For example, hey, like you, can still extend it so.

C

Yes, what graduating is promising that you will not break it. I think you should okay, like best would be to read. I would recommend you to read the kubernetes API rules. I'm, not I will not give you guarantee, but Han should be. Are you not closer to API.

A

Sure, no, you can add new optional things.

C

Yeah, okay, optional: it needs to be optional, yeah.

A

C

Has to be optional, so it would be good that you figure out what is the car like the important stuff? First.

A

Yeah yeah, but you can't you can't remove. Obviously you can deprecate them and that's fine. You can call it feel. Deprecated.

B

Yeah you can but like if it's stable, you can't anymore, like it's, not.

A

Possible yeah yeah. You can't read yeah, because you can't really remember.

B

That's why, like I'm, trying to take it slow uh with these ones, because, like once it goes stable, we are like plot. We can't be able to do anything anymore.

A

I think that makes sense, uh I will just leave this in your should.

B

I just send this to you uh yeah. You can understand me as well, or you would be working with me on that one.

A

Okay is this done?

A

uh This looks done.

C

I mean like beta: oh.

A

So so you're gonna keep this around for You're Gonna Keep this around for stable.

C

All right, I think I would need to check, but I think we were planning to slip One release because you we need three versions to guarantee to not break the backward compatibility yeah, so we removed them or we deprecated them two versions ago. We need one version more.

A

And then and then and then what's the plan.

C

And then we remove it and we'll wait for like bumps yeah.

A

Yeah people, people, okay yeah, it sounds good. Okay, I'm, just gonna should I send this to.

C

You that's that middle step, like with hiding what you propose, what you did. We could hide to scare people before they notice yeah.

A

I kind of like that, because it's a little bit friendlier right people freak out and they're like oh wait. I can turn it back on how thank God and then they have a quarter like.

C

Yeah, we can I think.

B

C

Think it's more reasonable because it's yeah people like.

A

Yeah people don't do anything until it breaks and then, when it breaks they freak out that that's my argument for it. But okay I'm going to assign you to this. No.

C

I'm I think I I grew out so I'm already yeah.

A

Okay, okay, then I will keep it.

C

Okay, like I, mean oh.

A

Okay, okay, I delegated.

C

Implementation to poly so yeah, but so.

A

Should I assign you or no.

C

um We can just I can bring this topic to the work to working yeah.

A

Okay sounds good.

A

C

A

A

This one is slated for beta in one two: five, no Alpha.

B

This is merged.

A

B

I, don't think so. The pr still seems to be open. No.

A

I just did another round of review. Okay.

B

So we should update.

A

This right, they get final review, so this should be five. Then right, yeah, six, something like that.

A

B

A

B

Need to tune it face slowly that she needs to update the cap document because, like the KPM might be still referencing, the previous versions.

A

B

A

We go and then we should otherwise be good right.

A

A

A

um This is the uh I want to be on this. I am curious about this.

A

A

Express metrics pod model: uh this is Clayton life cycle.

B

Of rotten, this is.

A

Right we should hold on.

A

A

Now so we need to do something about this, because it's an alpha stage right.

C

uh Yeah, it would be good to make decision yeah.

A

Otherwise we have to, we have to kill it.

A

B

A

C

Yeah so saying it was similar for the log filtering or this Dynamic log filtering. We like.

A

If there is no.

C

One working on this- those are alpha metric, I, think those are alpha metrics we can make them.

A

We can delete them.

A

Okay, I will have a small.

C

um One thing is: is there any way that we can like the more positive option would be to find someone to work on it? If we can announce it, but.

B

Yeah because I think, like even in Cube State metric, we are using this new Matrix right. We already depend on this stuff.

C

So then it's all that.

A

Needs to be done to graduate them. What's in the beta criteria, I think there is been a criteria- foreign.

A

We could just have an empty cup that just graduates at the beta, because it's being used I, don't know what else we need from this, though,.

B

A

They're, just a series of metrics right.

A

It's baked for a few releases, so they don't, they don't seem to be causing problems which is ideal.

C

Yeah would be good to have a better stage like we cannot graduate the metrics themselves, but it would be good to have a better stage, so at least mark them as.

A

That is next. After we get through these capture, we can talk about that.

A

We can talk about.

B

A

uh Structure logging and we're running out of time too wow. uh We can talk about next time. If we run out of time uh structured logging, you guys have a working group. We probably don't need this to track this here.

C

Yeah, like you, should make sure that we are doing something.

A

Yeah, what's that what state is this in beta you guys.

C

Are doing it um so we are planning to migrate scheduler in 125, but to do that we are doing it by or like scheduler was migrated, but we are doing the contextual logging. So basically we are migrating merging to migrations into one um so that the cover plans want 125. Is my great scheduler to contextual, login and update all documentation to use contextual, login and then close like and then continue structure. Looking as a migration, yeah.

A

Smaller diffs or less diffs yeah. That makes sense uh so then, is that beta is that part of beta.

C

Yeah, like we yeah so not like, should probably beat uh like beta for a long time so because we.

A

Added to do here, like uh oh.

A

Right, we probably should right where's the beta.

C

What demon can do.

A

Of uh yeah a lot of stuff- oh my God, it's so hard to find there.

C

A

Here we go, I can just.

A

Okay, what is what is the specific thing? How would you call this uh scheduler migration.

A

A

C

uh I don't know so I would treat that the the Milestones that you or beta Maestro has done I mean things to read. Beta was done just we are working toward towards ga.

A

C

Ga issue: like move: it's yeah, we we graduate like we are in beta, like we.

A

Okay, you guys have already graduated to Beta, so this is a ga thing. The migration itself is a ga feature. So then.

B

A

Should have we should have a ga thing here like yeah?

A

When do you think you're going to go to to ga.

C

Like I was hoping to not include full migration as part of like the original criteria for GA was, we will invest enough time, that's reverting. It will cost us more than than doing it. So, basically, when we were a significant migration, like doesn't matter like we'll continue to own its own and the rapper will do it like people will migrate it on its own, but I don't know why.

A

What are you talking about? I don't want to do it I mean it kind of kind of have to do it. I had to do the entire metrics migration yeah. You.

C

Have to do it ten thousand lines, it's a lot of lines, yeah I! Imagine it's ten thousand lines. I.

A

C

A

Had to touch every metric, I literally had to touch every metric. Yeah uh I'll give you 127.

A

127 GA release date or.

C

If you want to plan yeah.

A

Maybe yeah well I mean this is this is not set in stone? We can obviously edit this comment, but it'll give us something so now our Target release date is 127. and then uh I will.

A

Okay, since since you seem to have that all in your head, I think that's this makes sense. um Okay cool, so structured logging is nice. Congratulations! It's coming! It's coming along uh APS server, tracing Beta release date. This is not correct anymore. We are shooting for 25.

A

A

And otherwise, we are good on this right. Yep I have to update some the cap or something okay.

C

A

Have my business to.

C

Follow a discussion with David about at the city- and this is.

A

Can we close this, you should be able to close this. This is done no.

B

No, this is far from being donation event.

A

Api, what are you talking about stable, it's in jail because I think.

B

Yeah but I think there was still some stuff to do because I think the new API like is.

A

B

To me, you know.

A

Is this lighting the new.

B

A

B

B

To me, the new event Superior is better at most and like it's only used by like one of one component in the whole.

A

Company, oh, it's not migrated yet. Is that what you're saying yeah yeah I mean it's a stable okay.

C

This is like the problem is this was not originally a cap. If I remember correctly, this was and the previous process. It was just migrated to the cap, because we noticed that it was not that finished.

A

Okay, so this is not done, you need to find an owner for this.

B

Yeah he wasn't easy to put together yeah.

C

We did yeah I I, also like done them and said I, also remember that it was basically design new app you, you use it in one place where it mattered, so performance wise and then don't use it anywhere and yeah.

B

It's only like the scheduler or something like that is it or maybe controller manager, or something like that.

B

And there was like I think um there was some concerns about like moving everything to the new API.

A

Is that this is an accurate description.

B

A

I mean you can't just create a new event API and then call it Dash see. This is why this is why the migration has to be a part of GA for structural logging. Otherwise you just introduce the new logging thing and then basically, you just have two things.

C

I mean we have static analysis that will prevent people from from.

A

Doing new things.

C

Yeah like for doing stupid things I mean.

A

B

To sync, with Jordan right, Jordan had some ideas and concerns about like the whole migration. Okay, I think Ilana already talked to him at some point, so I.

A

Don't know, let me Circle, let me talk to Jordan about it and then we could Circle back next to the meeting and then we can also talk about the migration uh Damian. If you want to meet sometime in the next few weeks, because that's we should probably chat about yeah, you said you mentioned you're interested, so we should. We should chat about it sometime in the next two weeks. If you want to yeah.

B

That you could chat with me, yeah.

A

Yeah yeah sure I will share it with you right after this meeting. Okay there's some sex thanks everyone for joining uh yeah I. We will see- hopefully everyone uh in triage next week, see everyone all right. Bye.