Kubernetes SIG Instrumentation, 17 Mar 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: SIG Instrumentation 20220317

Description

SIG Instrumentation Bi-Weekly Meeting March 17th 2022

A

And welcome to today's edition of Sega instrumentation, it is Thursday March, 17 2022.. uh Today we have a very, very packed agenda. There is one item uh and it is a reminder about code freeze, uh which is in a little under two weeks now uh so because this was our last meeting scheduled before code. Freeze I wanted to make sure that we still met today, anyways, uh so that we have a chance to discuss anything that we might want to ensure that lands. This Milestone uh I, don't know. What's going on with our various caps.

A

uh Is anybody waiting on any approvals or things like that in order to land uh various enhancements? We have targeted.

B

Foreign, no but I'm waiting for us to be on 118, so I can commit my changes for the sets.

A

Honest very excited about go like generics. uh Let me take a quick look at our I might as well share my screen. um This is my screen.

A

Everybody can see uh enhancements, I'm, just gonna say a quick look for instrumentation and this milestone.

A

uh We got a bunch of things, have have these landed, I! Guess, let's take a look. We have a lot of the authors here. So uh I'll start with David. uh Is this gonna go to Beta this release.

C

Actually Merrick, do you know if um the LCD release is still on track to go to get in before the release.

B

C

B

Didn't see the activity community- oh yeah,.

A

B

On disaster in LCD, Community Land, there's.

A

Disaster hold on remember: this is recorded what sort of disaster no.

B

It was literally, it was literally in the public thing.

A

What am I looking at.

B

D

I I just wrote this a small email but yeah a lot of people who are yeah yeah. So to answer like the email is about like the some problems with activity so but to answer David's David's question we are like I, don't think we just I cut only Alpha for hcd and we are not close even close to to be sure that we will GA at CD before before.

D

C

That's good to know. We should probably move this out. Then. Okay,.

A

Let me clear the milestone yeah.

B

D

Would also love to have some help to graduate the tracing codes.

D

So basically, one of the things I'm working on is triaging and release managing for for features that were added like five years ago and no one cares to graduate them. So it would be good to graduate because it's still experimental features so I assume foreign.

C

D

C

As well, I still I would like to get a little bit more feedback on the tracing stuff, um I.

A

Think that's good. Honestly. uh There are cases where it's made sense to go from like Alpha to Beta after a single release, but in general uh I, don't I think it's good to get more feedback and get bug fixes in and that kind of thing. Yeah.

C

A

C

To get this to the right people's hands to make sure that it's what they actually want, so cool there's a little bit more for for me to do there.

A

Great uh next we have kubernetes systems, log sanitization, which we are deprecating that is still on track. All of the work is done for it. It merged super early. In the release um we have uh uh I. Think uh Peru uh has uh volunteered to do the doc changes for this, which is basically removing it from documentation.

A

Thank you so I'll just put note of that.

A

I thought it might be a fun thing for her to work on um open, Telemetry tracing. uh Apparently this is assigned to han han. Do you know? If did this? This has not merged.

B

A

We know what we're waiting.

B

On here, why is this assigned to me.

A

I, don't know why did you massage it I assume you decided to yourself, you assigned it.

B

Oh a long time ago you.

A

Want me to Auto sign it, but.

B

I can take a look at it. Can you can you ping me on CC and then it'll show up in my.

A

Email, oh, this needs a rebase, so let me ping I. Probably this hasn't been reviewed because it needs a rebase. uh It looks like that was two weeks ago: I'll try to Ping Sally um and let her know uh well. I can put a comment on here too I've.

C

Been keeping an eye on this I think it still wasn't passing tests last time. That's not good. If, if it is ready, then uh then we should probably then I can take another review as well. I think I'm assigned.

B

A

So we're not sure I'll pay exactly on slack as well, so I'm going to leave that tab open uh Merrick! What's going on with uh this deprecation that Kellogg Flags.

D

A

We're done it looks like it's done next week, nice.

E

I I think it I think it's done. They were asking about documentation, but I, don't think we actually need to update anything in this release. There haven't been any changes.

A

Oh, we Market, as needs Docs.

E

Does anyone remember what specifically needs to be changed? Nope.

A

Yeah, uh let's let me just double check in the cap. What the uh what the graduation criteria were. Her beta.

A

A

Go Runner project is well maintained and documented documentation on migrating off. K-Loc flex is publicly.

E

Yeah we already published that that's in.

A

E

The systems uh locks MD file.

E

We have documentation about that.

A

Where is that maybe can.

E

You link it I I I'm, looking for a link, yes.

E

I just need to fight the right. Branch I know where I have a pull request, but.

A

E

Do that offline, yeah.

A

uh I, thank you, so you can do that offline, great um and then contextual logging I feel like I change to the spec came in last minute. Are we okay with this one slipping.

E

I I think we are. We are getting this into 124., so, okay,.

A

E

Cap, the cap has been merged, has been approved by dashboard. It was reviewed by Tim and and uh maybe.

A

I was thinking of something else. There was something you pinged me for a review for earlier.

E

If this was this, was this contextual logging update but Dash David David uh yesterday approved it? That's why.

A

E

And we we have done the work with dims to update klog I'm, now updating keylog in kubernetes and then the remaining code changes will go in soon awesome.

A

Okay sounds good, so then that's on track. So then, really it's only uh the cumulate tracing that might miss, uh given that uh we definitely booted API server tracing. That's sad I was hoping for another release of tracing goodies, but tap it cool uh uh great. uh Let me just put a note of that in the agenda.

A

A

I will stop sharing my screen. uh I. Don't think we have anything else on that uh it looks like we have. An agenda item need reviewers for K log.

B

Who would like.

E

It I I just noticed that uh the people that we currently have in the owners file of K log might not be the right ones anymore and there's actually an open issue opened a while ago uh about that, and my observation just is that if I open a pull request against klog, it pretty much only always goes to Marek or Tim, and all of the other people listed in the owners. Files are not very responsive.

E

So the question is: can we update the owner's file to actually have some people from seek instrumentation in it that are willing and able to to Refuge pull requests?

E

Because, with a revised Direction with contextual logging, we now agreed that we will keep using klock infinitely as the logging package that is used by kubernetes, and then it makes sense to be fully owned by by SQL instrumentation as something that we need to have an eye on and need to maintain.

D

Yeah we can trim the the owners, but we, you know we need to just uh maybe more yeah.

B

We should probably put yeah.

A

I'm, looking at this owner's file now and.

B

A

Yeah, at least like I, would say two or three of these people have not been active in the project for over a year.

D

A

Approvers um there's.

B

A

Three computers on that list and like he went Emeritus like three years ago two years ago, something like that now, six.

B

People I see six approvers who are not active, yeah lava lamp, CZ, pyotor, Tim, all clear Justin, SB dims.

C

Generally, people who are active in the project I feel like it's okay to keep them for things, but I.

A

I suspected the reason that uh pyotor and uh Frederick are on that list is because they were the chairs of Sig instrumentation at the time, uh but I don't think either of them are active in klog yeah. So.

B

Let me comment.

A

On the issue and say that, like we think that this is still relevant.

D

Yeah so I plan to use the dims maintainers tool to clean up the owners. So assuming that someone at least wrote was active in reviewing or like any issue comments we, it should be like we. We have a tool that is accepted by Community to trim the owners. We just need a way to to get- maybe not not necessarily owners as an approvers from City instrumentation, because we have approvers.

D

We just need reviewers, which means people that want to have a first pass and maybe like one idea, was labeling like this report is not labeled with Sig instrumentation. So, basically, not it's not even cc'd or seeds, maybe not wasted.

B

For some reason, I get the the notifications I.

A

B

A

Any notifications for this.

B

B

I get notifications but they're never assigned to me so I I, don't look at them. Sometimes I do look at them, but I I don't comment because I'm not in the reverse file.

A

B

A

It sounds like a good step forward, for this is uh an action. uh Is that uh Miracle run the maintainer script to update owners, file and I?

A

Think that, like you know, getting more reviewers for klog, like I, think that it's challenging to recruit new people to do a thing if it looks like there's a bunch of people who are active there and like for people who don't realize that, like people might be in an owner's file but aren't active they're like oh but there's so many people in the owner's file, uh you know you won't need me right.

A

um So I think it's good to like make it explicit that there are many fewer people active than are on this list uh and then it'll make it easier to start uh recruiting and growing people uh to help out with this. So I'm definitely a fan of going ahead and doing this. Thanks for taking the initiative, um we.

B

Should include a comment that says welcoming new reviewers yeah, no seriously I'm serious, because people look in there and if there's a little tagline that says, welcoming new reviewers, then.

A

Come on, you can add the tagline. If you want or you can I don't know, it depends like.

B

Somebody's gonna, let someone's gonna, run the tools, so it's going to get modified. So yes, uh I'll. Do it afterwards.

A

Great, uh maybe we can even send an email, but I think uh you know if, if uh you like, you being the the organizers of working group structure, blogging want to like go on a mission to like recruit some of your helpful people and be like hey, we want more reviewers in klog. Like sounds good to me, sounds great.

B

I gotta I got a pull request on uh prom queue. Today, nice yeah, that's slowly, slowly gaining traction. There's 20, Stars, I'm, surprised.

A

Go get our sub projects are uh doing great yeah.

B

Yeah, that's awesome.

A

Okay, uh I think that's everything for what we have on the agenda. Do we have any other items? We should consider in our remaining nine minutes.

A

Sounds like no so I will end the recording.