Kubernetes SIG Service Catalog, 6 Aug 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Kubernetes SIG Service Catalog 2018-08-06

Description

vote results
controller redesign
originating identity on by default soon
pr review
milestone 0.2 review

A

Hello. Welcome to this week's edition of Service Catalog.

A

All right, Doug brought up radio and I can't help myself. Sorry.

B

A

I will be our facilitator for today. I've pasted it into our chat. The agenda looks like that one's out of their name to it. I'll just walk us through it. We're gonna save the top-secret popcorn announcement for the very end.

A

First up we had uh two sets of votes last week. Morgan, do you want to walk through yeah.

C

Yeah sure yeah sure I forgot to mention lazy consensus. I think everybody got the idea. There were no objections, so I think that's a good thing to go. Go forward.

C

Does anybody want to actually make the PR in test in front I? Think somebody besides me should do it I want.

A

To do it, I want to do it. Okay,.

C

And I will feel walk you through it. If you really, if you, if you want and if not I, will point you at a PR and you can figure it out or whatever I'm.

A

Just gonna rip off one of your old PRS and figure excellent.

C

Waiting on Carolyn awesome, the delete thing: five was a ten out of I. Don't know how many voters we got but yeah. That was definitely the majority opinion there in multiple ways, so I believe Jason to follow up about. You know a plan to tackle it.

C

You know I, don't know if we you know we want to try to force this thing through if we should make a working group of what or what not, but you know Jay. Would you like to speak to it? I.

D

Don't think there's any forcing I think I think the approach, so I thought what I would do is I'd start doing a write. A proposal on the web books also sometimes dark a proposal in OSB API.

D

Anybody wants to collaborate, work on it with whatever I'm actually welcome you and you know so: I'm Ellis, ba OSP API side. We obviously need to manage the naval brokerage to register. Saying hey I want to have a web hook for validations on create, update, delete on instances and bindings, and then we need to hammer out details the other actual implementation of that language. I thought.

D

First, we just float that up to the OSP API make sure it's going to this float and on the Service Catalog side, high level, design that we can all you know, review and agree on before we get going too far with it so and be my desire for a week.

A

I'm glad you said proposal.

C

Alright sounds good to me.

C

A

Cool, so if there's nothing else about that, J actually you're up next for broker action, work whose right.

D

Is Jonathan's at the one yeah I guess so I meant to have something done for that, and actually I probably should taken out of the agenda because I didn't get any prep them. We discussed this at the face-to-face.

D

The idea is to launch a another group to do a high level design reworking how we're doing the broker actions so that we have an appropriate backup and retry mechanism so that we don't hammer brokers on errors as we, we attempt a failed operation. I added this to the agenda. I meant to have something for today to get going into review, but I guess I'll just make it as a call, for you know, drop me a note in slack or whatever.

D

If you want to participate collaborate and we'll work on getting them something for next week as a real action item, I think we need to get moving on this one, it's kind of been dragging on for a long time since we known about it and in the worst case it's it's a pretty bad thing to the platform. I have a couple links there. One is an end-user and platform issue that was actually encountered encountered in the field.

D

The other is an issue from marco, where he did someone else and said: oh yeah, there's there's many problems going on here. The third item linked is just the temporary workaround. We have four instances which only deal with create an update retries. So that's it for me. Thank you.

A

Thanks for looking into that for us I agree: it's not it's not good! What we do right now, right and.

D

Again, just if anybody's interested in getting some early work on it- or you know just certainly take your names next week too, if you want but got, you know.

A

D

Right, the next thing was, as Jonathan was working through the flags for oh geez. What was the feature names faced, industry brokers right? We realized that you know we haven't changes like that kind of thing. I pointed to MIT some stuff that I thought was done for a region, an identity, but it turns out. Originally.

D

Identity is still a complete flag and I guess what I wanted to raise was the issue of I think that should be moved to defaulting to on and perhaps I, don't maybe there's already lifecycle for feature gates called out and I'm, just unaware of it, but I thought we showed I, have some discussion, perhaps around feature gates and how to promote them from a feature gate to a real-time feature. That's on.

A

That's a really good question people who have been around a little bit longer- maybe dog or Scott or cables. Do you have any experience with how we handle the feature gates in the past I always.

B

Thought we kind of did it at first just to make sure the beta levels. There are all the little things that we put into the code we're just going to break people, so we sort of what a future get around it. But I think this one's been there long enough. Now that I, don't I, don't think we need that gate anymore right.

D

Red Hat we've been having it on for the past six months or something like that and OpenShift, so I feel pretty confident about originated identity, yeah.

E

Mostly for like alpha things in the OSB spec as well, that's what I we sort of deferred to caution with those but like originating identities, been around for a long time and I. Think.

B

Everybody uses it.

E

B

Like our time skills these days a long time, yeah.

D

Got me on this was I couldn't say well, Jesus been on for the past six months, because actually it hasn't I mean our helmet right. It hasn't been on we, never we never changed it from enabled equals false to enabled it goes true. So I don't know if you want to take some baby steps here and say: okay, let's enable the feature gate for enabled equals true for two months or some time period and then elevate it on up I'm.

B

Looking either way, I don't like baby steps yeah. That sounds good to me here. All.

D

Right I'll create a PR to change the helm default. It true and I'll also try to do a PR someplace about feature gates in general and say that you know we want to try to elevate it up so initially starts out as false and then we'll go to true some period of time and then graduate it. You can remove the feature gate that sounds good. Everybody, oh yeah,.

F

That sounds perfect great thanks.

A

We're gonna do a plus + or minus hand. At this point, I'm.

C

Done I just wanted to insi said he was gonna, write some documentation, so that's good. Okay I think we need to have a process and we need to write the process down and you do do the process that we have written down. I.

A

Think we're doing a great job so far getting gated will work for us. So thank you that stops there. Okay, I'm gonna see how far we could take that.

G

When we get to the next thing, I actually wanted to talk about something just briefly the flags PR to add all the flags to create broker. It still exists. It's still up nobody's really taxing people, but nobody's commented on like really company reviews. So if anyone wants to be able to use register broker to actually do things, take a little PR I.

A

Totally don't conference all last week as an organizers like their I, couldn't like get five minutes together to look at it. So I'll do that probably.

A

Does anyone else want to beg for reviews before we go into the popcorn announcement? Popcorn I put popcorn on it, because I was excited about yeah I.

C

Let's see, there's I think we're doing a good job, clearing the PRS, so everything everything up there is either needs rebase or do not merge or whatever, and besides the two from earlier today and the most recent one is eighteen days ago. So I think it. I think that one may have been redone, because it has more comments than I remember.

C

Other than that I don't know how we get people to either rebase or refactor their whips stuff. If necessary, it would each go and review it's about it. I don't feel I, don't feel really feel necessary to go through the PRS that exists currently right now. You.

A

Know for some of them, if the person has lost interest and we personally don't really meet. What's out there I'm comfortable, saying like hey, we're, gonna close this for now, since we heard back reopen it if you're interested in pushing through and work with you that may be I mean otherwise, if there's something we really need and we're hoping someone else but finish, but they don't have time anymore. I mean we can just reach out. I can reach out and be like hey. You know we really still like this.

A

Do you mind if we help push this across the finish line or you know, take what they've started and you know help finish it: collaborate on their branch, perhaps yeah, perfect, okay I will do that. I'll! Look for some of the ones that are kind of stuck in an awkward state and help nudge things long.

C

Idea I would like to tackle this for five minutes. J. Did you get any follow-ups here? I.

D

Did it's been a week you got a list of those turtle. Would yeah.

C

The ones on the milestone point to try to open them all up or well.

D

I, like what I closed, that a bunch of stuff, Morgan so I, know, I took some action but I'm trying to remember on the milestones there might have been some stuff that were going to take off of my own Stern I. Think we got Paul on the call, so I didn't going to open the top one.

C

Was this stuck I think this has something to do with the delete as well leave a comment last time. I did not.

D

Do nothing it happened.

C

Well, I'm, fine leaving this one for now, but right.

D

Now it's going I think I can only do so much at once and I'm ideal, but my thought please: we need a proposal to move forward and I know. We've heard a couple things and some of them are, you know more controversial than others. You know there's the idea of moving things to a queue if it needs attention from an administrator, I, don't know what else we're gonna do with it, but.

A

Are we talking we're talking about a suggestion on that, one that I thought we seemed cool with? If you look at with a comma here on the bottom I mean in or do we just need to make this more clear to people that it's open and how wanted and what.

D

Was this the force where the SV can't takes off the final laser Carolyn yeah.

A

If you scroll up a little bit, I have an example of what this could look like I think it'd be sweet. Let's definitely do that. You know it just it it's something we're like we. We would force people that you know be like yes, I really mean it and make it try to make it clear that this could result in you know money, basically, no.

C

Should I hide anybody or.

A

C

Or something how.

A

Do you, how do you feel if I just close this and make a new issue and put Help Wanted on it? This seems like a pretty easy one, actually, because it's all the CLI to have someone some of our newer contributors tackle this. If I give some more explicit direction. Okay, no I'll do that right now,.

C

Documentation, I think we're. Oh yeah I think we just said we're gonna leave this open because we're doing pretty good job using this as the overarching issue for all of our documentation, so so that doesn't need an action.

C

Cube control, yet, let's see it's just uh so yeah I think this is we were going to follow up with Marco and then good.

D

Marco's been off on another project, he's coming back shortly here, so I will get with him tomorrow and try to get a timeline from him, but I think he's also got a PR in process that has server-side sorting that's going to help a lot with fortifying things. So I'll continue to have this as a follow-up.

H

H

We need this test rebased. What's.

C

Basically, it and still need. Are you based I.

D

Don't think Matt's on the call great that is Matt's yeah I'll drop a new.

C

Dog and Paul fight.

C

Fight I got distracted, okay, we're talking about the purge generated, make targets, it seems like Paul, wants to rewrite or eliminate it, and you still use it, and we have this issue talking about it. So can we assign somebody to actually work it or delete it or move it out of the milestone.

B

I'll poop I can first remember about this. One 15:09.

C

39 you're already assigned so I can't do anything else.

C

Where did I leave at the bottom here did I leave anything. No, no I did not none of these people who are on the previous call, and none of them are on this call.

C

So, let's find either a comment or move it out.

C

Does this have to do with the the same thing is like the controller refactor, or is this more documentation.

B

Just quite back to 3009 just for a sec. What is the proper way now to delete all generated files.

D

Don't worry about it make clean should be cleaning things up right, I mean I, know, that's not very specific.

B

But that's I, don't think it does I think make clean leaves Garriott files. This is a problem. Doesn't it that's? Why I and both to be clear, I wasn't it's like pushing back and what Paul was just in here. I was just asking them what to do. If you want to delete the generated files, because I have had situations where I needed to force a regeneration and I didn't know how to do it. Aside from this make step that he wants to delete, wait.

F

We keep that make target or not, but the so. The the issue is that, like the expansion's, which you used to add method that deals like, for example, with a sub resource, we use one of those expansion files to add the ref like reference, some resource to service instances, and if you run purge, make her generated. It blast that back as well, but is it generate so it just needs to be special case to avoid the bleeding that stuff and.

B

So it Paul, can you have a comment in there specifically calling out which files should not be deleted and I can easily, or at least try to modify the make file so that it doesn't delete those yeah? Okay, thank you. I'll take care of it them.

C

C

To to shoot you.

C

I mean this seems to be on the seems to be partially controller, stuff, partially documentation, so umbrella issue.

C

I mean this seems to be at least partially documenting what we do with our controller.

C

So I can either link it to the other one or we can just close it I'm not really sure. What's what we should do, given that it's basically it's a year old.

C

So I'm not sure how relevant to this any more thoughts.

C

My own mute now.

A

You're good, okay.

C

Cinci you're all done that closet, perhaps link it to the documentation issue or the controller issue. Yeah a I.

D

Don't even know what to do with this I think that's Fri appropriate, but I make sure you add that if they want to drive it forward to, you know, have more discussion around. It feel free to reopen it, but they gotta participate.

C

And I can add some comments later. Okay, so that's good. You think we're pretty close to the point to release.

C

There's not much in here. That is super significant, but it would be good to get some a a checklist to make sure that we have the documentation we want and.

C

Follow up with Marco on the client, slash server-side, rendering the cube control rebase this and dock handles that make sense. Everybody everybody follow yeah all right!

C

Yeah Carol will go through PR backlog and nudge things. Oh yes, PR bag, okay, yeah.

C

My turn I guess it's time anything else, yeah, okay, well, I'm gonna, go work on something else, basically is the short version. So I wanted to try to get to the next couple of weeks some transition, T stuff done and reassign some of the periodic tasks that I currently do, such as the release and the CI stuff. The reporting of the meetings you need a new volunteer for that and I can make a list in an issue we can talk through either one you know probably I can issue anyway. Just so we have a checklist.

A

Oh yeah I actually find one suggestion is, since we do have a number of people who are new, we're, maybe interesting and helping to call it interested in helping out. Maybe they'd, be interested in caring and learning on how to do the releases, and they could help a little bit. I wanna.

G

hmm I said I'll probably be working on the release stuff.

C

There we go volunteers, yeah, so I'll make an issue with a checklist and we can tackle it that way. I think.

A

Also Scott is asking what you're up to next? Is it.

C

Top secret totally top secret I'm gonna go work on something else. That's not goober, Nettie's related! So again, yeah! That's it! That's the that's! The big big thing.

A

Weis wanna say thank you for everything. You've done this entire time. You really like kept things going, picked up a whole bunch of the chop. Wood carry water and it's been extremely helpful and you've helped frankly make the savings happening for the past year. So thanks yeah.

D

It's gonna get a little in the CI CD stuff, so that's just one of them. Thanks Morgan and you've done doing a good job running the PRS. You know making sure we stay on top of them.

C

Yeah I appreciate it. I just wanted to I want to make sure we're all in the same page and yeah, covering all that stuff. So I'll make an issue with all that stuff. Unless you want to try to make a list right now, I've.

G

Got you sense dude, but.

C

I think an issue is probably appropriate. Then you.

D

C

D

Know maybe we can tag people in it as we decide who's gonna take over each thing or something like that. Yep.

H

That sounds good thanks. Morgan.

C

A

Gonna miss orchid I mean.

C

I'll be around for a little bit and you can always ask me questions, but you know end of the month is basically my personal stop doing stuff here: deadlines! Oh okay, that's.

A

A

Wow looks like we're at the end of the medium less anyone else. I was something they'd like to bring up we'll just finish: early mm yeah thanks everybody.

E